JsonReference::setUpProperties() - Code Metrics - Inspection of "Builder" - swaggest/php-json-schema - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Viacheslav

created 2017-05-22 09:10 UTC

JsonReference::setUpProperties() A

↳ Parent: JsonReference

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	2

<?php
/**
 * @file ATTENTION!!! The code below was carefully crafted by a mean machine.
 * Please consider to NOT put any emotional human-generated modifications as AI will throw them away with no mercy.
 */

namespace Swaggest\JsonSchema\SwaggerSchema;

use Swaggest\JsonSchema\Constraint\Properties;
use Swaggest\JsonSchema\Schema;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Swaggest\JsonSchema\Structure\ClassStructure;


class JsonReference extends ClassStructure {
	/** @var string */
	public $ref;

	/**
	 * @param Properties|static $properties
	 * @param Schema $ownerSchema
	 */
	public static function setUpProperties($properties, Schema $ownerSchema)
	{
		$properties->ref = Schema::string();
		$ownerSchema->addPropertyMapping('$ref', self::names()->ref);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$ownerSchema->type = 'object';

		$ownerSchema->additionalProperties = false;
		$ownerSchema->required = array (
		  0 => '$ref',
		);
	}
}



1			<?php
2			/**
3			* @file ATTENTION!!! The code below was carefully crafted by a mean machine.
4			* Please consider to NOT put any emotional human-generated modifications as AI will throw them away with no mercy.
5			*/
6
7			namespace Swaggest\JsonSchema\SwaggerSchema;
8
9			use Swaggest\JsonSchema\Constraint\Properties;
10			use Swaggest\JsonSchema\Schema;
			0 ignored issues – show Bug introduced 2017-05-22 09:50 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Swaggest\JsonSchema\SwaggerSchema\Schema`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
11			use Swaggest\JsonSchema\Structure\ClassStructure;
12
13
14			class JsonReference extends ClassStructure {
15			/** @var string */
16			public $ref;
17
18			/**
19			* @param Properties\|static $properties
20			* @param Schema $ownerSchema
21			*/
22			public static function setUpProperties($properties, Schema $ownerSchema)
23			{
24			$properties->ref = Schema::string();
25			$ownerSchema->addPropertyMapping('$ref', self::names()->ref);
			0 ignored issues – show Documentation introduced 2017-05-22 09:50 UTC by Report Bug Copy Issue Report The property `ref` does not exist on `object<Swaggest\JsonSchema\NameMirror>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
26			$ownerSchema->type = 'object';
			0 ignored issues – show Documentation Bug introduced 2017-05-22 09:50 UTC by Report Bug Copy Issue Report It seems like `'object'` of type `string` is incompatible with the declared type `object<Swaggest\JsonSchema\Constraint\Type>` of property `$type`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
27			$ownerSchema->additionalProperties = false;
28			$ownerSchema->required = array (
29			0 => '$ref',
30			);
31			}
32			}
33
34

swaggest / php-json-schema

Pull Request — master (#9)

JsonReference::setUpProperties() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like