TypeBuilder::getTypeString() - Code Metrics - Inspection of "Add JSDoc types renderer from JSON Schema" - swaggest/php-code-builder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#36)

by Viacheslav

created 2021-04-06 22:35 UTC

TypeBuilder::getTypeString() F

↳ Parent: TypeBuilder

Complexity

Conditions	37
Paths	> 20000

Size

Total Lines	158
Code Lines	95

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	37
eloc	95
c	1
b	0
f	0
nc	6220800
nop	2
dl	0
loc	158
rs	0

How to fix Long Method Complexity

<?php

namespace Swaggest\PhpCodeBuilder\JSDoc;

use Swaggest\CodeBuilder\CodeBuilder;
use Swaggest\JsonSchema\Schema;
use Swaggest\PhpCodeBuilder\PhpCode;

class TypeBuilder
{
    /** @var \SplObjectStorage */
    private $processed;

    public $trimNamePrefix = [
        '#/definitions'
    ];

    public $file = '';

    public function __construct()
    {
        $this->processed = new \SplObjectStorage();
    }

    /**
     * @param Schema|boolean $schema
     * @param string $path
     * @return string
     */
    public function getTypeString($schema, $path = '')
    {
        $schema = Schema::unboolSchema($schema);

        $isOptional = false;

        $isObject = false;
        $isArray = false;
        $isBoolean = false;
        $isString = false;
        $isNumber = false;

        $type = $schema->type;
        if (!is_array($type)) {
            $type = [$type];
        }

        $or = [];

        if ($schema->oneOf !== null) {
            foreach ($schema->oneOf as $item) {
                $or[] = $this->getTypeString($item);
            }
        }

        if ($schema->anyOf !== null) {
            foreach ($schema->anyOf as $item) {
                $or[] = $this->getTypeString($item);
            }
        }

        if ($schema->allOf !== null) {
            foreach ($schema->allOf as $item) {
                $or[] = $this->getTypeString($item);
            }
        }

        if ($schema->then !== null) {
            $or[] = $this->getTypeString($schema->then);
        }

        if ($schema->else !== null) {
            $or[] = $this->getTypeString($schema->else);
        }

        foreach ($type as $i => $t) {
            switch ($t) {
                case Schema::NULL:
                    $isOptional = true;
                    break;

                case Schema::OBJECT:
                    $isObject = true;
                    break;

                case Schema::_ARRAY:
                    $isArray = true;
                    break;

                case Schema::NUMBER:
                case Schema::INTEGER:
                    $isNumber = true;
                    break;

                case Schema::STRING:
                    $isString = true;
                    break;

                case Schema::BOOLEAN:
                    $isBoolean = true;
                    break;

            }
        }

        if ($isObject) {
            $typeAdded = false;

            if (!empty($schema->properties)) {
                if ($this->processed->contains($schema)) {
                    $or [] = $this->processed->offsetGet($schema);
                    $typeAdded = true;
                } else {
                    $typeName = $this->typeName($schema, $path);
                    $this->makeObjectTypeDef($schema, $path);

                    $or [] = $typeName;
                    $typeAdded = true;
                }

            }

            if ($schema->additionalProperties instanceof Schema) {
                $typeName = $this->getTypeString($schema->additionalProperties, $path . '/additionalProperties');
                $or [] = "object<string, $typeName>";
                $typeAdded = true;
            }

            if (!empty($schema->patternProperties)) {
                foreach ($schema->patternProperties as $pattern => $propertySchema) {
                    if ($propertySchema instanceof Schema) {
                        $typeName = $this->getTypeString($propertySchema, $path . '/patternProperties/' . $pattern);
                        $or [] = $typeName;
                        $typeAdded = true;
                    }
                }
            }

            if (!$typeAdded) {
                $or [] = 'object';
            }
        }

        if ($isArray) {
            $typeAdded = false;

            if ($schema->items instanceof Schema) {
                $typeName = $this->getTypeString($schema->items, $path . '/items');
                $or [] = "array<$typeName>";
                $typeAdded = true;
            }

            if ($schema->additionalItems instanceof Schema) {
                $typeName = $this->getTypeString($schema->additionalItems, $path . '/additionalItems');
                $or [] = "array<$typeName>";
                $typeAdded = true;
            }

            if (!$typeAdded) {
                $or [] = 'array';
            }
        }

        if ($isString) {
            $or [] = 'string';
        }

        if ($isNumber) {
            $or [] = 'number';
        }

        if ($isBoolean) {
            $or [] = 'boolean';
        }

        $res = '';
        foreach ($or as $item) {
            if (!empty($item) && $item !== '*') {
                $res .= '|' . $item;
            }
        }

        if ($res !== '') {
            $res = substr($res, 1);
        } else {
            $res = '*';
        }

        return $res;
    }

    private function typeName(Schema $schema, $path)
    {
        if ($fromRefs = $schema->getFromRefs()) {
            $path = $fromRefs[count($fromRefs) - 1];
        }

        foreach ($this->trimNamePrefix as $prefix) {
            if ($prefix === substr($path, 0, strlen($prefix))) {
                $path = substr($path, strlen($prefix));
            }
        }

        return PhpCode::makePhpName($path, false);
    }

    private function makeObjectTypeDef(Schema $schema, $path)
    {
        $typeName = $this->typeName($schema, $path);
        $this->processed->attach($schema, $typeName);

        $head = '';
        if (!empty($schema->title)) {
            $head .= $schema->title . "\n";
        }

        if (!empty($schema->description)) {
            $head .= $schema->description . "\n";
        }

        if ($head !== '') {
            $head = "\n" . CodeBuilder::padLines(' * ', trim($head), false);
        }

        $res = <<<JSDOC
/**$head
 * @typedef {$typeName}
 * @type {object}

JSDOC;
        foreach ($schema->properties as $propertyName => $propertySchema) {
            $typeString = $this->getTypeString($propertySchema, $path . '/' . $propertyName);
            $res .= <<<JSDOC
 * @property {{$typeString}} {$propertyName}{$this->description($propertySchema)}.

JSDOC;

        }

        $res .= <<<JSDOC
 */


JSDOC;

        $this->file .= $res;

        return $typeName;
    }

    private function description(Schema $schema)
    {
        $res = str_replace("\n", " ", $schema->title . $schema->description);
        if ($res) {
            return ' - ' . rtrim($res, '.');
        }

        return '';
    }
}

1			<?php
2
3			namespace Swaggest\PhpCodeBuilder\JSDoc;
4
5			use Swaggest\CodeBuilder\CodeBuilder;
6			use Swaggest\JsonSchema\Schema;
7			use Swaggest\PhpCodeBuilder\PhpCode;
8
9			class TypeBuilder
10			{
11			/** @var \SplObjectStorage */
12			private $processed;
13
14			public $trimNamePrefix = [
15			'#/definitions'
16			];
17
18			public $file = '';
19
20			public function __construct()
21			{
22			$this->processed = new \SplObjectStorage();
23			}
24
25			/**
26			* @param Schema\|boolean $schema
27			* @param string $path
28			* @return string
29			*/
30			public function getTypeString($schema, $path = '')
31			{
32			$schema = Schema::unboolSchema($schema);
33
34			$isOptional = false;
			0 ignored issues – show Unused Code introduced 2021-04-06 22:45 UTC by Report Bug Copy Issue Report The assignment to `$isOptional` is dead and can be removed. Loading history...
35			$isObject = false;
36			$isArray = false;
37			$isBoolean = false;
38			$isString = false;
39			$isNumber = false;
40
41			$type = $schema->type;
42			if (!is_array($type)) {
43			$type = [$type];
44			}
45
46			$or = [];
47
48			if ($schema->oneOf !== null) {
49			foreach ($schema->oneOf as $item) {
50			$or[] = $this->getTypeString($item);
51			}
52			}
53
54			if ($schema->anyOf !== null) {
55			foreach ($schema->anyOf as $item) {
56			$or[] = $this->getTypeString($item);
57			}
58			}
59
60			if ($schema->allOf !== null) {
61			foreach ($schema->allOf as $item) {
62			$or[] = $this->getTypeString($item);
63			}
64			}
65
66			if ($schema->then !== null) {
67			$or[] = $this->getTypeString($schema->then);
68			}
69
70			if ($schema->else !== null) {
71			$or[] = $this->getTypeString($schema->else);
72			}
73
74			foreach ($type as $i => $t) {
75			switch ($t) {
76			case Schema::NULL:
77			$isOptional = true;
78			break;
79
80			case Schema::OBJECT:
81			$isObject = true;
82			break;
83
84			case Schema::_ARRAY:
85			$isArray = true;
86			break;
87
88			case Schema::NUMBER:
89			case Schema::INTEGER:
90			$isNumber = true;
91			break;
92
93			case Schema::STRING:
94			$isString = true;
95			break;
96
97			case Schema::BOOLEAN:
98			$isBoolean = true;
99			break;
100
101			}
102			}
103
104			if ($isObject) {
105			$typeAdded = false;
106
107			if (!empty($schema->properties)) {
108			if ($this->processed->contains($schema)) {
109			$or [] = $this->processed->offsetGet($schema);
110			$typeAdded = true;
111			} else {
112			$typeName = $this->typeName($schema, $path);
113			$this->makeObjectTypeDef($schema, $path);
114
115			$or [] = $typeName;
116			$typeAdded = true;
117			}
118
119			}
120
121			if ($schema->additionalProperties instanceof Schema) {
122			$typeName = $this->getTypeString($schema->additionalProperties, $path . '/additionalProperties');
123			$or [] = "object<string, $typeName>";
124			$typeAdded = true;
125			}
126
127			if (!empty($schema->patternProperties)) {
128			foreach ($schema->patternProperties as $pattern => $propertySchema) {
129			if ($propertySchema instanceof Schema) {
130			$typeName = $this->getTypeString($propertySchema, $path . '/patternProperties/' . $pattern);
131			$or [] = $typeName;
132			$typeAdded = true;
133			}
134			}
135			}
136
137			if (!$typeAdded) {
138			$or [] = 'object';
139			}
140			}
141
142			if ($isArray) {
143			$typeAdded = false;
144
145			if ($schema->items instanceof Schema) {
146			$typeName = $this->getTypeString($schema->items, $path . '/items');
147			$or [] = "array<$typeName>";
148			$typeAdded = true;
149			}
150
151			if ($schema->additionalItems instanceof Schema) {
152			$typeName = $this->getTypeString($schema->additionalItems, $path . '/additionalItems');
153			$or [] = "array<$typeName>";
154			$typeAdded = true;
155			}
156
157			if (!$typeAdded) {
158			$or [] = 'array';
159			}
160			}
161
162			if ($isString) {
163			$or [] = 'string';
164			}
165
166			if ($isNumber) {
167			$or [] = 'number';
168			}
169
170			if ($isBoolean) {
171			$or [] = 'boolean';
172			}
173
174			$res = '';
175			foreach ($or as $item) {
176			if (!empty($item) && $item !== '*') {
177			$res .= '\|' . $item;
178			}
179			}
180
181			if ($res !== '') {
182			$res = substr($res, 1);
183			} else {
184			$res = '*';
185			}
186
187			return $res;
188			}
189
190			private function typeName(Schema $schema, $path)
191			{
192			if ($fromRefs = $schema->getFromRefs()) {
193			$path = $fromRefs[count($fromRefs) - 1];
194			}
195
196			foreach ($this->trimNamePrefix as $prefix) {
197			if ($prefix === substr($path, 0, strlen($prefix))) {
198			$path = substr($path, strlen($prefix));
199			}
200			}
201
202			return PhpCode::makePhpName($path, false);
203			}
204
205			private function makeObjectTypeDef(Schema $schema, $path)
206			{
207			$typeName = $this->typeName($schema, $path);
208			$this->processed->attach($schema, $typeName);
209
210			$head = '';
211			if (!empty($schema->title)) {
212			$head .= $schema->title . "\n";
213			}
214
215			if (!empty($schema->description)) {
216			$head .= $schema->description . "\n";
217			}
218
219			if ($head !== '') {
220			$head = "\n" . CodeBuilder::padLines(' * ', trim($head), false);
221			}
222
223			$res = <<<JSDOC
224			/**$head
225			* @typedef {$typeName}
226			* @type {object}
227
228			JSDOC;
229			foreach ($schema->properties as $propertyName => $propertySchema) {
230			$typeString = $this->getTypeString($propertySchema, $path . '/' . $propertyName);
231			$res .= <<<JSDOC
232			* @property {{$typeString}} {$propertyName}{$this->description($propertySchema)}.
233
234			JSDOC;
235
236			}
237
238			$res .= <<<JSDOC
239			*/
240
241
242			JSDOC;
243
244			$this->file .= $res;
245
246			return $typeName;
247			}
248
249			private function description(Schema $schema)
250			{
251			$res = str_replace("\n", " ", $schema->title . $schema->description);
252			if ($res) {
253			return ' - ' . rtrim($res, '.');
254			}
255
256			return '';
257			}
258			}

swaggest / php-code-builder

Pull Request — master (#36)

TypeBuilder::getTypeString() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like