swaggest /
php-code-builder
| Total Complexity | 78 |
| Total Lines | 461 |
| Duplicated Lines | 0 % |
| Coverage | 93.05% |
| Changes | 0 | ||
Complex classes like SchemaBuilder often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use SchemaBuilder, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 17 | class SchemaBuilder |
||
| 18 | { |
||
| 19 | /** @var Schema */ |
||
| 20 | private $schema; |
||
| 21 | /** @var string */ |
||
| 22 | private $varName; |
||
| 23 | /** @var bool */ |
||
| 24 | private $createVarName; |
||
| 25 | |||
| 26 | /** @var PhpBuilder */ |
||
| 27 | private $phpBuilder; |
||
| 28 | /** @var string */ |
||
| 29 | private $path; |
||
| 30 | |||
| 31 | /** @var PhpCode */ |
||
| 32 | private $result; |
||
| 33 | |||
| 34 | /** @var bool */ |
||
| 35 | private $skipProperties; |
||
| 36 | |||
| 37 | /** @var PhpClass */ |
||
| 38 | private $saveEnumConstInClass; |
||
| 39 | |||
| 40 | /** |
||
| 41 | * SchemaBuilder constructor. |
||
| 42 | * @param Schema $schema |
||
| 43 | * @param string $varName |
||
| 44 | * @param string $path |
||
| 45 | * @param PhpBuilder $phpBuilder |
||
| 46 | * @param bool $createVarName |
||
| 47 | */ |
||
| 48 | 11 | public function __construct($schema, $varName, $path, PhpBuilder $phpBuilder, $createVarName = true) |
|
| 49 | { |
||
| 50 | 11 | $this->schema = $schema; |
|
| 51 | 11 | $this->varName = $varName; |
|
| 52 | 11 | $this->phpBuilder = $phpBuilder; |
|
| 53 | 11 | $this->path = $path; |
|
| 54 | 11 | $this->createVarName = $createVarName; |
|
| 55 | 11 | } |
|
| 56 | |||
| 57 | 11 | private function processType() |
|
| 58 | { |
||
| 59 | 11 | if ($this->schema->type !== null) { |
|
| 60 | 7 | switch ($this->schema->type) { |
|
| 61 | case Type::INTEGER: |
||
| 62 | 4 | $result = $this->createVarName |
|
| 63 | 3 | ? "{$this->varName} = ::schema::integer();" |
|
| 64 | 4 | : "{$this->varName}->type = ::schema::INTEGER;"; |
|
| 65 | 4 | break; |
|
| 66 | |||
| 67 | case Type::NUMBER: |
||
| 68 | 5 | $result = $this->createVarName |
|
| 69 | 4 | ? "{$this->varName} = ::schema::number();" |
|
| 70 | 5 | : "{$this->varName}->type = ::schema::NUMBER;"; |
|
| 71 | 5 | break; |
|
| 72 | |||
| 73 | case Type::BOOLEAN: |
||
| 74 | 5 | $result = $this->createVarName |
|
| 75 | 5 | ? "{$this->varName} = ::schema::boolean();" |
|
| 76 | 5 | : "{$this->varName}->type = ::schema::BOOLEAN;"; |
|
| 77 | 5 | break; |
|
| 78 | |||
| 79 | case Type::STRING: |
||
| 80 | 6 | $result = $this->createVarName |
|
| 81 | 6 | ? "{$this->varName} = ::schema::string();" |
|
| 82 | 6 | : "{$this->varName}->type = ::schema::STRING;"; |
|
| 83 | 6 | break; |
|
| 84 | |||
| 85 | case Type::ARR: |
||
| 86 | 3 | $result = $this->createVarName |
|
| 87 | 3 | ? "{$this->varName} = ::schema::arr();" |
|
| 88 | 3 | : "{$this->varName}->type = ::schema::_ARRAY;"; |
|
| 89 | 3 | break; |
|
| 90 | |||
| 91 | case Type::OBJECT: |
||
| 92 | 7 | return; |
|
| 93 | |||
| 94 | case Type::NULL: |
||
| 95 | 1 | $result = $this->createVarName |
|
| 96 | 1 | ? "{$this->varName} = ::schema::null();" |
|
| 97 | 1 | : "{$this->varName}->type = ::schema::NULL;"; |
|
| 98 | 1 | break; |
|
| 99 | |||
| 100 | default: |
||
| 101 | $types = PhpCode::varExport($this->schema->type); |
||
| 102 | $result = $this->createVarName |
||
| 103 | ? "{$this->varName} = (new ::schema())->setType($types);" |
||
| 104 | 7 | : "{$this->varName}->type = $types;"; |
|
| 105 | } |
||
| 106 | } else { |
||
| 107 | 8 | if ($this->createVarName) { |
|
| 108 | 8 | $result = "{$this->varName} = new ::schema();"; |
|
| 109 | } |
||
| 110 | } |
||
| 111 | |||
| 112 | 11 | if (isset($result)) { |
|
| 113 | 11 | $this->result->addSnippet( |
|
| 114 | 11 | new PlaceholderString($result . "\n", array('::schema' => new ReferenceTypeOf(Palette::schemaClass()))) |
|
|
Deprecated Code
introduced
by
|
|||
| 115 | ); |
||
| 116 | } |
||
| 117 | 11 | } |
|
| 118 | |||
| 119 | 11 | private function processNamedClass() |
|
| 120 | { |
||
| 121 | 11 | if (!$this->skipProperties |
|
| 122 | //&& $this->schema->type === Type::OBJECT |
||
| 123 | 11 | && $this->schema->properties !== null |
|
| 124 | ) { |
||
| 125 | 8 | $class = $this->phpBuilder->getClass($this->schema, $this->path); |
|
| 126 | 8 | if ($this->schema->id === 'http://json-schema.org/draft-04/schema#') { |
|
| 127 | $this->result->addSnippet( |
||
| 128 | new PlaceholderString("{$this->varName} = ::class::schema();\n", |
||
| 129 | array('::class' => new TypeOf(Palette::schemaClass()))) |
||
| 130 | ); |
||
| 131 | } else { |
||
| 132 | 8 | $this->result->addSnippet( |
|
| 133 | 8 | new PlaceholderString("{$this->varName} = ::class::schema();\n", |
|
| 134 | 8 | array('::class' => new TypeOf($class))) |
|
| 135 | ); |
||
| 136 | } |
||
| 137 | 8 | return true; |
|
| 138 | } |
||
| 139 | 11 | return false; |
|
| 140 | } |
||
| 141 | |||
| 142 | 11 | private function processRef() |
|
| 143 | { |
||
| 144 | 11 | if (!$this->skipProperties |
|
| 145 | //&& $this->schema->type === Type::OBJECT |
||
| 146 | 11 | && !$this->phpBuilder->minimizeRefs |
|
| 147 | 11 | && $this->schema->getFromRefs() |
|
| 148 | ) { |
||
| 149 | 1 | $class = $this->phpBuilder->getClass($this->schema, $this->path); |
|
| 150 | 1 | if ($this->schema->id === 'http://json-schema.org/draft-04/schema#') { |
|
| 151 | $this->result->addSnippet( |
||
| 152 | new PlaceholderString("{$this->varName} = ::class::schema();\n", |
||
| 153 | array('::class' => new TypeOf(Palette::schemaClass()))) |
||
| 154 | ); |
||
| 155 | } else { |
||
| 156 | 1 | $this->result->addSnippet( |
|
| 157 | 1 | new PlaceholderString("{$this->varName} = ::class::schema();\n", |
|
| 158 | 1 | array('::class' => new TypeOf($class))) |
|
| 159 | ); |
||
| 160 | } |
||
| 161 | 1 | return true; |
|
| 162 | } |
||
| 163 | 11 | return false; |
|
| 164 | } |
||
| 165 | |||
| 166 | |||
| 167 | /** |
||
| 168 | * @throws Exception |
||
| 169 | */ |
||
| 170 | 11 | private function processObject() |
|
| 217 | |||
| 218 | } |
||
| 219 | } |
||
| 220 | 11 | } |
|
| 221 | |||
| 222 | /** |
||
| 223 | * @throws Exception |
||
| 224 | */ |
||
| 225 | 11 | private function processArray() |
|
| 226 | { |
||
| 227 | 11 | $schema = $this->schema; |
|
| 228 | |||
| 229 | 11 | if (is_bool($schema->additionalItems)) { |
|
| 230 | 2 | $val = $schema->additionalItems ? 'true' : 'false'; |
|
| 231 | 2 | $this->result->addSnippet( |
|
| 232 | 2 | "{$this->varName}->additionalItems = $val;\n" |
|
| 233 | ); |
||
| 234 | } |
||
| 235 | |||
| 236 | 11 | $pathItems = 'items'; |
|
| 237 | 11 | if ($schema->items instanceof ClassStructure) { // todo better check for schema, `getJsonSchema` interface ? |
|
| 238 | 2 | $items = array(); |
|
| 239 | 2 | $additionalItems = $schema->items; |
|
| 240 | 2 | $pathItems = 'items'; |
|
| 241 | 11 | } elseif ($schema->items === null) { // items defaults to empty schema so everything is valid |
|
| 242 | 11 | $items = array(); |
|
| 243 | 11 | $additionalItems = true; |
|
| 244 | } else { // listed items |
||
| 245 | $items = $schema->items; |
||
| 246 | $additionalItems = $schema->additionalItems; |
||
| 247 | $pathItems = 'additionalItems'; |
||
| 248 | } |
||
| 249 | |||
| 250 | 11 | if ($items !== null || $additionalItems !== null) { |
|
| 251 | 11 | if ($additionalItems instanceof ClassStructure) { |
|
| 252 | 2 | $this->result->addSnippet( |
|
| 253 | 2 | $this->copyTo(new SchemaBuilder( |
|
| 254 | 2 | $additionalItems, |
|
| 255 | 2 | "{$this->varName}->{$pathItems}", |
|
| 256 | 2 | $this->path . '->' . $pathItems, |
|
| 257 | 2 | $this->phpBuilder |
|
| 258 | 2 | ))->build() |
|
| 259 | ); |
||
| 260 | } |
||
| 261 | } |
||
| 262 | 11 | } |
|
| 263 | |||
| 264 | 11 | private function processEnum() |
|
| 291 | ); |
||
| 292 | |||
| 293 | } |
||
| 294 | 11 | } |
|
| 295 | |||
| 296 | private $skip = []; |
||
| 297 | |||
| 298 | public function skipProperty($name) |
||
| 302 | } |
||
| 303 | |||
| 304 | 9 | private function copyTo(SchemaBuilder $schemaBuilder) |
|
| 305 | { |
||
| 309 | } |
||
| 310 | |||
| 311 | 11 | private function processOther() |
|
| 362 | ); |
||
| 363 | } |
||
| 364 | 11 | } |
|
| 365 | |||
| 366 | 11 | private function processLogic() |
|
| 367 | { |
||
| 368 | 11 | $names = Schema::names(); |
|
| 369 | 11 | foreach (array($names->not, $names->if, $names->then, $names->else) as $keyword) { |
|
| 370 | 11 | if ($this->schema->$keyword !== null) { |
|
| 371 | 4 | $this->result->addSnippet( |
|
| 372 | 4 | $this->copyTo(new SchemaBuilder( |
|
| 373 | 4 | $this->schema->$keyword, |
|
| 374 | 4 | "{$this->varName}->{$keyword}", |
|
| 375 | 4 | $this->path . '->' . $keyword, |
|
| 376 | 4 | $this->phpBuilder |
|
| 377 | 4 | ))->build() |
|
| 378 | ); |
||
| 379 | } |
||
| 380 | |||
| 381 | } |
||
| 382 | |||
| 383 | 11 | foreach (array($names->anyOf, $names->oneOf, $names->allOf) as $keyword) { |
|
| 384 | 11 | if ($this->schema->$keyword !== null) { |
|
| 385 | 6 | foreach ($this->schema->$keyword as $index => $schema) { |
|
| 386 | 6 | $varName = '$' . PhpCode::makePhpName("{$this->varName}->{$keyword}[{$index}]"); |
|
| 387 | 6 | $schemaInit = $this->copyTo(new SchemaBuilder( |
|
| 388 | 6 | $schema, |
|
| 389 | 6 | $varName, |
|
| 390 | 6 | $this->path . "->{$keyword}[{$index}]", |
|
| 391 | 6 | $this->phpBuilder |
|
| 392 | 6 | ))->build(); |
|
| 393 | |||
| 394 | 6 | if (count($schemaInit->snippets) === 1) { // Init in single statement can be just assigned. |
|
| 395 | 6 | $this->result->addSnippet($this->copyTo(new SchemaBuilder( |
|
| 396 | 6 | $schema, |
|
| 397 | 6 | "{$this->varName}->{$keyword}[{$index}]", |
|
| 398 | 6 | $this->path . "->{$keyword}[{$index}]", |
|
| 399 | 6 | $this->phpBuilder |
|
| 400 | 6 | ))->build()); |
|
| 401 | } else { |
||
| 402 | 2 | $this->result->addSnippet($schemaInit); |
|
| 403 | 2 | $this->result->addSnippet(<<<PHP |
|
| 404 | 2 | {$this->varName}->{$keyword}[{$index}] = {$varName}; |
|
| 405 | |||
| 406 | PHP |
||
| 407 | ); |
||
| 408 | } |
||
| 409 | } |
||
| 410 | } |
||
| 411 | } |
||
| 412 | 11 | } |
|
| 413 | |||
| 414 | /** |
||
| 415 | * @return PhpCode |
||
| 416 | * @throws Exception |
||
| 417 | */ |
||
| 418 | 11 | public function build() |
|
| 419 | { |
||
| 420 | 11 | $this->result = new PhpCode(); |
|
| 421 | |||
| 422 | 11 | if ($this->processNamedClass()) { |
|
| 423 | 8 | return $this->result; |
|
| 424 | } |
||
| 425 | |||
| 426 | 11 | if ($this->processRef()) { |
|
| 427 | 1 | return $this->result; |
|
| 428 | } |
||
| 429 | |||
| 430 | 11 | $this->processType(); |
|
| 431 | 11 | $this->processObject(); |
|
| 432 | 11 | $this->processArray(); |
|
| 433 | 11 | $this->processLogic(); |
|
| 434 | 11 | $this->processEnum(); |
|
| 435 | 11 | $this->processOther(); |
|
| 436 | 11 | $this->processFromRef(); |
|
| 437 | |||
| 438 | 11 | return $this->result; |
|
| 439 | |||
| 440 | } |
||
| 441 | |||
| 442 | 11 | private function processFromRef() |
|
| 443 | { |
||
| 444 | 11 | if ($this->phpBuilder->minimizeRefs) { |
|
| 445 | 10 | if ($fromRefs = $this->schema->getFromRefs()) { |
|
| 446 | 3 | $fromRef = $fromRefs[count($fromRefs) - 1]; |
|
| 447 | 3 | $value = var_export($fromRef, 1); |
|
| 448 | 3 | $this->result->addSnippet("{$this->varName}->setFromRef($value);\n"); |
|
| 449 | } |
||
| 450 | 10 | return; |
|
| 451 | } |
||
| 452 | 1 | if ($fromRefs = $this->schema->getFromRefs()) { |
|
| 453 | 1 | foreach ($fromRefs as $fromRef) { |
|
| 454 | 1 | $value = var_export($fromRef, 1); |
|
| 455 | 1 | $this->result->addSnippet("{$this->varName}->setFromRef($value);\n"); |
|
| 456 | } |
||
| 457 | } |
||
| 458 | 1 | } |
|
| 459 | |||
| 460 | /** |
||
| 461 | * @param boolean $skipProperties |
||
| 462 | * @return $this |
||
| 463 | */ |
||
| 464 | 11 | public function setSkipProperties($skipProperties) |
|
| 465 | { |
||
| 466 | 11 | $this->skipProperties = $skipProperties; |
|
| 467 | 11 | return $this; |
|
| 468 | } |
||
| 469 | |||
| 470 | /** |
||
| 471 | * @param PhpClass $saveEnumConstInClass |
||
| 472 | * @return $this |
||
| 473 | */ |
||
| 474 | 4 | public function setSaveEnumConstInClass($saveEnumConstInClass) |
|
| 478 | } |
||
| 479 | |||
| 480 | |||
| 481 | } |
Loading history...
