JsonPointer::add() - Code Metrics - Inspection of "V2 fixes" - swaggest/json-diff - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Viacheslav

created 2018-01-29 05:15 UTC

JsonPointer::add() C

↳ Parent: JsonPointer

Complexity

Conditions	13
Paths	10

Size

Total Lines	35
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	23
CRAP Score	13

Importance

Changes

Metric	Value
dl	0
loc	35
ccs	23
cts	23
cp	1
rs	5.1234
c	0
b	0
f	0
cc	13
eloc	25
nc	10
nop	4
crap	13

How to fix Complexity

<?php

namespace Swaggest\JsonDiff;


class JsonPointer
{
    /**
     * @param string $key
     * @param bool $isURIFragmentId
     * @return string
     */
    public static function escapeSegment($key, $isURIFragmentId = false)
    {
        if ($isURIFragmentId) {
            return str_replace(array('%2F', '%7E'), array('~0', '~1'), urlencode($key));
        } else {
            return str_replace(array('~', '/'), array('~0', '~1'), $key);
        }
    }

    /**
     * @param string $path
     * @return string[]
     * @throws Exception
     */
    public static function splitPath($path)
    {
        $pathItems = explode('/', $path);
        $first = array_shift($pathItems);
        $result = array();
        if ($first === '#') {
            foreach ($pathItems as $key) {
                $key = str_replace(array('~1', '~0'), array('/', '~'), urldecode($key));
                $result[] = $key;
            }
        } else {
            if ($first !== '') {
                throw new Exception('Path must start with "/": ' . $path);
            }
            foreach ($pathItems as $key) {
                $key = str_replace(array('~1', '~0'), array('/', '~'), $key);
                $result[] = $key;
            }
        }
        return $result;
    }

    /**
     * @param mixed $holder
     * @param string[] $pathItems
     * @param mixed $value
     * @param bool $recursively
     * @throws Exception
     */
    public static function add(&$holder, $pathItems, $value, $recursively = true)
    {
        $pp = $pathItems;

        $ref = &$holder;
        while (null !== $key = array_shift($pathItems)) {
            if ($ref instanceof \stdClass) {
                $ref = &$ref->$key;
            } elseif ($ref === null
                && !is_int($key)
                && false === filter_var($key, FILTER_VALIDATE_INT)
            ) {
                $key = (string)$key;
                if ($recursively) {
                    $ref = new \stdClass();
                    $ref = &$ref->{$key};
                } else {
                    throw new Exception('Non-existent path');
                }
            } else {
                if ($recursively && $ref === null) {
                    $ref = array();
                }

                if ('-' === $key) {
                    $ref = &$ref[];
                } else {
                    $key = (int)$key;
                    if (is_array($ref) && array_key_exists($key, $ref) && !$pathItems) {

                        array_splice($ref, $key, 0, array($value));
                    }
                    $ref = &$ref[$key];
                }
            }
        }
        $ref = $value;
    }

    private static function arrayKeyExists($key, array $a)
    {
        if (array_key_exists($key, $a)) {
            return true;
        }
        $key = (string)$key;
        foreach ($a as $k => $v) {
            if ((string)$k === $key) {
                return true;
            }
        }
        return false;
    }

    private static function arrayGet($key, array $a)
    {
        $key = (string)$key;
        foreach ($a as $k => $v) {
            if ((string)$k === $key) {
                return $v;
            }
        }
        return false;
    }


    /**
     * @param mixed $holder
     * @param string[] $pathItems
     * @return bool|mixed
     * @throws Exception
     */
    public static function get($holder, $pathItems)
    {
        $ref = $holder;
        while (null !== $key = array_shift($pathItems)) {
            if ($ref instanceof \stdClass) {
                $vars = (array)$ref;
                if (self::arrayKeyExists($key, $vars)) {
                    $ref = self::arrayGet($key, $vars);
                } else {
                    throw new Exception('Key not found: ' . $key);
                }
            } elseif (is_array($ref)) {
                if (self::arrayKeyExists($key, $ref)) {
                    $ref = $ref[$key];
                } else {
                    throw new Exception('Key not found: ' . $key);
                }
            } else {
                throw new Exception('Key not found: ' . $key);
            }
        }
        return $ref;
    }

    /**
     * @param mixed $holder
     * @param string[] $pathItems
     * @return mixed
     * @throws Exception
     */
    public static function remove(&$holder, $pathItems)
    {
        $ref = &$holder;
        while (null !== $key = array_shift($pathItems)) {
            $parent = &$ref;
            $refKey = $key;
            if ($ref instanceof \stdClass) {
                if (property_exists($ref, $key)) {
                    $ref = &$ref->$key;
                } else {
                    throw new Exception('Key not found: ' . $key);
                }
            } else {
                if (array_key_exists($key, $ref)) {
                    $ref = &$ref[$key];
                } else {
                    throw new Exception('Key not found: ' . $key);
                }
            }
        }

        if (isset($parent) && isset($refKey)) {
            if ($parent instanceof \stdClass) {
                unset($parent->$refKey);
            } else {
                unset($parent[$refKey]);
                $parent = array_values($parent);

            }
        }
        return $ref;
    }
}

1		<?php
2
3		namespace Swaggest\JsonDiff;
4
5
6		class JsonPointer
7		{
8		/**
9		* @param string $key
10		* @param bool $isURIFragmentId
11		* @return string
12		*/
13	11	public static function escapeSegment($key, $isURIFragmentId = false)
14		{
15	11	if ($isURIFragmentId) {
16	1	return str_replace(array('%2F', '%7E'), array('~0', '~1'), urlencode($key));
17		} else {
18	10	return str_replace(array('~', '/'), array('~0', '~1'), $key);
19		}
20		}
21
22		/**
23		* @param string $path
24		* @return string[]
25		* @throws Exception
26		*/
27	22	public static function splitPath($path)
28		{
29	22	$pathItems = explode('/', $path);
30	22	$first = array_shift($pathItems);
31	22	$result = array();
32	22	if ($first === '#') {
33	1	foreach ($pathItems as $key) {
34	1	$key = str_replace(array('~1', '~0'), array('/', '~'), urldecode($key));
35	1	$result[] = $key;
36		}
37		} else {
38	22	if ($first !== '') {
39		throw new Exception('Path must start with "/": ' . $path);
40		}
41	22	foreach ($pathItems as $key) {
42	22	$key = str_replace(array('~1', '~0'), array('/', '~'), $key);
43	22	$result[] = $key;
44		}
45		}
46	22	return $result;
47		}
48
49		/**
50		* @param mixed $holder
51		* @param string[] $pathItems
52		* @param mixed $value
53		* @param bool $recursively
54		* @throws Exception
55		*/
56	24	public static function add(&$holder, $pathItems, $value, $recursively = true)
57		{
58	24	$pp = $pathItems;
		0 ignored issues – show Unused Code introduced 2018-01-29 05:17 UTC by Report Bug Copy Issue Report The assignment to `$pp` is dead and can be removed. Loading history...
59	24	$ref = &$holder;
60	24	while (null !== $key = array_shift($pathItems)) {
61	22	if ($ref instanceof \stdClass) {
62	22	$ref = &$ref->$key;
63	17	} elseif ($ref === null
64	17	&& !is_int($key)
65	17	&& false === filter_var($key, FILTER_VALIDATE_INT)
66		) {
67	13	$key = (string)$key;
68	13	if ($recursively) {
69	11	$ref = new \stdClass();
70	11	$ref = &$ref->{$key};
71		} else {
72	13	throw new Exception('Non-existent path');
73		}
74		} else {
75	12	if ($recursively && $ref === null) {
76	8	$ref = array();
77		}
78
79	12	if ('-' === $key) {
80	1	$ref = &$ref[];
81		} else {
82	11	$key = (int)$key;
83	11	if (is_array($ref) && array_key_exists($key, $ref) && !$pathItems) {
		0 ignored issues – show Bug Best Practice introduced 2018-01-29 05:17 UTC by Report Bug Copy Issue Report The expression `$pathItems` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
84	3	array_splice($ref, $key, 0, array($value));
85		}
86	11	$ref = &$ref[$key];
87		}
88		}
89		}
90	22	$ref = $value;
91	22	}
92
93	11	private static function arrayKeyExists($key, array $a)
94		{
95	11	if (array_key_exists($key, $a)) {
96	11	return true;
97		}
98	1	$key = (string)$key;
99	1	foreach ($a as $k => $v) {
100	1	if ((string)$k === $key) {
101	1	return true;
102		}
103		}
104	1	return false;
105		}
106
107	11	private static function arrayGet($key, array $a)
108		{
109	11	$key = (string)$key;
110	11	foreach ($a as $k => $v) {
111	11	if ((string)$k === $key) {
112	11	return $v;
113		}
114		}
115		return false;
116		}
117
118
119		/**
120		* @param mixed $holder
121		* @param string[] $pathItems
122		* @return bool\|mixed
123		* @throws Exception
124		*/
125	11	public static function get($holder, $pathItems)
126		{
127	11	$ref = $holder;
128	11	while (null !== $key = array_shift($pathItems)) {
129	11	if ($ref instanceof \stdClass) {
130	11	$vars = (array)$ref;
131	11	if (self::arrayKeyExists($key, $vars)) {
132	11	$ref = self::arrayGet($key, $vars);
133		} else {
134	11	throw new Exception('Key not found: ' . $key);
135		}
136	5	} elseif (is_array($ref)) {
137	5	if (self::arrayKeyExists($key, $ref)) {
138	5	$ref = $ref[$key];
139		} else {
140	5	throw new Exception('Key not found: ' . $key);
141		}
142		} else {
143		throw new Exception('Key not found: ' . $key);
144		}
145		}
146	11	return $ref;
147		}
148
149		/**
150		* @param mixed $holder
151		* @param string[] $pathItems
152		* @return mixed
153		* @throws Exception
154		*/
155	10	public static function remove(&$holder, $pathItems)
156		{
157	10	$ref = &$holder;
158	10	while (null !== $key = array_shift($pathItems)) {
159	10	$parent = &$ref;
160	10	$refKey = $key;
161	10	if ($ref instanceof \stdClass) {
162	10	if (property_exists($ref, $key)) {
163	9	$ref = &$ref->$key;
164		} else {
165	10	throw new Exception('Key not found: ' . $key);
166		}
167		} else {
168	5	if (array_key_exists($key, $ref)) {
169	5	$ref = &$ref[$key];
170		} else {
171		throw new Exception('Key not found: ' . $key);
172		}
173		}
174		}
175
176	9	if (isset($parent) && isset($refKey)) {
177	9	if ($parent instanceof \stdClass) {
178	7	unset($parent->$refKey);
179		} else {
180	4	unset($parent[$refKey]);
181	4	$parent = array_values($parent);
		0 ignored issues – show Unused Code introduced 2018-01-29 05:17 UTC by Report Bug Copy Issue Report The assignment to `$parent` is dead and can be removed. Loading history...
182		}
183		}
184	9	return $ref;
185		}
186		}

swaggest / json-diff

Pull Request — master (#3)

JsonPointer::add() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like