backend\models\query\MailerDomainQuery

Complexity

Total Complexity

2

Size/Duplication

Total Lines	10
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getListValues()	0	8	2

<?php
namespace backend\models\query;

use yii\db\ActiveQuery;
use backend\models\MailerDomain;

class MailerDomainQuery extends ActiveQuery
{
    public function getListValues()
    {
        /** @var MailerDomain $domain */
        $domains = [];
        foreach ($this->all() as $domain) {
            $domains[$domain->id] = $domain->name;

Accessing name on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing id on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }
        return $domains;
    }
}