backend\controllers\SiteController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	behaviors()	0	21	1
A	actions()	0	5	1
A	actionLogin()	0	13	4
A	actionIndex()	0	3	1
A	actionLogout()	0	5	1
A	logUserAction()	0	6	1

<?php
namespace backend\controllers;

use Yii;
use yii\filters\VerbFilter;
use common\models\LoginForm;
use backend\components\Controller;
use backend\models\Log;
use backend\models\User;

/**
 * Site controller
 */
class SiteController extends Controller
{
    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        $behaviors = parent::behaviors();
        $behaviors['access']['rules'] = [
            [
                'actions' => ['login', 'error'],
                'allow' => true,
            ],
            [
                'actions' => ['logout', 'index'],
                'allow' => true,
                'roles' => ['@'],
            ],
        ];
        $behaviors['verbs'] = [
            'class' => VerbFilter::class,
            'actions' => [
                'logout' => ['post'],
            ],
        ];
        return $behaviors;
    }

    /**
     * @inheritdoc
     */
    public function actions()
    {
        return [
            'error' => [
                'class' => 'yii\web\ErrorAction',
            ],
        ];
    }

    /**
     * Displays homepage.
     * @return string
     */
    public function actionIndex()
    {
        return $this->render('index');
    }

    /**
     * Login action.
     * @return string
     */
    public function actionLogin()
    {
        if (!Yii::$app->user->isGuest) {
            return $this->goHome();

The expression return $this->goHome() returns the type yii\web\Response which is incompatible with the documented return type string.

        }

        $model = new LoginForm();
        if ($model->load(Yii::$app->request->post()) && $model->login()) {
            $this->logUserAction(Log::ACTION_LOGIN);
            return $this->goBack();

The expression return $this->goBack() returns the type yii\web\Response which is incompatible with the documented return type string.

        } else {
            return $this->render('login', [
                'model' => $model,
            ]);
        }
    }

    /**
     * Logout action.
     * @return string
     */
    public function actionLogout()
    {
        $this->logUserAction(Log::ACTION_LOGOUT);
        Yii::$app->user->logout();

The method logout() does not exist on null.

        return $this->goHome();

The expression return $this->goHome() returns the type yii\web\Response which is incompatible with the documented return type string.

    }

    /**
     * @param string $action
     * @param bool $saveOldData
     * @param bool $saveNewData
     */
    protected function logUserAction($action, $saveOldData = false, $saveNewData = false)
    {
        $user = new User(Yii::$app->user->identity);

It seems like Yii::app->user->identity can also be of type yii\web\IdentityInterface; however, parameter $config of backend\models\User::__construct() does only seem to accept array, maybe add an additional type check?

        Log::find()
            ->createLogEntity($user, $action, $saveOldData, $saveNewData)
            ->save();
    }
}