backend\components\Controller

Complexity

Total Complexity

5

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	behaviors()	0	16	1
A	findModel()	0	9	3
A	addFlashMessage()	0	5	1

<?php
namespace backend\components;

use Yii;
use yii\base\InvalidConfigException;
use yii\filters\AccessControl;
use yii\web\NotFoundHttpException;
use yii\db\ActiveRecord;
use yii\filters\VerbFilter;

/**
 * Site controller
 */
class Controller extends \yii\web\Controller
{
    const FLASH_INFO = 'info';
    const FLASH_SUCCESS = 'success';
    const FLASH_WARNING = 'warning';
    const FLASH_DANGER = 'danger';

    /**
     * @var string | null | ActiveRecord
     */
    protected $modelClass;

    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        return [
            'access' => [
                'class' => AccessControl::class,
                'rules' => [
                    [
                        'allow' => true,
                        'roles' => ['@'],
                    ],
                ],
            ],
            'verbs' => [
                'class' => VerbFilter::class,
                'actions' => [
                    'delete' => ['POST'],
                ],
            ],
        ];
    }

    /**
     * Finds the MailerDomain model based on its primary key value.
     * If the model is not found, a 404 HTTP exception will be thrown.
     * @param integer | string $id
     * @return ActiveRecord
     * @throws InvalidConfigException
     * @throws NotFoundHttpException
     */
    protected function findModel($id)
    {
        if ($this->modelClass === null) {
            throw new InvalidConfigException('The "modelClass" property must be set.');
        }
        if (($model = $this->modelClass::findOne($id)) !== null) {
            return $model;

The expression return $model also could return the type string which is incompatible with the documented return type yii\db\ActiveRecord.

        } else {
            throw new NotFoundHttpException('The requested page does not exist.');
        }
    }

    /**
     * Adds a flash message.
     * @param string $message
     * @param string $key
     * @return $this
     */
    protected function addFlashMessage($message, $key = self::FLASH_INFO)
    {
        Yii::$app->session
            ->addFlash($key, $message);

The method addFlash() does not exist on null.

        return $this;
    }
}