ToDoController::create() - Code Metrics - Inspection of "setup infection for mutation testing" - svnldwg/symfony-todo-rest - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( c1d2e0...874a5e )

by Sven

created 2021-01-14 23:37 UTC

ToDoController::create() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
c	1
b	0
f	0
dl	0
loc	15
rs	9.9666
cc	1
nc	1
nop	1

<?php

namespace App\Controller;

use App\Entity\ToDo;
use App\Repository\ToDoRepository;
use App\Service\ToDoSerializer;
use App\Service\ToDoValidator;
use Doctrine\ORM\EntityManagerInterface;
use Nelmio\ApiDocBundle\Annotation\Model;
use OpenApi\Annotations as OA;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;

class ToDoController extends AbstractController
{
    public function __construct(
        private EntityManagerInterface $entityManager,

        private ToDoRepository $toDoRepository,
        private ToDoSerializer $toDoSerializer,
        private ToDoValidator $toDoValidator,
        private UrlGeneratorInterface $urlGenerator
    ) {
    }

    /**
     * Add a new ToDo item
     *
     * @Route("/api/todos", name="add_todo", methods={"POST"})
     * @OA\Tag(name="ToDo")
     * @OA\RequestBody(
     *     request="ToDo",
     *     description="The ToDo item to be created",
     *     required=true,
     *     @OA\JsonContent(ref=@Model(type=ToDo::class, groups={"request"}))
     * )
     * @OA\Response(
     *     response=201,
     *     description="The created ToDo item",
     *     @OA\JsonContent(ref=@Model(type=ToDo::class))
     * )
     * @OA\Response(
     *     response=400,
     *     description="Bad Request",
     *     @OA\JsonContent(ref="#/components/schemas/BadRequestError")
     * ),
     * @OA\Response(response="default", description="Unexpected error", @OA\JsonContent(ref="#/components/schemas/ErrorModel"))
     */
    public function create(Request $request): JsonResponse
    {
        $toDo = $this->toDoSerializer->deserializeRequestIntoNew($request->getContent());
        $this->toDoValidator->validate($toDo);

        $this->entityManager->persist($toDo);
        $this->entityManager->flush();

        $resourceUrl = $this->urlGenerator->generate(
            'show_todo',
            ['id' => $toDo->getId()],
            UrlGeneratorInterface::ABSOLUTE_URL
        );

        return $this->json($toDo, JsonResponse::HTTP_CREATED, ['Location' => $resourceUrl, ]);
    }

    /**
     * List all ToDo items
     *
     * @Route("/api/todos", name="list_todos", methods={"GET"})
     * @OA\Tag(name="ToDo")
     * @OA\Response(
     *     response=200,
     *     description="All existing ToDo items",
     *     @OA\JsonContent(
     *        type="array",
     *        @OA\Items(ref=@Model(type=ToDo::class))
     *     )
     * ),
     * @OA\Response(response="default", description="Unexpected error", @OA\JsonContent(ref="#/components/schemas/ErrorModel"))
     */
    public function list(): JsonResponse
    {
        $toDos = $this->toDoRepository->findAll();

        return $this->json($toDos);
    }

    /**
     * Show a single ToDo item
     *
     * @Route("/api/todos/{id<\d+>}", name="show_todo", methods={"GET"})
     * @OA\Tag(name="ToDo")
     * @OA\Response(
     *     response=200,
     *     description="ToDo item",
     *     @OA\JsonContent(ref=@Model(type=ToDo::class))
     * )
     * @OA\Response(response=404, description="ToDo item not found"),
     * @OA\Response(response="default", description="Unexpected error", @OA\JsonContent(ref="#/components/schemas/ErrorModel"))
     */
    public function show(ToDo $toDo): JsonResponse
    {
        return $this->json($toDo);
    }

    /**
     * Delete a ToDo item
     *
     * @Route("/api/todos/{id<\d+>}", name="delete_todo", methods={"DELETE"})
     * @OA\Tag(name="ToDo")
     * @OA\Response(
     *     response=204,
     *     description="ToDo deleted"
     * )
     * @OA\Response(response=404, description="ToDo item not found"),
     * @OA\Response(response="default", description="Unexpected error", @OA\JsonContent(ref="#/components/schemas/ErrorModel"))
     */
    public function delete(ToDo $toDo): JsonResponse
    {
        $this->entityManager->remove($toDo);
        $this->entityManager->flush();

        return new JsonResponse(null, JsonResponse::HTTP_NO_CONTENT);
    }

    /**
     * Update existing ToDo
     *
     * @Route("/api/todos/{id<\d+>}", name="update_todo", methods={"PUT"})
     * @OA\Tag(name="ToDo")
     * @OA\RequestBody(
     *     request="ToDo",
     *     description="The ToDo item to be updated",
     *     required=true,
     *     @OA\JsonContent(ref=@Model(type=ToDo::class, groups={"request"}))
     * )
     * @OA\Response(
     *     response=200,
     *     description="The updated ToDo item",
     *     @OA\JsonContent(ref=@Model(type=ToDo::class))
     * )
     * @OA\Response(
     *     response=400,
     *     description="Bad Request",
     *     @OA\JsonContent(ref="#/components/schemas/BadRequestError")
     * ),
     * @OA\Response(response="default", description="Unexpected error", @OA\JsonContent(ref="#/components/schemas/ErrorModel"))
     */
    public function update(ToDo $toDo, Request $request): JsonResponse
    {
        $this->toDoSerializer->deserializeRequestIntoExisting($request->getContent(), $toDo);
        $this->toDoValidator->validate($toDo);

        $this->entityManager->flush();

        return $this->json($toDo);
    }
}


1			<?php
2
3			namespace App\Controller;
4
5			use App\Entity\ToDo;
6			use App\Repository\ToDoRepository;
7			use App\Service\ToDoSerializer;
8			use App\Service\ToDoValidator;
9			use Doctrine\ORM\EntityManagerInterface;
10			use Nelmio\ApiDocBundle\Annotation\Model;
11			use OpenApi\Annotations as OA;
12			use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
13			use Symfony\Component\HttpFoundation\JsonResponse;
14			use Symfony\Component\HttpFoundation\Request;
15			use Symfony\Component\Routing\Annotation\Route;
16			use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
17
18			class ToDoController extends AbstractController
19			{
20			public function __construct(
21			private EntityManagerInterface $entityManager,
			0 ignored issues – show Bug introduced 2021-01-14 23:50 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_PRIVATE, expecting T_VARIABLE Loading history...
22			private ToDoRepository $toDoRepository,
23			private ToDoSerializer $toDoSerializer,
24			private ToDoValidator $toDoValidator,
25			private UrlGeneratorInterface $urlGenerator
26			) {
27			}
28
29			/**
30			* Add a new ToDo item
31			*
32			* @Route("/api/todos", name="add_todo", methods={"POST"})
33			* @OA\Tag(name="ToDo")
34			* @OA\RequestBody(
35			* request="ToDo",
36			* description="The ToDo item to be created",
37			* required=true,
38			* @OA\JsonContent(ref=@Model(type=ToDo::class, groups={"request"}))
39			* )
40			* @OA\Response(
41			* response=201,
42			* description="The created ToDo item",
43			* @OA\JsonContent(ref=@Model(type=ToDo::class))
44			* )
45			* @OA\Response(
46			* response=400,
47			* description="Bad Request",
48			* @OA\JsonContent(ref="#/components/schemas/BadRequestError")
49			* ),
50			* @OA\Response(response="default", description="Unexpected error", @OA\JsonContent(ref="#/components/schemas/ErrorModel"))
51			*/
52			public function create(Request $request): JsonResponse
53			{
54			$toDo = $this->toDoSerializer->deserializeRequestIntoNew($request->getContent());
55			$this->toDoValidator->validate($toDo);
56
57			$this->entityManager->persist($toDo);
58			$this->entityManager->flush();
59
60			$resourceUrl = $this->urlGenerator->generate(
61			'show_todo',
62			['id' => $toDo->getId()],
63			UrlGeneratorInterface::ABSOLUTE_URL
64			);
65
66			return $this->json($toDo, JsonResponse::HTTP_CREATED, ['Location' => $resourceUrl, ]);
67			}
68
69			/**
70			* List all ToDo items
71			*
72			* @Route("/api/todos", name="list_todos", methods={"GET"})
73			* @OA\Tag(name="ToDo")
74			* @OA\Response(
75			* response=200,
76			* description="All existing ToDo items",
77			* @OA\JsonContent(
78			* type="array",
79			* @OA\Items(ref=@Model(type=ToDo::class))
80			* )
81			* ),
82			* @OA\Response(response="default", description="Unexpected error", @OA\JsonContent(ref="#/components/schemas/ErrorModel"))
83			*/
84			public function list(): JsonResponse
85			{
86			$toDos = $this->toDoRepository->findAll();
87
88			return $this->json($toDos);
89			}
90
91			/**
92			* Show a single ToDo item
93			*
94			* @Route("/api/todos/{id<\d+>}", name="show_todo", methods={"GET"})
95			* @OA\Tag(name="ToDo")
96			* @OA\Response(
97			* response=200,
98			* description="ToDo item",
99			* @OA\JsonContent(ref=@Model(type=ToDo::class))
100			* )
101			* @OA\Response(response=404, description="ToDo item not found"),
102			* @OA\Response(response="default", description="Unexpected error", @OA\JsonContent(ref="#/components/schemas/ErrorModel"))
103			*/
104			public function show(ToDo $toDo): JsonResponse
105			{
106			return $this->json($toDo);
107			}
108
109			/**
110			* Delete a ToDo item
111			*
112			* @Route("/api/todos/{id<\d+>}", name="delete_todo", methods={"DELETE"})
113			* @OA\Tag(name="ToDo")
114			* @OA\Response(
115			* response=204,
116			* description="ToDo deleted"
117			* )
118			* @OA\Response(response=404, description="ToDo item not found"),
119			* @OA\Response(response="default", description="Unexpected error", @OA\JsonContent(ref="#/components/schemas/ErrorModel"))
120			*/
121			public function delete(ToDo $toDo): JsonResponse
122			{
123			$this->entityManager->remove($toDo);
124			$this->entityManager->flush();
125
126			return new JsonResponse(null, JsonResponse::HTTP_NO_CONTENT);
127			}
128
129			/**
130			* Update existing ToDo
131			*
132			* @Route("/api/todos/{id<\d+>}", name="update_todo", methods={"PUT"})
133			* @OA\Tag(name="ToDo")
134			* @OA\RequestBody(
135			* request="ToDo",
136			* description="The ToDo item to be updated",
137			* required=true,
138			* @OA\JsonContent(ref=@Model(type=ToDo::class, groups={"request"}))
139			* )
140			* @OA\Response(
141			* response=200,
142			* description="The updated ToDo item",
143			* @OA\JsonContent(ref=@Model(type=ToDo::class))
144			* )
145			* @OA\Response(
146			* response=400,
147			* description="Bad Request",
148			* @OA\JsonContent(ref="#/components/schemas/BadRequestError")
149			* ),
150			* @OA\Response(response="default", description="Unexpected error", @OA\JsonContent(ref="#/components/schemas/ErrorModel"))
151			*/
152			public function update(ToDo $toDo, Request $request): JsonResponse
153			{
154			$this->toDoSerializer->deserializeRequestIntoExisting($request->getContent(), $toDo);
155			$this->toDoValidator->validate($toDo);
156
157			$this->entityManager->flush();
158
159			return $this->json($toDo);
160			}
161			}
162

svnldwg / symfony-todo-rest

Push — master ( c1d2e0...874a5e )

ToDoController::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like