UserController::getUsersByUsername() - Code Metrics - Inspection of "VS-0 Get user by username (new enpoint)" - svbackend/my-art-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 50cc67...a8ce2f )

by Valentyn

created 2018-08-25 15:31 UTC

UserController::getUsersByUsername() A

↳ Parent: UserController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace App\Users\Controller;

use App\Controller\BaseController;
use App\Users\Entity\User;
use App\Users\Entity\UserRoles;
use App\Users\Event\UserRegisteredEvent;
use App\Users\Repository\ConfirmationTokenRepository;
use App\Users\Repository\UserRepository;
use App\Users\Request\ConfirmEmailRequest;
use App\Users\Request\RegisterUserRequest;
use App\Users\Request\UpdateUserRequest;
use App\Users\Service\RegisterService;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Security\Core\Exception\BadCredentialsException;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Component\Validator\Validator\ValidatorInterface;

class UserController extends BaseController
{
    /**
     * Registration.
     *
     * @Route("/api/users", methods={"POST"})
     *
     * @param RegisterUserRequest      $request
     * @param RegisterService          $registerService
     * @param EventDispatcherInterface $dispatcher
     * @param ValidatorInterface       $validator
     *
     * @return JsonResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function postUsers(RegisterUserRequest $request, RegisterService $registerService, EventDispatcherInterface $dispatcher, ValidatorInterface $validator)
    {
        if ($this->getUser() !== null) {
            throw new AccessDeniedHttpException();
        }

        $registeredUser = $registerService->registerByRequest($request);
        $errors = $validator->validate($registeredUser);

        if ($errors && $errors->count() !== 0) {
            return $request->getErrorResponse($errors);
        }

        $em = $this->getDoctrine()->getManager();
        $em->persist($registeredUser);
        $em->flush();

        $userRegisteredEvent = new UserRegisteredEvent($registeredUser);
        $dispatcher->dispatch(UserRegisteredEvent::NAME, $userRegisteredEvent);

        return $this->response($registeredUser, 200, [], [
            'groups' => ['view'],
        ]);
    }

    /**
     * Confirm email.
     *
     * @Route("/api/confirmEmail", methods={"POST"})
     *
     * @param ConfirmEmailRequest         $request
     * @param ConfirmationTokenRepository $confirmationTokenRepository
     * @param TranslatorInterface         $translator
     *
     * @return JsonResponse
     */
    public function postConfirmEmail(ConfirmEmailRequest $request, ConfirmationTokenRepository $confirmationTokenRepository, TranslatorInterface $translator)
    {
        $token = $request->get('token');

        if (null === $confirmationToken = $confirmationTokenRepository->findByToken($token)) {
            throw new BadCredentialsException($translator->trans('bad_email_confirmation_token', [
                'token' => $token,
            ], 'users'));
        }

        $user = $confirmationToken->getUser();
        $user->confirmEmail();

        $entityManager = $this->getDoctrine()->getManager();
        $entityManager->persist($user);
        $entityManager->remove($confirmationToken);
        $entityManager->flush();

        return new JsonResponse(null, 202);
    }

    /**
     * todo use param converter?
     * Get single user.
     *
     * @Route("/api/users/{id}", methods={"GET"}, requirements={"id"="\d+"})
     *
     * @param $id
     * @param TranslatorInterface $translator
     *
     * @return JsonResponse
     */
    public function getUsers($id, TranslatorInterface $translator)
    {
        /** @var $userRepository \App\Users\Repository\UserRepository */
        $userRepository = $this->getDoctrine()->getRepository(User::class);
        $user = $userRepository->find($id);

        if ($user === null) {
            throw new NotFoundHttpException($translator->trans('not_found_by_id', [
                'user_id' => $id,
            ], 'users'));
        }

        return $this->response($user, 200, [], [
            'groups' => ['view'],
        ]);
    }

    /**
     * Get single user by username.
     *
     * @Route("/api/users/{username}", methods={"GET"})
     *
     * @param User $user
     *
     * @return JsonResponse
     */
    public function getUsersByUsername(User $user)
    {
        return $this->response($user, 200, [], [
            'groups' => ['view'],
        ]);
    }

    /**
     * @Route("/api/users/{id}", methods={"POST", "PUT", "PATCH"}, requirements={"id"="\d+"})
     *
     * @param User              $user
     * @param UpdateUserRequest $request
     *
     * @throws \Exception
     *
     * @return JsonResponse
     */
    public function putUsers(User $user, UpdateUserRequest $request)
    {
        $currentUser = $this->getUser();
        if ($currentUser === null) {
            $this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');
        }

        /** @var $currentUser User */
        if ($currentUser->getId() !== $user->getId()) {
            $this->denyAccessUnlessGranted(UserRoles::ROLE_ADMIN);
        }

        $profile = $user->getProfile();
        $profileData = $request->get('profile');
        $profile->setFirstName($profileData['first_name']);
        $profile->setLastName($profileData['last_name']);
        $profile->setBirthDate(new \DateTimeImmutable($profileData['birth_date']));
        $profile->setAbout($profileData['about']);
        $profile->setPublicEmail($profileData['public_email']);
        $this->getDoctrine()->getManager()->flush();

        return new JsonResponse(null, 202);
    }

    /**
     * Get all users.
     *
     * @Route("/api/users", methods={"GET"})
     */
    public function getAll()
    {
        $this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');

        /**
         * @var UserRepository
         */
        $userRepository = $this->getDoctrine()->getRepository(User::class);
        $users = $userRepository->findAll();

        return $this->response($users, 200, [], [
            'groups' => ['list'],
        ]);
    }

    /**
     * @Route("/api/users/me", methods={"GET"})
     */
    public function getMe()
    {
        $this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');

        return $this->response($this->getUser(), 200, [], [
            'groups' => ['view'],
        ]);
    }
}


1		<?php
2
3		namespace App\Users\Controller;
4
5		use App\Controller\BaseController;
6		use App\Users\Entity\User;
7		use App\Users\Entity\UserRoles;
8		use App\Users\Event\UserRegisteredEvent;
9		use App\Users\Repository\ConfirmationTokenRepository;
10		use App\Users\Repository\UserRepository;
11		use App\Users\Request\ConfirmEmailRequest;
12		use App\Users\Request\RegisterUserRequest;
13		use App\Users\Request\UpdateUserRequest;
14		use App\Users\Service\RegisterService;
15		use Symfony\Component\EventDispatcher\EventDispatcherInterface;
16		use Symfony\Component\HttpFoundation\JsonResponse;
17		use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
18		use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
19		use Symfony\Component\Routing\Annotation\Route;
20		use Symfony\Component\Security\Core\Exception\BadCredentialsException;
21		use Symfony\Component\Translation\TranslatorInterface;
22		use Symfony\Component\Validator\Validator\ValidatorInterface;
23
24		class UserController extends BaseController
25		{
26		/**
27		* Registration.
28		*
29		* @Route("/api/users", methods={"POST"})
30		*
31		* @param RegisterUserRequest $request
32		* @param RegisterService $registerService
33		* @param EventDispatcherInterface $dispatcher
34		* @param ValidatorInterface $validator
35		*
36		* @return JsonResponse\|\Symfony\Component\HttpFoundation\Response
37		*/
38	3	public function postUsers(RegisterUserRequest $request, RegisterService $registerService, EventDispatcherInterface $dispatcher, ValidatorInterface $validator)
39		{
40	3	if ($this->getUser() !== null) {
41		throw new AccessDeniedHttpException();
42		}
43
44	3	$registeredUser = $registerService->registerByRequest($request);
45	3	$errors = $validator->validate($registeredUser);
46
47	3	if ($errors && $errors->count() !== 0) {
48	1	return $request->getErrorResponse($errors);
49		}
50
51	2	$em = $this->getDoctrine()->getManager();
52	2	$em->persist($registeredUser);
53	2	$em->flush();
54
55	2	$userRegisteredEvent = new UserRegisteredEvent($registeredUser);
56	2	$dispatcher->dispatch(UserRegisteredEvent::NAME, $userRegisteredEvent);
57
58	2	return $this->response($registeredUser, 200, [], [
59	2	'groups' => ['view'],
60		]);
61		}
62
63		/**
64		* Confirm email.
65		*
66		* @Route("/api/confirmEmail", methods={"POST"})
67		*
68		* @param ConfirmEmailRequest $request
69		* @param ConfirmationTokenRepository $confirmationTokenRepository
70		* @param TranslatorInterface $translator
71		*
72		* @return JsonResponse
73		*/
74	2	public function postConfirmEmail(ConfirmEmailRequest $request, ConfirmationTokenRepository $confirmationTokenRepository, TranslatorInterface $translator)
75		{
76	2	$token = $request->get('token');
77
78	2	if (null === $confirmationToken = $confirmationTokenRepository->findByToken($token)) {
79	1	throw new BadCredentialsException($translator->trans('bad_email_confirmation_token', [
80	1	'token' => $token,
81	1	], 'users'));
82		}
83
84	1	$user = $confirmationToken->getUser();
85	1	$user->confirmEmail();
86
87	1	$entityManager = $this->getDoctrine()->getManager();
88	1	$entityManager->persist($user);
89	1	$entityManager->remove($confirmationToken);
90	1	$entityManager->flush();
91
92	1	return new JsonResponse(null, 202);
93		}
94
95		/**
96		* todo use param converter?
97		* Get single user.
98		*
99		* @Route("/api/users/{id}", methods={"GET"}, requirements={"id"="\d+"})
100		*
101		* @param $id
102		* @param TranslatorInterface $translator
103		*
104		* @return JsonResponse
105		*/
106	3	public function getUsers($id, TranslatorInterface $translator)
107		{
108		/** @var $userRepository \App\Users\Repository\UserRepository */
109	3	$userRepository = $this->getDoctrine()->getRepository(User::class);
110	3	$user = $userRepository->find($id);
111
112	3	if ($user === null) {
113	1	throw new NotFoundHttpException($translator->trans('not_found_by_id', [
114	1	'user_id' => $id,
115	1	], 'users'));
116		}
117
118	2	return $this->response($user, 200, [], [
119	2	'groups' => ['view'],
120		]);
121		}
122
123		/**
124		* Get single user by username.
125		*
126		* @Route("/api/users/{username}", methods={"GET"})
127		*
128		* @param User $user
129		*
130		* @return JsonResponse
131		*/
132		public function getUsersByUsername(User $user)
133		{
134		return $this->response($user, 200, [], [
135		'groups' => ['view'],
136		]);
137		}
138
139		/**
140		* @Route("/api/users/{id}", methods={"POST", "PUT", "PATCH"}, requirements={"id"="\d+"})
141		*
142		* @param User $user
143		* @param UpdateUserRequest $request
144		*
145		* @throws \Exception
146		*
147		* @return JsonResponse
148		*/
149		public function putUsers(User $user, UpdateUserRequest $request)
150		{
151		$currentUser = $this->getUser();
152		if ($currentUser === null) {
153		$this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');
154		}
155
156		/** @var $currentUser User */
157		if ($currentUser->getId() !== $user->getId()) {
158		$this->denyAccessUnlessGranted(UserRoles::ROLE_ADMIN);
159		}
160
161		$profile = $user->getProfile();
162		$profileData = $request->get('profile');
163		$profile->setFirstName($profileData['first_name']);
164		$profile->setLastName($profileData['last_name']);
165		$profile->setBirthDate(new \DateTimeImmutable($profileData['birth_date']));
166		$profile->setAbout($profileData['about']);
167		$profile->setPublicEmail($profileData['public_email']);
168		$this->getDoctrine()->getManager()->flush();
169
170		return new JsonResponse(null, 202);
171		}
172
173		/**
174		* Get all users.
175		*
176		* @Route("/api/users", methods={"GET"})
177		*/
178	3	public function getAll()
179		{
180	3	$this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');
181
182		/**
183		* @var UserRepository
184		*/
185	2	$userRepository = $this->getDoctrine()->getRepository(User::class);
186	2	$users = $userRepository->findAll();
187
188	2	return $this->response($users, 200, [], [
189	2	'groups' => ['list'],
190		]);
191		}
192
193		/**
194		* @Route("/api/users/me", methods={"GET"})
195		*/
196		public function getMe()
197		{
198		$this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');
199
200		return $this->response($this->getUser(), 200, [], [
201		'groups' => ['view'],
202		]);
203		}
204		}
205

svbackend / my-art-lib

Push — master ( 50cc67...a8ce2f )

UserController::getUsersByUsername() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like