MovieRecommendationController::postMoviesRecommendations() - Code Metrics - Inspection of "Merge pull request #73 from svbackend/Filters" - svbackend/my-art-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0b4911...4851fa )

by Valentyn

created 2019-08-15 14:24 UTC

postMoviesRecommendations() A

↳ Parent: MovieRecommendationController

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	4.0186

Importance

Changes

Metric	Value
dl	0
loc	35
c	0
b	0
f	0
ccs	17
cts	19
cp	0.8947
rs	9.36
cc	4
nc	4
nop	4
crap	4.0186

<?php

namespace App\Movies\Controller;

use App\Controller\BaseController;
use App\Movies\Entity\Movie;
use App\Movies\Entity\MovieRecommendation;
use App\Movies\EventListener\AddRecommendationProcessor;
use App\Movies\Repository\MovieRecommendationRepository;
use App\Movies\Request\NewMovieRecommendationRequest;
use App\Movies\Request\RemoveMovieRecommendationRequest;
use App\Movies\Request\SearchRequest;
use App\Movies\Service\SearchService;
use App\Pagination\PaginatedCollection;
use App\Users\Entity\User;
use App\Users\Entity\UserRoles;
use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
use Doctrine\ORM\EntityManagerInterface;
use Enqueue\Client\Message;
use Enqueue\Client\MessagePriority;
use Enqueue\Client\ProducerInterface;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Routing\Annotation\Route;

class MovieRecommendationController extends BaseController
{
    /**
     * Add new recommendation.
     *
     * @Route("/api/movies/{id}/recommendations", methods={"POST"})
     *
     * @param NewMovieRecommendationRequest $request
     * @param Movie                         $originalMovie
     * @param EntityManagerInterface        $em
     * @param ProducerInterface             $producer
     *
     * @throws \Doctrine\ORM\ORMException
     *
     * @return JsonResponse
     */
    public function postMoviesRecommendations(NewMovieRecommendationRequest $request, Movie $originalMovie, EntityManagerInterface $em, ProducerInterface $producer)
    {
        $this->denyAccessUnlessGranted(UserRoles::ROLE_USER);

        $recommendation = $request->get('recommendation');
        $user = $this->getUser();

        if (empty($recommendation['movie_id'])) {
            $message = new Message(json_encode([
                'tmdb_id' => $recommendation['tmdb_id'],
                'movie_id' => $originalMovie->getId(),
                'user_id' => $user->getId(),
            ]));
            // todo redis doesnt support priority $message->setPriority(MessagePriority::VERY_LOW);
            $producer->sendEvent(AddRecommendationProcessor::ADD_RECOMMENDATION, $message);

            return new JsonResponse();
        }

        $recommendedMovie = $em->getReference(Movie::class, $recommendation['movie_id']);

        if ($recommendedMovie === null) {
            throw new NotFoundHttpException();
        }

        $originalMovie->addRecommendation($user, $recommendedMovie);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $em->persist($originalMovie);
        try {
            $em->flush();
        } catch (UniqueConstraintViolationException $exception) {
            // It's ok..
        }

        return new JsonResponse();
    }

    /**
     * Remove recommendation.
     *
     * @Route("/api/movies/{id}/recommendations", methods={"DELETE"})
     *
     * @param RemoveMovieRecommendationRequest $request
     * @param Movie                            $originalMovie
     * @param MovieRecommendationRepository    $repository
     * @param EntityManagerInterface           $em
     *
     * @return JsonResponse
     */
    public function deleteMoviesRecommendations(RemoveMovieRecommendationRequest $request, Movie $originalMovie, MovieRecommendationRepository $repository, EntityManagerInterface $em)

    {
        $this->denyAccessUnlessGranted(UserRoles::ROLE_USER);

        $user = $this->getUser();

        if (empty($request->get('movie_id'))) {
            $recommendedMovie = $this->findRecommendedMovieByTmdbId($originalMovie, $user, $request->get('tmdb_id'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            if ($recommendedMovie === null) {
                return new JsonResponse();
            }

            $em->remove($recommendedMovie);
            $em->flush();

            return new JsonResponse();
        }

        $recommendedMovie = $this->findRecommendedMovieById($originalMovie, $user, $request->get('movie_id'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if ($recommendedMovie === null) {
            return new JsonResponse();
        }

        $em->remove($recommendedMovie);
        $em->flush();

        return new JsonResponse();
    }

    private function findRecommendedMovieById(Movie $originalMovie, User $user, int $id): ?MovieRecommendation
    {
        foreach ($originalMovie->getRecommendations() as $recommendation) {
            if ($recommendation->getUser()->getId() === $user->getId() && $recommendation->getRecommendedMovie()->getId() === $id) {
                return $recommendation;
            }
        }

        return null;
    }

    private function findRecommendedMovieByTmdbId(Movie $originalMovie, User $user, int $tmdbId): ?MovieRecommendation
    {
        foreach ($originalMovie->getRecommendations() as $recommendation) {
            if ($recommendation->getUser()->getId() === $user->getId() && $recommendation->getRecommendedMovie()->getTmdb()->getId() === $tmdbId) {
                return $recommendation;
            }
        }

        return null;
    }

    /**
     * @Route("/api/movies/{id}/recommendations", methods={"GET"})
     *
     * @param Request                       $request
     * @param Movie                         $movie
     * @param MovieRecommendationRepository $repository
     *
     * @return JsonResponse
     */
    public function getMoviesRecommendations(Request $request, Movie $movie, MovieRecommendationRepository $repository)
    {
        $user = $this->getUser();

        $offset = (int) $request->get('offset', 0);
        $limit = $request->get('limit', null);

        if ($user instanceof User) {
            $recommendedMovies = $repository->findAllByMovieAndUser($movie->getId(), $user->getId());
        } else {
            $recommendedMovies = $repository->findAllByMovie($movie->getId());
        }

        $recommendedMovies = new PaginatedCollection($recommendedMovies, $offset, $limit, false);

        return $this->response($recommendedMovies, 200, [], [
            'groups' => ['list'],
        ]);
    }

    /**
     * Get movies by title.
     *
     * @Route("/api/movies/{id}/recommendations/search", methods={"POST"})
     *
     * @param int           $id
     * @param SearchRequest $request
     * @param SearchService $searchService
     * @param Request       $currentRequest
     *
     * @throws \App\Movies\Exception\TmdbMovieNotFoundException
     * @throws \App\Movies\Exception\TmdbRequestLimitException
     * @throws \ErrorException
     * @throws \Psr\SimpleCache\InvalidArgumentException
     *
     * @return \Symfony\Component\HttpFoundation\JsonResponse
     */
    public function getSearch(int $id, SearchRequest $request, SearchService $searchService, Request $currentRequest)
    {
        $offset = (int) $request->get('offset', 0);
        $limit = $request->get('limit', null);

        $query = $request->get('query');

        if (null === $user = $this->getUser()) {
            $movies = $searchService->findByQuery($query, $currentRequest->getLocale(), $offset, $limit);
        } else {
            $movies = $searchService->findByQueryWithUserRecommendedMovie($query, $id, $user->getId(), $currentRequest->getLocale(), $offset, $limit);
        }

        return $this->response($movies, 200, [], [
            'groups' => ['list'],
        ]);
    }
}


1		<?php
2
3		namespace App\Movies\Controller;
4
5		use App\Controller\BaseController;
6		use App\Movies\Entity\Movie;
7		use App\Movies\Entity\MovieRecommendation;
8		use App\Movies\EventListener\AddRecommendationProcessor;
9		use App\Movies\Repository\MovieRecommendationRepository;
10		use App\Movies\Request\NewMovieRecommendationRequest;
11		use App\Movies\Request\RemoveMovieRecommendationRequest;
12		use App\Movies\Request\SearchRequest;
13		use App\Movies\Service\SearchService;
14		use App\Pagination\PaginatedCollection;
15		use App\Users\Entity\User;
16		use App\Users\Entity\UserRoles;
17		use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
18		use Doctrine\ORM\EntityManagerInterface;
19		use Enqueue\Client\Message;
20		use Enqueue\Client\MessagePriority;
21		use Enqueue\Client\ProducerInterface;
22		use Symfony\Component\HttpFoundation\JsonResponse;
23		use Symfony\Component\HttpFoundation\Request;
24		use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
25		use Symfony\Component\Routing\Annotation\Route;
26
27		class MovieRecommendationController extends BaseController
28		{
29		/**
30		* Add new recommendation.
31		*
32		* @Route("/api/movies/{id}/recommendations", methods={"POST"})
33		*
34		* @param NewMovieRecommendationRequest $request
35		* @param Movie $originalMovie
36		* @param EntityManagerInterface $em
37		* @param ProducerInterface $producer
38		*
39		* @throws \Doctrine\ORM\ORMException
40		*
41		* @return JsonResponse
42		*/
43	7	public function postMoviesRecommendations(NewMovieRecommendationRequest $request, Movie $originalMovie, EntityManagerInterface $em, ProducerInterface $producer)
44		{
45	7	$this->denyAccessUnlessGranted(UserRoles::ROLE_USER);
46
47	7	$recommendation = $request->get('recommendation');
48	7	$user = $this->getUser();
49
50	7	if (empty($recommendation['movie_id'])) {
51	1	$message = new Message(json_encode([
52	1	'tmdb_id' => $recommendation['tmdb_id'],
53	1	'movie_id' => $originalMovie->getId(),
54	1	'user_id' => $user->getId(),
55		]));
56		// todo redis doesnt support priority $message->setPriority(MessagePriority::VERY_LOW);
57	1	$producer->sendEvent(AddRecommendationProcessor::ADD_RECOMMENDATION, $message);
58
59	1	return new JsonResponse();
60		}
61
62	6	$recommendedMovie = $em->getReference(Movie::class, $recommendation['movie_id']);
63
64	6	if ($recommendedMovie === null) {
65		throw new NotFoundHttpException();
66		}
67
68	6	$originalMovie->addRecommendation($user, $recommendedMovie);
		0 ignored issues – show Documentation introduced 2018-07-27 13:22 UTC by Report Bug Copy Issue Report `$user` is of type `null\|object`, but the function expects a `object<App\Users\Entity\User>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
69	6	$em->persist($originalMovie);
70		try {
71	6	$em->flush();
72		} catch (UniqueConstraintViolationException $exception) {
73		// It's ok..
74		}
75
76	6	return new JsonResponse();
77		}
78
79		/**
80		* Remove recommendation.
81		*
82		* @Route("/api/movies/{id}/recommendations", methods={"DELETE"})
83		*
84		* @param RemoveMovieRecommendationRequest $request
85		* @param Movie $originalMovie
86		* @param MovieRecommendationRepository $repository
87		* @param EntityManagerInterface $em
88		*
89		* @return JsonResponse
90		*/
91		public function deleteMoviesRecommendations(RemoveMovieRecommendationRequest $request, Movie $originalMovie, MovieRecommendationRepository $repository, EntityManagerInterface $em)
		0 ignored issues – show Unused Code introduced 2018-08-19 11:16 UTC by Report Bug Copy Issue Report The parameter `$repository` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
92		{
93		$this->denyAccessUnlessGranted(UserRoles::ROLE_USER);
94
95		$user = $this->getUser();
96
97		if (empty($request->get('movie_id'))) {
98		$recommendedMovie = $this->findRecommendedMovieByTmdbId($originalMovie, $user, $request->get('tmdb_id'));
		0 ignored issues – show Documentation introduced 2018-08-19 11:16 UTC by Report Bug Copy Issue Report `$user` is of type `null\|object`, but the function expects a `object<App\Users\Entity\User>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
99		if ($recommendedMovie === null) {
100		return new JsonResponse();
101		}
102
103		$em->remove($recommendedMovie);
104		$em->flush();
105
106		return new JsonResponse();
107		}
108
109		$recommendedMovie = $this->findRecommendedMovieById($originalMovie, $user, $request->get('movie_id'));
		0 ignored issues – show Documentation introduced 2018-08-19 11:16 UTC by Report Bug Copy Issue Report `$user` is of type `null\|object`, but the function expects a `object<App\Users\Entity\User>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
110		if ($recommendedMovie === null) {
111		return new JsonResponse();
112		}
113
114		$em->remove($recommendedMovie);
115		$em->flush();
116
117		return new JsonResponse();
118		}
119
120		private function findRecommendedMovieById(Movie $originalMovie, User $user, int $id): ?MovieRecommendation
121		{
122		foreach ($originalMovie->getRecommendations() as $recommendation) {
123		if ($recommendation->getUser()->getId() === $user->getId() && $recommendation->getRecommendedMovie()->getId() === $id) {
124		return $recommendation;
125		}
126		}
127
128		return null;
129		}
130
131		private function findRecommendedMovieByTmdbId(Movie $originalMovie, User $user, int $tmdbId): ?MovieRecommendation
132		{
133		foreach ($originalMovie->getRecommendations() as $recommendation) {
134		if ($recommendation->getUser()->getId() === $user->getId() && $recommendation->getRecommendedMovie()->getTmdb()->getId() === $tmdbId) {
135		return $recommendation;
136		}
137		}
138
139		return null;
140		}
141
142		/**
143		* @Route("/api/movies/{id}/recommendations", methods={"GET"})
144		*
145		* @param Request $request
146		* @param Movie $movie
147		* @param MovieRecommendationRepository $repository
148		*
149		* @return JsonResponse
150		*/
151	3	public function getMoviesRecommendations(Request $request, Movie $movie, MovieRecommendationRepository $repository)
152		{
153	3	$user = $this->getUser();
154
155	3	$offset = (int) $request->get('offset', 0);
156	3	$limit = $request->get('limit', null);
157
158	3	if ($user instanceof User) {
159	3	$recommendedMovies = $repository->findAllByMovieAndUser($movie->getId(), $user->getId());
160		} else {
161		$recommendedMovies = $repository->findAllByMovie($movie->getId());
162		}
163
164	3	$recommendedMovies = new PaginatedCollection($recommendedMovies, $offset, $limit, false);
165
166	3	return $this->response($recommendedMovies, 200, [], [
167	3	'groups' => ['list'],
168		]);
169		}
170
171		/**
172		* Get movies by title.
173		*
174		* @Route("/api/movies/{id}/recommendations/search", methods={"POST"})
175		*
176		* @param int $id
177		* @param SearchRequest $request
178		* @param SearchService $searchService
179		* @param Request $currentRequest
180		*
181		* @throws \App\Movies\Exception\TmdbMovieNotFoundException
182		* @throws \App\Movies\Exception\TmdbRequestLimitException
183		* @throws \ErrorException
184		* @throws \Psr\SimpleCache\InvalidArgumentException
185		*
186		* @return \Symfony\Component\HttpFoundation\JsonResponse
187		*/
188		public function getSearch(int $id, SearchRequest $request, SearchService $searchService, Request $currentRequest)
189		{
190		$offset = (int) $request->get('offset', 0);
191		$limit = $request->get('limit', null);
192
193		$query = $request->get('query');
194
195		if (null === $user = $this->getUser()) {
196		$movies = $searchService->findByQuery($query, $currentRequest->getLocale(), $offset, $limit);
197		} else {
198		$movies = $searchService->findByQueryWithUserRecommendedMovie($query, $id, $user->getId(), $currentRequest->getLocale(), $offset, $limit);
199		}
200
201		return $this->response($movies, 200, [], [
202		'groups' => ['list'],
203		]);
204		}
205		}
206

svbackend / my-art-lib

Push — master ( 0b4911...4851fa )

postMoviesRecommendations() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like