UserRecommendationTransformer::process() - Code Metrics - Inspection of "Some custom paginated collection improvments, sort..." - svbackend/my-art-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 321b0a...c0c467 )

by Valentyn

created 2018-10-20 19:04 UTC

UserRecommendationTransformer::process() B

↳ Parent: UserRecommendationTransformer

Complexity

Conditions	7
Paths	25

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	7

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	13
cts	13
cp	1
rs	8.6026
c	0
b	0
f	0
cc	7
nc	25
nop	1
crap	7

<?php

namespace App\Movies\Transformer;

use App\Transformer\Transformer;

class UserRecommendationTransformer implements Transformer
{
    private $hiddenFields = [];
    /**
     * [int movie id => int how many times this movie were recommended]
     * @var array
     */
    private $idToTimesRecommendedMap = [];

    public static function list(array $ids): self
    {
        $transformer = new self();
        $transformer->hiddenFields = [
            'budget',
            'genres',
            'imdbId',
            'overview',
            'runtime',
            'tmdb.id',
            'tmdb.voteAverage',
            'tmdb.voteCount',
        ];

        foreach ($ids as $data) {
            $transformer->idToTimesRecommendedMap[reset($data)] = $data['rate'];
        }

        return $transformer;
    }

    public function process(array $data): array
    {
        if (!isset($data['id'])) {
            return $data;
        }

        $data['isWatched'] = isset($data['userWatchedMovie']) && $data['userWatchedMovie'] ? true : false;

        if (isset($data['tmdb.id'])) {
            $data['tmdb']['id'] = $data['tmdb.id'];
            $data['tmdb']['voteAverage'] = $data['tmdb.voteAverage'];
            $data['tmdb']['voteCount'] = $data['tmdb.voteCount'];

            $data['rate'] = $this->idToTimesRecommendedMap[$data['id']] ?? 0;
        }

        foreach ($this->hiddenFields as $hiddenField) {
            if (isset($data[$hiddenField])) {
                unset($data[$hiddenField]);
            }
        }

        return $data;
    }
}

1		<?php
2
3		namespace App\Movies\Transformer;
4
5		use App\Transformer\Transformer;
6
7		class UserRecommendationTransformer implements Transformer
8		{
9		private $hiddenFields = [];
10		/**
11		* [int movie id => int how many times this movie were recommended]
12		* @var array
13		*/
14		private $idToTimesRecommendedMap = [];
15
16	2	public static function list(array $ids): self
17		{
18	2	$transformer = new self();
19	2	$transformer->hiddenFields = [
20		'budget',
21		'genres',
22		'imdbId',
23		'overview',
24		'runtime',
25		'tmdb.id',
26		'tmdb.voteAverage',
27		'tmdb.voteCount',
28		];
29
30	2	foreach ($ids as $data) {
31	2	$transformer->idToTimesRecommendedMap[reset($data)] = $data['rate'];
32		}
33
34	2	return $transformer;
35		}
36
37	2	public function process(array $data): array
38		{
39	2	if (!isset($data['id'])) {
40	2	return $data;
41		}
42
43	2	$data['isWatched'] = isset($data['userWatchedMovie']) && $data['userWatchedMovie'] ? true : false;
44
45	2	if (isset($data['tmdb.id'])) {
46	2	$data['tmdb']['id'] = $data['tmdb.id'];
47	2	$data['tmdb']['voteAverage'] = $data['tmdb.voteAverage'];
48	2	$data['tmdb']['voteCount'] = $data['tmdb.voteCount'];
49
50	2	$data['rate'] = $this->idToTimesRecommendedMap[$data['id']] ?? 0;
51		}
52
53	2	foreach ($this->hiddenFields as $hiddenField) {
54	2	if (isset($data[$hiddenField])) {
55	2	unset($data[$hiddenField]);
56		}
57		}
58
59	2	return $data;
60		}
61		}

svbackend / my-art-lib

Push — master ( 321b0a...c0c467 )

UserRecommendationTransformer::process() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like