App\Movies\Service\WatchedMovieService

Complexity

Total Complexity

15

Size/Duplication

Total Lines	138
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

50%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
B	addUserWatchedMovie()	0	33	5
B	addGuestWatchedMovie()	0	32	5
A	mergeWatchedMovies()	0	22	3
A	saveWatchedMovies()	0	5	1

<?php
declare(strict_types=1);

namespace App\Movies\Service;

use App\Guests\Repository\WatchedMovieRepository;
use App\Movies\DTO\WatchedMovieDTO;
use App\Movies\Entity\Movie;
use App\Guests\Entity\GuestSession;
use App\Guests\Entity\GuestWatchedMovie;
use App\Movies\Entity\WatchedMovie;
use App\Users\Entity\UserWatchedMovie;
use App\Movies\EventListener\WatchedMovieProcessor;
use App\Movies\Repository\MovieRepository;
use App\Movies\Service\SearchService;
use App\Users\Entity\User;
use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
use Doctrine\ORM\EntityManagerInterface;
use Enqueue\Client\ProducerInterface;

class WatchedMovieService
{
    private $em;
    /**
     * @var MovieRepository
     */
    private $repository;

    private $searchService;

    private $producer;

    public function __construct(EntityManagerInterface $entityManager, SearchService $searchService, ProducerInterface $producer)
    {
        $this->em = $entityManager;
        $this->repository = $entityManager->getRepository(Movie::class);
        $this->searchService = $searchService;
        $this->producer = $producer;
    }

    /**
     * @param User $user
     * @param WatchedMovieDTO $watchedMovieDTO
     * @param string $locale
     * @return bool
     * @throws \Exception
     */
    public function addUserWatchedMovie(User $user, WatchedMovieDTO $watchedMovieDTO, string $locale): bool
    {
        $movie = $this->repository->findOneByIdOrTmdbId($watchedMovieDTO->getMovieId(), $watchedMovieDTO->getTmdbId());

        if ($movie === null) {
            // Lets try to find it in TMDB library
            $movie = $this->searchService->findByTmdbId($watchedMovieDTO->getTmdbId(), $locale);
        }

        if ($movie === null) {
            return false;
        }

        $newWatchedMovie = new UserWatchedMovie($user, $movie, $watchedMovieDTO->getVote(), $watchedMovieDTO->getWatchedAt());

It seems like $movie can also be of type false; however, App\Users\Entity\UserWatchedMovie::__construct() does only seem to accept object<App\Movies\Entity\Movie>, did you maybe forget to handle an error condition?

        if ($movie->getId() === null) {
            $this->saveWatchedMovies([
                $newWatchedMovie
            ]);
            return true;
        }

        try {
            $this->em->persist($newWatchedMovie);
            $this->em->flush();
        } catch (UniqueConstraintViolationException $exception) {
            // You can throw new BadRequestHttpException('This movie already in your library of watched movies');

43% of this comment could be valid code. Did you maybe forget this after debugging?

            // But I think its nice to return 202 like operation was successful
            return true;
        }

        return true;
    }

    /**
     * @param GuestSession $guestSession
     * @param WatchedMovieDTO $watchedMovieDTO
     * @param string $locale
     * @return bool
     * @throws \Exception
     */
    public function addGuestWatchedMovie(GuestSession $guestSession, WatchedMovieDTO $watchedMovieDTO, string $locale): bool
    {
        $movie = $this->repository->findOneByIdOrTmdbId($watchedMovieDTO->getMovieId(), $watchedMovieDTO->getTmdbId());

        if ($movie === null) {
            // Lets try to find it in TMDB library
            $movie = $this->searchService->findByTmdbId($watchedMovieDTO->getTmdbId(), $locale);
        }

        if ($movie === null) {
            return false;
        }

        $newWatchedMovie = new GuestWatchedMovie($guestSession, $movie, $watchedMovieDTO->getVote(), $watchedMovieDTO->getWatchedAt());

It seems like $movie can also be of type false; however, App\Guests\Entity\GuestWatchedMovie::__construct() does only seem to accept object<App\Movies\Entity\Movie>, did you maybe forget to handle an error condition?

        if ($movie->getId() === null) {
            $watchedMovieSerialized = serialize([$newWatchedMovie]);
            $this->producer->sendEvent(WatchedMovieProcessor::ADD_WATCHED_MOVIE_TMDB, $watchedMovieSerialized);
            return true;
        }

        try {
            $this->em->persist($newWatchedMovie);
            $this->em->flush();
        } catch (UniqueConstraintViolationException $exception) {
            // You can throw new BadRequestHttpException('This movie already in your library of watched movies');

43% of this comment could be valid code. Did you maybe forget this after debugging?

            // But I think its nice to return 202 like operation was successful
            return true;
        }

        return true;
    }

    /**
     * @param GuestSession $guestSession
     * @param User $user
     * @throws \Exception
     */
    public function mergeWatchedMovies(GuestSession $guestSession, User $user): void
    {
        /** @var $guestWatchedMoviesRepository WatchedMovieRepository */
        $guestWatchedMoviesRepository = $this->em->getRepository(GuestWatchedMovie::class);
        $guestWatchedMovies = $guestWatchedMoviesRepository->findBy([
            'guestSession' => $guestSession->getId()
        ]);

        if (!reset($guestWatchedMovies)) {
            return;
        }

        $userWatchedMovies = [];
        foreach ($guestWatchedMovies as $guestWatchedMovie) {
            $movie = $guestWatchedMovie->getMovie();
            $vote = $guestWatchedMovie->getVote();
            $watchedAt = $guestWatchedMovie->getWatchedAt();
            $userWatchedMovies[] = new UserWatchedMovie($user, $movie, $vote, $watchedAt);
        }

        $this->saveWatchedMovies($userWatchedMovies);
    }

    /**
     * @param array|UserWatchedMovie[]|GuestWatchedMovie[] $watchedMovies
     */
    private function saveWatchedMovies(array $watchedMovies): void
    {
        $watchedMoviesSerialized = serialize($watchedMovies);
        $this->producer->sendEvent(WatchedMovieProcessor::ADD_WATCHED_MOVIE_TMDB, $watchedMoviesSerialized);
    }
}