App\Movies\Repository\MovieRecommendationRepository

Complexity

Total Complexity

6

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

82.35%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	findAllByUser()	0	49	3
A	findAllByMovieAndUser()	0	20	1
A	findAllByMovie()	0	18	1

<?php

declare(strict_types=1);

namespace App\Movies\Repository;

use App\Movies\Entity\Movie;
use App\Movies\Entity\MovieRecommendation;
use App\Users\Entity\User;
use App\Users\Entity\UserInterestedMovie;
use App\Users\Entity\UserWatchedMovie;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\ORM\Query;
use Symfony\Bridge\Doctrine\RegistryInterface;

/**
 * @method Movie|null find($id, $lockMode = null, $lockVersion = null)
 * @method Movie|null findOneBy(array $criteria, array $orderBy = null)
 * @method Movie[]    findAll()
 * @method Movie[]    findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
 */
class MovieRecommendationRepository extends ServiceEntityRepository
{
    public function __construct(RegistryInterface $registry)
    {
        parent::__construct($registry, MovieRecommendation::class);
    }

    // todo joins for movie (genres, translations etc.)
    public function findAllByUser(int $userId, int $minVote = 7, ?User $currentUser = null): array
    {
        $items = $this->getEntityManager()->createQueryBuilder()
            ->select('m')
            ->from(Movie::class, 'm')
            ->leftJoin('m.translations', 'mt', null, null, 'mt.locale')
            ->addSelect('mt')
            ->where('m.id IN (:ids)');

        $ids = $this->getEntityManager()->createQueryBuilder()
            ->select('IDENTITY(mr.recommendedMovie), COUNT(mr.recommendedMovie) HIDDEN rate')
            ->from(UserWatchedMovie::class, 'uwm')
            ->leftJoin(MovieRecommendation::class, 'mr', 'WITH', 'uwm.movie = mr.originalMovie')
            ->where('uwm.user = :user AND uwm.vote >= :vote')
            ->setParameter('user', $userId)
            ->setParameter('vote', $minVote)
            ->groupBy('mr.recommendedMovie')
            ->orderBy('rate DESC, MAX(mr.id)', 'DESC');

        if ($currentUser !== null) {
            if ($currentUser->getId() === $userId) {
                $items = $items
                    ->addSelect('uwmj')
                    ->leftJoin('m.userWatchedMovie', 'uwmj', 'WITH', 'uwmj.user = :user')
                    ->andWhere('uwmj.id IS NULL')
                    ->setParameter('user', $currentUser->getId());

                $ids
                    ->leftJoin(UserWatchedMovie::class, 'uwmj', 'WITH', 'uwmj.movie = mr.recommendedMovie AND uwmj.user = :user')
                    ->andWhere('uwmj.id IS NULL')
                    ->setParameter('user', $currentUser->getId());
            } else {
                $items = $items
                    ->addSelect('uwmj')
                    ->leftJoin('m.userWatchedMovie', 'uwmj', 'WITH', 'uwmj.user = :currentUser')
                    ->setParameter('currentUser', $currentUser->getId());
            }
        }

        $count = $this->getEntityManager()->createQueryBuilder()
            ->select('COUNT(DISTINCT mr.recommendedMovie)')
            ->from(UserWatchedMovie::class, 'uwm')
            ->leftJoin(MovieRecommendation::class, 'mr', 'WITH', 'uwm.movie = mr.originalMovie')
            ->where('uwm.user = :user AND uwm.vote >= :vote')
            ->setParameter('user', $userId)
            ->setParameter('vote', $minVote);

        return [$items->getQuery(), $ids->getQuery(), $count->getQuery()];
    }

    public function findAllByMovieAndUser(int $movieId, int $userId): Query
    {
        $query = $this->getEntityManager()->createQueryBuilder()
            ->select('m, COUNT(mr.recommendedMovie) HIDDEN rate')
            ->from(MovieRecommendation::class, 'mr')
            ->leftJoin(Movie::class, 'm', 'WITH', 'mr.recommendedMovie = m')
            ->leftJoin('m.userRecommendedMovie', 'urm', 'WITH', 'urm.originalMovie = mr.originalMovie AND urm.user = :user')
            ->addSelect('urm')
            ->leftJoin('m.userInterestedMovie', 'uim', 'WITH', 'uim.user = :user')
            ->addSelect('uim')
            ->where('mr.originalMovie = :movie')
            ->setParameter('user', $userId)
            ->setParameter('movie', $movieId)
            ->groupBy('mr.recommendedMovie, m.id, urm.id, uim.id')
            ->orderBy('rate', 'DESC')
            ->addOrderBy('MAX(mr.id)', 'DESC')
            ->getQuery();

        return $query;
    }

    public function findAllByMovie(int $movieId): Query
    {
        $query = $this->getEntityManager()->createQueryBuilder()
            ->select('m, COUNT(mr.recommendedMovie) HIDDEN rate')
            ->from(MovieRecommendation::class, 'mr')
            ->leftJoin(Movie::class, 'm', 'WITH', 'mr.recommendedMovie = m')
            //->leftJoin('m.userRecommendedMovie', 'urm', 'WITH', 'urm.user = :user AND urm.recommendedMovie = mr.recommendedMovie')

72% of this comment could be valid code. Did you maybe forget this after debugging?

            //->addSelect('urm')
            ->where('mr.originalMovie = :movie')
            //->setParameter('user', $userId)

75% of this comment could be valid code. Did you maybe forget this after debugging?

            ->setParameter('movie', $movieId)
            ->groupBy('mr.recommendedMovie, m.id')
            ->orderBy('rate', 'DESC')
            ->addOrderBy('MAX(mr.id)', 'DESC')
            ->getQuery();

        return $query;
    }
}