App\Users\Controller\UserController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	131
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Test Coverage

Coverage

73.52%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	postUsers()	0	6	1
A	postConfirmEmail()	0	20	2
A	getUsers()	0	18	2
A	getAll()	0	12	1

<?php

namespace App\Users\Controller;

use App\Controller\ControllerInterface;
use App\Users\Entity\User;
use App\Users\Repository\ConfirmationTokenRepository;
use App\Users\Repository\UserRepository;
use App\Users\Request\ConfirmEmailRequest;
use App\Users\Request\RegisterUserRequest;
use App\Users\Service\RegisterService;
use FOS\RestBundle\Controller\FOSRestController;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Swagger\Annotations as SWG;
use Symfony\Component\Routing\Annotation\Route;
use Nelmio\ApiDocBundle\Annotation\Model;
use Symfony\Component\Security\Core\Exception\BadCredentialsException;
use Symfony\Component\Translation\TranslatorInterface;

class UserController extends FOSRestController implements ControllerInterface
{
    /**
     * @var \App\Users\Service\RegisterService
     */
    private $registerService;

    private $translator;

    public function __construct(RegisterService $registerService, TranslatorInterface $translator)
    {
        $this->registerService = $registerService;
        $this->translator = $translator;
    }

    /**
     * Registration
     *
     * @Route("/api/users", methods={"POST"})
     * @SWG\Parameter(name="registration.username", in="formData", type="string")
     * @SWG\Parameter(name="registration.password", in="formData", type="string")
     * @SWG\Parameter(name="registration.email", in="formData", type="string")
     * @SWG\Response(
     *     description="Registration.",
     *     response=202,
     *     @Model(type=User::class)
     * )
     * @param $request \App\Users\Request\RegisterUserRequest
     * @return User
     */
    public function postUsers(RegisterUserRequest $request)
    {
        $this->denyAccessUnlessGranted('IS_AUTHENTICATED_ANONYMOUSLY');

        return $this->registerService->registerByRequest($request);

The expression $this->registerService->registerByRequest($request); of type Symfony\Component\HttpFoundation\JsonResponse|App\Users\Entity\User adds the type Symfony\Component\HttpFoundation\JsonResponse to the return on line 55 which is incompatible with the return type documented by App\Users\Controller\UserController::postUsers of type App\Users\Entity\User.

    }

    /**
     * Confirm email
     *
     * @Route("/api/confirmEmail", methods={"POST"})
     * @SWG\Parameter(name="token", in="formData", type="string")
     * @SWG\Response(
     *     description="Email confirmed.",
     *     response=202
     * )
     * @param $request ConfirmEmailRequest
     * @param $confirmationTokenRepository \App\Users\Repository\ConfirmationTokenRepository
     * @return JsonResponse
     */
    public function postConfirmEmail(ConfirmEmailRequest $request, ConfirmationTokenRepository $confirmationTokenRepository)
    {
        $token = $request->get('token');

        if (null === $confirmationToken = $confirmationTokenRepository->findOneOrNullByToken($token)) {
            throw new BadCredentialsException($this->translator->trans('bad_email_confirmation_token', [
                'token' => $token,
            ], 'users'));
        }

        $user = $confirmationToken->getUser();
        $user->confirmEmail();

        $entityManager = $this->getDoctrine()->getManager();
        $entityManager->persist($user);
        $entityManager->remove($confirmationToken);
        $entityManager->flush();

        return new JsonResponse(null, 202);
    }

    /**
     * Get single user
     *
     * @Route("/api/users/{id}", methods={"GET"})
     * @SWG\Response(
     *     description="REST action which returns user by id.",
     *     response=200,
     *     @Model(type=User::class)
     * )
     *
     * @param int $id
     * @return User
     */
    public function getUsers($id)
    {
        $this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');

        /**
         * @var $userRepository \App\Users\Repository\UserRepository
         */
        $userRepository = $this->getDoctrine()->getRepository(User::class);
        $user = $userRepository->find($id);

        if ($user === null) {
            throw new NotFoundHttpException($this->translator->trans('not_found_by_id', [
                'user_id' => $id,
            ], 'users'));
        }

        return $user;
    }

    /**
     * Get all users
     *
     * @Route("/api/users", methods={"GET"})
     * @SWG\Response(
     *     description="REST action which returns all users.",
     *     response=200,
     *     @SWG\Schema(
     *         type="array",
     *         @SWG\Items(ref=@Model(type=User::class, groups={"full"}))
     *     )
     * )
     *
     * @return User[]
     */
    public function getAll()
    {
        $this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');

        /**
         * @var $userRepository UserRepository
         */
        $userRepository = $this->getDoctrine()->getRepository(User::class);
        $users = $userRepository->findAll();

        return $users;
    }
}