UserController::postConfirmEmail() - Code Metrics - Inspection of "Allow to set country as null" - svbackend/my-art-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c5110b...a167e6 )

by Valentyn

created 2018-11-02 18:32 UTC

UserController::postConfirmEmail() A

↳ Parent: UserController

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	20
ccs	13
cts	13
cp	1
rs	9.6
c	0
b	0
f	0
cc	2
nc	2
nop	3
crap	2

<?php

namespace App\Users\Controller;

use App\Controller\BaseController;
use App\Users\Entity\User;
use App\Users\Entity\UserRoles;
use App\Users\Event\UserRegisteredEvent;
use App\Users\Repository\ConfirmationTokenRepository;
use App\Users\Repository\UserRepository;
use App\Users\Request\ConfirmEmailRequest;
use App\Users\Request\RegisterUserRequest;
use App\Users\Request\UpdateUserRequest;
use App\Users\Service\RegisterService;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Translation\TranslatorInterface;
use Symfony\Component\Validator\Validator\ValidatorInterface;

class UserController extends BaseController
{
    /**
     * Registration.
     *
     * @Route("/api/users", methods={"POST"})
     *
     * @param RegisterUserRequest      $request
     * @param RegisterService          $registerService
     * @param EventDispatcherInterface $dispatcher
     * @param ValidatorInterface       $validator
     *
     * @return JsonResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function postUsers(RegisterUserRequest $request, RegisterService $registerService, EventDispatcherInterface $dispatcher, ValidatorInterface $validator)
    {
        if ($this->getUser() !== null) {
            throw new AccessDeniedHttpException();
        }

        $registeredUser = $registerService->registerByRequest($request);
        $errors = $validator->validate($registeredUser);

        if ($errors && $errors->count() !== 0) {
            return $request->getErrorResponse($errors);
        }

        $em = $this->getDoctrine()->getManager();
        $em->persist($registeredUser);
        $em->flush();

        $userRegisteredEvent = new UserRegisteredEvent($registeredUser);
        $dispatcher->dispatch(UserRegisteredEvent::NAME, $userRegisteredEvent);

        return $this->response($registeredUser, 200, [], [
            'groups' => ['view'],
        ]);
    }

    /**
     * Confirm email.
     *
     * @Route("/api/confirmEmail", methods={"POST"})
     *
     * @param ConfirmEmailRequest         $request
     * @param ConfirmationTokenRepository $confirmationTokenRepository
     * @param TranslatorInterface         $translator
     *
     * @throws
     *
     * @return JsonResponse
     */
    public function postConfirmEmail(ConfirmEmailRequest $request, ConfirmationTokenRepository $confirmationTokenRepository, TranslatorInterface $translator)
    {
        $token = $request->get('token');

        if (null === $confirmationToken = $confirmationTokenRepository->findByToken($token)) {
            throw new NotFoundHttpException($translator->trans('bad_email_confirmation_token', [
                'token' => $token,
            ], 'users'));
        }

        $user = $confirmationToken->getUser();
        $user->confirmEmail();

        $entityManager = $this->getDoctrine()->getManager();
        $entityManager->persist($user);
        $entityManager->remove($confirmationToken);
        $entityManager->flush();

        return new JsonResponse(null, 202);
    }

    /**
     * todo use param converter?
     * Get single user.
     *
     * @Route("/api/users/{id}", methods={"GET"}, requirements={"id"="\d+"})
     *
     * @param $id
     * @param TranslatorInterface $translator
     *
     * @return JsonResponse
     */
    public function getUsers($id, TranslatorInterface $translator)
    {
        $this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');
        /** @var $userRepository \App\Users\Repository\UserRepository */
        $userRepository = $this->getDoctrine()->getRepository(User::class);
        $user = $userRepository->find($id);

        if ($user === null) {
            throw new NotFoundHttpException($translator->trans('not_found_by_id', [
                'user_id' => $id,
            ], 'users'));
        }

        return $this->response($user, 200, [], [
            'groups' => ['view'],
        ]);
    }

    /**
     * Get single user by username.
     *
     * @Route("/api/users/byUsername/{username}", methods={"GET"})
     *
     * @param User $user
     *
     * @return JsonResponse
     */
    public function getUsersByUsername(User $user)
    {
        return $this->response($user, 200, [], [
            'groups' => ['view'],
        ]);
    }

    /**
     * @Route("/api/users/{id}", methods={"POST", "PUT", "PATCH"}, requirements={"id"="\d+"})
     *
     * @param User              $user
     * @param UpdateUserRequest $request
     *
     * @throws \Exception
     *
     * @return JsonResponse
     */
    public function putUsers(User $user, UpdateUserRequest $request)
    {
        $currentUser = $this->getUser();
        if ($currentUser === null) {
            $this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');
        }

        /** @var $currentUser User */
        if ($currentUser->getId() !== $user->getId()) {
            $this->denyAccessUnlessGranted(UserRoles::ROLE_ADMIN);
        }

        $profile = $user->getProfile();
        $profileData = $request->get('profile');
        $profile->setFirstName($profileData['first_name']);
        $profile->setLastName($profileData['last_name']);
        $profile->setBirthDate(new \DateTimeImmutable($profileData['birth_date']));
        $profile->setAbout($profileData['about']);
        $profile->setPublicEmail($profileData['public_email']);
        $profile->setCountryCode($profileData['country_code']);
        $this->getDoctrine()->getManager()->flush();

        return new JsonResponse(null, 202);
    }

    /**
     * Get all users.
     *
     * @Route("/api/users", methods={"GET"})
     */
    public function getAll()
    {
        $this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');

        /**
         * @var UserRepository
         */
        $userRepository = $this->getDoctrine()->getRepository(User::class);
        $users = $userRepository->findAll();

        return $this->response($users, 200, [], [
            'groups' => ['list'],
        ]);
    }

    /**
     * @Route("/api/users/me", methods={"GET"})
     */
    public function getMe()
    {
        $this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');

        return $this->response($this->getUser(), 200, [], [
            'groups' => ['view'],
        ]);
    }
}


1		<?php
2
3		namespace App\Users\Controller;
4
5		use App\Controller\BaseController;
6		use App\Users\Entity\User;
7		use App\Users\Entity\UserRoles;
8		use App\Users\Event\UserRegisteredEvent;
9		use App\Users\Repository\ConfirmationTokenRepository;
10		use App\Users\Repository\UserRepository;
11		use App\Users\Request\ConfirmEmailRequest;
12		use App\Users\Request\RegisterUserRequest;
13		use App\Users\Request\UpdateUserRequest;
14		use App\Users\Service\RegisterService;
15		use Symfony\Component\EventDispatcher\EventDispatcherInterface;
16		use Symfony\Component\HttpFoundation\JsonResponse;
17		use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
18		use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
19		use Symfony\Component\Routing\Annotation\Route;
20		use Symfony\Component\Translation\TranslatorInterface;
21		use Symfony\Component\Validator\Validator\ValidatorInterface;
22
23		class UserController extends BaseController
24		{
25		/**
26		* Registration.
27		*
28		* @Route("/api/users", methods={"POST"})
29		*
30		* @param RegisterUserRequest $request
31		* @param RegisterService $registerService
32		* @param EventDispatcherInterface $dispatcher
33		* @param ValidatorInterface $validator
34		*
35		* @return JsonResponse\|\Symfony\Component\HttpFoundation\Response
36		*/
37	3	public function postUsers(RegisterUserRequest $request, RegisterService $registerService, EventDispatcherInterface $dispatcher, ValidatorInterface $validator)
38		{
39	3	if ($this->getUser() !== null) {
40		throw new AccessDeniedHttpException();
41		}
42
43	3	$registeredUser = $registerService->registerByRequest($request);
44	3	$errors = $validator->validate($registeredUser);
45
46	3	if ($errors && $errors->count() !== 0) {
47	1	return $request->getErrorResponse($errors);
48		}
49
50	2	$em = $this->getDoctrine()->getManager();
51	2	$em->persist($registeredUser);
52	2	$em->flush();
53
54	2	$userRegisteredEvent = new UserRegisteredEvent($registeredUser);
55	2	$dispatcher->dispatch(UserRegisteredEvent::NAME, $userRegisteredEvent);
56
57	2	return $this->response($registeredUser, 200, [], [
58	2	'groups' => ['view'],
59		]);
60		}
61
62		/**
63		* Confirm email.
64		*
65		* @Route("/api/confirmEmail", methods={"POST"})
66		*
67		* @param ConfirmEmailRequest $request
68		* @param ConfirmationTokenRepository $confirmationTokenRepository
69		* @param TranslatorInterface $translator
70		*
71		* @throws
72		*
73		* @return JsonResponse
74		*/
75	2	public function postConfirmEmail(ConfirmEmailRequest $request, ConfirmationTokenRepository $confirmationTokenRepository, TranslatorInterface $translator)
76		{
77	2	$token = $request->get('token');
78
79	2	if (null === $confirmationToken = $confirmationTokenRepository->findByToken($token)) {
80	1	throw new NotFoundHttpException($translator->trans('bad_email_confirmation_token', [
81	1	'token' => $token,
82	1	], 'users'));
83		}
84
85	1	$user = $confirmationToken->getUser();
86	1	$user->confirmEmail();
87
88	1	$entityManager = $this->getDoctrine()->getManager();
89	1	$entityManager->persist($user);
90	1	$entityManager->remove($confirmationToken);
91	1	$entityManager->flush();
92
93	1	return new JsonResponse(null, 202);
94		}
95
96		/**
97		* todo use param converter?
98		* Get single user.
99		*
100		* @Route("/api/users/{id}", methods={"GET"}, requirements={"id"="\d+"})
101		*
102		* @param $id
103		* @param TranslatorInterface $translator
104		*
105		* @return JsonResponse
106		*/
107	3	public function getUsers($id, TranslatorInterface $translator)
108		{
109	3	$this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');
110		/** @var $userRepository \App\Users\Repository\UserRepository */
111	2	$userRepository = $this->getDoctrine()->getRepository(User::class);
112	2	$user = $userRepository->find($id);
113
114	2	if ($user === null) {
115	1	throw new NotFoundHttpException($translator->trans('not_found_by_id', [
116	1	'user_id' => $id,
117	1	], 'users'));
118		}
119
120	1	return $this->response($user, 200, [], [
121	1	'groups' => ['view'],
122		]);
123		}
124
125		/**
126		* Get single user by username.
127		*
128		* @Route("/api/users/byUsername/{username}", methods={"GET"})
129		*
130		* @param User $user
131		*
132		* @return JsonResponse
133		*/
134		public function getUsersByUsername(User $user)
135		{
136		return $this->response($user, 200, [], [
137		'groups' => ['view'],
138		]);
139		}
140
141		/**
142		* @Route("/api/users/{id}", methods={"POST", "PUT", "PATCH"}, requirements={"id"="\d+"})
143		*
144		* @param User $user
145		* @param UpdateUserRequest $request
146		*
147		* @throws \Exception
148		*
149		* @return JsonResponse
150		*/
151	4	public function putUsers(User $user, UpdateUserRequest $request)
152		{
153	4	$currentUser = $this->getUser();
154	4	if ($currentUser === null) {
155	1	$this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');
156		}
157
158		/** @var $currentUser User */
159	3	if ($currentUser->getId() !== $user->getId()) {
160	2	$this->denyAccessUnlessGranted(UserRoles::ROLE_ADMIN);
161		}
162
163	2	$profile = $user->getProfile();
164	2	$profileData = $request->get('profile');
165	2	$profile->setFirstName($profileData['first_name']);
166	2	$profile->setLastName($profileData['last_name']);
167	2	$profile->setBirthDate(new \DateTimeImmutable($profileData['birth_date']));
168	2	$profile->setAbout($profileData['about']);
169	2	$profile->setPublicEmail($profileData['public_email']);
170	2	$profile->setCountryCode($profileData['country_code']);
171	2	$this->getDoctrine()->getManager()->flush();
172
173	2	return new JsonResponse(null, 202);
174		}
175
176		/**
177		* Get all users.
178		*
179		* @Route("/api/users", methods={"GET"})
180		*/
181	3	public function getAll()
182		{
183	3	$this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');
184
185		/**
186		* @var UserRepository
187		*/
188	2	$userRepository = $this->getDoctrine()->getRepository(User::class);
189	2	$users = $userRepository->findAll();
190
191	2	return $this->response($users, 200, [], [
192	2	'groups' => ['list'],
193		]);
194		}
195
196		/**
197		* @Route("/api/users/me", methods={"GET"})
198		*/
199	5	public function getMe()
200		{
201	5	$this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY');
202
203	5	return $this->response($this->getUser(), 200, [], [
204	5	'groups' => ['view'],
205		]);
206		}
207		}
208

svbackend / my-art-lib

Push — master ( c5110b...a167e6 )

UserController::postConfirmEmail() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like