Country::__construct() - Code Metrics - Inspection of "Allow to set country as null" - svbackend/my-art-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c5110b...a167e6 )

by Valentyn

created 2018-11-02 18:32 UTC

Country::__construct() A

↳ Parent: Country

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	0
cts	5
cp	0
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	6

<?php

declare(strict_types=1);

namespace App\Countries\Entity;

use Doctrine\ORM\Mapping as ORM;
use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;

/**
 * @ORM\Entity(repositoryClass="App\Countries\Repository\CountryRepository")
 * @ORM\Table(name="countries")
 * @UniqueEntity(fields="code", message="This code already exists")
 */
class Country
{
    /**
     * @ORM\Id()
     * @ORM\GeneratedValue()
     * @ORM\Column(type="integer")
     */
    private $id;

    /**
     * @ORM\Column(type="string", length=3, unique=true)
     */
    private $code;

    /**
     * @ORM\Column(type="string", length=50, unique=true)
     */
    private $name;

    public function __construct(string $name, string $code)
    {
        // todo movie to db constraint
        if (mb_strlen($code) !== 3) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            // throw new \InvalidArgumentException(sprintf('"%s" should be exactly 3 characters long', $code));

        }

        $this->code = mb_strtoupper($code);
        $this->name = ucfirst($name);
    }

    public function getId()
    {
        return $this->id;
    }

    public function getCode(): string
    {
        return $this->code;
    }

    public function getName(): string
    {
        return $this->name;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace App\Countries\Entity;
6
7			use Doctrine\ORM\Mapping as ORM;
8			use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;
9
10			/**
11			* @ORM\Entity(repositoryClass="App\Countries\Repository\CountryRepository")
12			* @ORM\Table(name="countries")
13			* @UniqueEntity(fields="code", message="This code already exists")
14			*/
15			class Country
16			{
17			/**
18			* @ORM\Id()
19			* @ORM\GeneratedValue()
20			* @ORM\Column(type="integer")
21			*/
22			private $id;
23
24			/**
25			* @ORM\Column(type="string", length=3, unique=true)
26			*/
27			private $code;
28
29			/**
30			* @ORM\Column(type="string", length=50, unique=true)
31			*/
32			private $name;
33
34			public function __construct(string $name, string $code)
35			{
36			// todo movie to db constraint
37			if (mb_strlen($code) !== 3) {
			0 ignored issues – show Unused Code introduced 2018-11-02 18:46 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
38			// throw new \InvalidArgumentException(sprintf('"%s" should be exactly 3 characters long', $code));
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-11-02 18:46 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
39			}
40
41			$this->code = mb_strtoupper($code);
42			$this->name = ucfirst($name);
43			}
44
45			public function getId()
46			{
47			return $this->id;
48			}
49
50			public function getCode(): string
51			{
52			return $this->code;
53			}
54
55			public function getName(): string
56			{
57			return $this->name;
58			}
59			}
60

svbackend / my-art-lib

Push — master ( c5110b...a167e6 )

Country::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like