BaseController::appendRolesToContextGroups() - Code Metrics - Inspection of "VS_0 BaseRequest now without state" - svbackend/my-art-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 572f95...1f2c43 )

by Valentyn

created 2018-05-03 12:48 UTC

BaseController::appendRolesToContextGroups() A

↳ Parent: BaseController

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	4.25

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	6
cts	8
cp	0.75
rs	9.2
c	0
b	0
f	0
cc	4
eloc	10
nc	4
nop	1
crap	4.25

<?php
declare(strict_types=1);

namespace App\Controller;

use App\Translation\TranslatedResponseTrait;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;

/**
 * Class BaseController
 * @package App\Controller
 */
abstract class BaseController extends Controller implements ControllerInterface
{
    use TranslatedResponseTrait;

    /**
     * @param $data
     * @param int $status
     * @param array $headers
     * @param array $context
     * @return JsonResponse
     */
    protected function response($data, int $status = 200, array $headers = [], array $context = []): JsonResponse
    {
        $contextWithRoles = $this->appendRolesToContextGroups($context);
        $translatedContent = $this->translateResponse($data, $contextWithRoles);

        return $this->json($translatedContent, $status, $headers, $context);
    }

    private function appendRolesToContextGroups(?array $context): array
    {
        if ($this->getUser() === null) return $context;

        if ($context === null) {
            return [
                'groups' => $this->getUser()->getRoles(),
            ];
        }

        if (isset($context['groups'])) {
            $context['groups'] = array_merge($context['groups'], $this->getUser()->getRoles());
        } else {
            $context['groups'] = $this->getUser()->getRoles();
        }

        return $context;
    }
}

1		<?php
2		declare(strict_types=1);
3
4		namespace App\Controller;
5
6		use App\Translation\TranslatedResponseTrait;
7		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
8		use Symfony\Component\HttpFoundation\JsonResponse;
9
10		/**
11		* Class BaseController
12		* @package App\Controller
13		*/
14		abstract class BaseController extends Controller implements ControllerInterface
15		{
16		use TranslatedResponseTrait;
17
18		/**
19		* @param $data
20		* @param int $status
21		* @param array $headers
22		* @param array $context
23		* @return JsonResponse
24		*/
25	15	protected function response($data, int $status = 200, array $headers = [], array $context = []): JsonResponse
26		{
27	15	$contextWithRoles = $this->appendRolesToContextGroups($context);
28	15	$translatedContent = $this->translateResponse($data, $contextWithRoles);
29
30	15	return $this->json($translatedContent, $status, $headers, $context);
31		}
32
33	15	private function appendRolesToContextGroups(?array $context): array
34		{
35	15	if ($this->getUser() === null) return $context;
36
37	5	if ($context === null) {
38		return [
39		'groups' => $this->getUser()->getRoles(),
40		];
41		}
42
43	5	if (isset($context['groups'])) {
44	5	$context['groups'] = array_merge($context['groups'], $this->getUser()->getRoles());
45		} else {
46		$context['groups'] = $this->getUser()->getRoles();
47		}
48
49	5	return $context;
50		}
51		}

svbackend / my-art-lib

Push — master ( 572f95...1f2c43 )

BaseController::appendRolesToContextGroups() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like