UsersFixtures::createTestApiToken() - Code Metrics - Inspection of "VS Swift Mailer" - svbackend/my-art-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1ba492...c9d345 )

by Valentyn

created 2018-04-19 13:42 UTC

UsersFixtures::createTestApiToken() A

↳ Parent: UsersFixtures

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	3

<?php

namespace App\DataFixtures;

use App\Entity\User;
use App\Entity\UserProfile;
use App\Entity\UserProfileContacts;
use Doctrine\Bundle\FixturesBundle\Fixture;
use Doctrine\Common\Persistence\ObjectManager;
use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;

class UsersFixtures extends Fixture
{
    const TESTER_EMAIL = '[email protected]';
    const TESTER_USERNAME = 'tester_fixture';
    const TESTER_PASSWORD = '123456';
    const TESTER_API_TOKEN = 'tester_api_token';

    private $encoder;

    public function __construct(UserPasswordEncoderInterface $encoder)
    {
        $this->encoder = $encoder;
    }

    public function load(ObjectManager $manager): void
    {
        $user = new User();
        $user->username = 'tester_fixture';
        $user->email = '[email protected]';
        $user->setPassword('123456', $this->encoder);

        $profile = $user->getProfile();
        $profile->first_name = 'First';
        $profile->last_name = 'Last';

        for ($i = 3; $i--> 0;) {
            $profile->addContacts("TestProvider #{$i}", "https://test.com/{$i}/info");
        }

        $manager->persist($user);
        $manager->flush();

        $this->createTestApiToken($user, self::TESTER_API_TOKEN, $manager);
    }

    private function createTestApiToken(User $user, string $token, ObjectManager $manager): void
    {
        $manager->getConnection()->exec("INSERT INTO users_api_tokens (id, user_id, token) VALUES (NEXTVAL('users_api_tokens_id_seq'), {$user->getId()}, '{$token}');");
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}

1			<?php
2
3			namespace App\DataFixtures;
4
5			use App\Entity\User;
6			use App\Entity\UserProfile;
7			use App\Entity\UserProfileContacts;
8			use Doctrine\Bundle\FixturesBundle\Fixture;
9			use Doctrine\Common\Persistence\ObjectManager;
10			use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;
11
12			class UsersFixtures extends Fixture
13			{
14			const TESTER_EMAIL = '[email protected]';
15			const TESTER_USERNAME = 'tester_fixture';
16			const TESTER_PASSWORD = '123456';
17			const TESTER_API_TOKEN = 'tester_api_token';
18
19			private $encoder;
20
21			public function __construct(UserPasswordEncoderInterface $encoder)
22			{
23			$this->encoder = $encoder;
24			}
25
26			public function load(ObjectManager $manager): void
27			{
28			$user = new User();
29			$user->username = 'tester_fixture';
30			$user->email = '[email protected]';
31			$user->setPassword('123456', $this->encoder);
32
33			$profile = $user->getProfile();
34			$profile->first_name = 'First';
35			$profile->last_name = 'Last';
36
37			for ($i = 3; $i--> 0;) {
38			$profile->addContacts("TestProvider #{$i}", "https://test.com/{$i}/info");
39			}
40
41			$manager->persist($user);
42			$manager->flush();
43
44			$this->createTestApiToken($user, self::TESTER_API_TOKEN, $manager);
45			}
46
47			private function createTestApiToken(User $user, string $token, ObjectManager $manager): void
48			{
49			$manager->getConnection()->exec("INSERT INTO users_api_tokens (id, user_id, token) VALUES (NEXTVAL('users_api_tokens_id_seq'), {$user->getId()}, '{$token}');");
			0 ignored issues – show Bug introduced 2018-04-19 13:48 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Doctrine\Common\Persistence\ObjectManager` as the method `getConnection()` does only exist in the following implementations of said interface: `Doctrine\ORM\Decorator\EntityManagerDecorator`, `Doctrine\ORM\EntityManager`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
50			}
51			}

svbackend / my-art-lib

Push — master ( 1ba492...c9d345 )

UsersFixtures::createTestApiToken() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like