MovieActorController::getMoviesActors() - Code Metrics - Inspection of "VS-0 Some cache usage for get movie and get actor..." - svbackend/my-art-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ea3b27...7da27d )

by Valentyn

created 2018-08-10 16:24 UTC

MovieActorController::getMoviesActors() A

↳ Parent: MovieActorController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	7
cts	7
cp	1
rs	9.8333
c	0
b	0
f	0
cc	1
nc	1
nop	3
crap	1

<?php

namespace App\Movies\Controller;

use App\Controller\BaseController;
use App\Movies\Repository\MovieActorRepository;
use App\Movies\Service\TmdbSearchService;
use App\Pagination\PaginatedCollection;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Annotation\Route;

class MovieActorController extends BaseController
{
    /**
     * @Route("/api/movies/{id}/actors", methods={"GET"}, requirements={"id"="\d+"})
     *
     * @param Request              $request
     * @param int                  $id
     * @param MovieActorRepository $repository
     *
     * @return JsonResponse
     */
    public function getMoviesActors(Request $request, int $id, MovieActorRepository $repository)
    {
        $actors = $repository->findAllByMovie($id);

        $offset = (int) $request->get('offset', 0);
        $limit = $request->get('limit', null);

        $collection = new PaginatedCollection($actors, $offset, $limit);

        return $this->response($collection, 200, [], [
            'groups' => ['list'],
        ]);
    }

    /**
     * @Route("/api/test", methods={"GET"})
     */
    public function test(TmdbSearchService $service)
    {
        return new JsonResponse($service->findMovieById(146));
    }
}


1		<?php
2
3		namespace App\Movies\Controller;
4
5		use App\Controller\BaseController;
6		use App\Movies\Repository\MovieActorRepository;
7		use App\Movies\Service\TmdbSearchService;
8		use App\Pagination\PaginatedCollection;
9		use Symfony\Component\HttpFoundation\JsonResponse;
10		use Symfony\Component\HttpFoundation\Request;
11		use Symfony\Component\Routing\Annotation\Route;
12
13		class MovieActorController extends BaseController
14		{
15		/**
16		* @Route("/api/movies/{id}/actors", methods={"GET"}, requirements={"id"="\d+"})
17		*
18		* @param Request $request
19		* @param int $id
20		* @param MovieActorRepository $repository
21		*
22		* @return JsonResponse
23		*/
24	1	public function getMoviesActors(Request $request, int $id, MovieActorRepository $repository)
25		{
26	1	$actors = $repository->findAllByMovie($id);
27
28	1	$offset = (int) $request->get('offset', 0);
29	1	$limit = $request->get('limit', null);
30
31	1	$collection = new PaginatedCollection($actors, $offset, $limit);
32
33	1	return $this->response($collection, 200, [], [
34	1	'groups' => ['list'],
35		]);
36		}
37
38		/**
39		* @Route("/api/test", methods={"GET"})
40		*/
41		public function test(TmdbSearchService $service)
42		{
43		return new JsonResponse($service->findMovieById(146));
44		}
45		}
46

svbackend / my-art-lib

Push — master ( ea3b27...7da27d )

MovieActorController::getMoviesActors() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like