Category::__construct() - Code Metrics - Inspection of "protected var tests" - suricate-php/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 5cbd49...d5f7f5 )

by Mathieu

created 2019-01-27 13:45 UTC

Category::__construct() A

↳ Parent: Category

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
cc	1
eloc	13
nc	1
nop	0
dl	0
loc	19
rs	9.8333
c	3
b	0
f	1

<?php

class Category extends \Suricate\DBObject
{
    protected $tableName = 'categories';
    protected $tableIndex = 'id';

    public function __construct()
    {
        parent::__construct();
        $database = new \Suricate\Database();
        $database->configure([
            'type' => 'sqlite',
            'file' => '/tmp/test.db',
        ]);
        $this->dbLink = $database;

        $this->dbVariables = [
            'id',
            'name',
            'parent_id',
        ];

        $this->protectedVariables = [
            'prot_var',
            'unloadable',
        ];
    }

    protected function accessToProtectedVariable($name)
    {
        switch ($name) {
            case 'prot_var':
                $this->prot_var = 42;

                return true;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'unloadable':
                return false;
        }
    }
}


1			<?php
2
3			class Category extends \Suricate\DBObject
4			{
5			protected $tableName = 'categories';
6			protected $tableIndex = 'id';
7
8			public function __construct()
9			{
10			parent::__construct();
11			$database = new \Suricate\Database();
12			$database->configure([
13			'type' => 'sqlite',
14			'file' => '/tmp/test.db',
15			]);
16			$this->dbLink = $database;
17
18			$this->dbVariables = [
19			'id',
20			'name',
21			'parent_id',
22			];
23
24			$this->protectedVariables = [
25			'prot_var',
26			'unloadable',
27			];
28			}
29
30			protected function accessToProtectedVariable($name)
31			{
32			switch ($name) {
33			case 'prot_var':
34			$this->prot_var = 42;
			0 ignored issues – show Bug Best Practice introduced 2019-01-27 13:46 UTC by Report Bug Copy Issue Report The property `prot_var` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
35			return true;
36			break;
			0 ignored issues – show Unused Code introduced 2019-01-27 13:46 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
37			case 'unloadable':
38			return false;
39			}
40			}
41			}
42

suricate-php / framework

Push — develop ( 5cbd49...d5f7f5 )

Category::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like