CollectionMapping::save() - Code Metrics - Inspection of "v0.2" - suricate-php/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Mathieu

created 2019-03-20 20:46 UTC

CollectionMapping::save() B

↳ Parent: Project

Complexity

Conditions	7
Paths	10

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
nc	10
nop	0
dl	0
loc	58
rs	7.983
c	0
b	0
f	0

How to fix Long Method

<?php declare(strict_types=1);
namespace Suricate;
/*
class CollectionMapping extends Collection
{
    const SQL_RELATION_TABLE_NAME   = '';
    const MAPPING_ID_NAME           = '';

    protected $additionalMappingFieldList = [];

    public static function loadForParentId($parentId)
    {

        $calledClass   = get_called_class();
        $collection     = new $calledClass;

        $itemName = $collection::ITEM_TYPE;

        $sql            = '';
        $sqlParams      = [];

        $sql .= "SELECT a.*";
        if (count($collection->additionalMappingFieldList)) {
            $sql .= ', b.' . implode(',b.', $collection->additionalMappingFieldList);
        }
        $sql .= " FROM `" . $collection::TABLE_NAME . "` a";
        $sql .= " RIGHT JOIN `" . $collection::SQL_RELATION_TABLE_NAME . "` b";
        $sql .= "   ON b." . $collection::MAPPING_ID_NAME . "=a." . $itemName->getTableIndex();
        $sql .= " WHERE";
        $sql .= "   " . $collection::PARENT_ID_NAME . "=:parent_id";

        $sqlParams['parent_id'] = $parentId;

        $results = Suricate::Database()->query($sql, $sqlParams)->fetchAll();

        if ($results !== false) {
            foreach ($results as $currentResult) {
                $itemName = $collection::ITEM_TYPE;
                $collection->addItem($itemName::buildFromArray($currentResult));
            }
        }
        $collection->parent_id = $parentId;

        return $collection;
    }

    public function setParentIdForAll($parentId)
    {
        $this->parent_id = $parentId;
    }

    public function save()
    {
        $dbHandler     = Suricate::Database(true);

        if ($this->parent_id != '') {
            // 1st step : delete all records for current parent_id
            $sql  = "DELETE FROM `" . static::SQL_RELATION_TABLE_NAME . "`";
            $sql .= " WHERE";
            $sql .= "   " . static::PARENT_ID_NAME . "=:parent_id";

            $sqlParams      = [];
            $sqlParams['parent_id'] = $this->parent_id;

            $dbHandler->query($sql, $sqlParams);

            // 2nd step : create items that are not saved in db
            foreach ($this->items as &$currentItem) {
                if ($currentItem->{$currentItem->getTableIndex()} == '') {
                    $currentItem->save();
                }

                //3rd step : create the mapping
                $sqlParams = [];

                $sql  = "INSERT INTO `" . static::SQL_RELATION_TABLE_NAME . "`";
                $sql .= " (`" . static::PARENT_ID_NAME . "`, `" . static::MAPPING_ID_NAME. "`";
                if (count($this->additionalMappingFieldList)) {
                    $sql .= ', ' . implode(
                        ",",
                        array_map(
                            function ($s) {
                                return '`' . $s . '`';
                            },
                            $this->additionalMappingFieldList
                        )
                    );
                }
                
                $sql .= ")";
                $sql .= " VALUES";
                $sql .= "(:parent_id, :id";
                if (count($this->additionalMappingFieldList)) {
                    foreach ($this->additionalMappingFieldList as $additionalField) {
                        $sql .= ',:' . $additionalField;
                        $sqlParams[$additionalField] = $currentItem->$additionalField;
                    }
                }
                
                $sql .= ")";

                
                $sqlParams['parent_id'] = $this->parent_id;
                $sqlParams['id']        = $currentItem->id;

                $dbHandler->query($sql, $sqlParams);
            }
        }
    }

    public function craftItem($itemData)
    {
        $itemName = static::ITEM_TYPE;
        
        foreach ($itemData as $data) {
            $newItem       = new $itemName();
            $hasData       = false;

            // One field contains item unique index, load from it
            if (isset($data[$newItem->getTableIndex()]) && $data[$newItem->getTableIndex()] != '') {
                $newItem->load($data[$newItem->getTableIndex()]);
            } else {
                // Build SQL query to load corresponding item
                $sqlData = [];
                

                $sql  = "SELECT *";
                $sql .= " FROM `" . $newItem::TABLE_NAME . "`";
                $sql .= " WHERE";
                foreach ($data as $field => $value) {
                    if ($newItem->isDBVariable($field)) {
                        $sqlData[$field] = $value;
                        $sql .= "   `" . $field . "`=:$field";
                    }
                }

                $newItem->loadFromSql($sql, $sqlData);
            }

            // Assign properties to object
            foreach ($data as $field => $value) {
                $newItem->$field = $value;
                $hasData = $hasData || ($value != '');
            }
            // Object is not empty, adding it to collection
            if ($hasData) {
                $this->addItem($newItem);
            }
        }
    }
}
*/

1			<?php declare(strict_types=1);
2			namespace Suricate;
3			/*
4			class CollectionMapping extends Collection
5			{
6			const SQL_RELATION_TABLE_NAME = '';
7			const MAPPING_ID_NAME = '';
8
9			protected $additionalMappingFieldList = [];
10
11			public static function loadForParentId($parentId)
12			{
13
14			$calledClass = get_called_class();
15			$collection = new $calledClass;
16
17			$itemName = $collection::ITEM_TYPE;
18
19			$sql = '';
20			$sqlParams = [];
21
22			$sql .= "SELECT a.*";
23			if (count($collection->additionalMappingFieldList)) {
24			$sql .= ', b.' . implode(',b.', $collection->additionalMappingFieldList);
25			}
26			$sql .= " FROM `" . $collection::TABLE_NAME . "` a";
27			$sql .= " RIGHT JOIN `" . $collection::SQL_RELATION_TABLE_NAME . "` b";
28			$sql .= " ON b." . $collection::MAPPING_ID_NAME . "=a." . $itemName->getTableIndex();
29			$sql .= " WHERE";
30			$sql .= " " . $collection::PARENT_ID_NAME . "=:parent_id";
31
32			$sqlParams['parent_id'] = $parentId;
33
34			$results = Suricate::Database()->query($sql, $sqlParams)->fetchAll();
35
36			if ($results !== false) {
37			foreach ($results as $currentResult) {
38			$itemName = $collection::ITEM_TYPE;
39			$collection->addItem($itemName::buildFromArray($currentResult));
40			}
41			}
42			$collection->parent_id = $parentId;
43
44			return $collection;
45			}
46
47			public function setParentIdForAll($parentId)
48			{
49			$this->parent_id = $parentId;
50			}
51
52			public function save()
53			{
54			$dbHandler = Suricate::Database(true);
55
56			if ($this->parent_id != '') {
57			// 1st step : delete all records for current parent_id
58			$sql = "DELETE FROM `" . static::SQL_RELATION_TABLE_NAME . "`";
59			$sql .= " WHERE";
60			$sql .= " " . static::PARENT_ID_NAME . "=:parent_id";
61
62			$sqlParams = [];
63			$sqlParams['parent_id'] = $this->parent_id;
64
65			$dbHandler->query($sql, $sqlParams);
66
67			// 2nd step : create items that are not saved in db
68			foreach ($this->items as &$currentItem) {
69			if ($currentItem->{$currentItem->getTableIndex()} == '') {
70			$currentItem->save();
71			}
72
73			//3rd step : create the mapping
74			$sqlParams = [];
75
76			$sql = "INSERT INTO `" . static::SQL_RELATION_TABLE_NAME . "`";
77			$sql .= " (`" . static::PARENT_ID_NAME . "`, `" . static::MAPPING_ID_NAME. "`";
78			if (count($this->additionalMappingFieldList)) {
79			$sql .= ', ' . implode(
80			",",
81			array_map(
82			function ($s) {
83			return '`' . $s . '`';
84			},
85			$this->additionalMappingFieldList
86			)
87			);
88			}
89
90			$sql .= ")";
91			$sql .= " VALUES";
92			$sql .= "(:parent_id, :id";
93			if (count($this->additionalMappingFieldList)) {
94			foreach ($this->additionalMappingFieldList as $additionalField) {
95			$sql .= ',:' . $additionalField;
96			$sqlParams[$additionalField] = $currentItem->$additionalField;
97			}
98			}
99
100			$sql .= ")";
101
102
103			$sqlParams['parent_id'] = $this->parent_id;
104			$sqlParams['id'] = $currentItem->id;
105
106			$dbHandler->query($sql, $sqlParams);
107			}
108			}
109			}
110
111			public function craftItem($itemData)
112			{
113			$itemName = static::ITEM_TYPE;
114
115			foreach ($itemData as $data) {
116			$newItem = new $itemName();
117			$hasData = false;
118
119			// One field contains item unique index, load from it
120			if (isset($data[$newItem->getTableIndex()]) && $data[$newItem->getTableIndex()] != '') {
121			$newItem->load($data[$newItem->getTableIndex()]);
122			} else {
123			// Build SQL query to load corresponding item
124			$sqlData = [];
125
126
127			$sql = "SELECT *";
128			$sql .= " FROM `" . $newItem::TABLE_NAME . "`";
129			$sql .= " WHERE";
130			foreach ($data as $field => $value) {
131			if ($newItem->isDBVariable($field)) {
132			$sqlData[$field] = $value;
133			$sql .= " `" . $field . "`=:$field";
134			}
135			}
136
137			$newItem->loadFromSql($sql, $sqlData);
138			}
139
140			// Assign properties to object
141			foreach ($data as $field => $value) {
142			$newItem->$field = $value;
143			$hasData = $hasData \|\| ($value != '');
144			}
145			// Object is not empty, adding it to collection
146			if ($hasData) {
147			$this->addItem($newItem);
148			}
149			}
150			}
151			}
152			*/

suricate-php / framework

Pull Request — master (#2)

CollectionMapping::save() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like