suralc / pvra

src/InformationProvider/LibraryInformation.php

Spacing +14 added lines, -14 removed lines

@@ -27,15 +27,15 @@ 
     /**
      * @var array
      */
-    private $additions = [];
+    private $additions = [ ];
     /**
      * @var array
      */
-    private $deprecations = [];
+    private $deprecations = [ ];
     /**
      * @var array
      */
-    private $removals = [];
+    private $removals = [ ];
 
     /**
      * Create a new instance and load default information
@@ -76,19 +76,19 @@ 
      *
      * @param array $data Array representation of data to represent
      */
-    public function __construct(array $data = [])
+    public function __construct(array $data = [ ])
     {
-        if (isset($data['additions'])) {
-            $this->additions = $data['additions'];
+        if (isset($data[ 'additions' ])) {
+            $this->additions = $data[ 'additions' ];
         }
-        if (isset($data['deprecations'])) {
-            $this->deprecations = $data['deprecations'];
+        if (isset($data[ 'deprecations' ])) {
+            $this->deprecations = $data[ 'deprecations' ];
         }
-        if (isset($data['removals'])) {
-            $this->removals = $data['removals'];
+        if (isset($data[ 'removals' ])) {
+            $this->removals = $data[ 'removals' ];
         }
 
-        $baseArray = ['class' => [], 'function' => [], 'constant' => []];
+        $baseArray = [ 'class' => [ ], 'function' => [ ], 'constant' => [ ] ];
         $this->additions += $baseArray;
         $this->deprecations += $baseArray;
         $this->removals += $baseArray;
@@ -112,9 +112,9 @@ 
     public function mergeWith(LibraryInformationInterface $info)
     {
         $newInfo = $info->toArray();
-        $this->additions = array_replace_recursive($this->additions, $newInfo['additions']);
-        $this->deprecations = array_replace_recursive($this->deprecations, $newInfo['deprecations']);
-        $this->removals = array_replace_recursive($this->removals, $newInfo['removals']);
+        $this->additions = array_replace_recursive($this->additions, $newInfo[ 'additions' ]);
+        $this->deprecations = array_replace_recursive($this->deprecations, $newInfo[ 'deprecations' ]);
+        $this->removals = array_replace_recursive($this->removals, $newInfo[ 'removals' ]);
         return $this;
     }
 

src/Analysers/Php53Features.php

Spacing +7 added lines, -7 removed lines

@@ -54,7 +54,7 @@ 
         if ($this->isClassDeclarationStatement($node)) {
             $this->inClass = true;
         }
-        if($this->mode & self::MODE_ADDITION) {
+        if ($this->mode & self::MODE_ADDITION) {
             $this->detectGotoKeywordAndJumpLabel($node);
             $this->detectNamespaces($node);
             $this->detectNowDoc($node);
@@ -65,7 +65,7 @@ 
             $this->detectDynamicAccessToStatic($node);
             $this->detectLateStateBinding($node);
         }
-        if($this->mode & self::MODE_DEPRECATION) {
+        if ($this->mode & self::MODE_DEPRECATION) {
             $this->detectNewByReference($node);
         }
     }
@@ -99,14 +99,14 @@ 
                 Reason::GOTO_KEYWORD,
                 $node->getLine(),
                 null,
-                ['name' => $node->name]
+                [ 'name' => $node->name ]
             );
         } elseif ($node instanceof Node\Stmt\Label) {
             $this->getResult()->addRequirement(
                 Reason::JUMP_LABEL,
                 $node->getLine(),
                 null,
-                ['name' => $node->name]
+                [ 'name' => $node->name ]
             );
         }
     }
@@ -121,7 +121,7 @@ 
                 Reason::NAMESPACE_DECLERATION,
                 $node->getLine(),
                 null,
-                ['name' => isset($node->name) ? $node->name->toString() : '::global::']
+                [ 'name' => isset($node->name) ? $node->name->toString() : '::global::' ]
             );
         } elseif ($node instanceof Node\Scalar\MagicConst\Namespace_) {
             $this->getResult()->addRequirement(Reason::NAMESPACE_MAGIC_CONSTANT, $node->getLine());
@@ -130,7 +130,7 @@ 
                 Reason::NAMESPACE_IMPORT,
                 $node->getLine(),
                 null,
-                ['import_count' => count($node->uses)]
+                [ 'import_count' => count($node->uses) ]
             );
         }
     }
@@ -181,7 +181,7 @@ 
                         Reason::CONST_KEYWORD_DOC_SYNTAX,
                         $const->value->getLine(),
                         null,
-                        ['name' => $const->name]
+                        [ 'name' => $const->name ]
                     );
                 }
             }

src/Analysers/Php70Features.php

Spacing +9 added lines, -9 removed lines

@@ -42,8 +42,8 @@ 
 class Php70Features extends LanguageFeatureAnalyser implements AnalyserAwareInterface
 {
     // move both to be const once 5.6+ is mandatory
-    private static $reservedNames = ['string', 'int', 'float', 'bool', 'null', 'false', 'true'];
-    private static $softReservedNames = ['object', 'resource', 'mixed', 'numeric'];
+    private static $reservedNames = [ 'string', 'int', 'float', 'bool', 'null', 'false', 'true' ];
+    private static $softReservedNames = [ 'object', 'resource', 'mixed', 'numeric' ];
 
     /**
      * @inheritdoc
@@ -101,12 +101,12 @@ 
                         Reason::PHP4_CONSTRUCTOR,
                         $method->getLine(),
                         null,
-                        ['name' => $method->name]
+                        [ 'name' => $method->name ]
                     ];
                 }
             }
             if ($possibleCtorInfo !== null) {
-                call_user_func_array([$this->getResult(), 'addLimit'], $possibleCtorInfo);
+                call_user_func_array([ $this->getResult(), 'addLimit' ], $possibleCtorInfo);
             }
         }
     }
@@ -134,9 +134,9 @@ 
     {
         if ($call->name instanceof Node\Name && strcasecmp('class_alias', $call->name->getLast()) === 0
         ) {
-            if (isset($call->args[1]) && $call->args[1]->value instanceof Node\Scalar\String_) {
-                $value = $call->args[1]->value->value;
-                $this->handleClassName($value, $call->args[1]->value->getLine());
+            if (isset($call->args[ 1 ]) && $call->args[ 1 ]->value instanceof Node\Scalar\String_) {
+                $value = $call->args[ 1 ]->value->value;
+                $this->handleClassName($value, $call->args[ 1 ]->value->getLine());
             }
         }
     }
@@ -180,10 +180,10 @@ 
             $baseName = baseName(str_replace('\\', '/', $name));
             if ($this->mode & self::MODE_DEPRECATION && $this->isNameSoftReserved($name)) {
                 $this->getResult()->addLimit(Reason::SOFT_RESERVED_NAME, $line, null,
-                    ['fqn' => $name, 'class' => $baseName]);
+                    [ 'fqn' => $name, 'class' => $baseName ]);
             } elseif ($this->mode & self::MODE_REMOVAL && $this->isNameReserved($name)) {
                 $this->getResult()->addLimit(Reason::RESERVED_CLASS_NAME, $line, null,
-                    ['fqn' => $name, 'class' => $baseName]);
+                    [ 'fqn' => $name, 'class' => $baseName ]);
             }
         }
     }

src/Analysers/LanguageFeatureAnalyser.php

Spacing +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
      * @param \Pvra\Analyser $analyser
      * @see setOwningAnalyser() Set the owning analyser
      */
-    public function __construct(array $options = [], Analyser $analyser = null)
+    public function __construct(array $options = [ ], Analyser $analyser = null)
     {
         $this->options = $options;
         $this->mode = $this->getOption('mode', self::MODE_ALL);

src/Analysers/LibraryChanges.php

Spacing +31 added lines, -31 removed lines

@@ -45,7 +45,7 @@ 
      * @param \Pvra\Analyser $analyser
      * @param \Pvra\InformationProvider\LibraryInformation $information
      */
-    public function __construct(array $options = [], Analyser $analyser = null, LibraryInformation $information = null)
+    public function __construct(array $options = [ ], Analyser $analyser = null, LibraryInformation $information = null)
     {
         parent::__construct($options, $analyser);
 
@@ -111,7 +111,7 @@ 
             $name = (string)$name;
         }
 
-        return [$name, $line];
+        return [ $name, $line ];
     }
 
     /**
@@ -122,31 +122,31 @@ 
     {
         list($name, $line) = $this->prepareNameAndLine($name, $line);
         $info = $this->getLibraryInformation()->getClassInfo($name);
-        if ($this->mode & self::MODE_ADDITION && $info['addition'] !== null) {
+        if ($this->mode & self::MODE_ADDITION && $info[ 'addition' ] !== null) {
             $this->getResult()->addArbitraryRequirement(
-                $info['addition'],
+                $info[ 'addition' ],
                 $line,
                 null,
                 Reason::LIB_CLASS_ADDITION,
-                ['className' => $name]
+                [ 'className' => $name ]
             );
         }
-        if ($this->mode & self::MODE_DEPRECATION && $info['deprecation'] !== null) {
+        if ($this->mode & self::MODE_DEPRECATION && $info[ 'deprecation' ] !== null) {
             $this->getResult()->addArbitraryLimit(
-                $info['deprecation'],
+                $info[ 'deprecation' ],
                 $line,
                 null,
                 Reason::LIB_CLASS_DEPRECATION,
-                ['className' => $name]
+                [ 'className' => $name ]
             );
         }
-        if ($this->mode & self::MODE_REMOVAL && $info['removal'] !== null) {
+        if ($this->mode & self::MODE_REMOVAL && $info[ 'removal' ] !== null) {
             $this->getResult()->addArbitraryLimit(
-                $info['removal'],
+                $info[ 'removal' ],
                 $line,
                 null,
                 Reason::LIB_CLASS_REMOVAL,
-                ['className' => $name]
+                [ 'className' => $name ]
             );
         }
     }
@@ -159,31 +159,31 @@ 
     {
         list($name, $line) = $this->prepareNameAndLine($name, $line);
         $info = $this->getLibraryInformation()->getFunctionInfo($name);
-        if ($this->mode & self::MODE_ADDITION && $info['addition'] !== null) {
+        if ($this->mode & self::MODE_ADDITION && $info[ 'addition' ] !== null) {
             $this->getResult()->addArbitraryRequirement(
-                $info['addition'],
+                $info[ 'addition' ],
                 $line,
                 null,
                 Reason::LIB_FUNCTION_ADDITION,
-                ['functionName' => $name]
+                [ 'functionName' => $name ]
             );
         }
-        if ($this->mode & self::MODE_DEPRECATION && $info['deprecation'] !== null) {
+        if ($this->mode & self::MODE_DEPRECATION && $info[ 'deprecation' ] !== null) {
             $this->getResult()->addArbitraryLimit(
-                $info['deprecation'],
+                $info[ 'deprecation' ],
                 $line,
                 null,
                 Reason::LIB_FUNCTION_DEPRECATION,
-                ['functionName' => $name]
+                [ 'functionName' => $name ]
             );
         }
-        if ($this->mode & self::MODE_REMOVAL && $info['removal'] !== null) {
+        if ($this->mode & self::MODE_REMOVAL && $info[ 'removal' ] !== null) {
             $this->getResult()->addArbitraryLimit(
-                $info['removal'],
+                $info[ 'removal' ],
                 $line,
                 null,
                 Reason::LIB_FUNCTION_REMOVAL,
-                ['functionName' => $name]
+                [ 'functionName' => $name ]
             );
         }
     }
@@ -196,31 +196,31 @@ 
     {
         list($name, $line) = $this->prepareNameAndLine($name, $line);
         $info = $this->getLibraryInformation()->getConstantInfo($name);
-        if (($this->mode & self::MODE_ADDITION) && $info['addition'] !== null) {
+        if (($this->mode & self::MODE_ADDITION) && $info[ 'addition' ] !== null) {
             $this->getResult()->addArbitraryRequirement(
-                $info['addition'],
+                $info[ 'addition' ],
                 $line,
                 null,
                 Reason::LIB_CONSTANT_ADDITION,
-                ['constantName' => $name]
+                [ 'constantName' => $name ]
             );
         }
-        if (($this->mode & self::MODE_DEPRECATION) && $info['deprecation'] !== null) {
+        if (($this->mode & self::MODE_DEPRECATION) && $info[ 'deprecation' ] !== null) {
             $this->getResult()->addArbitraryLimit(
-                $info['deprecation'],
+                $info[ 'deprecation' ],
                 $line,
                 null,
                 Reason::LIB_CONSTANT_DEPRECATION,
-                ['constantName' => $name]
+                [ 'constantName' => $name ]
             );
         }
-        if (($this->mode & self::MODE_REMOVAL) && $info['removal'] !== null) {
+        if (($this->mode & self::MODE_REMOVAL) && $info[ 'removal' ] !== null) {
             $this->getResult()->addArbitraryLimit(
-                $info['removal'],
+                $info[ 'removal' ],
                 $line,
                 null,
                 Reason::LIB_CONSTANT_REMOVAL,
-                ['constantName' => $name]
+                [ 'constantName' => $name ]
             );
         }
     }
@@ -256,13 +256,13 @@ 
         } elseif ($node instanceof Node\Stmt\Class_
             || $node instanceof Node\Stmt\Interface_
         ) {
-            $names = [];
+            $names = [ ];
             if (!empty($node->implements)) {
                 $names += $node->implements;
             }
             if (!empty($node->extends)) {
                 if ($node->extends instanceof Name) {
-                    $names[] = $node->extends;
+                    $names[ ] = $node->extends;
                 } else {
                     $names += $node->extends;
                 }

src/Lexer/ExtendedEmulativeLexer.php

Spacing +9 added lines, -9 removed lines

@@ -41,7 +41,7 @@ 
     public static function createDefaultInstance()
     {
         $class = get_called_class();
-        return new $class(['usedAttributes' => ['startLine', 'endLine', 'startFilePos', 'startTokenPos']]);
+        return new $class([ 'usedAttributes' => [ 'startLine', 'endLine', 'startFilePos', 'startTokenPos' ] ]);
     }
 
     /**
@@ -64,19 +64,19 @@ 
 
         if ($tokenId === Tokens::T_LNUMBER || $tokenId === Tokens::T_DNUMBER) {
             // could also use $startAttributes, doesn't really matter here
-            $endAttributes['originalValue'] = $value;
+            $endAttributes[ 'originalValue' ] = $value;
         } elseif ($tokenId === Tokens::T_START_HEREDOC) {
-            $startAttributes['isDocSyntax'] = true;
-            if (substr($this->code, $startAttributes['startFilePos'] + 3, 1) === '\'') {
-                $startAttributes['isNowDoc'] = true;
+            $startAttributes[ 'isDocSyntax' ] = true;
+            if (substr($this->code, $startAttributes[ 'startFilePos' ] + 3, 1) === '\'') {
+                $startAttributes[ 'isNowDoc' ] = true;
             } else {
-                $startAttributes['isHereDoc'] = true;
+                $startAttributes[ 'isHereDoc' ] = true;
             }
         } elseif ($tokenId === Tokens::T_ARRAY) {
-            $startAttributes['traditionalArray'] = true;
+            $startAttributes[ 'traditionalArray' ] = true;
         } elseif ($tokenId === Tokens::T_ECHO) {
-            if (substr($this->code, $startAttributes['startFilePos'], 3) === '<?=') {
-                $startAttributes['isShortEchoTag'] = true;
+            if (substr($this->code, $startAttributes[ 'startFilePos' ], 3) === '<?=') {
+                $startAttributes[ 'isShortEchoTag' ] = true;
             }
         }
 

src/AnalysisResult.php

Spacing +19 added lines, -19 removed lines

@@ -47,12 +47,12 @@ 
     /**
      * @var array|Reasoning[]
      */
-    private $requirements = [];
+    private $requirements = [ ];
 
     /**
      * @var array|Reasoning[]
      */
-    private $limits = [];
+    private $limits = [ ];
 
     /**
      * @var string|null
@@ -131,9 +131,9 @@ 
                 $version));
         }
 
-        $versionComponents += [2 => 0];
+        $versionComponents += [ 2 => 0 ];
 
-        return $versionComponents[0] * 10000 + $versionComponents[1] * 100 + $versionComponents[2];
+        return $versionComponents[ 0 ] * 10000 + $versionComponents[ 1 ] * 100 + $versionComponents[ 2 ];
     }
 
     /**
@@ -182,11 +182,11 @@ 
         $keys = array_keys($this->requirements);
 
         if (!empty($keys)) {
-            usort($keys, function ($a, $b) {
+            usort($keys, function($a, $b) {
                 return version_compare($b, $a);
             });
 
-            return $this->cachedVersionRequirement = $keys[0];
+            return $this->cachedVersionRequirement = $keys[ 0 ];
         }
 
         return '5.2.0';
@@ -211,11 +211,11 @@ 
         $keys = array_keys($this->limits);
 
         if (!empty($keys)) {
-            usort($keys, function ($a, $b) {
+            usort($keys, function($a, $b) {
                 return version_compare($a, $b);
             });
 
-            return $this->cachedVersionLimit = $keys[0];
+            return $this->cachedVersionLimit = $keys[ 0 ];
         }
 
         return '8.0.0';
@@ -240,7 +240,7 @@ 
         $line = -1,
         $msg = null,
         $reason = Reason::UNKNOWN,
-        array $data = []
+        array $data = [ ]
     ) {
         $this->addArbitraryVersionConstraint(self::VERSION_LIMIT_MAX, $version, $line, $msg, $reason,
             $data);
@@ -261,7 +261,7 @@ 
      * @return $this
      * @throws \LogicException Thrown if the reason is unknown or does not have a version requirement associated.
      */
-    public function addRequirement($reason, $line = -1, $msg = null, array $data = [])
+    public function addRequirement($reason, $line = -1, $msg = null, array $data = [ ])
     {
         $version = Reason::getVersionFromReason($reason);
 
@@ -283,7 +283,7 @@ 
      * @param array $data
      * @return $this
      */
-    public function addLimit($reason, $line = -1, $msg = null, array $data = [])
+    public function addLimit($reason, $line = -1, $msg = null, array $data = [ ])
     {
         $version = Reason::getVersionFromReason($reason);
 
@@ -311,7 +311,7 @@ 
         $line = -1,
         $msg = null,
         $reason = Reason::UNKNOWN,
-        array $data = []
+        array $data = [ ]
     ) {
         $this->addArbitraryVersionConstraint(self::VERSION_LIMIT_MIN, $version, $line, $msg, $reason,
             $data);
@@ -333,7 +333,7 @@ 
         $line = -1,
         $msg = null,
         $reason = Reason::UNKNOWN,
-        array $data = []
+        array $data = [ ]
     ) {
         if ($this->isSealed()) {
             throw new \RuntimeException('Impossible to write to already sealed result');
@@ -343,9 +343,9 @@ 
         $this->count++;
 
         if ($type === self::VERSION_LIMIT_MAX) {
-            $this->requirements[ $version ][] = new Reasoning($reason, $line, $this, $version, $msg, $data);
+            $this->requirements[ $version ][ ] = new Reasoning($reason, $line, $this, $version, $msg, $data);
         } elseif ($type === self::VERSION_LIMIT_MIN) {
-            $this->limits[ $version ][] = new Reasoning($reason, $line, $this, $version, $msg, $data);
+            $this->limits[ $version ][ ] = new Reasoning($reason, $line, $this, $version, $msg, $data);
         }
     }
 
@@ -387,7 +387,7 @@ 
             return $this->requirements[ $version ];
         }
 
-        return [];
+        return [ ];
     }
 
     /**
@@ -400,7 +400,7 @@ 
             return $this->limits[ $version ];
         }
 
-        return [];
+        return [ ];
     }
 
     /**
@@ -443,8 +443,8 @@ 
     public function getIterator()
     {
         $iterator = new \ArrayIterator();
-        $data = [$this->getRequirements(), $this->getLimits()];
-        array_walk_recursive($data, function ($value) use ($iterator) {
+        $data = [ $this->getRequirements(), $this->getLimits() ];
+        array_walk_recursive($data, function($value) use ($iterator) {
             if ($value instanceof Reasoning) {
                 $iterator->append($value);
             }

src/Console/Commands/DirCommand.php

Spacing +12 added lines, -12 removed lines

@@ -61,7 +61,7 @@ 
                 FileFinderBuilder::SORT_BY_NAME)
             ->addOption('listFilesOnly', null, InputOption::VALUE_NONE,
                 'Only list matched files and do not run analysis.')
-            ->addArgument('filters', InputArgument::IS_ARRAY | InputArgument::OPTIONAL, 'Filter', ['name:*.php']);
+            ->addArgument('filters', InputArgument::IS_ARRAY | InputArgument::OPTIONAL, 'Filter', [ 'name:*.php' ]);
     }
 
     /**
@@ -133,16 +133,16 @@ 
             $highestRequirement->getAnalysisTargetId()));
 
         if ($highestRequirement->count() !== 0) {
-            $tableData = [];
+            $tableData = [ ];
             // order by version->descending. Might want to implement ordering by line later.
             foreach (array_reverse($highestRequirement->getRequirements()) as $version => $reasons) {
                 foreach ($reasons as $reason) {
-                    $tableData[] = [$reason['version'], $reason['msg'], $reason['line']];
+                    $tableData[ ] = [ $reason[ 'version' ], $reason[ 'msg' ], $reason[ 'line' ] ];
                 }
             }
 
             (new Table($out))
-                ->setHeaders(['Version', 'Message', 'Line'])
+                ->setHeaders([ 'Version', 'Message', 'Line' ])
                 ->setRows($tableData)
                 ->render();
         } else {
@@ -171,14 +171,14 @@ 
                     ' for the following reasons:',
                     "\n"
                 ]));
-                $tableData = [];
+                $tableData = [ ];
                 /** @var $reason Reasoning */
                 foreach ($result->getRequirementIterator() as $reason) {
-                    $tableData[] = [$reason['version'], $reason['msg'], $reason['line']];
+                    $tableData[ ] = [ $reason[ 'version' ], $reason[ 'msg' ], $reason[ 'line' ] ];
                 }
 
                 (new Table($out))
-                    ->setHeaders(['Version', 'Message', 'Line'])
+                    ->setHeaders([ 'Version', 'Message', 'Line' ])
                     ->setRows($tableData)
                     ->render();
             }
@@ -207,7 +207,7 @@ 
         $out->writeln('Highest required version is PHP ' . $highestRequirement->getRequiredVersion() . ' in ' . $highestRequirement->getAnalysisTargetId() . ($results->count() > 1 ? ' and others' : ''));
         $out->writeln('');
 
-        $usedVersions = [];
+        $usedVersions = [ ];
         /** @var AnalysisResult $result */
         foreach ($results as $result) {
             $versions = array_keys($result->getRequirements());
@@ -216,12 +216,12 @@ 
             }
         }
 
-        usort($usedVersions, function ($a, $b) {
+        usort($usedVersions, function($a, $b) {
             return version_compare($b, $a);
         });
 
         $table = new Table($out);
-        $table->setHeaders(['Version', 'Message', 'Position']);
+        $table->setHeaders([ 'Version', 'Message', 'Position' ]);
 
         foreach ($usedVersions as $index => $version) {
             /** @var AnalysisResult $result */
@@ -231,8 +231,8 @@ 
                     foreach ($selectedResults as $reason) {
                         $table->addRow([
                             $version,
-                            $reason['msg'],
-                            $this->formatOutputPath($reason['targetId']) . ':' . $reason['line']
+                            $reason[ 'msg' ],
+                            $this->formatOutputPath($reason[ 'targetId' ]) . ':' . $reason[ 'line' ]
                         ]);
                     }
                 }

src/Console/Commands/Debug/DumpTokenListCommand.php

Spacing +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
 
             foreach ($tokens as $token) {
                 if (is_array($token)) {
-                    $out->writeln(sprintf('%s(%s) "%s"', token_name($token[0]), $token[0], $token[1]));
+                    $out->writeln(sprintf('%s(%s) "%s"', token_name($token[ 0 ]), $token[ 0 ], $token[ 1 ]));
                 } else {
                     $out->writeln('"' . $token . '"');
                 }
@@ -65,7 +65,7 @@ 
             $offset = 0;
             while ($id = $lexer->getNextToken()) {
                 if (is_string($name = $this->libTokenToTokenName($id))) {
-                    $out->writeln($name . '(' . $lexer->getTokens()[ $offset ][0] . ') ' . $lexer->getTokens()[ $offset ][1]);
+                    $out->writeln($name . '(' . $lexer->getTokens()[ $offset ][ 0 ] . ') ' . $lexer->getTokens()[ $offset ][ 1 ]);
                 } else {
                     $out->writeln('Discarded token with id ' . $id);
                 }