suralc / pvra

src/Analysers/LibraryChanges.php

Doc Comments +1 added lines, -1 removed lines

@@ -152,7 +152,7 @@
     }
 
     /**
-     * @param \PhpParser\Node\Name|string $name
+     * @param Name $name
      * @param int $line
      */
     private function handleFunctionName($name, $line = -1)

Spacing +31 added lines, -31 removed lines

@@ -45,7 +45,7 @@ 
      * @param \Pvra\Analyser $analyser
      * @param \Pvra\InformationProvider\LibraryInformation $information
      */
-    public function __construct(array $options = [], Analyser $analyser = null, LibraryInformation $information = null)
+    public function __construct(array $options = [ ], Analyser $analyser = null, LibraryInformation $information = null)
     {
         parent::__construct($options, $analyser);
 
@@ -111,7 +111,7 @@ 
             $name = (string)$name;
         }
 
-        return [$name, $line];
+        return [ $name, $line ];
     }
 
     /**
@@ -122,31 +122,31 @@ 
     {
         list($name, $line) = $this->prepareNameAndLine($name, $line);
         $info = $this->getLibraryInformation()->getClassInfo($name);
-        if ($this->mode & self::MODE_ADDITION && $info['addition'] !== null) {
+        if ($this->mode & self::MODE_ADDITION && $info[ 'addition' ] !== null) {
             $this->getResult()->addArbitraryRequirement(
-                $info['addition'],
+                $info[ 'addition' ],
                 $line,
                 null,
                 Reason::LIB_CLASS_ADDITION,
-                ['className' => $name]
+                [ 'className' => $name ]
             );
         }
-        if ($this->mode & self::MODE_DEPRECATION && $info['deprecation'] !== null) {
+        if ($this->mode & self::MODE_DEPRECATION && $info[ 'deprecation' ] !== null) {
             $this->getResult()->addArbitraryLimit(
-                $info['deprecation'],
+                $info[ 'deprecation' ],
                 $line,
                 null,
                 Reason::LIB_CLASS_DEPRECATION,
-                ['className' => $name]
+                [ 'className' => $name ]
             );
         }
-        if ($this->mode & self::MODE_REMOVAL && $info['removal'] !== null) {
+        if ($this->mode & self::MODE_REMOVAL && $info[ 'removal' ] !== null) {
             $this->getResult()->addArbitraryLimit(
-                $info['removal'],
+                $info[ 'removal' ],
                 $line,
                 null,
                 Reason::LIB_CLASS_REMOVAL,
-                ['className' => $name]
+                [ 'className' => $name ]
             );
         }
     }
@@ -159,31 +159,31 @@ 
     {
         list($name, $line) = $this->prepareNameAndLine($name, $line);
         $info = $this->getLibraryInformation()->getFunctionInfo($name);
-        if ($this->mode & self::MODE_ADDITION && $info['addition'] !== null) {
+        if ($this->mode & self::MODE_ADDITION && $info[ 'addition' ] !== null) {
             $this->getResult()->addArbitraryRequirement(
-                $info['addition'],
+                $info[ 'addition' ],
                 $line,
                 null,
                 Reason::LIB_FUNCTION_ADDITION,
-                ['functionName' => $name]
+                [ 'functionName' => $name ]
             );
         }
-        if ($this->mode & self::MODE_DEPRECATION && $info['deprecation'] !== null) {
+        if ($this->mode & self::MODE_DEPRECATION && $info[ 'deprecation' ] !== null) {
             $this->getResult()->addArbitraryLimit(
-                $info['deprecation'],
+                $info[ 'deprecation' ],
                 $line,
                 null,
                 Reason::LIB_FUNCTION_DEPRECATION,
-                ['functionName' => $name]
+                [ 'functionName' => $name ]
             );
         }
-        if ($this->mode & self::MODE_REMOVAL && $info['removal'] !== null) {
+        if ($this->mode & self::MODE_REMOVAL && $info[ 'removal' ] !== null) {
             $this->getResult()->addArbitraryLimit(
-                $info['removal'],
+                $info[ 'removal' ],
                 $line,
                 null,
                 Reason::LIB_FUNCTION_REMOVAL,
-                ['functionName' => $name]
+                [ 'functionName' => $name ]
             );
         }
     }
@@ -196,31 +196,31 @@ 
     {
         list($name, $line) = $this->prepareNameAndLine($name, $line);
         $info = $this->getLibraryInformation()->getConstantInfo($name);
-        if (($this->mode & self::MODE_ADDITION) && $info['addition'] !== null) {
+        if (($this->mode & self::MODE_ADDITION) && $info[ 'addition' ] !== null) {
             $this->getResult()->addArbitraryRequirement(
-                $info['addition'],
+                $info[ 'addition' ],
                 $line,
                 null,
                 Reason::LIB_CONSTANT_ADDITION,
-                ['constantName' => $name]
+                [ 'constantName' => $name ]
             );
         }
-        if (($this->mode & self::MODE_DEPRECATION) && $info['deprecation'] !== null) {
+        if (($this->mode & self::MODE_DEPRECATION) && $info[ 'deprecation' ] !== null) {
             $this->getResult()->addArbitraryLimit(
-                $info['deprecation'],
+                $info[ 'deprecation' ],
                 $line,
                 null,
                 Reason::LIB_CONSTANT_DEPRECATION,
-                ['constantName' => $name]
+                [ 'constantName' => $name ]
             );
         }
-        if (($this->mode & self::MODE_REMOVAL) && $info['removal'] !== null) {
+        if (($this->mode & self::MODE_REMOVAL) && $info[ 'removal' ] !== null) {
             $this->getResult()->addArbitraryLimit(
-                $info['removal'],
+                $info[ 'removal' ],
                 $line,
                 null,
                 Reason::LIB_CONSTANT_REMOVAL,
-                ['constantName' => $name]
+                [ 'constantName' => $name ]
             );
         }
     }
@@ -256,13 +256,13 @@ 
         } elseif ($node instanceof Node\Stmt\Class_
             || $node instanceof Node\Stmt\Interface_
         ) {
-            $names = [];
+            $names = [ ];
             if (!empty($node->implements)) {
                 $names += $node->implements;
             }
             if (!empty($node->extends)) {
                 if ($node->extends instanceof Name) {
-                    $names[] = $node->extends;
+                    $names[ ] = $node->extends;
                 } else {
                     $names += $node->extends;
                 }

src/AnalysisResult.php

Doc Comments +2 added lines, -2 removed lines

@@ -118,7 +118,7 @@ 
 
     /**
      * @param string $version
-     * @return int
+     * @return double
      * @throws \Exception
      */
     private function calculateVersionIdFromString($version)
@@ -438,7 +438,7 @@ 
 
     /**
      * @inheritdoc
-     * @return \ArrayIterator|array|Reasoning[]
+     * @return \ArrayIterator
      */
     public function getIterator()
     {

Spacing +15 added lines, -15 removed lines

@@ -47,12 +47,12 @@ 
     /**
      * @var array|Reasoning[]
      */
-    private $requirements = [];
+    private $requirements = [ ];
 
     /**
      * @var array|Reasoning[]
      */
-    private $limits = [];
+    private $limits = [ ];
 
     /**
      * @var string|null
@@ -132,9 +132,9 @@ 
                 $version));
         }
 
-        $versionComponents += [2 => 0];
+        $versionComponents += [ 2 => 0 ];
 
-        return $versionComponents[0] * 10000 + $versionComponents[1] * 100 + $versionComponents[2];
+        return $versionComponents[ 0 ] * 10000 + $versionComponents[ 1 ] * 100 + $versionComponents[ 2 ];
     }
 
     /**
@@ -233,7 +233,7 @@ 
         $line = -1,
         $msg = null,
         $reason = Reason::UNKNOWN,
-        array $data = []
+        array $data = [ ]
     ) {
         $this->addArbitraryVersionConstraint(self::VERSION_LIMIT_MAX, $version, $line, $msg, $reason,
             $data);
@@ -254,7 +254,7 @@ 
      * @return $this
      * @throws \LogicException Thrown if the reason is unknown or does not have a version requirement associated.
      */
-    public function addRequirement($reason, $line = -1, $msg = null, array $data = [])
+    public function addRequirement($reason, $line = -1, $msg = null, array $data = [ ])
     {
         $version = Reason::getVersionFromReason($reason);
 
@@ -276,7 +276,7 @@ 
      * @param array $data
      * @return $this
      */
-    public function addLimit($reason, $line = -1, $msg = null, array $data = [])
+    public function addLimit($reason, $line = -1, $msg = null, array $data = [ ])
     {
         $version = Reason::getVersionFromReason($reason);
 
@@ -304,7 +304,7 @@ 
         $line = -1,
         $msg = null,
         $reason = Reason::UNKNOWN,
-        array $data = []
+        array $data = [ ]
     ) {
         $this->addArbitraryVersionConstraint(self::VERSION_LIMIT_MIN, $version, $line, $msg, $reason,
             $data);
@@ -326,7 +326,7 @@ 
         $line = -1,
         $msg = null,
         $reason = Reason::UNKNOWN,
-        array $data = []
+        array $data = [ ]
     ) {
         if ($this->isSealed()) {
             throw new \RuntimeException('Impossible to write to already sealed result');
@@ -336,9 +336,9 @@ 
         $this->count++;
 
         if ($type === self::VERSION_LIMIT_MAX) {
-            $this->requirements[ $version ][] = new Reasoning($reason, $line, $this, $version, $msg, $data);
+            $this->requirements[ $version ][ ] = new Reasoning($reason, $line, $this, $version, $msg, $data);
         } elseif ($type === self::VERSION_LIMIT_MIN) {
-            $this->limits[ $version ][] = new Reasoning($reason, $line, $this, $version, $msg, $data);
+            $this->limits[ $version ][ ] = new Reasoning($reason, $line, $this, $version, $msg, $data);
         }
     }
 
@@ -380,7 +380,7 @@ 
             return $this->requirements[ $version ];
         }
 
-        return [];
+        return [ ];
     }
 
     /**
@@ -393,7 +393,7 @@ 
             return $this->limits[ $version ];
         }
 
-        return [];
+        return [ ];
     }
 
     /**
@@ -436,8 +436,8 @@ 
     public function getIterator()
     {
         $iterator = new \ArrayIterator();
-        $data = [$this->getRequirements(), $this->getLimits()];
-        array_walk_recursive($data, function ($value) use ($iterator) {
+        $data = [ $this->getRequirements(), $this->getLimits() ];
+        array_walk_recursive($data, function($value) use ($iterator) {
             if ($value instanceof Reasoning) {
                 $iterator->append($value);
             }

src/Result/Reason.php

Doc Comments +1 added lines, -1 removed lines

@@ -182,7 +182,7 @@
      * This method returns an array having the constants defined by this class as keys and their required
      * php versions as values.
      *
-     * @return array
+     * @return string[]
      */
     protected static function getReasonToVersionBaseValues()
     {

src/Result/ResultFormatter/ResultFormatter.php

Doc Comments +1 added lines

@@ -29,6 +29,7 @@
 {
     /**
      * @param array $options
+     * @return void
      */
     public function __construct(array $options = []);
 

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     /**
      * @param array $options
      */
-    public function __construct(array $options = []);
+    public function __construct(array $options = [ ]);
 
     /**
      * Generate a string representation of a `Result\Collection`

src/InformationProvider/LibraryInformation.php

Spacing +14 added lines, -14 removed lines

@@ -27,15 +27,15 @@ 
     /**
      * @var array
      */
-    private $additions = [];
+    private $additions = [ ];
     /**
      * @var array
      */
-    private $deprecations = [];
+    private $deprecations = [ ];
     /**
      * @var array
      */
-    private $removals = [];
+    private $removals = [ ];
 
     /**
      * Create a new instance and load default information
@@ -76,19 +76,19 @@ 
      *
      * @param array $data Array representation of data to represent
      */
-    public function __construct(array $data = [])
+    public function __construct(array $data = [ ])
     {
-        if (isset($data['additions'])) {
-            $this->additions = $data['additions'];
+        if (isset($data[ 'additions' ])) {
+            $this->additions = $data[ 'additions' ];
         }
-        if (isset($data['deprecations'])) {
-            $this->deprecations = $data['deprecations'];
+        if (isset($data[ 'deprecations' ])) {
+            $this->deprecations = $data[ 'deprecations' ];
         }
-        if (isset($data['removals'])) {
-            $this->removals = $data['removals'];
+        if (isset($data[ 'removals' ])) {
+            $this->removals = $data[ 'removals' ];
         }
 
-        $baseArray = ['class' => [], 'function' => [], 'constant' => []];
+        $baseArray = [ 'class' => [ ], 'function' => [ ], 'constant' => [ ] ];
         $this->additions += $baseArray;
         $this->deprecations += $baseArray;
         $this->removals += $baseArray;
@@ -112,9 +112,9 @@ 
     public function mergeWith(LibraryInformationInterface $info)
     {
         $newInfo = $info->toArray();
-        $this->additions = array_replace_recursive($this->additions, $newInfo['additions']);
-        $this->deprecations = array_replace_recursive($this->deprecations, $newInfo['deprecations']);
-        $this->removals = array_replace_recursive($this->removals, $newInfo['removals']);
+        $this->additions = array_replace_recursive($this->additions, $newInfo[ 'additions' ]);
+        $this->deprecations = array_replace_recursive($this->deprecations, $newInfo[ 'deprecations' ]);
+        $this->removals = array_replace_recursive($this->removals, $newInfo[ 'removals' ]);
         return $this;
     }
 

src/Analysers/LanguageFeatureAnalyser.php

Spacing +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
      * @param \Pvra\Analyser $analyser
      * @see setOwningAnalyser() Set the owning analyser
      */
-    public function __construct(array $options = [], Analyser $analyser = null)
+    public function __construct(array $options = [ ], Analyser $analyser = null)
     {
         $this->options = $options;
         $this->mode = $this->getOption('mode', self::MODE_ALL);

src/Lexer/ExtendedEmulativeLexer.php

Spacing +9 added lines, -9 removed lines

@@ -41,7 +41,7 @@ 
     public static function createDefaultInstance()
     {
         $class = get_called_class();
-        return new $class(['usedAttributes' => ['startLine', 'endLine', 'startFilePos', 'startTokenPos']]);
+        return new $class([ 'usedAttributes' => [ 'startLine', 'endLine', 'startFilePos', 'startTokenPos' ] ]);
     }
 
     /**
@@ -64,19 +64,19 @@ 
 
         if ($tokenId === Tokens::T_LNUMBER || $tokenId === Tokens::T_DNUMBER) {
             // could also use $startAttributes, doesn't really matter here
-            $endAttributes['originalValue'] = $value;
+            $endAttributes[ 'originalValue' ] = $value;
         } elseif ($tokenId === Tokens::T_START_HEREDOC) {
-            $startAttributes['isDocSyntax'] = true;
-            if (substr($this->code, $startAttributes['startFilePos'] + 3, 1) === '\'') {
-                $startAttributes['isNowDoc'] = true;
+            $startAttributes[ 'isDocSyntax' ] = true;
+            if (substr($this->code, $startAttributes[ 'startFilePos' ] + 3, 1) === '\'') {
+                $startAttributes[ 'isNowDoc' ] = true;
             } else {
-                $startAttributes['isHereDoc'] = true;
+                $startAttributes[ 'isHereDoc' ] = true;
             }
         } elseif ($tokenId === Tokens::T_ARRAY) {
-            $startAttributes['traditionalArray'] = true;
+            $startAttributes[ 'traditionalArray' ] = true;
         } elseif ($tokenId === Tokens::T_ECHO) {
-            if (substr($this->code, $startAttributes['startFilePos'], 3) === '<?=') {
-                $startAttributes['isShortEchoTag'] = true;
+            if (substr($this->code, $startAttributes[ 'startFilePos' ], 3) === '<?=') {
+                $startAttributes[ 'isShortEchoTag' ] = true;
             }
         }
 

src/Console/Commands/Debug/DumpTokenListCommand.php

Spacing +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
 
             foreach ($tokens as $token) {
                 if (is_array($token)) {
-                    $out->writeln(sprintf('%s(%s) "%s"', token_name($token[0]), $token[0], $token[1]));
+                    $out->writeln(sprintf('%s(%s) "%s"', token_name($token[ 0 ]), $token[ 0 ], $token[ 1 ]));
                 } else {
                     $out->writeln('"' . $token . '"');
                 }
@@ -65,7 +65,7 @@ 
             $offset = 0;
             while ($id = $lexer->getNextToken()) {
                 if (is_string($name = $this->libTokenToTokenName($id))) {
-                    $out->writeln($name . '(' . $lexer->getTokens()[ $offset ][0] . ') ' . $lexer->getTokens()[ $offset ][1]);
+                    $out->writeln($name . '(' . $lexer->getTokens()[ $offset ][ 0 ] . ') ' . $lexer->getTokens()[ $offset ][ 1 ]);
                 } else {
                     $out->writeln('Discarded token with id ' . $id);
                 }

src/Console/Commands/SelfUpdateCommand.php

Spacing +12 added lines, -12 removed lines

@@ -43,7 +43,7 @@ 
     protected function configure()
     {
         $this->setName('self-update')
-            ->setAliases(['selfupdate', 'update'])
+            ->setAliases([ 'selfupdate', 'update' ])
             ->setDescription('Checks for a newer tagged version in the github repository.');
         $this->addOption('repo-slug', 'r', InputOption::VALUE_REQUIRED, 'Source repository', self::DEFAULT_REPO_SLUG)
             ->addOption('api-root', 'a', InputOption::VALUE_REQUIRED, 'Api root url', self::DEFAULT_API_ROOT);
@@ -69,13 +69,13 @@ 
         list($ghReleases, $header) = $this->getReleases();
         if ($in->getOption('verbose')) {
             $headers = $this->parseHeader($header);
-            $out->writeln('Github api limit: ' . $headers['X-RateLimit-Limit']);
-            $out->writeln('Github api limit remaining: ' . $headers['X-RateLimit-Remaining']);
+            $out->writeln('Github api limit: ' . $headers[ 'X-RateLimit-Limit' ]);
+            $out->writeln('Github api limit remaining: ' . $headers[ 'X-RateLimit-Remaining' ]);
         }
         $ghReleasesContent = json_decode($ghReleases, true);
         unset($ghReleases);
         if (!empty($ghReleasesContent)) {
-            $remoteVersion = substr($ghReleasesContent[0]['tag_name'], 1);
+            $remoteVersion = substr($ghReleasesContent[ 0 ][ 'tag_name' ], 1);
             $out->writeln('Your version: ' . $this->getApplication()->getVersion() . '(' . $this->getComparableVersion() . ')');
             $out->writeln('Current remote version is: ' . $remoteVersion);
             $compared = version_compare($this->getComparableVersion(), $remoteVersion);
@@ -85,7 +85,7 @@ 
                 if ($this->getHelper('question')->ask($in, $out, $question)) {
                     $out->writeln('Upgrading...');
                     $temp = tmpfile();
-                    stream_copy_to_stream(fopen($this->getPharUrlFromAssetArray($ghReleasesContent[0]['assets']), 'rb'),
+                    stream_copy_to_stream(fopen($this->getPharUrlFromAssetArray($ghReleasesContent[ 0 ][ 'assets' ]), 'rb'),
                         $temp);
                     rewind($temp);
                     $running = Phar::running(false);
@@ -126,12 +126,12 @@ 
     {
         $response = file_get_contents(sprintf('%srepos/%s/releases%s', $this->apiRoot, $this->slug, $target), 0,
             $this->getNewDefaultStreamContext());
-        return [$response, $http_response_header];
+        return [ $response, $http_response_header ];
     }
 
     private function parseHeader(array $headerArray)
     {
-        $headers = [];
+        $headers = [ ];
         foreach ($headerArray as $num => $headerLine) {
             if ($num === 0) {
                 // status code
@@ -151,9 +151,9 @@ 
             $localVersion = ltrim($this->getApplication()->getVersion(), 'v');
             preg_match('/(?P<major>[\\d]+).(?P<minor>[\\d]+).(?P<patch>[\\d]+)-(?P<commitCount>[\\d]+)-(g)?(?P<hash>[0-9a-f]{5,40})/i',
                 $localVersion, $matches);
-            $comparableVersion = sprintf('%d.%d.%d', $matches['major'], $matches['minor'], $matches['patch']);
-            if (isset($matches['commitCount'])) {
-                $comparableVersion .= '.' . $matches['commitCount'];
+            $comparableVersion = sprintf('%d.%d.%d', $matches[ 'major' ], $matches[ 'minor' ], $matches[ 'patch' ]);
+            if (isset($matches[ 'commitCount' ])) {
+                $comparableVersion .= '.' . $matches[ 'commitCount' ];
             }
         }
         return $comparableVersion;
@@ -168,8 +168,8 @@ 
     {
         if (!empty($assets)) {
             foreach ($assets as $asset) {
-                if ($asset['name'] === 'pvra.phar') {
-                    return $asset['browser_download_url'];
+                if ($asset[ 'name' ] === 'pvra.phar') {
+                    return $asset[ 'browser_download_url' ];
                 }
             }
         }