suralc / pvra

src/Result/Reasoning.php

Spacing +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
         AnalysisResult $result,
         $version = null,
         $msg = null,
-        $data = []
+        $data = [ ]
     ) {
         $this->reasonId = $reasonId;
         $this->line = $line;
@@ -156,7 +156,7 @@ 
      */
     public function offsetExists($offset)
     {
-        return in_array($offset, ['data', 'reason', 'reasonName', 'line', 'msg', 'raw_msg', 'version', 'targetId']);
+        return in_array($offset, [ 'data', 'reason', 'reasonName', 'line', 'msg', 'raw_msg', 'version', 'targetId' ]);
     }
 
     /**

src/Result/ResultFormatter/ResultFormatter.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     /**
      * @param array $options
      */
-    public function __construct(array $options = []);
+    public function __construct(array $options = [ ]);
 
     /**
      * Generate a string representation of a `Result\Collection`

src/Result/ResultFormatter/Json.php

Spacing +3 added lines, -3 removed lines

@@ -44,10 +44,10 @@
      *
      * @param array $options
      */
-    public function __construct(array $options = [])
+    public function __construct(array $options = [ ])
     {
-        $this->options = isset($options['options']) ? $options['options'] : 0;
-        $this->depth = isset($options['depth']) ? $options['depth'] : 512;
+        $this->options = isset($options[ 'options' ]) ? $options[ 'options' ] : 0;
+        $this->depth = isset($options[ 'depth' ]) ? $options[ 'depth' ] : 512;
     }
 
     /**

src/Result/Collection.php

Spacing +4 added lines, -4 removed lines

@@ -32,7 +32,7 @@ 
      *
      * @var \Pvra\AnalysisResult[]
      */
-    private $results = [];
+    private $results = [ ];
     /**
      * The targetId of the currently highest demanding result
      *
@@ -190,11 +190,11 @@ 
      */
     public function jsonSerialize()
     {
-        $results = [];
+        $results = [ ];
         foreach ($this->getIterator() as $result) {
-            $reasonings = [];
+            $reasonings = [ ];
             foreach ($result->getIterator() as $reason) {
-                $reasonings[] = $reason->toArray();
+                $reasonings[ ] = $reason->toArray();
             }
             $results[ $result->getAnalysisTargetId() ] = $reasonings;
         }

src/Result/MessageFormatter.php

Spacing +11 added lines, -11 removed lines

@@ -46,7 +46,7 @@ 
     /**
      * @var array
      */
-    private $messageFormatters = [];
+    private $messageFormatters = [ ];
 
     /**
      * @param array|MessageLocator $locator
@@ -72,14 +72,14 @@ 
         }
 
         if ($addDefaultFormatter) {
-            $this->addMessageFormatter(function ($id, $format) {
+            $this->addMessageFormatter(function($id, $format) {
                 return sprintf('%s in :%s:::%s:', $format, MessageFormatter::FORMAT_KEY_TARGET_ID,
                     MessageFormatter::FORMAT_KEY_LINE);
             });
         }
 
         if ($addDefaultExclusiveMissingMessageLocatorHandler) {
-            $this->getLocator()->addMissingMessageHandler(function ($id, MessageLocator $locator) {
+            $this->getLocator()->addMissingMessageHandler(function($id, MessageLocator $locator) {
                 $locator->terminateCallbackChain();
                 $msg = 'Message for id "%s" %s could not be found.';
                 $desc = '';
@@ -116,9 +116,9 @@ 
      * @return mixed
      * @throws \Exception
      */
-    public function getFormattedMessageFromId($msgId, array $data = [])
+    public function getFormattedMessageFromId($msgId, array $data = [ ])
     {
-        return $this->format(['id' => $msgId, 'template' => $this->getMessageTemplate($msgId)], $data);
+        return $this->format([ 'id' => $msgId, 'template' => $this->getMessageTemplate($msgId) ], $data);
     }
 
     /**
@@ -127,12 +127,12 @@ 
      * @param bool $runUserFormatters
      * @return mixed
      */
-    public function format($messageInfo, array $data = [], $runUserFormatters = true)
+    public function format($messageInfo, array $data = [ ], $runUserFormatters = true)
     {
         if (is_string($messageInfo)) {
-            $messageInfo = ['template' => $messageInfo, 'id' => 'unknown_message_id'];
+            $messageInfo = [ 'template' => $messageInfo, 'id' => 'unknown_message_id' ];
         }
-        $data += ['id' => $messageInfo['id']];
+        $data += [ 'id' => $messageInfo[ 'id' ] ];
         if ($runUserFormatters) {
             $this->inCallbackChain(true);
             /** @var callable $formatter */
@@ -140,7 +140,7 @@ 
                 if ($this->isCallbackChainToBeTerminated()) {
                     break;
                 }
-                $messageInfo['template'] = $formatter($messageInfo['id'], $messageInfo['template'], $this, $data);
+                $messageInfo[ 'template' ] = $formatter($messageInfo[ 'id' ], $messageInfo[ 'template' ], $this, $data);
             }
             $this->markCallbackChainTerminated();
         }
@@ -148,10 +148,10 @@ 
         foreach ($data as $name => $value) {
             // str_replace(array, array) would be better
             // but this appears to be faster than iterating over the $data array and manipulating the keys
-            $messageInfo['template'] = str_replace(':' . $name . ':', $value, $messageInfo['template']);
+            $messageInfo[ 'template' ] = str_replace(':' . $name . ':', $value, $messageInfo[ 'template' ]);
         }
 
-        return $messageInfo['template'];
+        return $messageInfo[ 'template' ];
     }
 
     /**

src/Analysers/Php53Features.php

Spacing +5 added lines, -5 removed lines

@@ -99,14 +99,14 @@ 
                 Reason::GOTO_KEYWORD,
                 $node->getLine(),
                 null,
-                ['name' => $node->name]
+                [ 'name' => $node->name ]
             );
         } elseif ($node instanceof Node\Stmt\Label) {
             $this->getResult()->addRequirement(
                 Reason::JUMP_LABEL,
                 $node->getLine(),
                 null,
-                ['name' => $node->name]
+                [ 'name' => $node->name ]
             );
         }
     }
@@ -121,7 +121,7 @@ 
                 Reason::NAMESPACE_DECLERATION,
                 $node->getLine(),
                 null,
-                ['name' => isset($node->name) ? $node->name->toString() : '::global::']
+                [ 'name' => isset($node->name) ? $node->name->toString() : '::global::' ]
             );
         } elseif ($node instanceof Node\Scalar\MagicConst\Namespace_) {
             $this->getResult()->addRequirement(Reason::NAMESPACE_MAGIC_CONSTANT, $node->getLine());
@@ -130,7 +130,7 @@ 
                 Reason::NAMESPACE_IMPORT,
                 $node->getLine(),
                 null,
-                ['import_count' => count($node->uses)]
+                [ 'import_count' => count($node->uses) ]
             );
         }
     }
@@ -181,7 +181,7 @@ 
                         Reason::CONST_KEYWORD_DOC_SYNTAX,
                         $const->value->getLine(),
                         null,
-                        ['name' => $const->name]
+                        [ 'name' => $const->name ]
                     );
                 }
             }

src/Analysers/Php70Features.php

Spacing +9 added lines, -9 removed lines

@@ -42,8 +42,8 @@ 
 class Php70Features extends LanguageFeatureAnalyser implements AnalyserAwareInterface
 {
     // move both to be const once 5.6+ is mandatory
-    private static $reservedNames = ['string', 'int', 'float', 'bool', 'null', 'false', 'true'];
-    private static $softReservedNames = ['object', 'resource', 'mixed', 'numeric'];
+    private static $reservedNames = [ 'string', 'int', 'float', 'bool', 'null', 'false', 'true' ];
+    private static $softReservedNames = [ 'object', 'resource', 'mixed', 'numeric' ];
 
     /**
      * @inheritdoc
@@ -103,12 +103,12 @@ 
                         Reason::PHP4_CONSTRUCTOR,
                         $method->getLine(),
                         null,
-                        ['name' => $method->name],
+                        [ 'name' => $method->name ],
                     ];
                 }
             }
             if ($possibleCtorInfo !== null) {
-                call_user_func_array([$this->getResult(), 'addLimit'], $possibleCtorInfo);
+                call_user_func_array([ $this->getResult(), 'addLimit' ], $possibleCtorInfo);
             }
         }
     }
@@ -136,9 +136,9 @@ 
     {
         if ($call->name instanceof Node\Name && strcasecmp('class_alias', $call->name->getLast()) === 0
         ) {
-            if (isset($call->args[1]) && $call->args[1]->value instanceof Node\Scalar\String_) {
-                $value = $call->args[1]->value->value;
-                $this->handleClassName($value, $call->args[1]->value->getLine());
+            if (isset($call->args[ 1 ]) && $call->args[ 1 ]->value instanceof Node\Scalar\String_) {
+                $value = $call->args[ 1 ]->value->value;
+                $this->handleClassName($value, $call->args[ 1 ]->value->getLine());
             }
         }
     }
@@ -182,10 +182,10 @@ 
             $baseName = basename(str_replace('\\', '/', $name));
             if ($this->mode & self::MODE_DEPRECATION && $this->isNameSoftReserved($name)) {
                 $this->getResult()->addLimit(Reason::SOFT_RESERVED_NAME, $line, null,
-                    ['fqn' => $name, 'class' => $baseName]);
+                    [ 'fqn' => $name, 'class' => $baseName ]);
             } elseif ($this->mode & self::MODE_REMOVAL && $this->isNameReserved($name)) {
                 $this->getResult()->addLimit(Reason::RESERVED_CLASS_NAME, $line, null,
-                    ['fqn' => $name, 'class' => $baseName]);
+                    [ 'fqn' => $name, 'class' => $baseName ]);
             }
         }
     }

src/Console/Commands/DirCommand.php

Spacing +12 added lines, -12 removed lines

@@ -61,7 +61,7 @@ 
                 FileFinderBuilder::SORT_BY_NAME)
             ->addOption('listFilesOnly', null, InputOption::VALUE_NONE,
                 'Only list matched files and do not run analysis.')
-            ->addArgument('filters', InputArgument::IS_ARRAY | InputArgument::OPTIONAL, 'Filter', ['name:*.php']);
+            ->addArgument('filters', InputArgument::IS_ARRAY | InputArgument::OPTIONAL, 'Filter', [ 'name:*.php' ]);
     }
 
     /**
@@ -133,16 +133,16 @@ 
             $highestRequirement->getAnalysisTargetId()));
 
         if ($highestRequirement->count() !== 0) {
-            $tableData = [];
+            $tableData = [ ];
             // order by version->descending. Might want to implement ordering by line later.
             foreach (array_reverse($highestRequirement->getRequirements()) as $version => $reasons) {
                 foreach ($reasons as $reason) {
-                    $tableData[] = [$reason['version'], $reason['msg'], $reason['line']];
+                    $tableData[ ] = [ $reason[ 'version' ], $reason[ 'msg' ], $reason[ 'line' ] ];
                 }
             }
 
             (new Table($out))
-                ->setHeaders(['Version', 'Message', 'Line'])
+                ->setHeaders([ 'Version', 'Message', 'Line' ])
                 ->setRows($tableData)
                 ->render();
         } else {
@@ -171,14 +171,14 @@ 
                     ' for the following reasons:',
                     PHP_EOL,
                 ]);
-                $tableData = [];
+                $tableData = [ ];
                 /** @var $reason Reasoning */
                 foreach ($result->getRequirementIterator() as $reason) {
-                    $tableData[] = [$reason['version'], $reason['msg'], $reason['line']];
+                    $tableData[ ] = [ $reason[ 'version' ], $reason[ 'msg' ], $reason[ 'line' ] ];
                 }
 
                 (new Table($out))
-                    ->setHeaders(['Version', 'Message', 'Line'])
+                    ->setHeaders([ 'Version', 'Message', 'Line' ])
                     ->setRows($tableData)
                     ->render();
             }
@@ -213,7 +213,7 @@ 
         ]);
         $out->writeln('');
 
-        $usedVersions = [];
+        $usedVersions = [ ];
         /** @var AnalysisResult $result */
         foreach ($results as $result) {
             $versions = array_keys($result->getRequirements());
@@ -222,12 +222,12 @@ 
             }
         }
 
-        usort($usedVersions, function ($a, $b) {
+        usort($usedVersions, function($a, $b) {
             return version_compare($b, $a);
         });
 
         $table = new Table($out);
-        $table->setHeaders(['Version', 'Message', 'Position']);
+        $table->setHeaders([ 'Version', 'Message', 'Position' ]);
 
         foreach ($usedVersions as $index => $version) {
             /** @var AnalysisResult $result */
@@ -237,8 +237,8 @@ 
                     foreach ($selectedResults as $reason) {
                         $table->addRow([
                             $version,
-                            $reason['msg'],
-                            $this->formatOutputPath($reason['targetId']) . ':' . $reason['line'],
+                            $reason[ 'msg' ],
+                            $this->formatOutputPath($reason[ 'targetId' ]) . ':' . $reason[ 'line' ],
                         ]);
                     }
                 }

src/AnalysisResult.php

Spacing +15 added lines, -15 removed lines

@@ -47,12 +47,12 @@ 
     /**
      * @var array|Reasoning[]
      */
-    private $requirements = [];
+    private $requirements = [ ];
 
     /**
      * @var array|Reasoning[]
      */
-    private $limits = [];
+    private $limits = [ ];
 
     /**
      * @var string|null
@@ -132,9 +132,9 @@ 
                 $version));
         }
 
-        $versionComponents += [2 => 0];
+        $versionComponents += [ 2 => 0 ];
 
-        return $versionComponents[0] * 10000 + $versionComponents[1] * 100 + $versionComponents[2];
+        return $versionComponents[ 0 ] * 10000 + $versionComponents[ 1 ] * 100 + $versionComponents[ 2 ];
     }
 
     /**
@@ -233,7 +233,7 @@ 
         $line = -1,
         $msg = null,
         $reason = Reason::UNKNOWN,
-        array $data = []
+        array $data = [ ]
     ) {
         $this->addArbitraryVersionConstraint(self::VERSION_LIMIT_MAX, $version, $line, $msg, $reason,
             $data);
@@ -254,7 +254,7 @@ 
      * @return $this
      * @throws \LogicException Thrown if the reason is unknown or does not have a version requirement associated.
      */
-    public function addRequirement($reason, $line = -1, $msg = null, array $data = [])
+    public function addRequirement($reason, $line = -1, $msg = null, array $data = [ ])
     {
         $version = Reason::getVersionFromReason($reason);
 
@@ -276,7 +276,7 @@ 
      * @param array $data
      * @return $this
      */
-    public function addLimit($reason, $line = -1, $msg = null, array $data = [])
+    public function addLimit($reason, $line = -1, $msg = null, array $data = [ ])
     {
         $version = Reason::getVersionFromReason($reason);
 
@@ -304,7 +304,7 @@ 
         $line = -1,
         $msg = null,
         $reason = Reason::UNKNOWN,
-        array $data = []
+        array $data = [ ]
     ) {
         $this->addArbitraryVersionConstraint(self::VERSION_LIMIT_MIN, $version, $line, $msg, $reason,
             $data);
@@ -326,7 +326,7 @@ 
         $line = -1,
         $msg = null,
         $reason = Reason::UNKNOWN,
-        array $data = []
+        array $data = [ ]
     ) {
         if ($this->isSealed()) {
             throw new \RuntimeException('Impossible to write to already sealed result');
@@ -336,9 +336,9 @@ 
         $this->count++;
 
         if ($type === self::VERSION_LIMIT_MAX) {
-            $this->requirements[ $version ][] = new Reasoning($reason, $line, $this, $version, $msg, $data);
+            $this->requirements[ $version ][ ] = new Reasoning($reason, $line, $this, $version, $msg, $data);
         } elseif ($type === self::VERSION_LIMIT_MIN) {
-            $this->limits[ $version ][] = new Reasoning($reason, $line, $this, $version, $msg, $data);
+            $this->limits[ $version ][ ] = new Reasoning($reason, $line, $this, $version, $msg, $data);
         }
     }
 
@@ -380,7 +380,7 @@ 
             return $this->requirements[ $version ];
         }
 
-        return [];
+        return [ ];
     }
 
     /**
@@ -393,7 +393,7 @@ 
             return $this->limits[ $version ];
         }
 
-        return [];
+        return [ ];
     }
 
     /**
@@ -436,8 +436,8 @@ 
     public function getIterator()
     {
         $iterator = new \ArrayIterator();
-        $data = [$this->getRequirements(), $this->getLimits()];
-        array_walk_recursive($data, function ($value) use ($iterator) {
+        $data = [ $this->getRequirements(), $this->getLimits() ];
+        array_walk_recursive($data, function($value) use ($iterator) {
             if ($value instanceof Reasoning) {
                 $iterator->append($value);
             }