supernova-ws / SuperNova

includes/functions/tpl_helpers.php

<?php

// Compare function to sort fleet in time order
use Fleet\DbFleetStatic;
use Planet\DBStaticPlanet;

function tpl_assign_fleet_compare($a, $b) {
  if ($a['fleet']['OV_THIS_PLANET'] == $b['fleet']['OV_THIS_PLANET']) {
    if ($a['fleet']['OV_LEFT'] == $b['fleet']['OV_LEFT']) {
      return 0;
    }

    return ($a['fleet']['OV_LEFT'] < $b['fleet']['OV_LEFT']) ? -1 : 1;
  } else {
    return $a['fleet']['OV_THIS_PLANET'] ? -1 : 1;
  }
}

/**
 * @param array  $fleets
 * @param string $js_name
 *
 * @return array
 */
function tpl_assign_fleet_generate($fleets, $js_name = 'fleets') {
  $result = [];
  if (empty($fleets)) {
    return $result;
  }

  usort($fleets, 'tpl_assign_fleet_compare');

  foreach ($fleets as $fleet_data) {
    $temp = $fleet_data['fleet'];

    if ($fleet_data['ships']) {
      $temp['.']['ships'] = $fleet_data['ships'];
    }

    $result['.'][$js_name][] = $temp;
  }

  return $result;
}

/**
 * For backward compatibility
 *
 * @param template $template
 * @param array    $fleets
 * @param string   $js_name
 *
 * @deprecated
 */
function tpl_assign_fleet(&$template, $fleets, $js_name = 'fleets') {
  if (!$fleets) {

The expression $fleets of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

    return;
  }

  $template->assign_recursive(tpl_assign_fleet_generate($fleets, $js_name));
}

/**
 * function that parses internal fleet representation (as array(id => count))
 *
 * @param $fleet
 * @param $fleet_id
 *
 * @return mixed
 */
function tpl_parse_fleet_sn($fleet, $fleet_id) {
  global $lang, $user;

  $user_data = &$user;

  $return['fleet'] = array(

$return was never initialized. Although not strictly required by PHP, it is generally a good practice to add $return = array(); before regardless.

    'ID' => $fleet_id,

    'METAL'     => $fleet[RES_METAL],
    'CRYSTAL'   => $fleet[RES_CRYSTAL],
    'DEUTERIUM' => $fleet[RES_DEUTERIUM],
  );

  foreach ($fleet as $ship_id => $ship_amount) {
    if (in_array($ship_id, sn_get_groups('fleet'))) {
      $single_ship_data = get_ship_data($ship_id, $user_data);
      $return['ships'][$ship_id] = array(
        'ID'          => $ship_id,
        'NAME'        => $lang['tech'][$ship_id],
        'AMOUNT'      => $ship_amount,
        'CONSUMPTION' => $single_ship_data['consumption'],
        'SPEED'       => $single_ship_data['speed'],
        'CAPACITY'    => $single_ship_data['capacity'],
      );
    }
  }

  return $return;
}

/**
 * @param array      $fleet
 * @param int        $index
 * @param array|bool $user_data
 *
 * @return mixed
 */
function tpl_parse_fleet_db($fleet, $index, $user_data = false) {
  $result = null;

  return sn_function_call('tpl_parse_fleet_db', [$fleet, $index, $user_data, &$result]);
}

/**
 * @param array      $fleet
 * @param int        $index
 * @param array|bool $user_data
 * @param            $result
 *
 * @return mixed
 */
function sn_tpl_parse_fleet_db($fleet, $index, $user_data = false, &$result) {
  global $lang, $user;

  if (!$user_data) {
    $user_data = $user;
  }

  if ($fleet['fleet_mess'] == 0 && $fleet['fleet_mission'] == MT_AKS) {
    $aks = DbFleetStatic::dbAcsGetById($fleet['fleet_group']);
  }

  $spy_level = $user['id'] == $fleet['fleet_owner'] ? 100 : GetSpyLevel($user);

  $result['fleet'] = isset($result['fleet']) ? $result['fleet'] : array();

  $result['fleet'] = array(
    'NUMBER' => $index,

    'ID'           => $fleet['fleet_id'],
    'OWNER'        => $fleet['fleet_owner'],
    'TARGET_OWNER' => $fleet['fleet_target_owner'],

    'MESSAGE'      => $fleet['fleet_mess'],
    'MISSION'      => $fleet['fleet_mission'],
    'MISSION_NAME' => $lang['type_mission'][$fleet['fleet_mission']],
    'ACS'          => $aks['name'],

The variable $aks does not seem to be defined for all execution paths leading up to this point.

    'AMOUNT'       => $spy_level >= 4 ? (HelperString::numberFloorAndFormat($fleet['fleet_amount']) . ($fleet['fleet_resource_metal'] + $fleet['fleet_resource_crystal'] + $fleet['fleet_resource_deuterium'] ? '+' : '')) : '?',

    'METAL'     => $spy_level >= 8 ? $fleet['fleet_resource_metal'] : 0,
    'CRYSTAL'   => $spy_level >= 8 ? $fleet['fleet_resource_crystal'] : 0,
    'DEUTERIUM' => $spy_level >= 8 ? $fleet['fleet_resource_deuterium'] : 0,

    'START_TYPE_TEXT_SH' => $lang['sys_planet_type_sh'][$fleet['fleet_start_type']],
    'START_COORDS'       => "[{$fleet['fleet_start_galaxy']}:{$fleet['fleet_start_system']}:{$fleet['fleet_start_planet']}]",
    'START_TIME_TEXT'    => date(FMT_DATE_TIME, $fleet['fleet_end_time'] + SN_CLIENT_TIME_DIFF),
    'START_LEFT'         => floor($fleet['fleet_end_time'] + 1 - SN_TIME_NOW),
    'START_URL'          => uni_render_coordinates_href($fleet, 'fleet_start_', 3),
    'START_NAME'         => $fleet['fleet_start_name'],

    'END_TYPE_TEXT_SH' => $lang['sys_planet_type_sh'][$fleet['fleet_end_type']],
    'END_COORDS'       => "[{$fleet['fleet_end_galaxy']}:{$fleet['fleet_end_system']}:{$fleet['fleet_end_planet']}]",
    'END_TIME_TEXT'    => date(FMT_DATE_TIME, $fleet['fleet_start_time'] + SN_CLIENT_TIME_DIFF),
    'END_LEFT'         => floor($fleet['fleet_start_time'] + 1 - SN_TIME_NOW),
    'END_URL'          => uni_render_coordinates_href($fleet, 'fleet_end_', 3),
    'END_NAME'         => $fleet['fleet_end_name'],

    'STAY_TIME' => date(FMT_DATE_TIME, $fleet['fleet_end_stay'] + SN_CLIENT_TIME_DIFF),
    'STAY_LEFT' => floor($fleet['fleet_end_stay'] + 1 - SN_TIME_NOW),

    'OV_LABEL'        => $fleet['ov_label'],
    'EVENT_TIME_TEXT' => date(FMT_DATE_TIME, $fleet['event_time'] + SN_CLIENT_TIME_DIFF),
    'OV_LEFT'         => floor($fleet['event_time'] + 1 - SN_TIME_NOW),
    'OV_THIS_PLANET'  => $fleet['ov_this_planet'],
  );

  $ship_list = explode(';', $fleet['fleet_array']);

  $ship_id = 0;
  if ($spy_level >= 6) {
    foreach ($ship_list as $ship_record) {
      if ($ship_record) {
        $ship_data = explode(',', $ship_record);
        if ($spy_level >= 10) {
          $single_ship_data = get_ship_data($ship_data[0], $user_data);
          $result['ships'][$ship_data[0]] = array(
            'ID'          => $ship_data[0],
            'NAME'        => $lang['tech'][$ship_data[0]],
            'AMOUNT'      => $ship_data[1],
            'AMOUNT_TEXT' => HelperString::numberFloorAndFormat($ship_data[1]),

$ship_data[1] of type string is incompatible with the type double|integer expected by parameter $number of HelperString::numberFloorAndFormat().

            'CONSUMPTION' => $single_ship_data['consumption'],
            'SPEED'       => $single_ship_data['speed'],
            'CAPACITY'    => $single_ship_data['capacity'],
          );
        } else {
          $result['ships'][$ship_data[0]] = array(
            'ID'               => $ship_id++,
            'NAME'             => $lang['tech'][UNIT_SHIPS],
            'AMOUNT'           => $ship_data[1],
            'AMOUNT_TEXT'      => HelperString::numberFloorAndFormat($ship_data[1]),
            'CONSUMPTION'      => 0,
            'CONSUMPTION_TEXT' => '0',
            'SPEED'            => 0,
            'CAPACITY'         => 0,
          );
        }
      }
    }
  }

  return $result;
}

function tpl_parse_planet_que($que, $planet, $que_id) {
  $hangar_que = array();
  $que_hangar = $que['ques'][$que_id][$planet['id_owner']][$planet['id']];
  if (!empty($que_hangar)) {
    foreach ($que_hangar as $que_item) {
      $hangar_que['que'][] = array('id' => $que_item['que_unit_id'], 'count' => $que_item['que_unit_amount']);
      $hangar_que[$que_item['que_unit_id']] += $que_item['que_unit_amount'];
    }
  }

  return $hangar_que;
}

/**
 * @param array $planet
 * @param array $fleet_list
 *
 * @return array
 */
function tpl_parse_planet_result_fleet($planet, $fleet_list) {
  return [
    'FLEET_OWN'       => $fleet_list['own']['count'],
    'FLEET_ENEMY'     => $fleet_list['enemy']['count'],
    'FLEET_NEUTRAL'   => $fleet_list['neutral']['count'],
    'PLANET_FLEET_ID' => !empty($fleet_list['own']['count']) ? getUniqueFleetId($planet) : 0,
  ];
}


/**
 * @param int $parentPlanetId
 *
 * @return array
 */
function tpl_parse_planet_moon($parentPlanetId) {
  $moon_fill = 0;
  $moon_fleets = [];

  $moon = DBStaticPlanet::db_planet_by_parent($parentPlanetId);
  if ($moon) {
    $moon_fill = min(100, floor($moon['field_current'] / eco_planet_fields_max($moon) * 100));
    $moon_fleets = flt_get_fleets_to_planet($moon);
  }

  return [
    'MOON_ID'    => $moon['id'],
    'MOON_NAME'  => $moon['name'],
    'MOON_IMG'   => $moon['image'],
    'MOON_FILL'  => min(100, $moon_fill),
    'MOON_ENEMY' => !empty($moon_fleets['enemy']['count']) ? $moon_fleets['enemy']['count'] : 0,

    'MOON_PLANET' => $moon['parent_planet'],
  ];
}

/**
 * @param array $user
 * @param array $planet
 *
 * @return array
 */
function tpl_parse_planet($user, $planet) {
  global $lang;

  $que = que_get($planet['id_owner'], $planet['id'], false);
  $structure_que = tpl_parse_planet_que($que, $planet, QUE_STRUCTURES); // TODO Заменить на que_tpl_parse_element($que_element);
  $structure_que_first = is_array($structure_que['que']) ? reset($structure_que['que']) : array();
  $hangar_que = tpl_parse_planet_que($que, $planet, SUBQUE_FLEET); // TODO Заменить на que_tpl_parse_element($que_element);
  $hangar_que_first = is_array($hangar_que['que']) ? reset($hangar_que['que']) : array();
  $defense_que = tpl_parse_planet_que($que, $planet, SUBQUE_DEFENSE); // TODO Заменить на que_tpl_parse_element($que_element);
  $defense_que_first = is_array($defense_que['que']) ? reset($defense_que['que']) : array();

  $result = [
    'ID'    => $planet['id'],
    'NAME'  => $planet['name'],
    'IMAGE' => $planet['image'],

    'GALAXY'      => $planet['galaxy'],
    'SYSTEM'      => $planet['system'],
    'PLANET'      => $planet['planet'],
    'TYPE'        => $planet['planet_type'],
    'COORDINATES' => uni_render_coordinates($planet),
    'IS_CAPITAL'  => $planet['planet_type'] == PT_PLANET && $planet['id'] == $user['id_planet'],
    'IS_MOON'     => $planet['planet_type'] == PT_MOON,

    'METAL_PERCENT'     => $planet['metal_mine_porcent'] * 10,
    'CRYSTAL_PERCENT'   => $planet['crystal_mine_porcent'] * 10,
    'DEUTERIUM_PERCENT' => $planet['deuterium_sintetizer_porcent'] * 10,

    'STRUCTURE'       => isset($structure_que_first['id']) ? $lang['tech'][$structure_que_first['id']] : '',
    'STRUCTURE_SLOTS' => is_array($structure_que['que']) ? count($structure_que['que']) : 0,
    'HANGAR'          => isset($hangar_que_first['id']) ? $lang['tech'][$hangar_que_first['id']] : '',
    'HANGAR_SLOTS'    => is_array($hangar_que['que']) ? count($hangar_que['que']) : 0,
    'DEFENSE'         => isset($defense_que_first['id']) ? $lang['tech'][$defense_que_first['id']] : '',
    'DEFENSE_SLOTS'   => is_array($defense_que['que']) ? count($defense_que['que']) : 0,

    'FIELDS_CUR' => $planet['field_current'],
    'FIELDS_MAX' => eco_planet_fields_max($planet),
    'FILL'       => min(100, floor($planet['field_current'] / eco_planet_fields_max($planet) * 100)),

    'PLANET_GOVERNOR_ID'        => $planet['PLANET_GOVERNOR_ID'],
    'PLANET_GOVERNOR_NAME'      => $lang['tech'][$planet['PLANET_GOVERNOR_ID']],
    'PLANET_GOVERNOR_LEVEL'     => $planet['PLANET_GOVERNOR_LEVEL'],
    'PLANET_GOVERNOR_LEVEL_MAX' => get_unit_param($planet['PLANET_GOVERNOR_ID'], P_MAX_STACK),
  ];

  if (!empty($que['ques'][QUE_STRUCTURES][$planet['id_owner']][$planet['id']])) {
    $result['building_que'] = [];
    $building_que = &$que['ques'][QUE_STRUCTURES][$planet['id_owner']][$planet['id']];
    foreach ($building_que as $que_element) {
      $result['building_que'][] = que_tpl_parse_element($que_element);
    }
  }

  return $result;
}

function flt_get_fleets_to_planet($planet, $fleet_db_list = 0) {
  if (!($planet && $planet['id']) && !$fleet_db_list) {
    return $planet;
  }

  global $user;

  if ($fleet_db_list === 0) {
    $fleet_db_list = DbFleetStatic::fleet_and_missiles_list_by_coordinates($planet);
  }

  foreach ($fleet_db_list as $fleet) {
    if ($fleet['fleet_owner'] == $user['id']) {
      if ($fleet['fleet_mission'] == MT_MISSILE) {
        continue;
      }
      $fleet_ownage = 'own';
    } else {
      switch ($fleet['fleet_mission']) {
        case MT_ATTACK:
        case MT_AKS:
        case MT_DESTROY:
        case MT_MISSILE:
          $fleet_ownage = 'enemy';
        break;

        default:
          $fleet_ownage = 'neutral';
        break;

      }
    }

    $fleet_list[$fleet_ownage]['fleets'][$fleet['fleet_id']] = $fleet;

    if ($fleet['fleet_mess'] == 1 || ($fleet['fleet_mess'] == 0 && $fleet['fleet_mission'] == MT_RELOCATE) || ($fleet['fleet_target_owner'] != $user['id'])) {
//      $fleet_sn = flt_expand($fleet);
      $fleet_sn = sys_unit_str2arr($fleet['fleet_array']);
      foreach ($fleet_sn as $ship_id => $ship_amount) {
        if (in_array($ship_id, sn_get_groups('fleet'))) {
          $fleet_list[$fleet_ownage]['total'][$ship_id] += $ship_amount;
        }
      }
    }

    $fleet_list[$fleet_ownage]['count']++;
    $fleet_list[$fleet_ownage]['amount'] += $fleet['fleet_amount'];
    $fleet_list[$fleet_ownage]['total'][RES_METAL] += $fleet['fleet_resource_metal'];
    $fleet_list[$fleet_ownage]['total'][RES_CRYSTAL] += $fleet['fleet_resource_crystal'];
    $fleet_list[$fleet_ownage]['total'][RES_DEUTERIUM] += $fleet['fleet_resource_deuterium'];
  }

  return $fleet_list;

The variable $fleet_list does not seem to be defined for all execution paths leading up to this point.

}

/**
 * @param template $template
 * @param array    $planetrow
 * @param array    $fleets_to_planet
 */
function tpl_set_resource_info(&$template, $planetrow, $fleets_to_planet = array()) {
  $template->assign_vars(array(
    'RESOURCE_ROUNDING' => 0,

    'PLANET_ENERGY'                   => $planetrow['energy_used'],
    'ENERGY_BALANCE_NUMBER'           => $planetrow['energy_max'] - $planetrow['energy_used'],
    'ENERGY_BALANCE'                  => prettyNumberStyledDefault($planetrow['energy_max'] - $planetrow['energy_used']),
    'ENERGY_MAX_NUMBER'               => $planetrow['energy_max'],
    'ENERGY_MAX_NUMBER_TEXT_NO_COLOR' => HelperString::numberFloorAndFormat($planetrow['energy_max']),
    'ENERGY_MAX_NUMBER_TEXT'          => Tools::numberPercentSpan($planetrow['energy_max'], $planetrow['energy_used']),
    'ENERGY_MAX'                      => prettyNumberStyledCompare($planetrow['energy_max'], -$planetrow['energy_used']),
    'ENERGY_FILL'                     => round(($planetrow["energy_used"] / ($planetrow["energy_max"] + 1)) * 100, 0),

    'PLANET_METAL'              => floor($planetrow["metal"]),
    'PLANET_METAL_TEXT'         => prettyNumberStyledCompare($planetrow["metal"], $planetrow["metal_max"]),
    'PLANET_METAL_MAX'          => floor($planetrow["metal_max"]),
    'PLANET_METAL_MAX_TEXT'     => Tools::numberPercentSpan($planetrow["metal_max"], $planetrow["metal"]),
    'PLANET_METAL_MAX_NO_COLOR' => HelperString::numberFloorAndFormat($planetrow["metal_max"]),
    'PLANET_METAL_FILL'         => round(($planetrow["metal"] / ($planetrow["metal_max"] + 1)) * 100, 0),
    'PLANET_METAL_PERHOUR'      => round($planetrow["metal_perhour"], 5),
    'PLANET_METAL_FLEET_TEXT'   => prettyNumberStyledDefault($fleets_to_planet[$planetrow['id']]['fleet']['METAL']),

    'PLANET_CRYSTAL'              => floor($planetrow["crystal"]),
    'PLANET_CRYSTAL_TEXT'         => prettyNumberStyledCompare($planetrow["crystal"], $planetrow["crystal_max"]),
    'PLANET_CRYSTAL_MAX'          => floor($planetrow["crystal_max"]),
    'PLANET_CRYSTAL_MAX_TEXT'     => Tools::numberPercentSpan($planetrow["crystal_max"], $planetrow["crystal"]),
    'PLANET_CRYSTAL_MAX_NO_COLOR' => HelperString::numberFloorAndFormat($planetrow["crystal_max"]),
    'PLANET_CRYSTAL_FILL'         => round(($planetrow["crystal"] / ($planetrow["crystal_max"] + 1)) * 100, 0),
    'PLANET_CRYSTAL_PERHOUR'      => round($planetrow["crystal_perhour"], 5),
    'PLANET_CRYSTAL_FLEET_TEXT'   => prettyNumberStyledDefault($fleets_to_planet[$planetrow['id']]['fleet']['CRYSTAL']),

    'PLANET_DEUTERIUM'              => floor($planetrow["deuterium"]),
    'PLANET_DEUTERIUM_TEXT'         => prettyNumberStyledCompare($planetrow["deuterium"], $planetrow["deuterium_max"]),
    'PLANET_DEUTERIUM_MAX'          => floor($planetrow["deuterium_max"]),
    'PLANET_DEUTERIUM_MAX_TEXT'     => Tools::numberPercentSpan($planetrow["deuterium_max"], $planetrow["deuterium"]),
    'PLANET_DEUTERIUM_MAX_NO_COLOR' => HelperString::numberFloorAndFormat($planetrow["deuterium_max"]),
    'PLANET_DEUTERIUM_FILL'         => round(($planetrow["deuterium"] / ($planetrow["deuterium_max"] + 1)) * 100, 0),
    'PLANET_DEUTERIUM_PERHOUR'      => round($planetrow["deuterium_perhour"], 5),
    'PLANET_DEUTERIUM_FLEET_TEXT'   => prettyNumberStyledDefault($fleets_to_planet[$planetrow['id']]['fleet']['DEUTERIUM']),
  ));
}

/**
 * @return int[][]
 */
function templateFillPercent() {
  $result = [];
  for ($i = 100; $i >= 0; $i -= 10) {
    $result[] = ['PERCENT' => $i];
  }

  return ['.' => ['percent' => $result]];

The expression return array('.' => array('percent' => $result)) returns the type array<string,array<string,array|array<mixed,array<string,integer>>>> which is incompatible with the documented return type array<mixed,integer[]>.

}