Issues (1369)

includes/functions/ali_alliances.php (4 issues)

1
<?php
2
3
function ali_rank_list_save($ranks) {
4
  global $user;
5
6
  if (!empty($ranks)) {
7
    foreach ($ranks as $rank => $rights) {
8
      $rights = implode(',', $rights);
9
      $ranklist .= $rights . ';';
0 ignored issues
show
Comprehensibility Best Practice introduced by
The variable $ranklist does not exist. Did you maybe mean $ranks?
Loading history...
10
    }
11
  }
12
13
  doquery("UPDATE {{alliance}} SET `ranklist` = '{$ranklist}' WHERE `id` ='{$user['ally_id']}';");
0 ignored issues
show
Deprecated Code introduced by
The function doquery() has been deprecated. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

13
  /** @scrutinizer ignore-deprecated */ doquery("UPDATE {{alliance}} SET `ranklist` = '{$ranklist}' WHERE `id` ='{$user['ally_id']}';");
Loading history...
14
15
  return $ranklist;
16
}
17
18
function ali_relations($ally_from, $ally_to = 0) {
19
  $ally_to = intval($ally_to);
20
  $ally_to = $ally_to ? " AND alliance_diplomacy_contr_ally_id = {$ally_to}" : '';
21
22
  $temp_array = array();
23
  $query = doquery(
0 ignored issues
show
Deprecated Code introduced by
The function doquery() has been deprecated. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

23
  $query = /** @scrutinizer ignore-deprecated */ doquery(
Loading history...
24
    "SELECT b.*
25
      FROM
26
        {{alliance_diplomacy}} AS b,
27
        (SELECT alliance_diplomacy_contr_ally_id, MAX(alliance_diplomacy_time) AS alliance_diplomacy_time
28
          FROM {{alliance_diplomacy}}
29
          WHERE alliance_diplomacy_ally_id = {$ally_from}  {$ally_to}
30
          GROUP BY alliance_diplomacy_ally_id, alliance_diplomacy_contr_ally_id
31
        ) AS m
32
      WHERE b.alliance_diplomacy_contr_ally_id = m.alliance_diplomacy_contr_ally_id
33
        AND b.alliance_diplomacy_time = m.alliance_diplomacy_time AND b.alliance_diplomacy_ally_id = {$ally_from}
34
      ORDER BY alliance_diplomacy_time, alliance_diplomacy_id;"
35
  );
36
37
  while ($record = db_fetch($query)) {
0 ignored issues
show
Deprecated Code introduced by
The function db_fetch() has been deprecated. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

37
  while ($record = /** @scrutinizer ignore-deprecated */ db_fetch($query)) {
Loading history...
38
    $temp_array[$record['alliance_diplomacy_contr_ally_id']] = $record;
39
  }
40
41
  return $temp_array;
42
}
43
44
function ali_relation($ally_from, $ally_to) {
45
  $relation = ali_relations($ally_from, $ally_to);
46
47
  return empty($relation) ? ALLY_DIPLOMACY_NEUTRAL : $relation[$ally_to]['alliance_diplomacy_relation'];
48
}
49