Issues in TContainer.php (trunk) - Issues in trunk - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1369)

classes/Common/Traits/TContainer.php (7 issues)

Labels

Bug 7

Severity

Minor 7

<?php
/**
 * Created by Gorlum 08.01.2018 15:16
 */

namespace Common\Traits;

use Common\Interfaces\IContainer;

trait TContainer {
  /**
   * @return ?IContainer
   */
  public function _getContainer() {
    return null;
  }

  public function __set($name, $value) {
    if (is_object($this->_getContainer())) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
      $this->_getContainer()->__set($this->_containerTranslatePropertyName($name), $value);
    }
  }

  public function __isset($name) {
    return is_object($this->_getContainer())
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
      ? $this->_getContainer()->__isset($this->_containerTranslatePropertyName($name))
      : null;
  }

  public function __get($name) {
    return is_object($this->_getContainer())
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
      ? $this->_getContainer()->__get($this->_containerTranslatePropertyName($name))
      : null;
  }

  public function __unset($name) {
    if (is_object($this->_getContainer())) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
      $this->_getContainer()->__unset($this->_containerTranslatePropertyName($name));
    }
  }

  /**
   * Is container contains no data
   *
   * @return bool
   */
  public function isEmpty() {
    return is_object($this->_getContainer()) ? $this->_getContainer()->isEmpty() : false;
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
  }

  /**
   * Clears container contents
   */
  public function clear() {
    if (is_object($this->_getContainer())) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
      $this->_getContainer()->clear();
    }
  }

  public function __call($name, $arguments) {
    return is_object($this->_getContainer()) ? call_user_func_array([$this->_getContainer(), $name], $arguments) : null;
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
  }

  protected function _containerTranslatePropertyName($name) {
    return $name;
  }

}


1			<?php
2			/**
3			* Created by Gorlum 08.01.2018 15:16
4			*/
5
6			namespace Common\Traits;
7
8			use Common\Interfaces\IContainer;
9
10			trait TContainer {
11			/**
12			* @return ?IContainer
13			*/
14			public function _getContainer() {
15			return null;
16			}
17
18			public function __set($name, $value) {
19			if (is_object($this->_getContainer())) {
			0 ignored issues – show Bug introduced 2025-05-06 18:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->_getContainer()` targeting `Common\Traits\TContainer::_getContainer()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
20			$this->_getContainer()->__set($this->_containerTranslatePropertyName($name), $value);
21			}
22			}
23
24			public function __isset($name) {
25			return is_object($this->_getContainer())
			0 ignored issues – show Bug introduced 2025-05-06 18:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->_getContainer()` targeting `Common\Traits\TContainer::_getContainer()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
26			? $this->_getContainer()->__isset($this->_containerTranslatePropertyName($name))
27			: null;
28			}
29
30			public function __get($name) {
31			return is_object($this->_getContainer())
			0 ignored issues – show Bug introduced 2025-05-06 18:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->_getContainer()` targeting `Common\Traits\TContainer::_getContainer()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
32			? $this->_getContainer()->__get($this->_containerTranslatePropertyName($name))
33			: null;
34			}
35
36			public function __unset($name) {
37			if (is_object($this->_getContainer())) {
			0 ignored issues – show Bug introduced 2025-05-06 18:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->_getContainer()` targeting `Common\Traits\TContainer::_getContainer()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
38			$this->_getContainer()->__unset($this->_containerTranslatePropertyName($name));
39			}
40			}
41
42			/**
43			* Is container contains no data
44			*
45			* @return bool
46			*/
47			public function isEmpty() {
48			return is_object($this->_getContainer()) ? $this->_getContainer()->isEmpty() : false;
			0 ignored issues – show Bug introduced 2025-05-06 18:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->_getContainer()` targeting `Common\Traits\TContainer::_getContainer()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
49			}
50
51			/**
52			* Clears container contents
53			*/
54			public function clear() {
55			if (is_object($this->_getContainer())) {
			0 ignored issues – show Bug introduced 2025-05-06 18:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->_getContainer()` targeting `Common\Traits\TContainer::_getContainer()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
56			$this->_getContainer()->clear();
57			}
58			}
59
60			public function __call($name, $arguments) {
61			return is_object($this->_getContainer()) ? call_user_func_array([$this->_getContainer(), $name], $arguments) : null;
			0 ignored issues – show Bug introduced 2025-05-06 18:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->_getContainer()` targeting `Common\Traits\TContainer::_getContainer()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
62			}
63
64			protected function _containerTranslatePropertyName($name) {
65			return $name;
66			}
67
68			}
69

supernova-ws / SuperNova

Issues (1369)

classes/Common/Traits/TContainer.php (7 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like