Issues in overview.php - All Issues - Inspection of "CODE-misc-41a51.59: Streamlined some code" - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( 867546...331178 )

by SuperNova.WS

created 2016-08-10 19:21 UTC

overview.php (18 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * index.php - overview.php
 *
 * 2.4 - copyright (c) 2010 by Gorlum for http://supernova.ws
 *     [-] Removed News frame
 *     [-] Time & Usersonline moved to Top-Frame
 * 2.3 - copyright (c) 2010 by Gorlum for http://supernova.ws
 *     [*] Complying with PCG
 * 2.2 - copyright (c) 2010 by Gorlum for http://supernova.ws
 *     [+] Redo flying fleet list
 * 2.1 - copyright (c) 2010 by Gorlum for http://supernova.ws
 *     [+] Planets on planet list now have indication of planet fill
 *     [+] Planets on planet list now have indication when there is enemy fleet flying to planet
 * 2.0 - copyright (c) 2010 by Gorlum for http://supernova.ws
 *     [+] Now there is full planet list on right side of screen a-la oGame
 *     [+] Planet list now include icons for buildings/tech/fleet on progress
 * 1.5 - copyright (c) 2010 by Gorlum for http://supernova.ws
 *     [*] Subplanet timers now use sn_timer.js library
 * 1.4 - copyright (c) 2010 by Gorlum for http://supernova.ws
 *     [*] All mainplanet timers now use new sn_timer.js library
 * 1.3 - copyright (c) 2010 by Gorlum for http://supernova.ws
 *     [*] Adjusted layouts of player infos
 * 1.2 - copyright (c) 2010 by Gorlum for http://supernova.ws
 *     [*] Adjusted layouts of planet infos
 * 1.1 - Security checks by Gorlum for http://supernova.ws
 * @version 1
 * @copyright 2008 By Chlorel for XNova
 */

//define('SN_RENDER_NAVBAR_PLANET', false);


include('common.' . substr(strrchr(__FILE__, '.'), 1));

//$ccc = 0;

//foreach(DBStaticUser::db_user_list_non_bots() as $ip) {
//  $ccc++;
//}
//pdump($ccc);
//
//foreach(DBStaticUser::db_user_list_non_bots() as $ip) {
//  pdump($ip['id']);
//  $ccc++;
//}
//
//pdump(DBStaticUser::db_user_list_non_bots());

lng_include('overview');

$result = array();

switch($mode = sys_get_param_str('mode')) {
  case 'manage':
    sn_sys_sector_buy('overview.php?mode=manage');

    $user_dark_matter = mrc_get_level($user, null, RES_DARK_MATTER);
    $result[] = sn_sys_planet_core_transmute($user, $planetrow);

    $template  = gettemplate('planet_manage', true);
    $planet_id = sys_get_param_id('planet_id');

    if(sys_get_param_str('rename') && ($new_name_unsafe = sys_get_param_str_unsafe('new_name'))) {
      $planetrow['name'] = $new_name_unsafe;
      DBStaticPlanet::db_planet_update_set_by_id(
        $planetrow['id'],
        array(
          'name' => $new_name_unsafe,
        )
      );
    } elseif(sys_get_param_str('action') == 'make_capital') {
      try {
        sn_db_transaction_start();
        $user = DBStaticUser::db_user_by_id($user['id'], true, '*');
        $planetrow = DBStaticPlanet::db_planet_by_id($planetrow['id'], true, '*');

        if($planetrow['planet_type'] != PT_PLANET) {

          throw new exception(classLocale::$lang['ov_capital_err_not_a_planet'], ERR_ERROR);
        }

        if($planetrow['id'] == $user['id_planet']) {
          throw new exception(classLocale::$lang['ov_capital_err_capital_already'], ERR_ERROR);
        }

        if($user_dark_matter < classSupernova::$config->planet_capital_cost) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
          throw new exception(classLocale::$lang['ov_capital_err_no_dark_matter'], ERR_ERROR);
        }

        rpg_points_change($user['id'], RPG_CAPITAL, -classSupernova::$config->planet_capital_cost,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
          array('Planet %s ID %d at coordinates %s now become Empire Capital', $planetrow['name'], $planetrow['id'], uni_render_coordinates($planetrow))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        DBStaticUser::db_user_set_by_id(
          $user['id'],
          array(
            'id_planet' => $planetrow['id'],
            'galaxy'    => $planetrow['galaxy'],
            'system'    => $planetrow['system'],
            'planet'    => $planetrow['planet'],
          )
        );

        $user['id_planet'] = $planetrow['id'];
        $result[] = array(
          'STATUS'  => ERR_NONE,
          'MESSAGE' => classLocale::$lang['ov_capital_err_none'],
        );
        sn_db_transaction_commit();
        sys_redirect('overview.php?mode=manage');
      } catch(exception $e) {
        sn_db_transaction_rollback();
        $result[] = array(
          'STATUS'  => $e->getCode(),
          'MESSAGE' => $e->getMessage(),
        );
      }
    } elseif(sys_get_param_str('action') == 'planet_teleport') {
      try {
        if(!uni_coordinates_valid($new_coordinates = array(
          'galaxy' => sys_get_param_int('new_galaxy'),
          'system' => sys_get_param_int('new_system'),
          'planet' => sys_get_param_int('new_planet')))
        ) {
          throw new exception(classLocale::$lang['ov_teleport_err_wrong_coordinates'], ERR_ERROR);
        }

        sn_db_transaction_start();
        // При телепорте обновлять данные не надо - просто получить текущие данные и залочить их
        $user = DBStaticUser::db_user_by_id($user['id'], true, '*');
        $planetrow = DBStaticPlanet::db_planet_by_id($planetrow['id'], true, '*');
//        $global_data = sys_o_get_updated($user, $planetrow['id'], SN_TIME_NOW);

//        $user = $global_data['user'];
//        $planetrow = $global_data['planet'];

        $can_teleport = uni_planet_teleport_check($user, $planetrow, $new_coordinates);
        if($can_teleport['result'] != ERR_NONE) {
          throw new exception($can_teleport['message'], $can_teleport['result']);
        }

        rpg_points_change($user['id'], RPG_TELEPORT, -classSupernova::$config->planet_teleport_cost,
          array(&classLocale::$lang['ov_teleport_log_record'], $planetrow['name'], $planetrow['id'], uni_render_coordinates($planetrow), uni_render_coordinates($new_coordinates))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        $planet_teleport_next = SN_TIME_NOW + classSupernova::$config->planet_teleport_timeout;
        DBStaticPlanet::db_planet_update_by_gspt(
          $planetrow['galaxy'], $planetrow['system'], $planetrow['planet'], PT_ALL,
          array(
            'galaxy'               => $new_coordinates['galaxy'],
            'system'               => $new_coordinates['system'],
            'planet'               => $new_coordinates['planet'],
            'planet_teleport_next' => $planet_teleport_next,
          ),
          array()
        );

        if($planetrow['id'] == $user['id_planet']) {
          DBStaticUser::db_user_set_by_id(
            $user['id'],
            array(
              'galaxy' => $new_coordinates['galaxy'],
              'system' => $new_coordinates['system'],
              'planet' => $new_coordinates['planet'],
            )
          );
        }

        // $global_data = sys_o_get_updated($user, $planetrow['id'], SN_TIME_NOW);

        sn_db_transaction_commit();
        $user = DBStaticUser::db_user_by_id($user['id'], true, '*');
        $planetrow = DBStaticPlanet::db_planet_by_id($planetrow['id'], true, '*');
        $result[] = array(
          'STATUS'  => ERR_NONE,
          'MESSAGE' => classLocale::$lang['ov_teleport_err_none'],
        );
        sys_redirect('overview.php?mode=manage');
      } catch(exception $e) {
        sn_db_transaction_rollback();
        $result[] = array(
          'STATUS'  => $e->getCode(),
          'MESSAGE' => $e->getMessage(),
        );
      }
    } elseif(sys_get_param_str('action') == 'planet_abandon') {
      // if(sec_password_check($user['id'], sys_get_param('abandon_confirm'))) {

      if(classSupernova::$auth->password_check(sys_get_param('abandon_confirm'))) {
        if($user['id_planet'] != $user['current_planet'] && $user['current_planet'] == $planet_id) {
          $destroyed = SN_TIME_NOW + 60 * 60 * 24;
          DBStaticPlanet::db_planet_update_set_by_id(
            $user['current_planet'],
            array(
              'destruyed' => $destroyed,
              'id_owner'  => 0,
            )
          );

          DBStaticPlanet::db_planet_set_by_parent(
            $user['current_planet'],
            array(
              'destruyed' => $destroyed,
              'id_owner'  => 0,
            )
          );
          DBStaticUser::db_user_set_by_id(
            $user['id'],
            array('current_planet' => $user['id_planet'])
          );
          message(classLocale::$lang['ov_delete_ok'], classLocale::$lang['colony_abandon'], 'overview.php?mode=manage');
        } else {
          message(classLocale::$lang['ov_delete_wrong_planet'], classLocale::$lang['colony_abandon'], 'overview.php?mode=manage');
        }
      } else {
        message(classLocale::$lang['ov_delete_wrong_pass'] , classLocale::$lang['colony_abandon'], 'overview.php?mode=manage');
      }
    } elseif(
      ($hire = sys_get_param_int('hire')) && in_array($hire, sn_get_groups('governors'))
      && (
        !get_unit_param($hire, P_MAX_STACK) ||
        ($planetrow['PLANET_GOVERNOR_ID'] != $hire) ||
        (
          $planetrow['PLANET_GOVERNOR_ID'] == $hire &&
          $planetrow['PLANET_GOVERNOR_LEVEL'] < get_unit_param($hire, P_MAX_STACK)
        )
      )
    ) {
      sn_db_transaction_start();
      $user = DBStaticUser::db_user_by_id($user['id'], true);
      $planetrow = DBStaticPlanet::db_planet_by_id($planetrow['id'], true);
      $build_data = eco_get_build_data($user, $planetrow, $hire, $planetrow['PLANET_GOVERNOR_ID'] == $hire ? $planetrow['PLANET_GOVERNOR_LEVEL'] : 0);
      if($build_data['CAN'][BUILD_CREATE]) {
        if($planetrow['PLANET_GOVERNOR_ID'] == $hire) {
          $planetrow['PLANET_GOVERNOR_LEVEL']++;
        } else {
          $planetrow['PLANET_GOVERNOR_LEVEL'] = 1;
          $planetrow['PLANET_GOVERNOR_ID'] = $hire;
        }
        DBStaticPlanet::db_planet_update_set_by_id(
          $planetrow['id'],
          array(
            'PLANET_GOVERNOR_ID' => $hire,
            // TODO - change it
            'PLANET_GOVERNOR_LEVEL' => $planetrow['PLANET_GOVERNOR_LEVEL'],
          )
        );

        rpg_points_change(
          $user['id'],
          RPG_GOVERNOR,
          -$build_data[BUILD_CREATE][RES_DARK_MATTER],
          sprintf(classLocale::$lang['ov_governor_purchase'], classLocale::$lang['tech'][$hire], $hire, $planetrow['PLANET_GOVERNOR_LEVEL'], uni_render_planet_full($planetrow, '', false, true))
        );

        //  => 'Игрок купил Губернатора %1$s ID %2$d уровня %3$d на планету %4$s',
        // die();
      }
      sn_db_transaction_commit();
      sys_redirect('overview.php?mode=manage');
      die();
    }

    lng_include('mrc_mercenary');
    int_planet_pretemplate($planetrow, $template);
    foreach(sn_get_groups('governors') as $governor_id) {
      if($planetrow['planet_type'] == PT_MOON && $governor_id == MRC_TECHNOLOGIST) {
        continue;
      }

      $governor_level = $planetrow['PLANET_GOVERNOR_ID'] == $governor_id ? $planetrow['PLANET_GOVERNOR_LEVEL'] : 0;
      $build_data = eco_get_build_data($user, $planetrow, $governor_id, $governor_level);
      $template->assign_block_vars('governors', array(
        'ID'         => $governor_id,
        'NAME'       => classLocale::$lang['tech'][$governor_id],
        'COST'       => $build_data[BUILD_CREATE][RES_DARK_MATTER],
        'MAX'        => get_unit_param($governor_id, P_MAX_STACK),
        'LEVEL'      => $governor_level,
        'LEVEL_PLUS' => mrc_get_level($user, $planetrow, $governor_id) - $governor_level,
      ));
    }

    $user_dark_matter = mrc_get_level($user, null, RES_DARK_MATTER);
    $planet_density_index = $planetrow['density_index'];
    $density_price_chart = planet_density_price_chart($planetrow);
    tpl_planet_density_info($template, $density_price_chart, $user_dark_matter);

    $sector_cost = eco_get_build_data($user, $planetrow, UNIT_SECTOR, mrc_get_level($user, $planetrow, UNIT_SECTOR), true);
    $sector_cost = $sector_cost[BUILD_CREATE][RES_DARK_MATTER];
    $planet_fill = floor($planetrow['field_current'] / eco_planet_fields_max($planetrow) * 100);
    $planet_fill = $planet_fill > 100 ? 100 : $planet_fill;
    $can_teleport = uni_planet_teleport_check($user, $planetrow);
    $template->assign_vars(array(
      'DARK_MATTER'           => $user_dark_matter,

      'PLANET_FILL'           => floor($planetrow['field_current'] / eco_planet_fields_max($planetrow) * 100),
      'PLANET_FILL_BAR'       => $planet_fill,
      'SECTOR_CAN_BUY'        => $sector_cost <= $user_dark_matter,
      'SECTOR_COST'           => $sector_cost,
      'SECTOR_COST_TEXT'      => pretty_number($sector_cost),
      'planet_field_current'  => $planetrow['field_current'],
      'planet_field_max'      => eco_planet_fields_max($planetrow),

      'CAN_TELEPORT'          => $can_teleport['result'] == ERR_NONE,
      'CAN_NOT_TELEPORT_MSG'  => $can_teleport['message'],
      'TELEPORT_COST_TEXT'    => pretty_number(classSupernova::$config->planet_teleport_cost, true, $user_dark_matter),

      'CAN_CAPITAL'           => $user_dark_matter >= classSupernova::$config->planet_capital_cost,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
      'CAPITAL_COST_TEXT'     => pretty_number(classSupernova::$config->planet_capital_cost, true, $user_dark_matter),
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

      'PLANET_DENSITY_INDEX'  => $planet_density_index,
      'PLANET_CORE_TEXT'      => classLocale::$lang['uni_planet_density_types'][$planet_density_index],

      'IS_CAPITAL'            => $planetrow['id'] == $user['id_planet'],

      'PAGE_HINT'   => classLocale::$lang['ov_manage_page_hint'],
    ));

    foreach($result as &$a_result) {
      $template->assign_block_vars('result', $a_result);
    }

    display($template, classLocale::$lang['rename_and_abandon_planet']);
  break;

  default:
    sn_sys_sector_buy();

    if(sys_get_param_str('rename') && $new_name_unsafe = sys_get_param_str_unsafe('new_name')) {
      $planetrow['name'] = $new_name_unsafe;
      DBStaticPlanet::db_planet_update_set_by_id(
        $planetrow['id'],
        array(
          'name' => $new_name_unsafe,
        )
      );

    }

    $result[] = sn_sys_planet_core_transmute($user, $planetrow);

    $template = gettemplate('planet_overview', true);

    $user_dark_matter = mrc_get_level($user, null, RES_DARK_MATTER);

    $planet_density_index = $planetrow['density_index'];
    $density_price_chart = planet_density_price_chart($planetrow);
    tpl_planet_density_info($template, $density_price_chart, $user_dark_matter);

    rpg_level_up($user, RPG_STRUCTURE);
    rpg_level_up($user, RPG_RAID);
    rpg_level_up($user, RPG_TECH);
    rpg_level_up($user, RPG_EXPLORE);

    $fleet_id = 1;

//    $fleet_and_missiles_list = FleetList::fleet_and_missiles_list_incoming($user['id']);

//    $fleets = flt_parse_fleets_to_events($fleet_and_missiles_list);
    $fleet_and_missiles_list = FleetList::dbGetFleetListAndMissileINCOMING($user['id']);
    $fleets = flt_parse_objFleetList_to_events($fleet_and_missiles_list);

    $planet_count = 0;
    $planets_query = DBStaticPlanet::db_planet_list_sorted($user, false, '*');
    foreach($planets_query as $an_id => $UserPlanet) {
      sn_db_transaction_start();
      $UserPlanet = sys_o_get_updated($user, $UserPlanet['id'], SN_TIME_NOW, false, true);
      sn_db_transaction_commit();
      $list_planet_que = $UserPlanet['que'];
      $UserPlanet = $UserPlanet['planet'];

      $template_planet = tpl_parse_planet($UserPlanet);

      $planet_fleet_id = 0;
      $fleet_list = $template_planet['fleet_list'];
      if($fleet_list['own']['count']) {

        $planet_fleet_id = "p{$UserPlanet['id']}";
        $fleets_to_planet[$UserPlanet['id']] = tpl_parse_fleet_sn($fleet_list['own']['total'], $planet_fleet_id);
//        $fleet_id++;tpl_parse_fleet_sn
      }
      if($UserPlanet['planet_type'] == PT_MOON) {
        continue;
      }
      $moon = DBStaticPlanet::db_planet_by_parent($UserPlanet['id']);
      if($moon) {
        $moon_fill = min(100, floor($moon['field_current'] / eco_planet_fields_max($moon) * 100));
      } else {
        $moon_fill = 0;
      }

//      $moon_fleets = flt_get_fleets_to_planet($moon);

      $moon_fleets = FleetList::EMULATE_flt_get_fleets_to_planet($moon);
//      $moon_fleets = array();

//      $fleet_db_list = FleetList::dbGetFleetListAndMissileByCoordinates($moon);
//      /**
//       * @var Fleet[] $array_of_Fleet
//       */
//      $array_of_Fleet = array();
//      if(!empty($fleet_db_list) && $fleet_db_list->count()) {
//        foreach($fleet_db_list->_container as $fleet_id => $objFleet) {
//          $array_of_Fleet[$fleet_id] = $objFleet;
//        }
//        $moon_fleets = flt_get_fleets_to_planet_by_array_of_Fleet($array_of_Fleet);
//      }

      $template->assign_block_vars('planet', array_merge($template_planet, array(
        'PLANET_FLEET_ID'  => $planet_fleet_id,

        'MOON_ID'      => $moon['id'],
        'MOON_NAME'    => $moon['name'],
        'MOON_IMG'     => $moon['image'],
        'MOON_FILL'    => min(100, $moon_fill),
        'MOON_ENEMY'   => !empty($moon_fleets['enemy']['count']) ? $moon_fleets['enemy']['count'] : 0,

        'MOON_PLANET'  => $moon['parent_planet'],
      )));

      $planet_count++;
    }

    tpl_assign_fleet($template, $fleets_to_planet);
    tpl_assign_fleet($template, $fleets);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

    $lune = $planetrow['planet_type'] == PT_PLANET ? DBStaticPlanet::db_planet_by_parent($planetrow['id']) : DBStaticPlanet::db_planet_by_id($planetrow['parent_planet']);
    if($lune) {
      $template->assign_vars(array(
        'MOON_ID' => $lune['id'],
        'MOON_IMG' => $lune['image'],
        'MOON_NAME' => $lune['name'],
      ));
    }

    $planet_fill = floor($planetrow['field_current'] / eco_planet_fields_max($planetrow) * 100);
    $planet_fill = $planet_fill > 100 ? 100 : $planet_fill;

    $planet_recyclers_orbiting = 0;
    foreach(Fleet::$snGroupRecyclers as $recycler_id) {
      $planet_recyclers_orbiting += mrc_get_level($user, $planetrow, $recycler_id);
    }

    int_planet_pretemplate($planetrow, $template);

    $sn_group_ques = sn_get_groups('ques');
    if(!defined('GAME_STRUCTURES_DISABLED') || !GAME_STRUCTURES_DISABLED) {
      foreach(array(QUE_STRUCTURES => $sn_group_ques[QUE_STRUCTURES]) as $que_id => $que_type_data) {
        $this_que = $que['ques'][$que_id][$user['id']][$planetrow['id']];
        $template->assign_block_vars('ques', array(
          'ID'     => $que_id,
          'NAME'   => classLocale::$lang['sys_ques'][$que_id],
          'LENGTH' => empty($this_que) ? 0 : count($this_que),
        ));

        if(!empty($this_que)) {
          foreach($this_que as $que_item) {
            $template->assign_block_vars('que', que_tpl_parse_element($que_item));
          }
        }
      }
    }

    $que_hangar_length = tpl_assign_hangar($template, $planetrow, SUBQUE_FLEET);
    $template->assign_block_vars('ques', array(
      'ID'     => QUE_HANGAR,
      'NAME'   => classLocale::$lang['sys_ques'][QUE_HANGAR],
      'LENGTH' => $que_hangar_length,
    ));

    if(!defined('GAME_DEFENSE_DISABLED') || !GAME_DEFENSE_DISABLED) {
      $que_hangar_length = tpl_assign_hangar($template, $planetrow, SUBQUE_DEFENSE);
      $template->assign_block_vars('ques', array(
        'ID'     => SUBQUE_DEFENSE,
        'NAME'   => classLocale::$lang['sys_ques'][SUBQUE_DEFENSE],
        'LENGTH' => $que_hangar_length,
      ));
    }

    $overview_planet_rows = $user['opt_int_overview_planet_rows'];
    $overview_planet_columns = $user['opt_int_overview_planet_columns'];

    if($overview_planet_rows <= 0 && $overview_planet_columns <= 0) {
      $overview_planet_rows = $user_option_list[OPT_INTERFACE]['opt_int_overview_planet_rows'];
      $overview_planet_columns = $user_option_list[OPT_INTERFACE]['opt_int_overview_planet_columns'];
    }

    if($overview_planet_rows > 0 && $overview_planet_columns <= 0) {
      $overview_planet_columns = ceil($planet_count / $overview_planet_rows);
    }

    $sector_cost = eco_get_build_data($user, $planetrow, UNIT_SECTOR, mrc_get_level($user, $planetrow, UNIT_SECTOR), true);
    $sector_cost = $sector_cost[BUILD_CREATE][RES_DARK_MATTER];
    $governor_level = $planetrow['PLANET_GOVERNOR_ID'] ? mrc_get_level($user, $planetrow, $planetrow['PLANET_GOVERNOR_ID'], false, true) : 0;
    $template->assign_vars(array(
      'USER_ID'               => $user['id'],
      'user_username'         => $user['username'],
      'USER_AUTHLEVEL'        => $user['authlevel'],

      'NEW_MESSAGES'          => $user['new_message'],
      'NEW_LEVEL_MINER'       => $level_miner,
      'NEW_LEVEL_RAID'        => $level_raid,

      'planet_diameter'       => pretty_number($planetrow['diameter']),
      'planet_field_current'  => $planetrow['field_current'],
      'planet_field_max'      => eco_planet_fields_max($planetrow),
      'PLANET_FILL'           => floor($planetrow['field_current'] / eco_planet_fields_max($planetrow) * 100),
      'PLANET_FILL_BAR'       => $planet_fill,
      'metal_debris'          => pretty_number($planetrow['debris_metal']),
      'crystal_debris'        => pretty_number($planetrow['debris_crystal']),
      'PLANET_RECYCLERS'      => $planet_recyclers_orbiting,
      'planet_image'          => $planetrow['image'],
      'planet_temp_min'       => $planetrow['temp_min'],
      'planet_temp_avg'       => round(($planetrow['temp_min'] + $planetrow['temp_max']) / 2),
      'planet_temp_max'       => $planetrow['temp_max'],
      'planet_density'        => $planetrow['density'],
      'planet_density_index'  => $planetrow['density_index'],
      'planet_density_text'   => classLocale::$lang['uni_planet_density_types'][$planetrow['density_index']],

      'GATE_LEVEL'            => mrc_get_level($user, $planetrow, STRUC_MOON_GATE),
      'GATE_JUMP_REST_TIME'   => uni_get_time_to_jump($planetrow),

      'ADMIN_EMAIL'           => classSupernova::$config->game_adminEmail,

      'PLANET_GOVERNOR_ID'    => $planetrow['PLANET_GOVERNOR_ID'],
//      'PLANET_GOVERNOR_LEVEL' => $planetrow['PLANET_GOVERNOR_LEVEL'] mrc_get_level($user, $planetrow,),

      'PLANET_GOVERNOR_LEVEL' => $governor_level,
      'PLANET_GOVERNOR_LEVEL_PLUS' => mrc_get_level($user, $planetrow, $planetrow['PLANET_GOVERNOR_ID']) - $governor_level,
      'PLANET_GOVERNOR_NAME'  => classLocale::$lang['tech'][$planetrow['PLANET_GOVERNOR_ID']],

      'LIST_ROW_COUNT'        => $overview_planet_rows,
      'LIST_COLUMN_COUNT'     => $overview_planet_columns,

      'DARK_MATTER'           => $user_dark_matter,

      'PLANET_DENSITY_INDEX'  => $planet_density_index,
      'PLANET_CORE_TEXT'      => classLocale::$lang['uni_planet_density_types'][$planet_density_index],

      'SECTOR_CAN_BUY'        => $sector_cost <= mrc_get_level($user, null, RES_DARK_MATTER),
      'SECTOR_COST'           => $sector_cost,
      'SECTOR_COST_TEXT'      => pretty_number($sector_cost),
    ));
    tpl_set_resource_info($template, $planetrow, $fleets_to_planet, 2);

    foreach($result as &$a_result) {
      $template->assign_block_vars('result', $a_result);
    }

    $classLocale = classLocale::$lang;
    display($template, "{$classLocale['ov_overview']} - {$classLocale['sys_planet_type'][$planetrow['planet_type']]} {$planetrow['name']} [{$planetrow['galaxy']}:{$planetrow['system']}:{$planetrow['planet']}]");
  break;
}


1			<?php
2			/**
3			* index.php - overview.php
4			*
5			* 2.4 - copyright (c) 2010 by Gorlum for http://supernova.ws
6			* [-] Removed News frame
7			* [-] Time & Usersonline moved to Top-Frame
8			* 2.3 - copyright (c) 2010 by Gorlum for http://supernova.ws
9			* [*] Complying with PCG
10			* 2.2 - copyright (c) 2010 by Gorlum for http://supernova.ws
11			* [+] Redo flying fleet list
12			* 2.1 - copyright (c) 2010 by Gorlum for http://supernova.ws
13			* [+] Planets on planet list now have indication of planet fill
14			* [+] Planets on planet list now have indication when there is enemy fleet flying to planet
15			* 2.0 - copyright (c) 2010 by Gorlum for http://supernova.ws
16			* [+] Now there is full planet list on right side of screen a-la oGame
17			* [+] Planet list now include icons for buildings/tech/fleet on progress
18			* 1.5 - copyright (c) 2010 by Gorlum for http://supernova.ws
19			* [*] Subplanet timers now use sn_timer.js library
20			* 1.4 - copyright (c) 2010 by Gorlum for http://supernova.ws
21			* [*] All mainplanet timers now use new sn_timer.js library
22			* 1.3 - copyright (c) 2010 by Gorlum for http://supernova.ws
23			* [*] Adjusted layouts of player infos
24			* 1.2 - copyright (c) 2010 by Gorlum for http://supernova.ws
25			* [*] Adjusted layouts of planet infos
26			* 1.1 - Security checks by Gorlum for http://supernova.ws
27			* @version 1
28			* @copyright 2008 By Chlorel for XNova
29			*/
30
31			//define('SN_RENDER_NAVBAR_PLANET', false);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
32
33			include('common.' . substr(strrchr(__FILE__, '.'), 1));
34
35			//$ccc = 0;
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-26 17:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
36			//foreach(DBStaticUser::db_user_list_non_bots() as $ip) {
37			// $ccc++;
38			//}

supernova-ws / SuperNova

Push — work-fleets ( 867546...331178 )

overview.php (18 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like