Issues in changelog.php - Fixed Issues - Inspection of "CODE-feat-41a6.41: Partially moved $lang to proper..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( 069d1a...74a0d7 )

by SuperNova.WS

created 2016-03-25 20:42 UTC

changelog.php (2 issues)

Labels

Best Practice 1
Duplication 1

Severity

Minor 1
Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * changelog.php
 *
 * @version 1.0
 * @copyright 2008 by ??????? for XNova
 */

include('common.' . substr(strrchr(__FILE__, '.'), 1));

lng_include('changelog');

$template = gettemplate('changelog_table');


foreach($lang['changelog'] as $a => $b)

{

  $parse['version_number'] = $a;
  $parse['description'] = nl2br($b);

  $body .= parsetemplate($template, $parse);

}

$parse = $lang;
$parse['body'] = $body;

display(parsetemplate(gettemplate('changelog_body'), $parse), "Change Log");

// Created by Perberos. All rights reversed (C) 2006

?>


1		<?php
2
3		/**
4		* changelog.php
5		*
6		* @version 1.0
7		* @copyright 2008 by ??????? for XNova
8		*/
9
10		include('common.' . substr(strrchr(__FILE__, '.'), 1));
11
12		lng_include('changelog');
13
14		$template = gettemplate('changelog_table');
15
16
17	View Code Duplication	foreach($lang['changelog'] as $a => $b)
		0 ignored issues – show Duplication introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		{
19
20		$parse['version_number'] = $a;
21		$parse['description'] = nl2br($b);
22
23		$body .= parsetemplate($template, $parse);
24
25		}
26
27		$parse = $lang;
28		$parse['body'] = $body;
29
30		display(parsetemplate(gettemplate('changelog_body'), $parse), "Change Log");
31
32		// Created by Perberos. All rights reversed (C) 2006
33
34		?>
		0 ignored issues – show Best Practice introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...

supernova-ws / SuperNova

Push — work-fleets ( 069d1a...74a0d7 )

changelog.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like