Issues in annonce.php - Fixed Issues - Inspection of "CODE-feat-41a6.41: Partially moved $lang to proper..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( 069d1a...74a0d7 )

by SuperNova.WS

created 2016-03-25 20:42 UTC

annonce.php (1 issue)

Labels

Best Practice 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * annonce.php
 *
 * Announces for trading between players
 *
 * @version 1.0s - Security checked for SQL-injection by Gorlum for http://supernova.ws
 * @version 1.0
 * @copyright 2008 by ??????? for XNova
 */

include('common.' . substr(strrchr(__FILE__, '.'), 1));

$users = db_user_by_id($user['id'], false, '`username`,`galaxy`,`system`');
$action = sys_get_param_int('action');
$GET_id = sys_get_param_int('id');

lng_include('announce');

switch($action) {
  case 1://on veut poster une annonce
    $page .= '<HTML>
    <center>
    <br>
    <table width="600">
    <td class="c" colspan="10" align="center"><b><font color="white">' . $lang['Classifieds'] . '</font></b></td></tr>
    <form action="annonce.php?action=2" method="post">
    <td class="c" colspan="10" align="center"><b>' . $lang['Resources_to_be_sold'] . '</font></b></td>
    <tr><th colspan="5">' . $lang['metal'] . '</th><th colspan="5"><input type="texte" value="0" name="metalvendre" /></th></tr>
    <tr><th colspan="5">' . $lang['crystal'] . '</th><th colspan="5"><input type="texte" value="0" name="cristalvendre" /></th></tr>
    <tr><th colspan="5">' . $lang['deuterium'] . '</th><th colspan="5"><input type="texte" value="0" name="deutvendre" /></th></tr>

    <td class="c" colspan="10" align="center"><b>' . $lang['Desired_resources'] . '</font></b></td></tr>
    <tr><th colspan="5">' . $lang['metal'] . '</th><th colspan="5"><input type="texte" value="0" name="metalsouhait" /></th></tr>
    <tr><th colspan="5">' . $lang['crystal'] . '</th><th colspan="5"><input type="texte" value="0" name="cristalsouhait" /></th></tr>
    <tr><th colspan="5">' . $lang['deuterium'] . '</th><th colspan="5"><input type="texte" value="0" name="deutsouhait" /></th></tr>
    <tr><th colspan="10"><input type="submit" value="' . $lang['send'] . '" /></th></tr>

    <form>
    </table>
    </HTML>';

    display($page);
  break;

  case 2:// On vient d'envoyer une annonce, on l'enregistre et on affiche un message comme quoi on l'a bien fait
    $metalvendre = sys_get_param_float('metalvendre');
    $metalsouhait = sys_get_param_float('metalsouhait');
    $cristalvendre = sys_get_param_float('cristalvendre');
    $cristalsouhait = sys_get_param_float('cristalsouhait');
    $deutvendre = sys_get_param_float('deutvendre');
    $deutsouhait = sys_get_param_float('deutsouhait');

    if(($metalvendre != 0 && $metalsouhait == 0) || ($cristalvendre != 0 && $cristalsouhait == 0) || ($deutvendre != 0 && $deutsouhait == 0)) {
      db_ANNONCE_insert_set($users, $metalvendre, $cristalvendre, $deutvendre, $metalsouhait, $cristalsouhait, $deutsouhait);
      message($lang['Your_announce_was_recorded'], $lang['announce_status'], "annonce.php");
    } else {
      message($lang['Your_announce_not_recorded'], $lang['announce_status'], "annonce.php?action=1");
    }
  break;

  case 3://Suppression d'annonce
    db_ANNONCE_delete_by_id($GET_id);
    message($lang['Your_announce_was_deleted'], $lang['announce_status'], "annonce.php");
  break;

  default://Sinon on affiche la liste des annonces
    $annonce = db_ANNONCE_LIST_select_all();

    $page2 = "<HTML><center><br>
    <table width=\"600\">
    <td class=\"c\" colspan=\"10\"><font color=\"#FFFFFF\">{$lang['Classifieds']}</font></td></tr>
    <tr><th colspan=\"3\">{$lang['Infos_of_delivery']}</th><th colspan=\"3\">{$lang['Resources_to_be_sold']}</th><th colspan=\"3\">{$lang['Desired_resources']}</th><th>{$lang['Action']}</th></tr>
    <tr><th>{$lang['Salesman']}</th><th>{$lang['Galaxy']}</th><th>{$lang['Solar_system']}</th><th>{$lang['metal']}</th><th>{$lang['crystal']}</th><th>{$lang['deuterium']}</th><th>{$lang['metal']}</th><th>{$lang['crystal']}</th><th>{$lang['deuterium']}</th><th>{$lang['Delete']}</th></tr>";

    while($b = db_fetch($annonce)) {
      $page2 .= '<tr><th>';
      foreach($b as $name => $value) {
        if($name != 'id') {
          $page2 .= $value;
          $page2 .= '</th><th>';
        }
      }
      $page2 .= ($b['user'] == $users['username']) ? "<a href=\"annonce.php?action=3&id={$b[id]}\">X</a></th></tr>" : "</th></tr>";
    }

    $page2 .= "<tr><th colspan=\"10\" align=\"center\"><a href=\"annonce.php?action=1\">{$lang['add_announce']}</a></th></tr></td></table></HTML>";

    display($page2);
  break;
}

// Créé par Tom1991 Copyright 2008
// Modifié par BenjaminV
?>



1			<?php
2
3			/**
4			* annonce.php
5			*
6			* Announces for trading between players
7			*
8			* @version 1.0s - Security checked for SQL-injection by Gorlum for http://supernova.ws
9			* @version 1.0
10			* @copyright 2008 by ??????? for XNova
11			*/
12
13			include('common.' . substr(strrchr(__FILE__, '.'), 1));
14
15			$users = db_user_by_id($user['id'], false, '`username`,`galaxy`,`system`');
16			$action = sys_get_param_int('action');
17			$GET_id = sys_get_param_int('id');
18
19			lng_include('announce');
20
21			switch($action) {
22			case 1://on veut poster une annonce
23			$page .= '<HTML>
24			<center>
25			<br>
26			<table width="600">
27			<td class="c" colspan="10" align="center"><b><font color="white">' . $lang['Classifieds'] . '</font></b></td></tr>
28			<form action="annonce.php?action=2" method="post">
29			<td class="c" colspan="10" align="center"><b>' . $lang['Resources_to_be_sold'] . '</font></b></td>
30			<tr><th colspan="5">' . $lang['metal'] . '</th><th colspan="5"><input type="texte" value="0" name="metalvendre" /></th></tr>
31			<tr><th colspan="5">' . $lang['crystal'] . '</th><th colspan="5"><input type="texte" value="0" name="cristalvendre" /></th></tr>
32			<tr><th colspan="5">' . $lang['deuterium'] . '</th><th colspan="5"><input type="texte" value="0" name="deutvendre" /></th></tr>
33
34			<td class="c" colspan="10" align="center"><b>' . $lang['Desired_resources'] . '</font></b></td></tr>
35			<tr><th colspan="5">' . $lang['metal'] . '</th><th colspan="5"><input type="texte" value="0" name="metalsouhait" /></th></tr>
36			<tr><th colspan="5">' . $lang['crystal'] . '</th><th colspan="5"><input type="texte" value="0" name="cristalsouhait" /></th></tr>
37			<tr><th colspan="5">' . $lang['deuterium'] . '</th><th colspan="5"><input type="texte" value="0" name="deutsouhait" /></th></tr>
38			<tr><th colspan="10"><input type="submit" value="' . $lang['send'] . '" /></th></tr>
39
40			<form>
41			</table>
42			</HTML>';
43
44			display($page);
45			break;
46
47			case 2:// On vient d'envoyer une annonce, on l'enregistre et on affiche un message comme quoi on l'a bien fait
48			$metalvendre = sys_get_param_float('metalvendre');
49			$metalsouhait = sys_get_param_float('metalsouhait');
50			$cristalvendre = sys_get_param_float('cristalvendre');
51			$cristalsouhait = sys_get_param_float('cristalsouhait');
52			$deutvendre = sys_get_param_float('deutvendre');
53			$deutsouhait = sys_get_param_float('deutsouhait');
54
55			if(($metalvendre != 0 && $metalsouhait == 0) \|\| ($cristalvendre != 0 && $cristalsouhait == 0) \|\| ($deutvendre != 0 && $deutsouhait == 0)) {
56			db_ANNONCE_insert_set($users, $metalvendre, $cristalvendre, $deutvendre, $metalsouhait, $cristalsouhait, $deutsouhait);
57			message($lang['Your_announce_was_recorded'], $lang['announce_status'], "annonce.php");
58			} else {
59			message($lang['Your_announce_not_recorded'], $lang['announce_status'], "annonce.php?action=1");
60			}
61			break;
62
63			case 3://Suppression d'annonce
64			db_ANNONCE_delete_by_id($GET_id);
65			message($lang['Your_announce_was_deleted'], $lang['announce_status'], "annonce.php");
66			break;
67
68			default://Sinon on affiche la liste des annonces
69			$annonce = db_ANNONCE_LIST_select_all();
70
71			$page2 = "<HTML><center><br>
72			<table width=\"600\">
73			<td class=\"c\" colspan=\"10\"><font color=\"#FFFFFF\">{$lang['Classifieds']}</font></td></tr>
74			<tr><th colspan=\"3\">{$lang['Infos_of_delivery']}</th><th colspan=\"3\">{$lang['Resources_to_be_sold']}</th><th colspan=\"3\">{$lang['Desired_resources']}</th><th>{$lang['Action']}</th></tr>
75			<tr><th>{$lang['Salesman']}</th><th>{$lang['Galaxy']}</th><th>{$lang['Solar_system']}</th><th>{$lang['metal']}</th><th>{$lang['crystal']}</th><th>{$lang['deuterium']}</th><th>{$lang['metal']}</th><th>{$lang['crystal']}</th><th>{$lang['deuterium']}</th><th>{$lang['Delete']}</th></tr>";
76
77			while($b = db_fetch($annonce)) {
78			$page2 .= '<tr><th>';
79			foreach($b as $name => $value) {
80			if($name != 'id') {
81			$page2 .= $value;
82			$page2 .= '</th><th>';
83			}
84			}
85			$page2 .= ($b['user'] == $users['username']) ? "<a href=\"annonce.php?action=3&id={$b[id]}\">X</a></th></tr>" : "</th></tr>";
86			}
87
88			$page2 .= "<tr><th colspan=\"10\" align=\"center\"><a href=\"annonce.php?action=1\">{$lang['add_announce']}</a></th></tr></td></table></HTML>";
89
90			display($page2);
91			break;
92			}
93
94			// Créé par Tom1991 Copyright 2008
95			// Modifié par BenjaminV
96			?>
			0 ignored issues – show Best Practice introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
97

supernova-ws / SuperNova

Push — work-fleets ( 069d1a...74a0d7 )

annonce.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like