supernova-ws / SuperNova

fleet.php

<?php

/*
  fleet.php
  Fleet manager

  V3.3 copyright (c) 2009-2010 by Gorlum for http://supernova.ws
    [~] Imploded fleet_back.php code

  V3.2 copyright (c) 2009-2010 by Gorlum for http://supernova.ws
    [~] separate independent chunks in INC-files

  V3.1 copyright (c) 2009-2010 by Gorlum for http://supernova.ws
    [~] Security checked & tested

  V3.0 Updated by Gorlum Sep 2009
    [!] extracting templates from code
    [~] some redundant code cleaning

  V2.0 Updated by Chlorel. 16 Jan 2008 (String extraction, bug corrections, code uniformisation

  V1.0 Created by Perberos. All rights reversed (C) 2006
*/

include('common.' . substr(strrchr(__FILE__, '.'), 1));
$template_result = is_array($template_result) ? $template_result : array();

define('SN_IN_FLEET', true);

require_once('includes/includes/flt_functions.php');

lng_include('fleet');

//$fleet_page = ($fleet_page = sys_get_param_int('fleet_page')) ? $fleet_page : sys_get_param_int('mode');

54% of this comment could be valid code. Did you maybe forget this after debugging?

$fleet_page = sys_get_param_int('fleet_page', sys_get_param_int('mode'));

$galaxy = sys_get_param_int('galaxy', $planetrow['galaxy']);
$system = sys_get_param_int('system', $planetrow['system']);
$planet = sys_get_param_int('planet', $planetrow['planet']);

$target_mission = sys_get_param_int('target_mission');
if($target_mission == MT_COLONIZE || $target_mission == MT_EXPLORE) {
  $planet_type = PT_PLANET;
} elseif($target_mission == MT_RECYCLE) {
  $planet_type = PT_DEBRIS;
} elseif($target_mission == MT_DESTROY) {
  $planet_type = PT_MOON;
} else {
  $planet_type = sys_get_param_int('planet_type');
  if (!$planet_type) {
    $planet_type = sys_get_param_int('planettype', $planetrow['planet_type']);
  }
}

$options = array();
$options['fleets_max'] = GetMaxFleets($user);

$MaxFleets = GetMaxFleets($user);
$FlyingFleets = FleetList::fleet_count_flying($user['id']);
if($MaxFleets <= $FlyingFleets && $fleet_page && $fleet_page != 4) {
  message(classLocale::$lang['fl_noslotfree'], classLocale::$lang['fl_error'], "fleet." . PHP_EX, 5);
}

$MaxExpeditions = get_player_max_expeditons($user);
if($MaxExpeditions) {
  $FlyingExpeditions  = FleetList::fleet_count_flying($user['id'], MT_EXPLORE);
} else {
  $FlyingExpeditions = 0;
}

switch ($fleet_page) {
  case 3:

  case 2:
    $fleet_group_mr = sys_get_param_id('fleet_group');
    $fleetarray     = unserialize(base64_decode(str_rot13(sys_get_param('usedfleet'))));
    $fleetarray = is_array($fleetarray) ? $fleetarray : array();

    foreach($fleetarray as $ship_id => &$ship_amount) {
      if(!in_array($ship_id, sn_get_groups('fleet')) || (string)floatval($ship_amount) != $ship_amount || $ship_amount < 1) {
        $debug->warning('Supplying wrong ship in ship list on fleet page', 'Hack attempt', 302, array('base_dump' => true));
        die();
      }
      $ship_amount = floatval($ship_amount);
    }

    $UsedPlanet = false;
    $YourPlanet = false;
    $missiontype = array();
    if ($planet > classSupernova::$config->game_maxPlanet) {
      $target_mission = MT_EXPLORE;
      $missiontype[MT_EXPLORE] = classLocale::$lang['type_mission'][MT_EXPLORE];
    } elseif ($galaxy && $system && $planet) {
      $check_type = $planet_type == PT_MOON ? PT_MOON : PT_PLANET;

      $TargetPlanet = db_planet_by_gspt($galaxy, $system, $planet, $check_type);

      if ($TargetPlanet['id_owner']) {
        $UsedPlanet = true;
        if ($TargetPlanet['id_owner'] == $user['id']) {
          $YourPlanet = true;
        }
      }

      if (!$UsedPlanet) {
        if ($fleetarray[SHIP_COLONIZER]) {
          $missiontype[MT_COLONIZE] = classLocale::$lang['type_mission'][MT_COLONIZE];
          $target_mission = MT_COLONIZE;
          $planet_type = PT_PLANET;
        } else {
          message ("<font color=\"red\"><b>". classLocale::$lang['fl_no_planet_type'] ."</b></font>", classLocale::$lang['fl_error']);
        }
      } else {
        $recyclers = 0;
        foreach(sn_get_groups('flt_recyclers') as $recycler_id) {
          $recyclers += $fleetarray[$recycler_id];
        }
        if ($recyclers > 0 && $planet_type == PT_DEBRIS) {
          $target_mission = MT_RECYCLE;
          $missiontype[MT_RECYCLE] = classLocale::$lang['type_mission'][MT_RECYCLE];
        } elseif ($planet_type == PT_PLANET || $planet_type == PT_MOON) {
          if ($YourPlanet) {
            $missiontype[MT_RELOCATE] = classLocale::$lang['type_mission'][MT_RELOCATE];
            $missiontype[MT_TRANSPORT] = classLocale::$lang['type_mission'][MT_TRANSPORT];
          } else {
            // Not Your Planet
            if ($fleetarray[SHIP_SPY]) {
              // Only spy missions if any spy
              $missiontype[MT_SPY] = classLocale::$lang['type_mission'][MT_SPY];
            } else {
              // If no spies...
              if ($fleet_group_mr) {
                $missiontype[MT_AKS] = classLocale::$lang['type_mission'][MT_AKS];
              } else {
                $missiontype[MT_ATTACK] = classLocale::$lang['type_mission'][MT_ATTACK];
                $missiontype[MT_TRANSPORT] = classLocale::$lang['type_mission'][MT_TRANSPORT];

                $missiontype[MT_HOLD] = classLocale::$lang['type_mission'][MT_HOLD];

                if($planet_type == PT_MOON && $fleetarray[SHIP_HUGE_DEATH_STAR]) {
                  $missiontype[MT_DESTROY] = classLocale::$lang['type_mission'][MT_DESTROY];
                }
              }
            }
          }
        }
      }
    }

    if (!$target_mission && is_array($missiontype)) {
      $target_mission = MT_ATTACK;
    }

    ksort($missiontype);

    $speed_percent = sys_get_param_int('speed', 10);
    $travel_data   = flt_travel_data($user, $planetrow, array('galaxy' => $galaxy, 'system' => $system, 'planet' => $planet), $fleetarray, $speed_percent);

    $fleet_speed   = $travel_data['fleet_speed'];
    $distance      = $travel_data['distance'];
    $duration      = $travel_data['duration'];
    $consumption   = $travel_data['consumption'];
  // No Break

  case 1:
    if ($galaxy && $system && $planet) {
      $check_type = $planet_type == PT_MOON ? PT_MOON : PT_PLANET;

      $TargetPlanet = db_planet_by_gspt($galaxy, $system, $planet, $check_type);
    }

  case 0:
    $template_result += array(
      'thisgalaxy'      => $planetrow['galaxy'],
      'thissystem'      => $planetrow['system'],
      'thisplanet'      => $planetrow['planet'],
      'thisplanet_type' => $planetrow['planet_type'],
    );
  // no break

}

$template_result += array(
  'galaxy' => $galaxy,
  'system' => $system,
  'planet' => $planet,
  'planet_type' => $planet_type,
  'target_mission'  => $target_mission ? $target_mission : 0,
  'MISSION_NAME'		=> $target_mission ? classLocale::$lang['type_mission'][$target_mission] : '',
);

$is_transport_missions = false;
if($missiontype) {

The expression $missiontype of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

  $sn_group_missions = sn_get_groups('missions');
  foreach($missiontype as $mission_data_id => $mission_data) {
    $is_transport_missions = $is_transport_missions || (isset($sn_group_missions[$mission_data_id]['transport']) && $sn_group_missions[$mission_data_id]['transport']);
  }
}

switch($fleet_page) {
  case 1:
    require('includes/includes/flt_page1.inc');
  break;

  case 2:
    require_once('includes/includes/flt_page2.inc');
    sn_fleet_page2();
  break;

  case 3:
    require_once('includes/includes/flt_page3.inc');
    sn_fleet_page3($duration);
  break;

  case 4:
    require('includes/includes/flt_page4.inc');
  break;

  case 5:
    require('includes/includes/flt_page5.inc');
  break;

  default:
    define('SN_RENDER_NAVBAR_PLANET', true);

    require('includes/includes/flt_page0.inc');
  break;
}