Issues in metamatter.php - Fixed Issues - Inspection of "CODE-misc-41a6.69: More work to reduce code smell" - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — work-fleets (1ceb9c)

by SuperNova.WS

created 2016-03-26 22:37 UTC

metamatter.php (5 issues)

Labels

Documentation 5

Severity

Minor 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

global $debug;

// Придумать какой статус должен быть у глобальных ответов, что бы не перекрывать статусы платежных систем
// Может добавить спецстатус "Ответ системы платежа" и парсить дальше getMessage
// см constants.php

include_once('common.' . substr(strrchr(__FILE__, '.'), 1));

if(!sn_module_get_active_count('payment')) {
  sys_redirect('dark_matter.php');
  die();
}

lng_include('payment');
lng_include('infos');

$template = gettemplate('metamatter', true);

$player_currency_default = classSupernova::$user_options[PLAYER_OPTION_CURRENCY_DEFAULT];
$player_currency = sys_get_param_str('player_currency', $player_currency_default);
empty(classLocale::$lang['pay_currency_list'][$player_currency]) ? ($player_currency = $player_currency_default ? $player_currency_default : classSupernova::$config->payment_currency_default) : false;
$player_currency_default != $player_currency ? classSupernova::$user_options[PLAYER_OPTION_CURRENCY_DEFAULT] = $player_currency : false;

// Таблица скидок
$prev_discount = 0;
if(isset(sn_module_payment::$bonus_table) && is_array(sn_module_payment::$bonus_table)) {
  foreach(sn_module_payment::$bonus_table as $sum => $discount) {
    if($discount && $discount != $prev_discount) {
      $template->assign_block_vars('discount', array(
        'SUM'          => $sum,
        'DISCOUNT'     => $discount * 100,
        'DISCOUNT_ONE' => 1 + $discount,
        'TEXT'         => sprintf(classLocale::$lang['pay_mm_bonus_each'], pretty_number($sum), round($discount * 100)),
      ));
      $prev_discount = $discount;
    }
  }
}

// Результат платежа
if($payment_id = sys_get_param_id('payment_id')) {
  $payment = db_payment_get($payment_id);
  if($payment && $payment['payment_user_id'] == $user['id']) {
    if($payment['payment_status'] == PAYMENT_STATUS_COMPLETE) {
      $template->assign_block_vars('result', array('MESSAGE' => sprintf(classLocale::$lang['pay_msg_mm_purchase_complete'], $payment['payment_dark_matter_paid'], $payment['payment_module_name'], $payment['payment_dark_matter_gained'])));
    }
    if($payment['payment_status'] == PAYMENT_STATUS_NONE) {
      $template->assign_block_vars('result', array(
        'MESSAGE' => sprintf(classLocale::$lang['pay_msg_mm_purchase_incomplete'], $payment['payment_dark_matter_paid'], $payment['payment_module_name']),
        'STATUS'  => 1,
      ));
    }
    if($payment['payment_test']) {
      $template->assign_block_vars('result', array(
        'MESSAGE' => sprintf(classLocale::$lang['pay_msg_mm_purchase_test']),
        'STATUS'  => -1,
      ));
    }
  }
}

$unit_available_amount_list = &sn_module_payment::$bonus_table;

$request = array(
  'metamatter' => sys_get_param_float('metamatter'),
);

if(!$request['metamatter']) {
  unset($_POST);
}

$payment_methods_available = array_combine(array_keys(sn_module_payment::$payment_methods), array_fill(0, count(sn_module_payment::$payment_methods), null));
array_walk($payment_methods_available, function (&$value, $index) {
  $value = !empty(sn_module_payment::$payment_methods[$index]) ? array_combine(array_keys(sn_module_payment::$payment_methods[$index]), array_fill(0, count(sn_module_payment::$payment_methods[$index]), null)) : $value;
});

// pdump($payment_methods_available);
$payment_module_valid = false;
$payment_module = sys_get_param_str('payment_module');
foreach(sn_module::$sn_module_list['payment'] as $module_name => $module) {
  if(!is_object($module) || !$module->manifest['active']) {
    continue;
  }

  lng_include($module_name, $module->manifest['root_relative']);

  foreach(sn_module_payment::$payment_methods as $payment_type_id => $available_methods) {
    foreach($available_methods as $payment_method => $payment_currency) {
      if(isset($module->manifest['payment_method'][$payment_method])) {
        $payment_methods_available[$payment_type_id][$payment_method][$module_name] = $module->manifest['payment_method'][$payment_method];
      }
    }
  }

  $payment_module_valid = $payment_module_valid || $module_name == $payment_module;
}

global $template_result;
// Доступные платежные методы
foreach($payment_methods_available as $payment_type_id => $payment_methods) {
  if(empty($payment_methods)) {
    continue;
  }

  $template_result['.']['payment'][$payment_type_id] = array(
    'ID'   => $payment_type_id,
    'NAME' => classLocale::$lang['pay_methods'][$payment_type_id],
  );
  foreach($payment_methods as $payment_method_id => $module_list) {
    if(empty($module_list)) {
      continue;
    }
    $template_result['.']['payment'][$payment_type_id]['.']['method'][$payment_method_id] = array(
      'ID'         => $payment_method_id,
      'NAME'       => classLocale::$lang['pay_methods'][$payment_method_id],
      'IMAGE'      => isset(sn_module_payment::$payment_methods[$payment_type_id][$payment_method_id]['image'])
        ? sn_module_payment::$payment_methods[$payment_type_id][$payment_method_id]['image'] : '',
      'NAME_FORCE' => isset(sn_module_payment::$payment_methods[$payment_type_id][$payment_method_id]['name']),
      'BUTTON'     => isset(sn_module_payment::$payment_methods[$payment_type_id][$payment_method_id]['button']),
    );
    foreach($module_list as $payment_module_name => $payment_module_method_details) {
      $template_result['.']['payment'][$payment_type_id]['.']['method'][$payment_method_id]['.']['module'][] = array(
        'MODULE' => $payment_module_name,
      );
    }
  }

  if(empty($template_result['.']['payment'][$payment_type_id]['.'])) {
    unset($template_result['.']['payment'][$payment_type_id]);
  }
}

$template->assign_recursive($template_result);

$payment_type_selected = sys_get_param_int('payment_type');
$payment_method_selected = sys_get_param_int('payment_method');

$payment_module_valid = $payment_module_valid && (!$payment_method_selected || isset($payment_methods_available[$payment_type_selected][$payment_method_selected][$module_name]));

// If payment_module invalid - making it empty OR if there is only one payment_module - selecting it
if($payment_module_valid) {
  // $payment_module = $payment_module; // Really - do nothing
} elseif($payment_type_selected && count($payment_methods_available[$payment_type_selected][$payment_method_selected]) == 1) {
  reset($payment_methods_available[$payment_type_selected][$payment_method_selected]);
  $payment_module = key($payment_methods_available[$payment_type_selected][$payment_method_selected]);
} elseif(count(sn_module::$sn_module_list['payment']) == 1) {
  $payment_module = $module_name;
} else {
  $payment_module = '';
}

if($payment_type_selected && $payment_method_selected) {
  foreach($payment_methods_available[$payment_type_selected][$payment_method_selected] as $module_name => $temp) {
    $template->assign_block_vars('payment_module', array(
      'ID'          => $module_name,
      'NAME'        => classLocale::$lang["module_{$module_name}_name"],
      'DESCRIPTION' => classLocale::$lang["module_{$module_name}_description"],
    ));
  }
}

foreach(classLocale::$lang['pay_currency_list'] as $key => $value) {
  $course = get_exchange_rate($key);
  if(!$course) {
    continue;
  }
  $template->assign_block_vars('exchange', array(
    'SYMBOL'          => $key,
    'TEXT'            => $value,
    'COURSE_DIRECT'   => pretty_number($course, 4),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    'COURSE_REVERSE'  => pretty_number(1 / $course, 4),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    'MM_PER_CURRENCY' => pretty_number(sn_module_payment::currency_convert(1, $key, 'MM_')),
    'LOT_PRICE'       => sn_module_payment::currency_convert(get_mm_cost(), 'MM_', $key),
    'DEFAULT'         => $key == classSupernova::$config->payment_currency_default,
    // 'UNIT_PER_LOT' => sn_module_payment::currency_convert(2500, 'MM_', $key),
  ));
}

if($request['metamatter'] && $payment_module) {
  try {
    // Any possible errors about generating paylink should be raised in module!
    $pay_link = sn_module::$sn_module[$payment_module]->compile_request($request);

    // Поддержка дополнительной информации
    if(is_array($pay_link['RENDER'])) {
      foreach($pay_link['RENDER'] as $html_data) {
        $template->assign_block_vars('render', $html_data);
        if(isset($html_data['VALUE']) && is_array($html_data['VALUE'])) {
          foreach($html_data['VALUE'] as $value_id => $value_value) {
            $template->assign_block_vars('render.value', array(
              'FIELD' => $value_id,
              'VALUE' => $value_value,
            ));
          }
        }
      }
    }

    // Поддержка передачи данных для многошаговых платежных систем
    if(is_array($pay_link['DATA'])) {
      foreach($pay_link['DATA'] as $key => $value) {
        $template->assign_block_vars('pay_link_data', array(
          'FIELD' => $key,
          'VALUE' => $value,
        ));
      }
    }

    if(is_array($pay_link) && in_array($pay_link['PAY_LINK_METHOD'], array('POST', 'GET', 'LINK', 'STEP'))) {
      // TODO Переделать это под assign_vars_recursive и возвращать пустые строки если нет платежного метода - для унификации формы в темплейте
      $template->assign_vars(array(
        'PAY_LINK_METHOD' => $pay_link['PAY_LINK_METHOD'],
        'PAY_LINK_URL'    => $pay_link['PAY_LINK_URL'],
      ));
    } else {
      throw new exception(classLocale::$lang['pay_msg_request_paylink_unsupported'], ERR_ERROR);
    }
  } catch(exception $e) {
    $template->assign_block_vars('result', $response = array(
      'STATUS'  => $e->getCode(),
      'MESSAGE' => $e->getMessage(),
    ));
    $debug->warning('Результат операции: код ' . $e->getCode() . ' сообщение "' . $e->getMessage() . '"', 'Ошибка платежа', LOG_INFO_PAYMENT);
  }
}

// Прегенерированные пакеты
foreach($unit_available_amount_list as $unit_amount => $discount) {
  $temp = sn_module_payment::currency_convert($unit_amount, 'MM_', $player_currency);
  $template->assign_block_vars('mm_amount', array(
    'VALUE'            => $unit_amount,
    // 'PRICE' => $temp,
    'PRICE_TEXT'       => pretty_number($temp, 2),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    'CURRENCY'         => $player_currency,
    'DISCOUNT'         => $discount,
    'DISCOUNT_PERCENT' => $discount * 100,
    'DISCOUNTED'       => $unit_amount * (1 + $discount),
    'TEXT'             => pretty_number($unit_amount),
    'TEXT_DISCOUNTED'  => pretty_number($unit_amount * (1 + $discount)),
  ));
}

$currency = $payment_module ? sn_module_payment::$payment_methods[$payment_type_selected][$payment_method_selected]['currency'] : '';
$bonus_percent = round(sn_module_payment::bonus_calculate($request['metamatter'], true, true) * 100);
$income_metamatter_text = pretty_number(sn_module_payment::bonus_calculate($request['metamatter']), true, true);

$template->assign_vars(array(
  'PAGE_HEADER' => classLocale::$lang['sys_metamatter'],

  'URL_PURCHASE' => classSupernova::$config->url_purchase_metamatter,

  'PAYMENT_TYPE'        => $payment_type_selected,
  'PAYMENT_METHOD'      => $payment_method_selected,
  'PAYMENT_METHOD_NAME' => classLocale::$lang['pay_methods'][$payment_method_selected],

  'PAYMENT_MODULE'             => $payment_module,
  'PAYMENT_MODULE_NAME'        => classLocale::$lang["module_{$payment_module}_name"],
  'PAYMENT_MODULE_DESCRIPTION' => classLocale::$lang["module_{$payment_module}_description"],

  'PLAYER_CURRENCY'              => $player_currency,
  'PLAYER_CURRENCY_PRICE_PER_MM' => sn_module_payment::currency_convert(1, $player_currency, 'MM_', 10),

  'UNIT_AMOUNT'                 => (float)$request['metamatter'],
  'UNIT_AMOUNT_TEXT'            => pretty_number($request['metamatter']),
  'UNIT_AMOUNT_BONUS_PERCENT'   => $bonus_percent,
  'UNIT_AMOUNT_TEXT_DISCOUNTED' => $income_metamatter_text,
  'UNIT_AMOUNT_TEXT_COST_BASE'  => pretty_number(sn_module_payment::currency_convert($request['metamatter'], 'MM_', $player_currency), 2),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

  'PAYMENT_CURRENCY_EXCHANGE_DEFAULT' => pretty_number(get_mm_cost(), true, true),
  'PAYMENT_CURRENCY_DEFAULT_TEXT'     => classLocale::$lang['pay_currency_list'][classSupernova::$config->payment_currency_default],

  'METAMATTER' => mrc_get_level($user, null, RES_METAMATTER),

  'METAMATTER_COST_TEXT'       => sprintf(classLocale::$lang['pay_mm_buy_conversion_cost'],
    pretty_number($request['metamatter'], true, true),
    pretty_number(sn_module_payment::currency_convert($request['metamatter'], 'MM_', $currency), 2, true),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    $currency),
  'METAMATTER_COST_BONUS_TEXT' => $bonus_percent
    ? sprintf(classLocale::$lang['pay_mm_buy_real_income'], pretty_number($bonus_percent, true, true), $income_metamatter_text)
    : '',

  'DARK_MATTER_DESCRIPTION' => classLocale::$lang['info'][RES_DARK_MATTER]['description'],

  'PAYMENT_AVAILABLE' => sn_module_get_active_count('payment') && !defined('SN_GOOGLE'),

));

display($template, classLocale::$lang['sys_metamatter']);


1		<?php
2
3		global $debug;
4
5		// Придумать какой статус должен быть у глобальных ответов, что бы не перекрывать статусы платежных систем
6		// Может добавить спецстатус "Ответ системы платежа" и парсить дальше getMessage
7		// см constants.php
8
9		include_once('common.' . substr(strrchr(__FILE__, '.'), 1));
10
11		if(!sn_module_get_active_count('payment')) {
12		sys_redirect('dark_matter.php');
13		die();
14		}
15
16		lng_include('payment');
17		lng_include('infos');
18
19		$template = gettemplate('metamatter', true);
20
21		$player_currency_default = classSupernova::$user_options[PLAYER_OPTION_CURRENCY_DEFAULT];
22		$player_currency = sys_get_param_str('player_currency', $player_currency_default);
23		empty(classLocale::$lang['pay_currency_list'][$player_currency]) ? ($player_currency = $player_currency_default ? $player_currency_default : classSupernova::$config->payment_currency_default) : false;
24		$player_currency_default != $player_currency ? classSupernova::$user_options[PLAYER_OPTION_CURRENCY_DEFAULT] = $player_currency : false;
25
26		// Таблица скидок
27		$prev_discount = 0;
28		if(isset(sn_module_payment::$bonus_table) && is_array(sn_module_payment::$bonus_table)) {
29		foreach(sn_module_payment::$bonus_table as $sum => $discount) {
30		if($discount && $discount != $prev_discount) {
31		$template->assign_block_vars('discount', array(
32		'SUM' => $sum,
33		'DISCOUNT' => $discount * 100,
34		'DISCOUNT_ONE' => 1 + $discount,
35		'TEXT' => sprintf(classLocale::$lang['pay_mm_bonus_each'], pretty_number($sum), round($discount * 100)),
36		));
37		$prev_discount = $discount;
38		}
39		}
40		}
41
42		// Результат платежа
43		if($payment_id = sys_get_param_id('payment_id')) {
44		$payment = db_payment_get($payment_id);
45		if($payment && $payment['payment_user_id'] == $user['id']) {
46	View Code Duplication	if($payment['payment_status'] == PAYMENT_STATUS_COMPLETE) {
47		$template->assign_block_vars('result', array('MESSAGE' => sprintf(classLocale::$lang['pay_msg_mm_purchase_complete'], $payment['payment_dark_matter_paid'], $payment['payment_module_name'], $payment['payment_dark_matter_gained'])));
48		}
49	View Code Duplication	if($payment['payment_status'] == PAYMENT_STATUS_NONE) {
50		$template->assign_block_vars('result', array(
51		'MESSAGE' => sprintf(classLocale::$lang['pay_msg_mm_purchase_incomplete'], $payment['payment_dark_matter_paid'], $payment['payment_module_name']),
52		'STATUS' => 1,
53		));
54		}
55		if($payment['payment_test']) {
56		$template->assign_block_vars('result', array(
57		'MESSAGE' => sprintf(classLocale::$lang['pay_msg_mm_purchase_test']),
58		'STATUS' => -1,
59		));
60		}
61		}
62		}
63
64		$unit_available_amount_list = &sn_module_payment::$bonus_table;
65
66		$request = array(
67		'metamatter' => sys_get_param_float('metamatter'),
68		);
69
70		if(!$request['metamatter']) {
71		unset($_POST);
72		}
73
74		$payment_methods_available = array_combine(array_keys(sn_module_payment::$payment_methods), array_fill(0, count(sn_module_payment::$payment_methods), null));
75		array_walk($payment_methods_available, function (&$value, $index) {
76		$value = !empty(sn_module_payment::$payment_methods[$index]) ? array_combine(array_keys(sn_module_payment::$payment_methods[$index]), array_fill(0, count(sn_module_payment::$payment_methods[$index]), null)) : $value;
77		});
78
79		// pdump($payment_methods_available);
80		$payment_module_valid = false;
81		$payment_module = sys_get_param_str('payment_module');
82		foreach(sn_module::$sn_module_list['payment'] as $module_name => $module) {
83		if(!is_object($module) \|\| !$module->manifest['active']) {
84		continue;
85		}
86
87		lng_include($module_name, $module->manifest['root_relative']);
88
89		foreach(sn_module_payment::$payment_methods as $payment_type_id => $available_methods) {
90		foreach($available_methods as $payment_method => $payment_currency) {
91		if(isset($module->manifest['payment_method'][$payment_method])) {
92		$payment_methods_available[$payment_type_id][$payment_method][$module_name] = $module->manifest['payment_method'][$payment_method];
93		}
94		}
95		}
96
97		$payment_module_valid = $payment_module_valid \|\| $module_name == $payment_module;
98		}
99
100		global $template_result;
101		// Доступные платежные методы
102		foreach($payment_methods_available as $payment_type_id => $payment_methods) {
103		if(empty($payment_methods)) {
104		continue;
105		}
106
107		$template_result['.']['payment'][$payment_type_id] = array(
108		'ID' => $payment_type_id,
109		'NAME' => classLocale::$lang['pay_methods'][$payment_type_id],
110		);
111		foreach($payment_methods as $payment_method_id => $module_list) {
112		if(empty($module_list)) {
113		continue;
114		}
115		$template_result['.']['payment'][$payment_type_id]['.']['method'][$payment_method_id] = array(
116		'ID' => $payment_method_id,
117		'NAME' => classLocale::$lang['pay_methods'][$payment_method_id],
118		'IMAGE' => isset(sn_module_payment::$payment_methods[$payment_type_id][$payment_method_id]['image'])
119		? sn_module_payment::$payment_methods[$payment_type_id][$payment_method_id]['image'] : '',
120		'NAME_FORCE' => isset(sn_module_payment::$payment_methods[$payment_type_id][$payment_method_id]['name']),
121		'BUTTON' => isset(sn_module_payment::$payment_methods[$payment_type_id][$payment_method_id]['button']),
122		);
123		foreach($module_list as $payment_module_name => $payment_module_method_details) {
124		$template_result['.']['payment'][$payment_type_id]['.']['method'][$payment_method_id]['.']['module'][] = array(
125		'MODULE' => $payment_module_name,
126		);
127		}
128		}
129
130		if(empty($template_result['.']['payment'][$payment_type_id]['.'])) {
131		unset($template_result['.']['payment'][$payment_type_id]);
132		}
133		}
134
135		$template->assign_recursive($template_result);
136
137		$payment_type_selected = sys_get_param_int('payment_type');
138		$payment_method_selected = sys_get_param_int('payment_method');
139
140		$payment_module_valid = $payment_module_valid && (!$payment_method_selected \|\| isset($payment_methods_available[$payment_type_selected][$payment_method_selected][$module_name]));
141
142		// If payment_module invalid - making it empty OR if there is only one payment_module - selecting it
143		if($payment_module_valid) {
144		// $payment_module = $payment_module; // Really - do nothing
145		} elseif($payment_type_selected && count($payment_methods_available[$payment_type_selected][$payment_method_selected]) == 1) {
146		reset($payment_methods_available[$payment_type_selected][$payment_method_selected]);
147		$payment_module = key($payment_methods_available[$payment_type_selected][$payment_method_selected]);
148		} elseif(count(sn_module::$sn_module_list['payment']) == 1) {
149		$payment_module = $module_name;
150		} else {
151		$payment_module = '';
152		}
153
154		if($payment_type_selected && $payment_method_selected) {
155		foreach($payment_methods_available[$payment_type_selected][$payment_method_selected] as $module_name => $temp) {
156		$template->assign_block_vars('payment_module', array(
157		'ID' => $module_name,
158		'NAME' => classLocale::$lang["module_{$module_name}_name"],
159		'DESCRIPTION' => classLocale::$lang["module_{$module_name}_description"],
160		));
161		}
162		}
163
164		foreach(classLocale::$lang['pay_currency_list'] as $key => $value) {
165		$course = get_exchange_rate($key);
166		if(!$course) {
167		continue;
168		}
169		$template->assign_block_vars('exchange', array(
170		'SYMBOL' => $key,
171		'TEXT' => $value,
172		'COURSE_DIRECT' => pretty_number($course, 4),
		0 ignored issues – show Documentation introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `4` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
173		'COURSE_REVERSE' => pretty_number(1 / $course, 4),
		0 ignored issues – show Documentation introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `4` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
174		'MM_PER_CURRENCY' => pretty_number(sn_module_payment::currency_convert(1, $key, 'MM_')),
175		'LOT_PRICE' => sn_module_payment::currency_convert(get_mm_cost(), 'MM_', $key),
176		'DEFAULT' => $key == classSupernova::$config->payment_currency_default,
177		// 'UNIT_PER_LOT' => sn_module_payment::currency_convert(2500, 'MM_', $key),
178		));
179		}
180
181		if($request['metamatter'] && $payment_module) {
182		try {
183		// Any possible errors about generating paylink should be raised in module!
184		$pay_link = sn_module::$sn_module[$payment_module]->compile_request($request);
185
186		// Поддержка дополнительной информации
187		if(is_array($pay_link['RENDER'])) {
188		foreach($pay_link['RENDER'] as $html_data) {
189		$template->assign_block_vars('render', $html_data);
190	View Code Duplication	if(isset($html_data['VALUE']) && is_array($html_data['VALUE'])) {
191		foreach($html_data['VALUE'] as $value_id => $value_value) {
192		$template->assign_block_vars('render.value', array(
193		'FIELD' => $value_id,
194		'VALUE' => $value_value,
195		));
196		}
197		}
198		}
199		}
200
201		// Поддержка передачи данных для многошаговых платежных систем
202	View Code Duplication	if(is_array($pay_link['DATA'])) {
203		foreach($pay_link['DATA'] as $key => $value) {
204		$template->assign_block_vars('pay_link_data', array(
205		'FIELD' => $key,
206		'VALUE' => $value,
207		));
208		}
209		}
210
211		if(is_array($pay_link) && in_array($pay_link['PAY_LINK_METHOD'], array('POST', 'GET', 'LINK', 'STEP'))) {
212		// TODO Переделать это под assign_vars_recursive и возвращать пустые строки если нет платежного метода - для унификации формы в темплейте
213		$template->assign_vars(array(
214		'PAY_LINK_METHOD' => $pay_link['PAY_LINK_METHOD'],
215		'PAY_LINK_URL' => $pay_link['PAY_LINK_URL'],
216		));
217		} else {
218		throw new exception(classLocale::$lang['pay_msg_request_paylink_unsupported'], ERR_ERROR);
219		}
220		} catch(exception $e) {
221		$template->assign_block_vars('result', $response = array(
222		'STATUS' => $e->getCode(),
223		'MESSAGE' => $e->getMessage(),
224		));
225		$debug->warning('Результат операции: код ' . $e->getCode() . ' сообщение "' . $e->getMessage() . '"', 'Ошибка платежа', LOG_INFO_PAYMENT);
226		}
227		}
228
229		// Прегенерированные пакеты
230		foreach($unit_available_amount_list as $unit_amount => $discount) {
231		$temp = sn_module_payment::currency_convert($unit_amount, 'MM_', $player_currency);
232		$template->assign_block_vars('mm_amount', array(
233		'VALUE' => $unit_amount,
234		// 'PRICE' => $temp,
235		'PRICE_TEXT' => pretty_number($temp, 2),
		0 ignored issues – show Documentation introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `2` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
236		'CURRENCY' => $player_currency,
237		'DISCOUNT' => $discount,
238		'DISCOUNT_PERCENT' => $discount * 100,
239		'DISCOUNTED' => $unit_amount * (1 + $discount),
240		'TEXT' => pretty_number($unit_amount),
241		'TEXT_DISCOUNTED' => pretty_number($unit_amount * (1 + $discount)),
242		));
243		}
244
245		$currency = $payment_module ? sn_module_payment::$payment_methods[$payment_type_selected][$payment_method_selected]['currency'] : '';
246		$bonus_percent = round(sn_module_payment::bonus_calculate($request['metamatter'], true, true) * 100);
247		$income_metamatter_text = pretty_number(sn_module_payment::bonus_calculate($request['metamatter']), true, true);
248
249		$template->assign_vars(array(
250		'PAGE_HEADER' => classLocale::$lang['sys_metamatter'],
251
252		'URL_PURCHASE' => classSupernova::$config->url_purchase_metamatter,
253
254		'PAYMENT_TYPE' => $payment_type_selected,
255		'PAYMENT_METHOD' => $payment_method_selected,
256		'PAYMENT_METHOD_NAME' => classLocale::$lang['pay_methods'][$payment_method_selected],
257
258		'PAYMENT_MODULE' => $payment_module,
259		'PAYMENT_MODULE_NAME' => classLocale::$lang["module_{$payment_module}_name"],
260		'PAYMENT_MODULE_DESCRIPTION' => classLocale::$lang["module_{$payment_module}_description"],
261
262		'PLAYER_CURRENCY' => $player_currency,
263		'PLAYER_CURRENCY_PRICE_PER_MM' => sn_module_payment::currency_convert(1, $player_currency, 'MM_', 10),
264
265		'UNIT_AMOUNT' => (float)$request['metamatter'],
266		'UNIT_AMOUNT_TEXT' => pretty_number($request['metamatter']),
267		'UNIT_AMOUNT_BONUS_PERCENT' => $bonus_percent,
268		'UNIT_AMOUNT_TEXT_DISCOUNTED' => $income_metamatter_text,
269		'UNIT_AMOUNT_TEXT_COST_BASE' => pretty_number(sn_module_payment::currency_convert($request['metamatter'], 'MM_', $player_currency), 2),
		0 ignored issues – show Documentation introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `2` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
270
271		'PAYMENT_CURRENCY_EXCHANGE_DEFAULT' => pretty_number(get_mm_cost(), true, true),
272		'PAYMENT_CURRENCY_DEFAULT_TEXT' => classLocale::$lang['pay_currency_list'][classSupernova::$config->payment_currency_default],
273
274		'METAMATTER' => mrc_get_level($user, null, RES_METAMATTER),
275
276		'METAMATTER_COST_TEXT' => sprintf(classLocale::$lang['pay_mm_buy_conversion_cost'],
277		pretty_number($request['metamatter'], true, true),
278		pretty_number(sn_module_payment::currency_convert($request['metamatter'], 'MM_', $currency), 2, true),
		0 ignored issues – show Documentation introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `2` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
279		$currency),
280		'METAMATTER_COST_BONUS_TEXT' => $bonus_percent
281		? sprintf(classLocale::$lang['pay_mm_buy_real_income'], pretty_number($bonus_percent, true, true), $income_metamatter_text)
282		: '',
283
284		'DARK_MATTER_DESCRIPTION' => classLocale::$lang['info'][RES_DARK_MATTER]['description'],
285
286		'PAYMENT_AVAILABLE' => sn_module_get_active_count('payment') && !defined('SN_GOOGLE'),
287
288		));
289
290		display($template, classLocale::$lang['sys_metamatter']);
291

supernova-ws / SuperNova

Branch — work-fleets (1ceb9c)

metamatter.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like