V2PropertyContainer::setDirect() - Code Metrics - Inspection of "CODE-misc-41a52.0: Reworked V2PropertyController" - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( cef73c...bee521 )

by SuperNova.WS

created 2016-08-11 10:49 UTC

V2PropertyContainer::setDirect() A

↳ Parent: V2PropertyContainer

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
c	1
b	0
f	0
nc	1
nop	2
dl	0
loc	3
rs	10
ccs	3
cts	3
cp	1
crap	1

<?php

use \Common\ContainerMagic;
use \Common\IPropertyContainer;

/**
 * Class V2PropertyContainer
 *
 * Support accessors for properties: getter, setter, unsetter
 *
 * Below $that - is a shortcut for container object which will be passed to accessor
 *
 * Getter is a callable like
 *    function ($this) {}
 *
 * Setter is a callable like
 *    function ($that, $value)  {}
 *
 * Unsetter is a callable like
 *    function ($that) {}
 *
 * Use setDirect() and getDirect() methods to access same variable for setter/getter function!
 * If setter works with other object properties it needs an unsetter to handle clearProperties() method
 *
 */
class V2PropertyContainer extends ContainerMagic implements IPropertyContainer {

  /**
   * Property descriptions
   *
   * @var array[]
   */
  protected $properties = array();

  /**
   * Array of accessors - getters/setters/etc
   *
   * @var callable[][]
   */
  protected $accessors = array();

  public function setProperties($properties) {
    $this->properties = $properties;
  }

  public function setDirect($name, $value) {
    parent::__set($name, $value);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
  }

  public function assignAccessor($varName, $type, $callable) {
    if (empty($callable)) {
      return;
    }

    if (is_callable($callable)) {
      $this->accessors[$varName][$type] = $callable;
    } else {
      throw new Exception('Error assigning callable in ' . get_called_class() . '! Callable typed [' . $type . '] is not a callable or not accessible in the scope');
    }
  }

  public function __set($name, $value) {
    if(is_callable($value)) {
      $this->accessors[$name][P_CONTAINER_GETTER] = $value;
    } elseif (!empty($this->accessors[$name][P_CONTAINER_SETTER]) && is_callable($this->accessors[$name][P_CONTAINER_SETTER])) {
      call_user_func($this->accessors[$name][P_CONTAINER_SETTER], $this, $value);
    } else {
      parent::__set($name, $value);
    }
  }

  public function __get($name) {

    if (
      !empty($this->accessors[$name][P_CONTAINER_GETTER])
      &&
      is_callable($this->accessors[$name][P_CONTAINER_GETTER])
    ) {
      return call_user_func($this->accessors[$name][P_CONTAINER_GETTER], $this);
    } else {
      return parent::__get($name);
    }
  }

  public function __isset($name) {
    // TODO - or here already can isset($this->name) ????

    $value = $this->$name;
    return isset($value);
  }

  public function __unset($name) {

    if (
      !empty($this->accessors[$name][P_CONTAINER_UNSETTER])
      &&
      is_callable($this->accessors[$name][P_CONTAINER_UNSETTER])
    ) {
      return call_user_func($this->accessors[$name][P_CONTAINER_UNSETTER], $this);
    } else {
      return parent::__unset($name);
    }
  }

  public function clearProperties() {
    foreach ($this->properties as $propertyName => $propertyData) {
      unset($this->$propertyName);
    }
  }

}


1			<?php
2
3			use \Common\ContainerMagic;
4			use \Common\IPropertyContainer;
5
6			/**
7			* Class V2PropertyContainer
8			*
9			* Support accessors for properties: getter, setter, unsetter
10			*
11			* Below $that - is a shortcut for container object which will be passed to accessor
12			*
13			* Getter is a callable like
14			* function ($this) {}
15			*
16			* Setter is a callable like
17			* function ($that, $value) {}
18			*
19			* Unsetter is a callable like
20			* function ($that) {}
21			*
22			* Use setDirect() and getDirect() methods to access same variable for setter/getter function!
23			* If setter works with other object properties it needs an unsetter to handle clearProperties() method
24			*
25			*/
26			class V2PropertyContainer extends ContainerMagic implements IPropertyContainer {
27
28			/**
29			* Property descriptions
30			*
31			* @var array[]
32			*/
33			protected $properties = array();
34
35			/**
36			* Array of accessors - getters/setters/etc
37			*
38			* @var callable[][]
39			*/
40			protected $accessors = array();
41
42	1		public function setProperties($properties) {
43	1		$this->properties = $properties;
44	1		}
45
46	1		public function setDirect($name, $value) {
47	1		parent::__set($name, $value);
			0 ignored issues – show Comprehensibility Bug introduced 2016-08-11 10:55 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`__set()` instead of `setDirect()`). Are you sure this is correct? If so, you might want to change this to `$this->__set()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
48	1		}
49
50	1		public function assignAccessor($varName, $type, $callable) {
51	1		if (empty($callable)) {
52	1		return;
53			}
54
55	1		if (is_callable($callable)) {
56	1		$this->accessors[$varName][$type] = $callable;
57	1		} else {
58	1		throw new Exception('Error assigning callable in ' . get_called_class() . '! Callable typed [' . $type . '] is not a callable or not accessible in the scope');
59			}
60	1		}
61
62	1		public function __set($name, $value) {
63	1		if(is_callable($value)) {
64	1		$this->accessors[$name][P_CONTAINER_GETTER] = $value;
65	1		} elseif (!empty($this->accessors[$name][P_CONTAINER_SETTER]) && is_callable($this->accessors[$name][P_CONTAINER_SETTER])) {
66	1		call_user_func($this->accessors[$name][P_CONTAINER_SETTER], $this, $value);
67	1		} else {
68	1		parent::__set($name, $value);
69			}
70	1		}
71
72	1	View Code Duplication	public function __get($name) {
			0 ignored issues – show Duplication introduced 2016-07-30 08:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
73			if (
74	1		!empty($this->accessors[$name][P_CONTAINER_GETTER])
75	1		&&
76	1		is_callable($this->accessors[$name][P_CONTAINER_GETTER])
77	1		) {
78	1		return call_user_func($this->accessors[$name][P_CONTAINER_GETTER], $this);
79			} else {
80	1		return parent::__get($name);
81			}
82			}
83
84	1		public function __isset($name) {
85			// TODO - or here already can isset($this->name) ????
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-10 19:27 UTC by Report Bug Copy Issue Report `42%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
86	1		$value = $this->$name;
87	1		return isset($value);
88			}
89
90	1	View Code Duplication	public function __unset($name) {
			0 ignored issues – show Duplication introduced 2016-08-11 10:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91			if (
92	1		!empty($this->accessors[$name][P_CONTAINER_UNSETTER])
93	1		&&
94	1		is_callable($this->accessors[$name][P_CONTAINER_UNSETTER])
95	1		) {
96	1		return call_user_func($this->accessors[$name][P_CONTAINER_UNSETTER], $this);
97			} else {
98	1		return parent::__unset($name);
99			}
100			}
101
102	1		public function clearProperties() {
103	1		foreach ($this->properties as $propertyName => $propertyData) {
104	1		unset($this->$propertyName);
105	1		}
106	1		}
107
108			}
109

supernova-ws / SuperNova

Push — work-fleets ( cef73c...bee521 )

V2PropertyContainer::setDirect() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like