sn_module::initialize() - Code Metrics - Inspection of "CODE-feat-43a15.20: Some classes moved to namespac..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — trunk ( 0e7a2e...6a6c5e )

by SuperNova.WS

created 2018-03-21 14:29 UTC

sn_module::initialize() F

↳ Parent: sn_module

Complexity

Conditions	53
Paths	> 20000

Size

Total Lines	131
Code Lines	72

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2862

Importance

Changes

Metric	Value
cc	53
eloc	72
nc	23041
nop	0
dl	0
loc	131
ccs	0
cts	104
cp	0
crap	2862
rs	2
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace Modules;

use Common\Hooker\Pimp;
use Exception;
use SN;
use template;

class sn_module {
  // Manifest params
  const M_REQUIRE = 'require';
  const M_ROOT_RELATIVE = 'root_relative';
  const M_LOAD_ORDER = 'load_order';

  /**
   * SN version in which module was committed. Can be treated as version in which module guaranteed to work
   * @var string $versionCommitted
   */
  public $versionCommitted = '#43a15.20#';

  public $manifest = [
    'package'   => 'core',
    'name'      => 'Modules\sn_module',
    'version'   => '1c0',
    'copyright' => 'Project "SuperNova.WS" #43a15.20# copyright © 2009-2017 Gorlum',

    self::M_LOAD_ORDER => MODULE_LOAD_ORDER_DEFAULT,

    self::M_REQUIRE       => [],
    self::M_ROOT_RELATIVE => '',

    'installed' => true,
    'active'    => true,

    // 'constants' array - contents of this array would be instaled into engine
    'constants' => [
//      'UNIT_STRUCTURE_NEW' => 999999,

    ],

    'vars'      => [], // Just a placeholder. vars assigned via special method __assign_vars(). Need 'cause of new constants that can be defined within module. See below

    // 'functions' array - this functions would be installed as hooks
    // Key: overwritable function name to replace
    // Value: which method to use. Format: [*][<object_name>][.]<method>
    // '*' means that new function would replace old one
    // If object_name is ommited but "." is present - hook linked to global function
    // If only "method" present - overwritable linked to appropriate method of current object
    // Function/Method should be accessible on module init
    'functions' => [
//      'test_object_test_method' => 'test_object.test_method',

//      'test_function' => '.my_test_function',
//      'this_object_test_method' => 'test_method',
    ],

    // 'menu' array - this menu items would be merged into main game menu
    // Array element almost identical to $sn_menu with additional param 'LOCATION'.
    // 'LOCATION' => '-news', // Special atrtribute for modules

    // [-|+][<menu_item_id>]

    // <menu_item_id> identifies menu item aginst new menu item would be placed. When ommited new item placed against whole menu
    // -/+ indicates that new item should be placed before/after identified menu item (or whole menu). If ommited and menu item exists - new item will replace previous one
    // Empty or non-existent LOCATION equivalent to '+' - place item at end of menu
    // Non-existent menu_item_id treated as ommited
    'menu'      => [],

    // 'page' array - defines pages which will handle this module and appropriate handlers
    'page'      => [],

    /**
     * 'mvc' subarray
     * [
     *    FIELD_MODEL =>
     *    FIELD_VIEW =>
     *    MVC_OPTIONS =>
     * ]
     */
    'mvc'       => [],
  ];

  /**
   * New way to add functions instead of manifest['functions']
   *
   * [
   *   (string)$functionName => [
   *     (callable)$callable,
   *     (string)'methodName',                             // Local method name aka $this->methodName
   *     (callable array)[$this|objectName, 'methodName'], // Callable array
   *   ],
   * ]
   *
   * @var array $functions
   */
  protected $functions = [];

  protected $hooks = [];

  protected $config = array();

  protected $module_full_class_path = __FILE__;

  protected $filename = '';

  /**
   * @param string   $functionName
   * @param callable $callable
   */
  public function addFunctionHook($functionName, $callable) {
    $this->functions[$functionName][] = $callable;
  }

  /**
   * Динамическое назначение переменных
   *
   * Актуально, когда записываемые данные зависят от статуса игры
   * Например - назначаются константы внутри модуля
   *
   * @return array
   */
  protected function __assign_vars() {
    return array(/*

      'sn_data' => array(
        UNIT_STRUCTURE_NEW => array( // Will honor new constants
          'name' => 'robot_factory',
          'type' => UNIT_STRUCTURE,
          'location' => LOC_PLANET,
          'cost' => array(
            RES_METAL     => 400,
            RES_CRYSTAL   => 120,
            RES_DEUTERIUM => 200,
            RES_ENERGY    => 0,
            'factor' => 2,
          ),
          'metal' => 400,
          'crystal' => 120,
          'deuterium' => 200,
          'energy' => 0,
          'factor' => 2,
        ),
      ),
*/
    );
  }

  /**
   * sn_module constructor.
   *
   * @param string $filename
   */
  public function __construct($filename = __FILE__) {
    $this->filename = $filename;

    // Getting module PHP class name
    $class_module_name = get_called_class();

    // Validating source settings. Some fields are mandatory in each manifest
    // Should be removed when manifest would be parsed to separate fields
    foreach (['name', 'package', 'installed', 'active', 'version'] as $mandatoryManifest) {
      if (!array_key_exists($mandatoryManifest, $this->manifest)) {
        throw new Exception('{ There is no mandatory field "' . $mandatoryManifest . '" in manifest of module } "' . $class_module_name . '"');
      }
    }

    // Getting module root relative to SN
    $this->manifest[static::M_ROOT_RELATIVE] = str_replace(
      [SN_ROOT_PHYSICAL, basename($this->filename)],
      '',
      str_replace('\\', '/', $this->filename)
    );

    // TODO: Load configuration from DB. Manifest setting
    // Trying to load configuration from file
    $config_exists = false;
    // Конфигурация может лежать в config_path в манифеста или в корне модуля
    if (isset($this->manifest['config_path']) && file_exists($config_filename = $this->manifest['config_path'] . '/config.php')) {
      $config_exists = true;
    } elseif (file_exists($config_filename = dirname($filename) . '/config.php')) {
      $config_exists = true;
    }

    if ($config_exists) {
      include($config_filename);
      $module_config_array = $class_module_name . '_config';
      $this->config = $$module_config_array;
    }

    // Registering classes with autoloader
    \Core\Autoloader::register($this->getRootRelative() . 'classes/');

    // TODO - currently not possible because each module is not a service
    // When it's done - remove double registration from loadModulesFromDirectory()
    // Registering module in manager

//    SN::$gc->modules->registerModule($class_module_name, $this);
  }

  protected function __patch_menu(&$sn_menu_extra, &$menu_patch) {
    if (isset($menu_patch) && is_array($menu_patch) && !empty($menu_patch)) {
      foreach ($menu_patch as $menu_item_name => $menu_item_data) {
        $sn_menu_extra[$menu_item_name] = $menu_item_data;
      }
    }
  }


  /**
   *
   */
  public function initialize() {
    // Checking module status - is it installed and active
    $this->check_status();
    if (!$this->manifest['active']) {
      return;
    }

    // Setting constants - if any
    if (isset($this->manifest['constants']) && is_array($this->manifest['constants']) && !empty($this->manifest['constants'])) {
      foreach ($this->manifest['constants'] as $constant_name => $constant_value) {
        defined($constant_name) or define($constant_name, $constant_value);
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
      }
    }

    // Adding vars - if any
    // Due to possible introduce of new constants in previous step vars is assigned via special method to honor new constants
    // Assignation can work with simple variables and with multidimensional arrays - for ex. 'sn_data[groups][test]'
    // New values from module variables will overwrite previous values (for root variables) and array elements with corresponding indexes (for arrays)
    // Constants as array indexes are honored - it's make valid such declarations as 'sn_data[ques][QUE_STRUCTURES]'
    $this->manifest['vars'] = $this->__assign_vars();
    if (!empty($this->manifest['vars'])) {
      $vars_assigned = array();
      foreach ($this->manifest['vars'] as $var_name => $var_value) {
        $sub_vars = explode('[', str_replace(']', '', $var_name));
        $var_name = $sub_vars[0];

        if (!isset($vars_assigned[$var_name])) {
          $vars_assigned[$var_name] = true;
          global $$var_name;
function myFunction($a, $b) {
    // Do something
}
        }

        $pointer = &$$var_name;
        if (($n = count($sub_vars)) > 1) {
          for ($i = 1; $i < $n; $i++) {
            if (defined($sub_vars[$i])) {
              $sub_vars[$i] = constant($sub_vars[$i]);
            }

            if (!isset($pointer[$sub_vars[$i]]) && $i != $n) {
              $pointer[$sub_vars[$i]] = array();
            }
            $pointer = &$pointer[$sub_vars[$i]];
          }
        }

        if (!isset($pointer) || !is_array($pointer)) {
          $pointer = $var_value;
        } elseif (is_array($$var_name)) {
          $pointer = array_merge_recursive_numeric($pointer, $var_value);
        }
      }
    }

    // Overriding function if any
    global $functions;
function myFunction($a, $b) {
    // Do something
}
    sn_sys_handler_add($functions, $this->manifest['functions'], $this);

    foreach ($this->functions as $functionName => $callableList) {
      !is_array($callableList) ? $callableList = [$callableList] : false;
      foreach ($callableList as $callable) {
        sys_handler_add_one($functions, $functionName, $callable, static::class, '');
      }
    }

    $this->registerHooks();

    // Patching game menu - if any
    global $sn_menu_extra, $sn_menu_admin_extra;
function myFunction($a, $b) {
    // Do something
}
    isset($this->manifest['menu']) and $this->__patch_menu($sn_menu_extra, $this->manifest['menu']);
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
    isset($this->manifest['menu_admin']) and $this->__patch_menu($sn_menu_admin_extra, $this->manifest['menu_admin']);
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);

    global $sn_mvc;
function myFunction($a, $b) {
    // Do something
}
    foreach ($sn_mvc as $handler_type => &$handler_data) {
      if ($handler_type == MVC_OPTIONS) {
        continue;
      }
      sn_sys_handler_add($handler_data, $this->manifest['mvc'][$handler_type], $this, $handler_type);
    }

    if (!empty($this->manifest['mvc'][MVC_OPTIONS])) {
      foreach ($this->manifest['mvc'][MVC_OPTIONS] as $pageName => $pageOptions) {
        if (empty($pageOptions)) {
          continue;
        }

        !is_array($sn_mvc['pages'][$pageName][MVC_OPTIONS]) ? $sn_mvc['pages'][$pageName][MVC_OPTIONS] = [] : false;
        $sn_mvc['pages'][$pageName][MVC_OPTIONS] = array_merge($sn_mvc['pages'][$pageName][MVC_OPTIONS], $pageOptions);
      }
    }

    if (isset($this->manifest['i18n']) && is_array($this->manifest['i18n']) && !empty($this->manifest['i18n'])) {
      foreach ($this->manifest['i18n'] as $i18n_page_name => &$i18n_file_list) {
        foreach ($i18n_file_list as &$i18n_file_data) {
          if (is_array($i18n_file_data) && !$i18n_file_data['path']) {
            $i18n_file_data['path'] = $this->getRootRelative();
          }
        }
        if (!isset($sn_mvc['i18n'][$i18n_page_name])) {
          $sn_mvc['i18n'][$i18n_page_name] = array();
        }
        $sn_mvc['i18n'][$i18n_page_name] += $i18n_file_list;
      }
    }

    if (!empty($this->manifest['javascript']) && is_array($this->manifest['javascript'])) {
      foreach ($this->manifest['javascript'] as $javascript_page_name => &$javascript_list) {
        !isset($sn_mvc['javascript'][$javascript_page_name]) ? $sn_mvc['javascript'][$javascript_page_name] = array() : false;
        foreach ($javascript_list as $script_name => &$script_content) {
          $sn_mvc['javascript'][$javascript_page_name][$script_name] = $script_content;
        }
      }
    }

    if (!empty($this->manifest['css']) && is_array($this->manifest['css'])) {
      foreach ($this->manifest['css'] as $javascript_page_name => &$javascript_list) {
        !isset($sn_mvc['css'][$javascript_page_name]) ? $sn_mvc['css'][$javascript_page_name] = array() : false;
        foreach ($javascript_list as $script_name => &$script_content) {
          $sn_mvc['css'][$javascript_page_name][$script_name] = $script_content;
        }
      }
    }

    if (!empty($this->manifest['navbar_prefix_button']) && is_array($this->manifest['navbar_prefix_button'])) {
      foreach ($this->manifest['navbar_prefix_button'] as $button_image => $button_url_relative) {
        $sn_mvc['navbar_prefix_button'][$button_image] = $button_url_relative;
      }
    }

    if (!empty($this->manifest['navbar_main_button']) && is_array($this->manifest['navbar_main_button'])) {
      foreach ($this->manifest['navbar_main_button'] as $button_image => $button_url_relative) {
        $sn_mvc['navbar_main_button'][$button_image] = $button_url_relative;
      }
    }
  }

  public function check_status() {
  }

  /**
   * Checks if module is active
   *
   * @return bool
   */
  public function isActive() {
    return !empty($this->manifest['active']) && !empty($this->manifest['installed']);
  }

  /**
   * Register pages in $manifest['mvc']['pages'] for further use
   *
   * @param string[] $pages - array of records ['pageName' => 'pageFile']. 'pageFile' is currently unused
   *
   * @deprecated
   */
  protected function __mvcRegisterPagesOld($pages) {
    !is_array($this->manifest['mvc']['pages']) ? $this->manifest['mvc']['pages'] = [] : false;
    if (is_array($pages) && !empty($pages)) {
      $this->manifest['mvc']['pages'] = array_merge($this->manifest['mvc']['pages'], $pages);
    }
  }

  protected function registerHooks() {
    foreach ($this->hooks as $hookName => $hookRecord) {
      // Priority can be first element of hook array
      $priority = Pimp::ORDER_AS_IS;
      if (is_array($hookRecord) && count($hookRecord) > 1 && is_numeric(reset($hookRecord))) {
        $priority = intval(reset($hookRecord));
        array_shift($hookRecord);
      }

      // There is 2 elements in callable array
      if (is_array($hookRecord) && 2 == count($hookRecord)) {
        // Checking - if first should be replaced with $this
        if (THIS_STRING === reset($hookRecord)) {
          $hookRecord = [$this, end($hookRecord)];
        }
      }

      SN::$gc->pimp->register($hookName, $hookRecord, $priority);
    }
  }

  public function getLoadOrder() {
    return !empty($this->manifest[self::M_LOAD_ORDER]) ? $this->manifest[self::M_LOAD_ORDER] : MODULE_LOAD_ORDER_DEFAULT;
  }

  public function getRootRelative() {
    if (empty($this->manifest[static::M_ROOT_RELATIVE])) {
      $this->manifest[static::M_ROOT_RELATIVE] = str_replace([SN_ROOT_PHYSICAL, basename($this->filename)], '', str_replace('\\', '/', $this->filename));
    }

    return $this->manifest[static::M_ROOT_RELATIVE];
  }

  protected function getTemplateRootRelative() {
    return $this->getRootRelative() . 'design/templates/';
  }

  /**
   *
   * Should stay public due using in Festivals (?)
   *
   * @param string   $templateName
   * @param template $template
   *
   * @return template
   */
  public function addModuleTemplate($templateName, $template) {
    return gettemplate($templateName, $template, $this->getTemplateRootRelative());
  }

}


Push — trunk ( 0e7a2e...6a6c5e )

sn_module::initialize() F

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Logical Operators are used for Control-Flow

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

1. Pass all data via parameters

2. Create a class that maintains your state

supernova-ws / SuperNova

Push — trunk ( 0e7a2e...6a6c5e )

sn_module::initialize() F

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Logical Operators are used for Control-Flow

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like