ExceptionSnLocalized::getMessageLocalized() - Code Metrics - Inspection of "CODE-feat-43a15.20: Some classes moved to namespac..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — trunk ( 0e7a2e...6a6c5e )

by SuperNova.WS

created 2018-03-21 14:29 UTC

ExceptionSnLocalized::getMessageLocalized() A

↳ Parent: ExceptionSnLocalized

Complexity

Conditions	3
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
eloc	4
nc	2
nop	0
dl	0
loc	7
ccs	0
cts	6
cp	0
crap	12
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * Created by Gorlum 04.06.2017 15:18
 */

namespace Common\Exceptions;

use Throwable;

/**
 * Class ExceptionSnLocalized
 *
 * Localized Exception - uses Message as locale string ID
 *
 * @package Exceptions
 */
class ExceptionSnLocalized extends \Exception {

  /**
   * @var array $sprintf
   */
  protected $sprintf = array();

  /**
   * ExceptionSnLocalized constructor.
   *
   * @param string         $message
   * @param int            $code
   * @param Throwable|null $previous
   * @param array          $sprintf - params for sprintf() call to embed into message
   */
  public function __construct($message = "", $code = 0, Throwable $previous = null, $sprintf = array()) {
    parent::__construct($message, $code, $previous);
    $this->sprintf = $sprintf;
  }

  /**
   * @param string $message
   *
   * @return string
   */
  protected function getPlayerLocalization($message) {
    global $lang;
function myFunction($a, $b) {
    // Do something
}

    return !empty($lang[$message]) ? $lang[$message] : '';
  }

  /**
   * @return string
   */
  public function getMessageLocalized() {
    $message = $this->getPlayerLocalization($this->getMessage());
    if (is_array($this->sprintf) && !empty($this->sprintf)) {
      $message = call_user_func_array('sprintf', array_merge(array($message), $this->sprintf));
    }

    return $message;
  }

}


Push — trunk ( 0e7a2e...6a6c5e )

ExceptionSnLocalized::getMessageLocalized() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/**
3			* Created by Gorlum 04.06.2017 15:18
4			*/
5
6			namespace Common\Exceptions;
7
8			use Throwable;
9
10			/**
11			* Class ExceptionSnLocalized
12			*
13			* Localized Exception - uses Message as locale string ID
14			*
15			* @package Exceptions
16			*/
17			class ExceptionSnLocalized extends \Exception {
18
19			/**
20			* @var array $sprintf
21			*/
22			protected $sprintf = array();
23
24			/**
25			* ExceptionSnLocalized constructor.
26			*
27			* @param string $message
28			* @param int $code
29			* @param Throwable\|null $previous
30			* @param array $sprintf - params for sprintf() call to embed into message
31			*/
32			public function __construct($message = "", $code = 0, Throwable $previous = null, $sprintf = array()) {
33			parent::__construct($message, $code, $previous);
34			$this->sprintf = $sprintf;
35			}
36
37			/**
38			* @param string $message
39			*
40			* @return string
41			*/
42			protected function getPlayerLocalization($message) {
43			global $lang;
			0 ignored issues – show Compatibility Best Practice introduced 2018-03-21 14:36 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
44
45			return !empty($lang[$message]) ? $lang[$message] : '';
46			}
47
48			/**
49			* @return string
50			*/
51			public function getMessageLocalized() {
52			$message = $this->getPlayerLocalization($this->getMessage());
53			if (is_array($this->sprintf) && !empty($this->sprintf)) {
54			$message = call_user_func_array('sprintf', array_merge(array($message), $this->sprintf));
55			}
56
57			return $message;
58			}
59
60			}
61

supernova-ws / SuperNova

Push — trunk ( 0e7a2e...6a6c5e )

ExceptionSnLocalized::getMessageLocalized() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like