supernova-ws / SuperNova

includes/db/db_helpers.php

Spacing +5 added lines, -5 removed lines

@@ -27,19 +27,19 @@
  */
 function db_set_make_safe_string($set, $delta = false) {
   $set_safe = array();
-  foreach($set as $field => $value) {
-    if(empty($field)) {
+  foreach ($set as $field => $value) {
+    if (empty($field)) {
       continue;
     }
 
     $field = '`' . db_escape($field) . '`';
     $new_value = $value;
-    if($value === null) {
+    if ($value === null) {
       $new_value = 'NULL';
-    } elseif(is_string($value) && (string)($new_value = floatval($value)) != (string)$value) {
+    } elseif (is_string($value) && (string) ($new_value = floatval($value)) != (string) $value) {
       // non-float
       $new_value = '"' . db_escape($value) . '"';
-    } elseif($delta) {
+    } elseif ($delta) {
       // float and DELTA-set
       $new_value = "{$field} + ({$new_value})";
     }

Indentation +5 added lines, -5 removed lines

@@ -1,10 +1,10 @@
 <?php
 /**
- * Created by PhpStorm.
- * User: Gorlum
- * Date: 26.12.2015
- * Time: 17:19
- */
+   * Created by PhpStorm.
+   * User: Gorlum
+   * Date: 26.12.2015
+   * Time: 17:19
+   */
 
 /**
  * Normalize and make ID safe

includes/db/db_queries.php

Spacing +4 added lines, -4 removed lines

@@ -85,7 +85,7 @@ 
 
 function db_stat_list_statistic($who, $is_common_stat, $Rank, $start, $source = false) {
 // pdump($source);
-  if(!$source) {
+  if (!$source) {
     $source = array(
       'statpoints' => 'statpoints',
       'users'      => 'users',
@@ -106,8 +106,8 @@ 
     );
   }
 // pdump($source);
-  if($who == 1) {
-    if($is_common_stat) { // , UNIX_TIMESTAMP(CONCAT(YEAR(CURRENT_DATE), DATE_FORMAT(`user_birthday`, '-%m-%d'))) AS `nearest_birthday`
+  if ($who == 1) {
+    if ($is_common_stat) { // , UNIX_TIMESTAMP(CONCAT(YEAR(CURRENT_DATE), DATE_FORMAT(`user_birthday`, '-%m-%d'))) AS `nearest_birthday`
       $query_str =
         "SELECT
       @rownum:=@rownum+1 rownum, subject.{$source['id']} as `id`, sp.{$Rank}_rank as rank, sp.{$Rank}_old_rank as rank_old, sp.{$Rank}_points as points, subject.{$source['username']} as `name`, subject.*
@@ -191,7 +191,7 @@ 
 function db_get_set_unique_id_value($current_value_unsafe, $db_id_field_name, $db_table_name, $db_value_field_name) {
   $current_value_safe = db_escape($current_value_unsafe);
   $value_id = doquery("SELECT `{$db_id_field_name}` AS id_field FROM {{{$db_table_name}}} WHERE `{$db_value_field_name}` = '{$current_value_safe}' LIMIT 1 FOR UPDATE", true);
-  if(!isset($value_id['id_field']) || !$value_id['id_field']) {
+  if (!isset($value_id['id_field']) || !$value_id['id_field']) {
     doquery("INSERT INTO {{{$db_table_name}}} (`{$db_value_field_name}`) VALUES ('{$current_value_safe}');");
     $variable_id = db_insert_id();
   } else {

Doc Comments +20 added lines, -15 removed lines

@@ -188,6 +188,11 @@ 
  */
 // OK v4
 // TODO - вынести в отдельный класс
+/**
+ * @param string $db_id_field_name
+ * @param string $db_table_name
+ * @param string $db_value_field_name
+ */
 function db_get_set_unique_id_value($current_value_unsafe, $db_id_field_name, $db_table_name, $db_value_field_name) {
   $current_value_safe = db_escape($current_value_unsafe);
   $value_id = doquery("SELECT `{$db_id_field_name}` AS id_field FROM {{{$db_table_name}}} WHERE `{$db_value_field_name}` = '{$current_value_safe}' LIMIT 1 FOR UPDATE", true);
@@ -220,7 +225,7 @@ 
 
 /**
  * @param $user
- * @param $username_safe
+ * @param string $username_safe
  */
 function db_player_name_history_replace($user, $username_safe) {
   doquery("REPLACE INTO {{player_name_history}} SET `player_id` = {$user['id']}, `player_name` = '{$username_safe}'");
@@ -228,7 +233,7 @@ 
 
 
 /**
- * @param $username_safe
+ * @param string $username_safe
  *
  * @return array|bool|mysqli_result|null
  */
@@ -485,12 +490,12 @@ 
 
 
 /**
- * @param $user_id
- * @param $change_type
+ * @param integer $user_id
+ * @param integer $change_type
  * @param $dark_matter
- * @param $comment
+ * @param string $comment
  * @param $row
- * @param $page_url
+ * @param string $page_url
  */
 function db_log_dark_matter_insert($user_id, $change_type, $dark_matter, $comment, $row, $page_url) {
   doquery(
@@ -506,7 +511,7 @@ 
 /**
  * @param $user_id_safe
  *
- * @return array|bool|mysqli_result|null
+ * @return integer
  */
 function db_referral_get_by_id($user_id_safe) {
   $old_referral = doquery("SELECT * FROM {{referrals}} WHERE `id` = {$user_id_safe} LIMIT 1 FOR UPDATE;", true);
@@ -534,9 +539,9 @@ 
 
 // Quests ***********************************************************************************************************
 /**
- * @param $query_add_select
+ * @param string $query_add_select
  * @param $query_add_from
- * @param $query_add_where
+ * @param string $query_add_where
  *
  * @return array|bool|mysqli_result|null
  */
@@ -580,11 +585,11 @@ 
 }
 
 /**
- * @param $quest_name
- * @param $quest_type
- * @param $quest_description
+ * @param string $quest_name
+ * @param integer $quest_type
+ * @param string $quest_description
  * @param $quest_conditions
- * @param $quest_rewards
+ * @param string $quest_rewards
  * @param $quest_id
  */
 function db_quest_update($quest_name, $quest_type, $quest_description, $quest_conditions, $quest_rewards, $quest_id) {
@@ -607,7 +612,7 @@ 
 /**
  * @param $banner
  * @param $banned
- * @param $reason
+ * @param string $reason
  * @param $ban_until
  */
 function db_ban_insert($banner, $banned, $reason, $ban_until) {
@@ -630,7 +635,7 @@ 
 /**
  * @param $banner
  * @param $banned
- * @param $reason
+ * @param string $reason
  */
 function db_ban_insert_unset($banner, $banned, $reason) {
   doquery(

includes/db/db_queries_users.php

Spacing +1 added lines, -1 removed lines

@@ -161,7 +161,7 @@
   !is_array($user_id_list) ? $user_id_list = array($user_id_list) : false;
 
   $user_list = array();
-  foreach($user_id_list as $user_id_unsafe) {
+  foreach ($user_id_list as $user_id_unsafe) {
     $user = db_user_by_id($user_id_unsafe);
     !empty($user) ? $user_list[$user_id_unsafe] = $user : false;
   }

Doc Comments +6 added lines

@@ -47,6 +47,9 @@ 
 }
 
 
+/**
+ * @param boolean $player
+ */
 function db_user_by_id($user_id_unsafe, $for_update = false, $fields = '*', $player = null) {
   return classSupernova::db_get_user_by_id($user_id_unsafe, $for_update, $fields, $player);
 }
@@ -105,6 +108,9 @@ 
   return isset($result['user_count']) ? $result['user_count'] : 0;
 }
 
+/**
+ * @param integer $config_user_birthday_range
+ */
 function db_user_list_to_celebrate($config_user_birthday_range) {
   return doquery(
     "SELECT

includes/db/db_queries_fleet.php

Indentation +2 added lines, -2 removed lines

@@ -1,7 +1,7 @@
 <?php
 /**
- * DB ACS functions
- */
+   * DB ACS functions
+   */
 
 /* ACS ****************************************************************************************************************/
 /**

Doc Comments +7 added lines, -3 removed lines

@@ -22,6 +22,10 @@ 
   doquery('DELETE FROM `{{aks}}` WHERE `id` NOT IN (SELECT DISTINCT `fleet_group` FROM `{{fleets}}`);');
 }
 
+/**
+ * @param double $arrival
+ * @param integer $target_structure
+ */
 function db_missile_insert($target_coord, $user, $planetrow, $arrival, $fleet_ship_count, $target_structure) {
   doquery(
     "INSERT INTO `{{iraks}}` SET
@@ -52,7 +56,7 @@ 
 /**
  * @param $user
  * @param $planet_dst
- * @param $time_limit
+ * @param integer $time_limit
  *
  * @return array|bool|mysqli_result|null
  */
@@ -113,14 +117,14 @@ 
 
 
 /**
- * @param $fleet_group_id_list
+ * @param string $fleet_group_id_list
  */
 function db_acs_delete_by_list($fleet_group_id_list) {
   doquery("DELETE FROM {{aks}} WHERE `id` IN ({$fleet_group_id_list})");
 }
 
 /**
- * @param $bashing_list
+ * @param string $bashing_list
  */
 function db_bashing_insert($bashing_list) {
   doquery("INSERT INTO {{bashing}} (bashing_user_id, bashing_planet_id, bashing_time) VALUES {$bashing_list};");

includes/includes/flt_mission_hold.php

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
  * @copyright 2008 by Gorlum for Project "SuperNova.WS"
  */
 function flt_mission_hold($mission_data) {
-  if($mission_data->fleet->time_mission_job_complete < SN_TIME_NOW) {
+  if ($mission_data->fleet->time_mission_job_complete < SN_TIME_NOW) {
     $mission_data->fleet->mark_fleet_as_returned_and_save();
 
     return CACHE_FLEET;

includes/includes/flt_mission_relocate.php

Spacing +2 added lines, -2 removed lines

@@ -16,7 +16,7 @@ 
 
   $destination_planet = &$mission_data->dst_planet;
 
-  if(empty($destination_planet['id_owner']) || $objFleet->playerOwnerId != $destination_planet['id_owner']) {
+  if (empty($destination_planet['id_owner']) || $objFleet->playerOwnerId != $destination_planet['id_owner']) {
     $objFleet->mark_fleet_as_returned_and_save();
 
     return CACHE_FLEET;
@@ -31,7 +31,7 @@ 
       $fleet_resources[RES_DEUTERIUM], $lang['Deuterium']
     ) . '<br />' . $lang['sys_relocate_mess_user'];
   $fleet_real_array = $objFleet->get_unit_list();
-  foreach($fleet_real_array as $ship_id => $ship_count) {
+  foreach ($fleet_real_array as $ship_id => $ship_count) {
     $Message .= $lang['tech'][$ship_id] . ' - ' . $ship_count . '<br />';
   }
   msg_send_simple_message(

includes/includes/flt_mission_transport.php

Spacing +2 added lines, -2 removed lines

@@ -16,7 +16,7 @@ 
   $source_planet = &$mission_data->src_planet;
   $destination_planet = &$mission_data->dst_planet;
 
-  if(!isset($destination_planet['id']) || !$destination_planet['id_owner']) {
+  if (!isset($destination_planet['id']) || !$destination_planet['id_owner']) {
     $objFleet->mark_fleet_as_returned_and_save();
 
     return CACHE_FLEET;
@@ -31,7 +31,7 @@ 
     $fleet_resources[RES_DEUTERIUM], $lang['Deuterium']);
   msg_send_simple_message($objFleet->target_owner_id, '', $objFleet->time_arrive_to_target, MSG_TYPE_TRANSPORT, $lang['sys_mess_tower'], $lang['sys_mess_transport'], $Message);
 
-  if($objFleet->target_owner_id <> $objFleet->playerOwnerId) {
+  if ($objFleet->target_owner_id <> $objFleet->playerOwnerId) {
     msg_send_simple_message($objFleet->playerOwnerId, '', $objFleet->time_arrive_to_target, MSG_TYPE_TRANSPORT, $lang['sys_mess_tower'], $lang['sys_mess_transport'], $Message);
   }
 

Doc Comments +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
 /**
  * Fleet mission "Relocate"
  *
- * @param $mission_data Mission
+ * @param Mission $mission_data Mission
  *
  * @return int
  *

includes/includes/flt_mission_recycle.php

Spacing +10 added lines, -10 removed lines

@@ -20,7 +20,7 @@ 
 
   $destination_planet = &$mission_data->dst_planet;
 
-  if(empty($destination_planet['id'])) {
+  if (empty($destination_planet['id'])) {
     $objFleet->mark_fleet_as_returned();
     $objFleet->flush_changes_to_db();
 
@@ -31,10 +31,10 @@ 
   $OtherFleetCapacity = 0;
 
   $fleet_array = $objFleet->get_unit_list();
-  foreach($fleet_array as $unit_id => $unit_count) {
-    if(in_array($unit_id, sn_get_groups('fleet'))) {
+  foreach ($fleet_array as $unit_id => $unit_count) {
+    if (in_array($unit_id, sn_get_groups('fleet'))) {
       $capacity = get_unit_param($unit_id, P_CAPACITY) * $unit_count;
-      if(in_array($unit_id, sn_get_groups('flt_recyclers'))) {
+      if (in_array($unit_id, sn_get_groups('flt_recyclers'))) {
         $RecyclerCapacity += $capacity;
       } else {
         $OtherFleetCapacity += $capacity;
@@ -43,33 +43,33 @@ 
   }
 
   $fleet_resources_amount = $objFleet->get_resources_amount();
-  if($fleet_resources_amount > $OtherFleetCapacity) {
+  if ($fleet_resources_amount > $OtherFleetCapacity) {
     // Если во флоте есть другие корабли И количество ресурсов больше, чем их ёмкость трюмов - значит часть этих ресурсов лежит в трюмах переработчиков
     // Уменьшаем ёмкость переработчиков на указанную величину
     $RecyclerCapacity -= ($fleet_resources_amount - $OtherFleetCapacity);
   }
 
   $resources_recycled = array();
-  if(($destination_planet["debris_metal"] + $destination_planet["debris_crystal"]) <= $RecyclerCapacity) {
+  if (($destination_planet["debris_metal"] + $destination_planet["debris_crystal"]) <= $RecyclerCapacity) {
     $resources_recycled[RES_METAL] = $destination_planet["debris_metal"];
     $resources_recycled[RES_CRYSTAL] = $destination_planet["debris_crystal"];
   } else {
-    if(($destination_planet["debris_metal"] > $RecyclerCapacity / 2) &&
+    if (($destination_planet["debris_metal"] > $RecyclerCapacity / 2) &&
       ($destination_planet["debris_crystal"] > $RecyclerCapacity / 2)
     ) {
       $resources_recycled[RES_METAL] = $RecyclerCapacity / 2;
       $resources_recycled[RES_CRYSTAL] = $RecyclerCapacity / 2;
     } else {
-      if($destination_planet["debris_metal"] > $destination_planet["debris_crystal"]) {
+      if ($destination_planet["debris_metal"] > $destination_planet["debris_crystal"]) {
         $resources_recycled[RES_CRYSTAL] = $destination_planet["debris_crystal"];
-        if($destination_planet["debris_metal"] > ($RecyclerCapacity - $resources_recycled[RES_CRYSTAL])) {
+        if ($destination_planet["debris_metal"] > ($RecyclerCapacity - $resources_recycled[RES_CRYSTAL])) {
           $resources_recycled[RES_METAL] = $RecyclerCapacity - $resources_recycled[RES_CRYSTAL];
         } else {
           $resources_recycled[RES_METAL] = $destination_planet["debris_metal"];
         }
       } else {
         $resources_recycled[RES_METAL] = $destination_planet["debris_metal"];
-        if($destination_planet["debris_crystal"] > ($RecyclerCapacity - $resources_recycled[RES_METAL])) {
+        if ($destination_planet["debris_crystal"] > ($RecyclerCapacity - $resources_recycled[RES_METAL])) {
           $resources_recycled[RES_CRYSTAL] = $RecyclerCapacity - $resources_recycled[RES_METAL];
         } else {
           $resources_recycled[RES_CRYSTAL] = $destination_planet["debris_crystal"];

includes/includes/sys_stat.php

Spacing +25 added lines, -25 removed lines

@@ -39,23 +39,23 @@ 
 
   $sta_update_msg = db_escape($sta_update_msg);
 
-  if($next_step) {
+  if ($next_step) {
     $sta_update_step++;
   }
   $sta_update_msg = "Update in progress. Step {$sta_update_step}/14: {$sta_update_msg}.";
 
   $config->db_saveItem('var_stat_update_msg', $sta_update_msg);
-  if($next_step) {
+  if ($next_step) {
     $debug->warning($sta_update_msg, 'Stat update', LOG_INFO_STAT_PROCESS);
   }
 }
 
 function sys_stat_calculate_flush(&$data, $force = false) {
-  if(count($data) < 25 && !$force) {
+  if (count($data) < 25 && !$force) {
     return;
   }
 
-  if(!empty($data)) {
+  if (!empty($data)) {
     doquery('REPLACE INTO {{statpoints}}
       (`id_owner`, `id_ally`, `stat_type`, `stat_code`, `tech_points`, `tech_count`, `build_points`, `build_count`,
        `defs_points`, `defs_count`, `fleet_points`, `fleet_count`, `res_points`, `res_count`, `total_points`,
@@ -95,11 +95,11 @@ 
   $user_list = db_user_list('', true, 'id, dark_matter, metal, crystal, deuterium, user_as_ally, ally_id');
   $row_num = count($user_list);
   // while($player = db_fetch($query))
-  foreach($user_list as $player) {
-    if($i++ % 100 == 0) {
+  foreach ($user_list as $player) {
+    if ($i++ % 100 == 0) {
       sta_set_time_limit("calculating players stats (player {$i}/{$row_num})", false);
     }
-    if(array_key_exists($user_id = $player['id'], $user_skip_list)) {
+    if (array_key_exists($user_id = $player['id'], $user_skip_list)) {
       continue;
     }
 
@@ -109,7 +109,7 @@ 
     // $points[$user_id][UNIT_RESOURCES] += $resources;
 
     // А здесь мы фильтруем пользователей по $user_skip_list - далее не нужно этого делать, потому что
-    if(!isset($user_skip_list[$user_id])) {
+    if (!isset($user_skip_list[$user_id])) {
       $user_allies[$user_id] = $player['ally_id'];
     }
   }
@@ -123,11 +123,11 @@ 
   $i = 0;
   $query = db_planet_list_resources_by_owner();
   $row_num = db_num_rows($query);
-  while($planet = db_fetch($query)) {
-    if($i++ % 100 == 0) {
+  while ($planet = db_fetch($query)) {
+    if ($i++ % 100 == 0) {
       sta_set_time_limit("calculating planets stats (planet {$i}/{$row_num})", false);
     }
-    if(array_key_exists($user_id = $planet['id_owner'], $user_skip_list)) {
+    if (array_key_exists($user_id = $planet['id_owner'], $user_skip_list)) {
       continue;
     }
 
@@ -142,8 +142,8 @@ 
   $i = 0;
   $query = FleetList::dbQueryAllId();
   $row_num = db_num_rows($query);
-  while($fleet_row = db_fetch($query)) {
-    if($i++ % 100 == 0) {
+  while ($fleet_row = db_fetch($query)) {
+    if ($i++ % 100 == 0) {
       sta_set_time_limit("calculating flying fleets stats (fleet {$i}/{$row_num})", false);
     }
     $objFleet = new Fleet();
@@ -151,15 +151,15 @@ 
     // К тому же при включённом кэшировании это быстро забъёт кэш холодными данными
     // $objFleet->_reset();
     $objFleet->dbRowParse($fleet_row);
-    if(array_key_exists($user_id = $objFleet->playerOwnerId, $user_skip_list)) {
+    if (array_key_exists($user_id = $objFleet->playerOwnerId, $user_skip_list)) {
       continue;
     }
 
     $fleet = $objFleet->get_unit_list();
-    foreach($fleet as $unit_id => $unit_amount) {
+    foreach ($fleet as $unit_id => $unit_amount) {
       $counts[$user_id][UNIT_SHIPS] += $unit_amount;
 
-      if(!isset($unit_cost_cache[$unit_id][0])) {
+      if (!isset($unit_cost_cache[$unit_id][0])) {
         $unit_cost_cache[$unit_id][0] = get_unit_param($unit_id, P_COST);
       }
       $unit_cost_data = &$unit_cost_cache[$unit_id][0];
@@ -179,11 +179,11 @@ 
   $i = 0;
   $query = db_unit_list_stat_calculate();
   $row_num = db_num_rows($query);
-  while($unit = db_fetch($query)) {
-    if($i++ % 100 == 0) {
+  while ($unit = db_fetch($query)) {
+    if ($i++ % 100 == 0) {
       sta_set_time_limit("calculating unit stats (unit {$i}/{$row_num})", false);
     }
-    if(array_key_exists($user_id = $unit['unit_player_id'], $user_skip_list)) {
+    if (array_key_exists($user_id = $unit['unit_player_id'], $user_skip_list)) {
       continue;
     }
 
@@ -197,11 +197,11 @@ 
   $i = 0;
   $query = db_que_list_stat();
   $row_num = db_num_rows($query);
-  while($que_item = db_fetch($query)) {
-    if($i++ % 100 == 0) {
+  while ($que_item = db_fetch($query)) {
+    if ($i++ % 100 == 0) {
       sta_set_time_limit("calculating ques stats (que item {$i}/{$row_num})", false);
     }
-    if(array_key_exists($user_id = $que_item['que_player_id'], $user_skip_list)) {
+    if (array_key_exists($user_id = $que_item['que_player_id'], $user_skip_list)) {
       continue;
     }
     $que_unit_amount = $que_item['que_unit_amount'];
@@ -219,7 +219,7 @@ 
 
   sta_set_time_limit('posting new user stats to DB');
   $data = array();
-  foreach($user_allies as $user_id => $ally_id) {
+  foreach ($user_allies as $user_id => $ally_id) {
     // $counts[UNIT_RESOURCES] дублирует $points[UNIT_RESOURCES], поэтому $points не заполняем, а берем $counts и делим на 1000
     $points[$user_id][UNIT_RESOURCES] = $counts[$user_id][UNIT_RESOURCES] / 1000;
     $points[$user_id] = array_map('floor', $points[$user_id]);
@@ -275,7 +275,7 @@ 
 
   // Updating player's ranks
   sta_set_time_limit("updating ranks for players");
-  foreach($rankNames as $rankName) {
+  foreach ($rankNames as $rankName) {
     sta_set_time_limit("updating player rank '{$rankName}'", false);
     doquery($qryResetRowNum);
     doquery(sprintf($qryFormat, $rankName, 1));
@@ -283,7 +283,7 @@ 
 
   sta_set_time_limit("updating ranks for Alliances");
   // --- Updating Allie's ranks
-  foreach($rankNames as $rankName) {
+  foreach ($rankNames as $rankName) {
     sta_set_time_limit("updating Alliances rank '{$rankName}'", false);
     doquery($qryResetRowNum);
     doquery(sprintf($qryFormat, $rankName, 2));