EntityContainer::processNumeric() - Code Metrics - Inspection of "CODE-misc-41a52.60: Work on KeyedModel save/load" - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( 88e4e3...4e1f0c )

by SuperNova.WS

created 2016-08-25 09:34 UTC

EntityContainer::processNumeric() B

↳ Parent: EntityContainer::__set()

Complexity

Conditions	6
Paths	4

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	6

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
cc	6
eloc	8
c	3
b	0
f	1
nc	4
nop	2
dl	0
loc	14
ccs	10
cts	10
cp	1
crap	6
rs	8.8571

<?php

namespace Entity;

use Common\ContainerAccessors;

/**
 * Class Entity\EntityContainer
 *
 * @property array $row - Entity row read from DB
 */
class EntityContainer extends ContainerAccessors {
  /**
   * @var EntityModel $model
   */
  protected $model;

  /**
   * @var \Common\Accessors $accessors
   */
  protected $accessors;

  /**
   * @var array $original
   */
  protected $original = array();

  /**
   * @var array $delta
   */
  protected $delta = array();

  /** @noinspection PhpMissingParentConstructorInspection */
  /**
   * Entity\EntityContainer constructor.
   *
   * @param EntityModel $model
   */
  public function __construct($model) {
    $this->setModel($model);
  }

  /**
   * @param EntityModel $model
   */
  public function setModel(EntityModel $model) {
    $this->model = $model;
    $this->accessors = $model->getAccessors();
  }

  /**
   * @return EntityModel
   */
  public function getModel() {
    return $this->model;
  }

  public function __set($name, $value) {
    $properties = $this->model->getProperties();
    if (isset($properties[$name][P_DB_FIELD_TYPE])) {
      $value = \classSupernova::$gc->types->castAs($properties[$name][P_DB_FIELD_TYPE], $value);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    parent::__set($name, $value);
    // If it is first assign - saving this value as original
    if (!array_key_exists($name, $this->original)) {
      $this->original[$name] = $value;
    } // If it is not first assign
    elseif ($value != $this->original[$name] && (is_int($value) || is_float($value))) {
//      // New value not equal original value. We should update delta
      $this->delta[$name] = $value - $this->original[$name];
    }
  }

  public function clear() {
    parent::clear();
    $this->original = array();
    $this->delta = array();
  }

}


1		<?php
2
3		namespace Entity;
4
5		use Common\ContainerAccessors;
6
7		/**
8		* Class Entity\EntityContainer
9		*
10		* @property array $row - Entity row read from DB
11		*/
12		class EntityContainer extends ContainerAccessors {
13		/**
14		* @var EntityModel $model
15		*/
16		protected $model;
17
18		/**
19		* @var \Common\Accessors $accessors
20		*/
21		protected $accessors;
22
23		/**
24		* @var array $original
25		*/
26		protected $original = array();
27
28		/**
29		* @var array $delta
30		*/
31		protected $delta = array();
32
33		/** @noinspection PhpMissingParentConstructorInspection */
34		/**
35		* Entity\EntityContainer constructor.
36		*
37		* @param EntityModel $model
38		*/
39	1	public function __construct($model) {
40	1	$this->setModel($model);
41	1	}
42
43		/**
44		* @param EntityModel $model
45		*/
46	1	public function setModel(EntityModel $model) {
47	1	$this->model = $model;
48	1	$this->accessors = $model->getAccessors();
49	1	}
50
51		/**
52		* @return EntityModel
53		*/
54	1	public function getModel() {
55	1	return $this->model;
56		}
57
58	1	public function __set($name, $value) {
59	1	$properties = $this->model->getProperties();
60	1	if (isset($properties[$name][P_DB_FIELD_TYPE])) {
61	1	$value = \classSupernova::$gc->types->castAs($properties[$name][P_DB_FIELD_TYPE], $value);
		0 ignored issues – show Bug introduced 2016-08-21 23:21 UTC by Report Bug Copy Issue Report The method `castAs` does only exist in `Common\Types`, but not in `Closure`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
62	1	}
63
64	1	parent::__set($name, $value);
65		// If it is first assign - saving this value as original
66	1	if (!array_key_exists($name, $this->original)) {
67	1	$this->original[$name] = $value;
68	1	} // If it is not first assign
69	1	elseif ($value != $this->original[$name] && (is_int($value) \|\| is_float($value))) {
70		// // New value not equal original value. We should update delta
71	1	$this->delta[$name] = $value - $this->original[$name];
72	1	}
73	1	}
74
75		public function clear() {
76		parent::clear();
77		$this->original = array();
78		$this->delta = array();
79		}
80
81		}
82

supernova-ws / SuperNova

Push — work-fleets ( 88e4e3...4e1f0c )

EntityContainer::processNumeric() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like