uni_functions.php ➔ uni_create_moon() - Code Metrics - Inspection of "DBAL-misc-41a51.24: Separates doInsert()" - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — work-fleets ( 04acf9...8f8df9 )

by SuperNova.WS
created 2016-08-04 17:54 UTC
uni_functions.php ➔ uni_create_moon() C

↳ Parent: Project
Complexity

Conditions	9
Paths	26
Size

Total Lines	74
Code Lines	56
Duplication

Lines	0
Ratio	0 %
Importance

Changes	2
Bugs	0	Features	0
Metric	Value
cc	9
eloc	56
c	2
b	0
f	0
nc	26
nop	8
dl	0
loc	74
rs	5.9292
How to fix Long Method Many Parameters

<?php

use Vector\Vector;

function uni_create_planet_get_density($position_data, $user_row, $planet_sectors) {
  $density_list = sn_get_groups('planet_density');
  $density_min = reset($density_list);
  unset($density_list[PLANET_DENSITY_NONE]);

  $possible_cores = array();
  $probability = 0;
  foreach($density_list as $possible_core_id => $core_data) {
    if(!$core_data[UNIT_PLANET_DENSITY_RARITY]) {
      continue;
    }

    if(
      // Core type exists
      in_array($possible_core_id, $position_data['core_types'])
      // Limit core type with planet sector count
      && $planet_sectors < $density_list[$possible_core_id][UNIT_PLANET_DENSITY_MAX_SECTORS]
      // Limit core type with player AstroTech level
      && (empty($user_row) || mrc_get_level($user_row, null, TECH_ASTROTECH) >= $density_list[$possible_core_id][UNIT_PLANET_DENSITY_MIN_ASTROTECH])
    ) {
      // Фильтруем типы ядер, которые не подходят по размеру планеты
      $probability += $density_list[$possible_core_id][UNIT_PLANET_DENSITY_RARITY];
      $possible_cores[$possible_core_id] = array(
        UNIT_PLANET_DENSITY_INDEX  => $possible_core_id,
        UNIT_PLANET_DENSITY_RARITY => $probability,
        UNIT_PLANET_DENSITY        => mt_rand($density_min[UNIT_PLANET_DENSITY], $density_list[$possible_core_id][UNIT_PLANET_DENSITY] - 1),
      );
    }
    $density_min = $density_list[$possible_core_id];
  }

  $random = mt_rand(1, $probability);
  $selected_core = null;
  foreach($possible_cores as $core_type => $core_info) {
    if($random <= $core_info[UNIT_PLANET_DENSITY_RARITY]) {
      $selected_core = $core_info;
      break;
    }
  }

  return $selected_core;
}

/**
 * @param int        $Galaxy
 * @param int        $System
 * @param int        $Position
 * @param int        $PlanetOwnerID
 * @param string     $planet_name_unsafe
 * @param bool|false $HomeWorld
 * @param array      $options
 *
 * @return bool
 */
function uni_create_planet($Galaxy, $System, $Position, $PlanetOwnerID, $planet_name_unsafe = '', $HomeWorld = false, $options = array()) {
  $Position = intval($Position);

  if(!isset($options['skip_check']) && DBStaticPlanet::db_planet_by_gspt($Galaxy, $System, $Position, PT_PLANET, true, '`id`')) {
    return false;
  }

  $user_row = !empty($options['user_row']) && is_array($options['user_row']) ? $options['user_row'] : DBStaticUser::db_user_by_id($PlanetOwnerID);


  $planet_generator = sn_get_groups('planet_generator');

  if($HomeWorld) {
    $position_data = $planet_generator[0];
  } else {
    $position_data = $planet_generator[$Position >= UNIVERSE_RANDOM_PLANET_START || $Position < 1 ? UNIVERSE_RANDOM_PLANET_START : $Position];
    if($Position >= UNIVERSE_RANDOM_PLANET_START) {
      // Корректируем температуру для планеты-странника
      $position_data['t_max_max'] -= UNIVERSE_RANDOM_PLANET_TEMPERATURE_DECREASE * ($Position - UNIVERSE_RANDOM_PLANET_START);
    }
  }

  $planet_images = sn_get_groups('planet_images');
  $planet_image = $position_data['planet_images'][mt_rand(0, count($position_data['planet_images']) - 1)];
  $planet_image .= 'planet' . $planet_images[$planet_image][mt_rand(0, count($planet_images[$planet_image]) - 1)];

  $t_max = sn_rand_gauss_range($position_data['t_max_min'], $position_data['t_max_max'], true, 1.3, true);
  $t_min = $t_max - sn_rand_gauss_range($position_data['t_delta_min'], $position_data['t_delta_max'], true, 1.3, true);

  $planet_sectors = sn_rand_gauss_range($position_data['size_min'], $position_data['size_max'], true, 1.7, true);
//  $planet_diameter = round(pow($planet_sectors, 2) * 1000);

  $planet_diameter = round(sqrt($planet_sectors) * 1000);

  $core_info = uni_create_planet_get_density($position_data, $user_row, $planet_sectors);

  $planet_name_unsafe = $user_row['username'] . ' ' . ($planet_name_unsafe ? $planet_name_unsafe : classLocale::$lang['sys_colo_defaultname']);

  $planet['name'] = trim(strip_tags($planet_name_unsafe));
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
  $planet['id_owner'] = $PlanetOwnerID;
  $planet['last_update'] = SN_TIME_NOW;
  $planet['image'] = $planet_image;

  $planet['galaxy'] = $Galaxy;
  $planet['system'] = $System;
  $planet['planet'] = $planet['position_original'] = $Position;
  $planet['planet_type'] = PT_PLANET;

  $planet['diameter'] = $planet_diameter;
  $planet['field_max'] = $planet['field_max_original'] = $planet_sectors;
  $planet['density'] = $core_info[UNIT_PLANET_DENSITY];
  $planet['density_index'] = $core_info[UNIT_PLANET_DENSITY_INDEX];
  $planet['temp_min'] = $planet['temp_min_original'] = $t_min;
  $planet['temp_max'] = $planet['temp_max_original'] = $t_max;

  $planet['metal'] = classSupernova::$config->eco_planet_starting_metal;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
  $planet['crystal'] = classSupernova::$config->eco_planet_starting_crystal;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
  $planet['deuterium'] = classSupernova::$config->eco_planet_starting_deuterium;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
  $planet['metal_max'] = classSupernova::$config->eco_planet_storage_metal;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
  $planet['crystal_max'] = classSupernova::$config->eco_planet_storage_crystal;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
  $planet['deuterium_max'] = classSupernova::$config->eco_planet_storage_deuterium;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

  $density_info_resources = &$density_list[$core_info[UNIT_PLANET_DENSITY_INDEX]][UNIT_RESOURCES];

  $planet['metal_perhour'] = classSupernova::$config->metal_basic_income * $density_info_resources[RES_METAL];
  $planet['crystal_perhour'] = classSupernova::$config->crystal_basic_income * $density_info_resources[RES_CRYSTAL];
  $planet['deuterium_perhour'] = classSupernova::$config->deuterium_basic_income * $density_info_resources[RES_DEUTERIUM];

  $RetValue = classSupernova::$gc->cacheOperator->db_ins_record(LOC_PLANET, $planet);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

  return !empty($RetValue['id']) ? $RetValue['id'] : false; // OK
}

/**
 * uni_create_moon.php
 *
 * UNI: Create moon record
 *
 * V2.1  - copyright (c) 2010-2011 by Gorlum for http://supernova.ws
 *   [~] Renamed CreateOneMoonRecord to uni_create_moon
 *   [-] Removed unsed $MoonID parameter from call
 *   [~] PCG1 compliant
 * V2.0  - copyright (c) 2010 by Gorlum for http://supernova.ws
 *   [+] Deep rewrite to rid of using `galaxy` and `lunas` tables greatly reduce numbers of SQL-queries
 * @version 1.1
 * @copyright 2008
 */

/**
 * @param        $pos_galaxy
 * @param        $pos_system
 * @param        $pos_planet
 * @param        $user_id
 * @param int    $moon_chance
 * <p><b>0</b> случайный размер луны</p>
 * <p>1..100 Шанс выпадения луны</p>
 * <p>> 100 Размер луны</p>
 * @param string $moon_name
 * @param bool   $update_debris
 * @param array  $options
 *
 * @return array|false|resource
 */
function uni_create_moon($pos_galaxy, $pos_system, $pos_planet, $user_id, $moon_chance = 0, $moon_name = '', $update_debris = true, $options = array()) {

  $classLocale = classLocale::$lang;

  $moon_name = '';
  $moon_row = array();
  $moon = DBStaticPlanet::db_planet_by_gspt($pos_galaxy, $pos_system, $pos_planet, PT_MOON, false, 'id');
  if(!$moon['id']) {
    $moon_planet = DBStaticPlanet::db_planet_by_gspt($pos_galaxy, $pos_system, $pos_planet, PT_PLANET, true, '`id`, `temp_min`, `temp_max`, `name`, `debris_metal`, `debris_crystal`');

    if($moon_planet['id']) {
      $base_storage_size = BASE_STORAGE_SIZE;

      if(!$moon_chance) {
        $size = mt_rand(1100, 8999);
      } elseif($moon_chance <= 100) {
        $size = mt_rand($moon_chance * 100 + 1000, $moon_chance * 200 + 2999);
      } else {
        $size = $moon_chance;
      }

      $moon_chance = min(30, ceil($size / 1000));

      $temp_min = $moon_planet['temp_min'] - rand(10, 45);
      $temp_max = $temp_min + 40;

      $moon_name = $moon_name ? $moon_name : "{$moon_planet['name']} {$classLocale['sys_moon']}";

      $field_max = ceil($size / 1000);

      if(isset($options['image']) && $options['image']) {
        $moon_image = $options['image'];
      } else {
        $moon_image = 'mond';
      }

      $moon_row = classSupernova::$gc->cacheOperator->db_ins_record(LOC_PLANET, array(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        'id_owner'          => $user_id,
        'parent_planet'     => $moon_planet['id'],
        'name'              => $moon_name,
        'last_update'       => SN_TIME_NOW,
        'image'             => $moon_image,
        'galaxy'            => $pos_galaxy,
        'system'            => $pos_system,
        'planet'            => $pos_planet,
        'planet_type'       => PT_MOON,
        'diameter'          => $size,
        'field_max'         => $field_max,
        'density'           => 2500,
        'density_index'     => 2,
        'temp_min'          => $temp_min,
        'temp_max'          => $temp_max,
        'metal'             => 0,
        'metal_perhour'     => 0,
        'metal_max'         => $base_storage_size,
        'crystal'           => 0,
        'crystal_perhour'   => 0,
        'crystal_max'       => $base_storage_size,
        'deuterium'         => 0,
        'deuterium_perhour' => 0,
        'deuterium_max'     => $base_storage_size,
      ));

      if($update_debris) {
        $debris_spent = $moon_chance * 1000000;
        $metal_spent = round(min($moon_planet['debris_metal'], $debris_spent * mt_rand(50, 75) / 100));
        $crystal_spent = min($moon_planet['debris_crystal'], $debris_spent - $metal_spent);
        $metal_spent = min($moon_planet['debris_metal'], $debris_spent - $crystal_spent); // Need if crystal less then their part
        DBStaticPlanet::db_planet_update_set_by_id($moon_planet['id'], "`debris_metal` = GREATEST(0, `debris_metal` - {$metal_spent}), `debris_crystal` = GREATEST(0, `debris_crystal` - {$crystal_spent})");
      }
    }
  }

  return $moon_row;
}

/*
 *
 * @function SetSelectedPlanet
 *
 * @history
 *
 * 4 - copyright (c) 2014 by Gorlum for http://supernova.ws
 *   [!] Full rewrote from scratch
 * 3 - copyright (c) 2009-2011 by Gorlum for http://supernova.ws
 *   [+] Added handling case when current_planet does not exists or didn't belong to user
 *   [+] Moved from SetSelectedPlanet.php
 *   [+] Function now return
 *   [~] Complies with PCG1
 * 2 - copyright (c) 2009-2011 by Gorlum for http://supernova.ws
 *   [~] Security checked for SQL-injection
 * 1 - copyright 2008 By Chlorel for XNova
 *
 */
function SetSelectedPlanet(&$user) {
  $planet_row['id'] = $user['current_planet'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

  // Пытаемся переключить на новую планету
  if(($selected_planet = sys_get_param_id('cp')) && $selected_planet != $user['current_planet']) {
    $planet_row = DBStaticPlanet::db_planet_by_id_and_owner($selected_planet, $user['id'], false, 'id');
  } else {
    $planet_row = DBStaticPlanet::db_planet_by_id($planet_row['id']);
  }

  // Если новая планета не найдена или было переключения - проверяем текущую выбранную планету
  if(!isset($planet_row['id'])) // || $planet_row['id'] != $user['current_planet']

  {
    $planet_row = DBStaticPlanet::db_planet_by_id_and_owner($user['current_planet'], $user['id'], false, 'id');
    // Если текущей планеты не существует - выставляем Столицу
    if(!isset($planet_row['id'])) {
      $planet_row = DBStaticPlanet::db_planet_by_id_and_owner($user['id_planet'], $user['id'], false, 'id');
      // Если и столицы не существует - значит что-то очень не так с записью пользователя
      if(!isset($planet_row['id'])) {
        classSupernova::$debug->error("User ID {$user['id']} has Capital planet {$user['id_planet']} but this planet does not exists", 'User record error', 502);
      }
    }
  }

  // Если производилось переключение планеты - делаем запись в юзере
  if($user['current_planet'] != $planet_row['id']) {
    DBStaticUser::db_user_set_by_id($user['id'], "`current_planet` = '{$planet_row['id']}'");
    $user['current_planet'] = $planet_row['id'];
  }

  return $user['current_planet'];
}

/**
 * @param Vector $vector
 */
function uniRenderVector($vector) {
  return "[{$vector->galaxy}:{$vector->system}:{$vector->planet}]";
}

// ----------------------------------------------------------------------------------------------------------------
function uni_render_coordinates($from, $prefix = '') {
  return "[{$from[$prefix . 'galaxy']}:{$from[$prefix . 'system']}:{$from[$prefix . 'planet']}]";
}

function uni_render_planet($from) {
  return "[{$from['galaxy']}:{$from['system']}:{$from['planet']}] {$from['name']}";
}

function uni_render_planet_full($from, $prefix = '', $html_safe = true, $include_id = false) {
  if(!$from['id']) {
    $result = classLocale::$lang['sys_planet_expedition'];
  } else {
    $from_planet_id = $include_id ? (
      'ID {' . ($from['id'] ? $from['id'] : ($from[$prefix . 'planet_id'] ? $from[$prefix . 'planet_id'] : 0)) . '} '
    ) : '';

    $from_planet_type = $from['planet_type'] ? $from['planet_type'] : ($from[$prefix . 'type'] ? $from[$prefix . 'type'] : 0);
    $from_planet_type = ($from_planet_type ? ' ' . classLocale::$lang['sys_planet_type_sh'][$from_planet_type] : '');

    $result = $from_planet_id . uni_render_coordinates($from, $prefix) . $from_planet_type . ($from['name'] ? ' ' . $from['name'] : '');
    $result = $html_safe ? str_replace(' ', '&nbsp;', htmlentities($result, ENT_COMPAT, 'UTF-8')) : $result;
  }

  return $result;
}

function uni_render_coordinates_url($from, $prefix = '', $page = 'galaxy.php') {
  return $page . (strpos($page, '?') === false ? '?' : '&') . "galaxy={$from[$prefix . 'galaxy']}&system={$from[$prefix . 'system']}&planet={$from[$prefix . 'planet']}";
}

function uni_render_coordinates_href($from, $prefix = '', $mode = 0, $fleet_type = '') {
  return '<a href="' . uni_render_coordinates_url($from, $prefix, "galaxy.php?mode={$mode}") . '"' . ($fleet_type ? " {$fleet_type}" : '') . '>' . uni_render_coordinates($from, $prefix) . '</a>';
}

function uni_get_time_to_jump($moon_row) {
  $jump_gate_level = mrc_get_level($user, $moon_row, STRUC_MOON_GATE);

  return $jump_gate_level ? max(0, $moon_row['last_jump_time'] + abs(60 * 60 / $jump_gate_level) - SN_TIME_NOW) : 0;
}

function uni_calculate_moon_chance($FleetDebris) {
  $MoonChance = $FleetDebris / 1000000;

  return ($MoonChance < 1) ? 0 : ($MoonChance > 30 ? 30 : $MoonChance);
}

/**
 * @param array  $coordinates
 * @param string $prefix
 *
 * @return bool
 */
function uni_coordinates_valid($coordinates, $prefix = '') {
  // array_walk($coordinates, 'intval');

  $coordinates["{$prefix}galaxy"] = intval($coordinates["{$prefix}galaxy"]);
  $coordinates["{$prefix}system"] = intval($coordinates["{$prefix}system"]);
  $coordinates["{$prefix}planet"] = intval($coordinates["{$prefix}planet"]);

  return
    isset($coordinates["{$prefix}galaxy"]) && $coordinates["{$prefix}galaxy"] > 0 && $coordinates["{$prefix}galaxy"] <= Vector::$knownGalaxies&&
    isset($coordinates["{$prefix}system"]) && $coordinates["{$prefix}system"] > 0 && $coordinates["{$prefix}system"] <= Vector::$knownSystems&&
    isset($coordinates["{$prefix}planet"]) && $coordinates["{$prefix}planet"] > 0 && $coordinates["{$prefix}planet"] <= Vector::$knownPlanets;
}

function uni_planet_teleport_check($user, $planetrow, $new_coordinates = null) {
  try {
    if($planetrow['planet_teleport_next'] && $planetrow['planet_teleport_next'] > SN_TIME_NOW) {
      throw new exception(classLocale::$lang['ov_teleport_err_cooldown'], ERR_ERROR);
    }

    if(mrc_get_level($user, null, RES_DARK_MATTER) < classSupernova::$config->planet_teleport_cost) {
      throw new exception(classLocale::$lang['ov_teleport_err_no_dark_matter'], ERR_ERROR);
    }

    // TODO: Replace quick-check with using gathered flying fleet data
    if(FleetList::fleet_count_incoming($planetrow['galaxy'], $planetrow['system'], $planetrow['planet'])) {

      throw new exception(classLocale::$lang['ov_teleport_err_fleet'], ERR_ERROR);
    }

    if(is_array($new_coordinates)) {
      $new_coordinates['planet_type'] = PT_PLANET;
      $incoming = DBStaticPlanet::db_planet_by_vector($new_coordinates, '', true, 'id');
      if($incoming['id']) {
        throw new exception(classLocale::$lang['ov_teleport_err_destination_busy'], ERR_ERROR);
      }
    }

    $response = array(
      'result'  => ERR_NONE,
      'message' => '',
    );
  } catch(exception $e) {
    $response = array(
      'result'  => $e->getCode(),
      'message' => $e->getMessage(),
    );
  }

  return $response;
}

Push — work-fleets ( 04acf9...8f8df9 )

uni_functions.php ➔ uni_create_moon() C

Complexity

Size

Duplication

Importance

How to fix Long Method Many Parameters

Long Method

Many Parameters

Available Fixes

Available Fixes

supernova-ws / SuperNova

Push — work-fleets ( 04acf9...8f8df9 )

uni_functions.php ➔ uni_create_moon() C

Complexity

Size

Duplication

Importance

How to fix Long Method Many Parameters

Long Method

Many Parameters

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
