DbRowDirectOperator

Complexity

Total Complexity

4

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes	5
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getById()	0	9	1
A	deleteById()	0	7	1
A	insert()	0	13	2

<?php

/**
 * Class DbRowDirectOperator
 *
 * Handle Entity storing/loading operations
 */

class DbRowDirectOperator implements \Common\IEntityOperator {

  /**
   * @param \Common\IEntity $entity
   *
   * @return array
   */
  public function getById($entity) {
    $stmt = classSupernova::$gc->query

The method setIdField cannot be called on \classSupernova::$gc->query (of type callable).

      ->setIdField($entity->getIdFieldName())
      ->field('*')
      ->from($entity->getTableName())
      ->where($entity->getIdFieldName() . ' = "' . $entity->dbId . '"');

Accessing dbId on the interface Common\IEntity suggest that you code against a concrete implementation. How about adding an instanceof check?

    return $stmt->selectRow();
  }

  /**
   * @param \Common\IEntity $entity
   */
  public function deleteById($entity) {
    $db = $entity->getDbStatic();

    $db->doDeleteRowWhere($entity->getTableName(), array($entity->getIdFieldName() => $entity->dbId));

Accessing dbId on the interface Common\IEntity suggest that you code against a concrete implementation. How about adding an instanceof check?

    return $db->db_affected_rows();
  }

  /**
   * @param \Common\IEntity $entity
   */
  public function insert($entity) {
    $db = $entity->getDbStatic();

    $row = $entity->exportRowWithoutId();
    if (empty($row)) {
      // TODO Exceptiion
      return 0;
    }
    $db->doInsertSet($entity->getTableName(), $row);

    // TODO Exceptiion if db_insert_id() is empty
    return $entity->dbId = $db->db_insert_id();

Accessing dbId on the interface Common\IEntity suggest that you code against a concrete implementation. How about adding an instanceof check?

  }

}