DBStaticUser::renderNameAndCoordinates() - Code Metrics - Inspection of "CODE-misc-41a52.18: Moved DBStaticXXX classes to s..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( d7065d...1ee481 )

by SuperNova.WS

created 2016-08-13 14:27 UTC

DBStaticUser::renderNameAndCoordinates() A

↳ Parent: DBStaticUser

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	3
ccs	0
cts	3
cp	0
crap	2
rs	10

<?php

namespace DBStatic;

use classSupernova;
use DbEmptyIterator;
use DbMysqliResultIterator;
use DbResultIterator;
use mysqli_result;

/**
 * Class DBStatic\DBStaticUser
 */
class DBStaticUser {
//  public static $_table = 'users';

//  public static $_idField = 'id';

  // TODO - это вообще-то надо хранить в конфигурации
  /**
   * @return string
   */
  public static function getLastRegisteredUserName() {

    $query =
      "SELECT `username` 
      FROM `{{users}}` 
      WHERE 
        `user_as_ally` IS NULL 
        AND 
        `user_bot` = " . USER_BOT_PLAYER . " 
      ORDER BY `id` DESC 
      LIMIT 1"
    ;
    $result = classSupernova::$db->doSelectFetchValue($query);

//    $query =

//      static::buildDBQ()
//        ->field('username')
//        ->where('`user_as_ally` IS NULL')
//        ->orderBy(array('`id` DESC'));
//    $result = (string)$query->selectValue();

    return $result;
  }

  /**
   * @return DbResultIterator
   */
  public static function db_player_list_export_blitz_info() {

    $query =
      "SELECT `id`, `username`, `total_rank`, `total_points`, `onlinetime` 
      FROM `{{users}}` 
      WHERE 
        `user_as_ally` IS NULL 
        AND 
        `user_bot` = " . USER_BOT_PLAYER . " 
      ORDER BY `id`";
    $result = classSupernova::$db->doSelectIterator($query);


//    $result = static::buildDBQ()

//      ->fields(array('id', 'username', 'total_rank', 'total_points', 'onlinetime',))
//      ->where('`user_as_ally` IS NULL')
//      ->orderBy(array('`id`'))
//      ->selectIterator();

    return $result;
  }

  /**
   * @return DbResultIterator
   */
  public static function db_user_list_non_bots() {

    $query = "SELECT `id` FROM `{{users}}` WHERE `user_as_ally` IS NULL AND `user_bot` = " . USER_BOT_PLAYER . " FOR UPDATE;";
    $result = classSupernova::$db->doSelectIterator($query);

//    $query =

//      static::buildDBQ()
//        ->field('id')
//        ->where("`user_as_ally` IS NULL")
//        ->where("`user_bot` = " . USER_BOT_PLAYER)
//        ->setForUpdate();
//    $result = $query->selectIterator();

    return $result;
  }

  public static function db_user_lock_with_target_owner_and_acs($user, $planet = array()) {
    $query =
      "SELECT 1 
      FROM `{{users}}` 
      WHERE `id` = " . idval($user['id']) .
      (!empty($planet['id_owner']) ? ' OR `id` = ' . idval($planet['id_owner']) : '') .
      " FOR UPDATE";

    classSupernova::$db->doSelect($query);
  }

  /**
   * @param bool $online
   *
   * @return int
   */
  public static function db_user_count($online = false) {
    return intval(classSupernova::$db->doSelectFetchValue(
      "SELECT COUNT(`id`) AS `user_count` 
      FROM `{{users}}` 
      WHERE 
        `user_as_ally` IS NULL" .
      ($online ? ' AND `onlinetime` > ' . (SN_TIME_NOW - classSupernova::$config->game_users_online_timeout) : '')
    ));
  }

  public static function db_user_list_admin_sorted($sort, $online = false) {
    $query = "SELECT
          u.*, COUNT(r.id) AS referral_count, SUM(r.dark_matter) AS referral_dm
      FROM
          {{users}} as u
          LEFT JOIN
              {{referrals}} as r on r.id_partner = u.id
      WHERE " .
        ($online ? "`onlinetime` >= " . intval(SN_TIME_NOW - classSupernova::$config->game_users_online_timeout) : 'user_as_ally IS NULL') .
      " GROUP BY u.id
      ORDER BY user_as_ally, {$sort} ASC";
    $result = classSupernova::$db->doSelectIterator($query);

//    $query = static::buildDBQ()

//      ->setAlias('u')
//      ->field('u.*')
//      ->fieldCount('r.id', 'referral_count')
//      ->fieldSingleFunction('sum', 'r.dark_matter', 'referral_dm')
//      ->join('LEFT JOIN {{referrals}} as r on r.id_partner = u.id')
//      ->where($online ? "`onlinetime` >= " . intval(SN_TIME_NOW - classSupernova::$config->game_users_online_timeout) : 'user_as_ally IS NULL')
//      ->groupBy('u.id')
//      ->orderBy("user_as_ally, {$sort} ASC");
//
//    $result = $query->selectIterator();

    return $result;
  }

  public static function db_user_list_to_celebrate($config_user_birthday_range) {
    $query = "SELECT
        `id`, `username`, `user_birthday`, `user_birthday_celebrated`,
        CONCAT(YEAR(CURRENT_DATE), DATE_FORMAT(`user_birthday`, '-%m-%d')) AS `current_birthday`,
        DATEDIFF(CURRENT_DATE, CONCAT(YEAR(CURRENT_DATE), DATE_FORMAT(`user_birthday`, '-%m-%d'))) AS `days_after_birthday`
      FROM
        `{{users}}`
      WHERE
        `user_birthday` IS NOT NULL
        AND `user_as_ally` IS NULL
        AND (`user_birthday_celebrated` IS NULL OR DATE_ADD(`user_birthday_celebrated`, INTERVAL 1 YEAR) < CURRENT_DATE)
      HAVING
        `days_after_birthday` >= 0 AND `days_after_birthday` < {$config_user_birthday_range} FOR UPDATE";

    $result = classSupernova::$db->doSelectIterator($query);

    return $result;
  }

  /**
   * @return DbEmptyIterator|DbMysqliResultIterator
   */
  public static function db_user_list_admin_multiaccounts() {
    $query = "SELECT COUNT(*) AS `ip_count`, `user_lastip`
      FROM `{{users}}`
      WHERE `user_as_ally` IS NULL
      GROUP BY `user_lastip`
      HAVING COUNT(*) > 1";

    return classSupernova::$db->doSelectIterator($query);
  }

  public static function db_player_list_blitz_delete_players() {
    classSupernova::$db->doDeleteDanger(

      TABLE_USERS,
      array(),
      array(
        "`username` LIKE 'Игрок%'"
      )
    );
  }

  /**
   * @deprecated - NEVER change DM amount directly w/o logging!
   */
  public static function db_player_list_blitz_set_50k_dm() {
    classSupernova::$db->doUpdateTableSet(
      TABLE_USERS,
      array(
        'dark_matter'       => 50000,
        'dark_matter_total' => 50000,
      )
    );

  }


  /**
   * Выбирает записи игроков по списку их ID
   *
   * @param $user_id_list
   *
   * @return array
   */
  public static function db_user_list_by_id($user_id_list) {
    !is_array($user_id_list) ? $user_id_list = array($user_id_list) : false;

    $user_list = array();
    foreach ($user_id_list as $user_id_unsafe) {
      $user = DBStaticUser::db_user_by_id($user_id_unsafe);
      !empty($user) ? $user_list[$user_id_unsafe] = $user : false;
    }

    return $user_list;
  }


  public static function db_user_by_username($username_unsafe, $for_update = false, $fields = '*', $player = null, $like = false) {

    // TODO Проверить, кстати - а везде ли нужно выбирать юзеров или где-то все-таки ищутся Альянсы ?
    if (!($username_unsafe = trim($username_unsafe))) {
      return false;
    }

    $user = null;
    if (classSupernova::$gc->snCache->isArrayLocation(LOC_USER)) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
      foreach (classSupernova::$gc->snCache->getData(LOC_USER) as $user_id => $user_data) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        if (is_array($user_data) && isset($user_data['username'])) {
          // проверяем поле
          // TODO Возможно есть смысл всегда искать по strtolower - но может игрок захочет переименоваться с другим регистром? Проверить!
          if ((!$like && $user_data['username'] == $username_unsafe) || ($like && strtolower($user_data['username']) == strtolower($username_unsafe))) {
            // $user_as_ally = intval($user_data['user_as_ally']);

            $user_as_ally = idval($user_data['user_as_ally']);
            if ($player === null || ($player === true && !$user_as_ally) || ($player === false && $user_as_ally)) {
              $user = $user_data;
              break;
            }
          }
        }
      }
    }

    if ($user === null) {
      // Вытаскиваем запись
      $username_safe = db_escape($like ? strtolower($username_unsafe) : $username_unsafe); // тут на самом деле strtolower() лишняя, но пусть будет

      $user = classSupernova::$db->doSelectFetch(
        "SELECT * FROM {{users}} WHERE `username` " . ($like ? 'LIKE' : '=') . " '{$username_safe}'"
        . " FOR UPDATE"
      );
      classSupernova::$gc->snCache->cache_set(LOC_USER, $user); // В кэш-юзер так же заполнять индексы
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    return $user;
  }

  public static function db_user_list($user_filter = '', $for_update = false, $fields = '*') {

    return classSupernova::$gc->cacheOperator->db_get_record_list(LOC_USER, $user_filter);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
  }

  /**
   * @param       $user_id
   * @param array $set
   *
   * @return array|bool|mysqli_result|null
   */
  public static function db_user_set_by_id($user_id, $set) {
    return classSupernova::$gc->cacheOperator->db_upd_record_by_id(LOC_USER, $user_id, $set, array());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
  }

  /**
   * @param       $user_id
   * @param array $set
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
   * @param array $adjust
   *
   * @return array|bool|mysqli_result|null
   */
  public static function db_user_adjust_by_id($user_id, $adjust) {
    return classSupernova::$gc->cacheOperator->db_upd_record_by_id(LOC_USER, $user_id, array(), $adjust);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
  }

  /**
   * Возвращает информацию о пользователе по его ID
   *
   * @param int|array $user_id_unsafe
   *    <p>int - ID пользователя</p>
   *    <p>array - запись пользователя с установленным полем ['id']</p>
   * @param bool      $for_update @deprecated
   * @param string    $fields @deprecated список полей или '*'/'' для всех полей
   * @param null      $player
   * @param bool|null $player Признак выбора записи пользователь типа "игрок"
   *    <p>null - Можно выбрать запись любого типа</p>
   *    <p>true - Выбирается только запись типа "игрок"</p>
   *    <p>false - Выбирается только запись типа "альянс"</p>
   *
   * @return array|false
   *    <p>false - Нет записи с указанным ID и $player</p>
   *    <p>array - запись типа $user</p>
   */
  public static function db_user_by_id($user_id_unsafe, $for_update = false, $fields = '*', $player = null) {
    $user = classSupernova::$gc->cacheOperator->db_get_record_by_id(LOC_USER, $user_id_unsafe, $for_update, $fields);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

    return (is_array($user) &&
      (
        $player === null
        ||
        ($player === true && !$user['user_as_ally'])
        ||
        ($player === false && $user['user_as_ally'])
      )) ? $user : false;
  }


  /**
   * @param       $ally_id
   * @param       $ally_rank_id
   * @param array $set
   * @param array $adjust
   */
  public static function db_user_list_set_by_ally_and_rank($ally_id, $ally_rank_id, $set, $adjust) {
    classSupernova::$gc->cacheOperator->db_upd_record_list_DANGER(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
      LOC_USER,
      $set,
      $adjust,
      array(
        'ally_id' => $ally_id,
      ),
      array(
        // TODO - DANGER !!!
        "`ally_rank_id` >= {$ally_rank_id}"
      )
    );
  }

  /**
   * @param array $playerArray
   */
  public static function renderNameAndCoordinates($playerArray) {
    return "{$playerArray['username']} " . uni_render_coordinates($playerArray);
  }

  /**
   * @param mixed $user
   */
  public static function validateUserRecord($user) {
    if (!is_array($user)) {
      // TODO - remove later
      print('<h1>СООБЩИТЕ ЭТО АДМИНУ: sn_db_unit_changeset_prepare() - USER is not ARRAY</h1>');
      pdump(debug_backtrace());
      die('USER is not ARRAY');
    }
    if (!isset($user['id']) || !$user['id']) {
      // TODO - remove later
      print('<h1>СООБЩИТЕ ЭТО АДМИНУ: sn_db_unit_changeset_prepare() - USER[id] пустой</h1>');
      pdump($user);
      pdump(debug_backtrace());
      die('USER[id] пустой');
    }
  }

  /**
   * @param array $playerRowFieldChanges - array of $resourceId => $amount
   * @param int   $userId
   *
   * // TODO - DEDUPLICATE
   * @see DBStaticPlanet::db_planet_update_resources
   */
  public static function db_user_update_resources($playerRowFieldChanges, $userId) {

    $fields = array();
    foreach ($playerRowFieldChanges as $resourceId => $value) {
      $fields[pname_resource_name($resourceId)] = $value;
    }
    if (!empty($fields)) {
      classSupernova::$gc->db->doUpdateRowAdjust(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        TABLE_USERS,
        array(),
        $fields,
        array(
          'id' => $userId
        )
      );
    }
  }

  public static function lockAllRecords() {
    classSupernova::$db->doSelect("SELECT 1 FROM `{{users}}` FOR UPDATE");
  }

}


Push — work-fleets ( d7065d...1ee481 )

DBStaticUser::renderNameAndCoordinates() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace DBStatic;
4
5		use classSupernova;
6		use DbEmptyIterator;
7		use DbMysqliResultIterator;
8		use DbResultIterator;
9		use mysqli_result;
10
11		/**
12		* Class DBStatic\DBStaticUser
13		*/
14		class DBStaticUser {
15		// public static $_table = 'users';
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-13 14:35 UTC by Report Bug Copy Issue Report `44%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
16		// public static $_idField = 'id';
17
18		// TODO - это вообще-то надо хранить в конфигурации
19		/**
20		* @return string
21		*/
22	View Code Duplication	public static function getLastRegisteredUserName() {
		0 ignored issues – show Duplication introduced 2016-08-13 14:35 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		$query =
24		"SELECT `username`
25		FROM `{{users}}`
26		WHERE
27		`user_as_ally` IS NULL
28		AND
29		`user_bot` = " . USER_BOT_PLAYER . "
30		ORDER BY `id` DESC
31		LIMIT 1"
32		;
33		$result = classSupernova::$db->doSelectFetchValue($query);
34
35		// $query =
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-13 14:35 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
36		// static::buildDBQ()
37		// ->field('username')

supernova-ws / SuperNova

Push — work-fleets ( d7065d...1ee481 )

DBStaticUser::renderNameAndCoordinates() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like