View GitHub Repository SuperNova

Schedule Inspection
Subscribe
Completed
Push — work-fleets ( d7065d...1ee481 )
by SuperNova.WS
08:22
created

DBStaticSurvey::db_survey_insert()   A

↳ Parent: DBStaticSurvey

Complexity

Conditions 1
Paths 1

Size

Total Lines 7
Code Lines 5

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 1
eloc 5
c 1
b 0
f 0
nc 1
nop 3
dl 0
loc 7
ccs 0
cts 7
cp 0
crap 2
rs 9.4285
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace DBStatic;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                
use classSupernova;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
class DBStaticSurvey {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
  public static function db_survey_delete_by_id($announce_id) {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
    classSupernova::$gc->db->doDeleteWhere(TABLE_SURVEY, array('survey_announce_id' => $announce_id));

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The method doDeleteWhere does only exist in db_mysql, but not in Closure.
                                                                                                                                                                                                        

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
It seems like the method you are trying to call exists only in some of the
possible types.


Let’s take a look at an example:


class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}







Available Fixes


  1. Add an additional type-check:
    

    /**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo();

    if ($x instanceof B) {
        $x->bar();
    }
}

    

    

    2. 

  2. Only allow a single type to be passed if the variable comes from a parameter:
    

    function someFunction(B $x) { /** ... */ }

    

    

    3. 



                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
  }

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
  public static function db_survey_insert($announce_id, $survey_question_unsafe, $survey_until) {

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
    classSupernova::$db->doInsertSet(TABLE_SURVEY, array(

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
      'survey_announce_id' => $announce_id,

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
      'survey_question'    => $survey_question_unsafe,

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
      'survey_until'       => $survey_until,

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
    ));

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
  }

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
}