DBStaticFleetMissile::db_missile_insert() - Code Metrics - Inspection of "CODE-misc-41a52.18: Moved DBStaticXXX classes to s..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( d7065d...1ee481 )

by SuperNova.WS

created 2016-08-13 14:27 UTC

DBStaticFleetMissile::db_missile_insert() A

↳ Parent: DBStaticFleetMissile

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	13
c	1
b	0
f	0
nc	1
nop	6
dl	0
loc	15
ccs	0
cts	15
cp	0
crap	2
rs	9.4285

<?php

namespace DBStatic;
use classSupernova;
use mysqli_result;

class DBStaticFleetMissile {

  public static function db_missile_insert($target_coord, $user, $planetrow, $arrival, $fleet_ship_count, $target_structure) {
    classSupernova::$db->doInsertSet(TABLE_MISSILES, array(
      'fleet_target_owner' => $target_coord['id_owner'],
      'fleet_end_galaxy'   => $target_coord['galaxy'],
      'fleet_end_system'   => $target_coord['system'],
      'fleet_end_planet'   => $target_coord['planet'],
      'fleet_owner'        => $user['id'],
      'fleet_start_galaxy' => $planetrow['galaxy'],
      'fleet_start_system' => $planetrow['system'],
      'fleet_start_planet' => $planetrow['planet'],
      'fleet_end_time'     => $arrival,
      'fleet_amount'       => $fleet_ship_count,
      'primaer'            => $target_structure,
    ));
  }


  /**
   * @param $fleetDbId
   */
  public static function db_missile_delete($fleetDbId) {
    classSupernova::$gc->db->doDeleteRow(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
      TABLE_MISSILES,
      array(
        'id' => $fleetDbId,
      )
    );
  }

  /**
   * @return array|bool|mysqli_result|null
   */
  public static function db_missile_list_by_arrival() {
    $iraks = classSupernova::$db->doSelect("SELECT * FROM `{{iraks}}` WHERE `fleet_end_time` <= " . SN_TIME_NOW . " FOR UPDATE;");

    return $iraks;
  }


}

1			<?php
2
3			namespace DBStatic;
4			use classSupernova;
5			use mysqli_result;
6
7			class DBStaticFleetMissile {
8
9			public static function db_missile_insert($target_coord, $user, $planetrow, $arrival, $fleet_ship_count, $target_structure) {
10			classSupernova::$db->doInsertSet(TABLE_MISSILES, array(
11			'fleet_target_owner' => $target_coord['id_owner'],
12			'fleet_end_galaxy' => $target_coord['galaxy'],
13			'fleet_end_system' => $target_coord['system'],
14			'fleet_end_planet' => $target_coord['planet'],
15			'fleet_owner' => $user['id'],
16			'fleet_start_galaxy' => $planetrow['galaxy'],
17			'fleet_start_system' => $planetrow['system'],
18			'fleet_start_planet' => $planetrow['planet'],
19			'fleet_end_time' => $arrival,
20			'fleet_amount' => $fleet_ship_count,
21			'primaer' => $target_structure,
22			));
23			}
24
25
26			/**
27			* @param $fleetDbId
28			*/
29			public static function db_missile_delete($fleetDbId) {
30			classSupernova::$gc->db->doDeleteRow(
			0 ignored issues – show Bug introduced 2016-08-07 01:51 UTC by Report Bug Copy Issue Report The method `doDeleteRow` does only exist in `db_mysql`, but not in `Closure`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
31			TABLE_MISSILES,
32			array(
33			'id' => $fleetDbId,
34			)
35			);
36			}
37
38			/**
39			* @return array\|bool\|mysqli_result\|null
40			*/
41			public static function db_missile_list_by_arrival() {
42			$iraks = classSupernova::$db->doSelect("SELECT * FROM `{{iraks}}` WHERE `fleet_end_time` <= " . SN_TIME_NOW . " FOR UPDATE;");
43
44			return $iraks;
45			}
46
47
48			}

supernova-ws / SuperNova

Push — work-fleets ( d7065d...1ee481 )

DBStaticFleetMissile::db_missile_insert() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like