Issues in simulator.php - New Issues - Inspection of "CODE-misc-41a52.64: Moved fleet-related groups fro..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( d1f99e...fc0000 )

by SuperNova.WS

created 2016-09-03 12:23 UTC

simulator.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

include('common.' . substr(strrchr(__FILE__, '.'), 1));

if(sys_get_param_int('BE_DEBUG') && !defined('BE_DEBUG'))
{
  define('BE_DEBUG', true);
}

require_once('includes/includes/coe_simulator_helpers.php');

$replay = $_GET['replay'] ? $_GET['replay'] : $_POST['replay'];
$execute = intval($_GET['execute']);
$sym_defender = $_POST['defender'] ? $_POST['defender'] : array();
$sym_attacker = $_POST['attacker'] ? $_POST['attacker'] : array();

if($replay)
{
  $unpacked = sn_ube_simulator_decode_replay($replay);

  $sym_defender = $unpacked['D'];
  $sym_attacker = $unpacked['A'];
}
else
{
  $sym_defender = array(0 => $sym_defender);
  $sym_attacker = array(1 => $sym_attacker);
}

if($_POST['submit'] || $execute)
{
  $replay = sn_ube_simulator_encode_replay($sym_defender, 'D');
  $replay .= sn_ube_simulator_encode_replay($sym_attacker, 'A');

  require_once('classes/UBE/UBE.php');
  UBE::display_simulator($sym_attacker, $sym_defender);
}
else
{
  $template = gettemplate('simulator', true);
  $techs_and_officers = array(TECH_WEAPON, TECH_SHIELD, TECH_ARMOR, MRC_ADMIRAL);

  foreach($techs_and_officers as $tech_id)
  {
    if(!$sym_attacker[1][$tech_id])
    {
      $sym_attacker[1][$tech_id] = mrc_get_level($user, null, $tech_id);
    }
  }

  $show_groups = array(
    UNIT_TECHNOLOGIES => array(TECH_WEAPON, TECH_SHIELD, TECH_ARMOR),
    UNIT_MERCENARIES => array(MRC_ADMIRAL),
    UNIT_SHIPS => classSupernova::$gc->groupFleet,
    UNIT_RESOURCES => sn_get_groups('resources_loot'),
    UNIT_GOVERNORS => array(MRC_FORTIFIER),
    UNIT_DEFENCE => sn_get_groups('defense_active'),
  );
  foreach($show_groups as $unit_group_id => $unit_group)
  {
    $template->assign_block_vars('simulator', array(
      'GROUP' => $unit_group_id,
      'NAME' => classLocale::$lang['tech'][$unit_group_id],
    ));

    foreach($unit_group as $unit_id)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
    {
      $tab++;

      $value = mrc_get_level($user, $planetrow, $unit_id);

      $template->assign_block_vars('simulator', array(
        'NUM'      => $tab < 9 ? "0{$tab}" : $tab,
        'ID'       => $unit_id,
        'GROUP'    => $unit_group_id,
        'NAME'     => classLocale::$lang['tech'][$unit_id],
        'ATTACKER' => intval($sym_attacker[1][$unit_id]),
        'DEFENDER' => intval($sym_defender[0][$unit_id]),
        'VALUE'    => $value,
      ));
    }
  }

  $template->assign_vars(array(
    'BE_DEBUG' => BE_DEBUG,
    'UNIT_DEFENCE' => UNIT_DEFENCE,
    'UNIT_GOVERNORS' => UNIT_GOVERNORS,
  ));

  display($template, classLocale::$lang['coe_combatSimulator'], false);
}


1			<?php
2
3			include('common.' . substr(strrchr(__FILE__, '.'), 1));
4
5			if(sys_get_param_int('BE_DEBUG') && !defined('BE_DEBUG'))
6			{
7			define('BE_DEBUG', true);
8			}
9
10			require_once('includes/includes/coe_simulator_helpers.php');
11
12			$replay = $_GET['replay'] ? $_GET['replay'] : $_POST['replay'];
13			$execute = intval($_GET['execute']);
14			$sym_defender = $_POST['defender'] ? $_POST['defender'] : array();
15			$sym_attacker = $_POST['attacker'] ? $_POST['attacker'] : array();
16
17			if($replay)
18			{
19			$unpacked = sn_ube_simulator_decode_replay($replay);
20
21			$sym_defender = $unpacked['D'];
22			$sym_attacker = $unpacked['A'];
23			}
24			else
25			{
26			$sym_defender = array(0 => $sym_defender);
27			$sym_attacker = array(1 => $sym_attacker);
28			}
29
30			if($_POST['submit'] \|\| $execute)
31			{
32			$replay = sn_ube_simulator_encode_replay($sym_defender, 'D');
33			$replay .= sn_ube_simulator_encode_replay($sym_attacker, 'A');
34
35			require_once('classes/UBE/UBE.php');
36			UBE::display_simulator($sym_attacker, $sym_defender);
37			}
38			else
39			{
40			$template = gettemplate('simulator', true);
41			$techs_and_officers = array(TECH_WEAPON, TECH_SHIELD, TECH_ARMOR, MRC_ADMIRAL);
42
43			foreach($techs_and_officers as $tech_id)
44			{
45			if(!$sym_attacker[1][$tech_id])
46			{
47			$sym_attacker[1][$tech_id] = mrc_get_level($user, null, $tech_id);
48			}
49			}
50
51			$show_groups = array(
52			UNIT_TECHNOLOGIES => array(TECH_WEAPON, TECH_SHIELD, TECH_ARMOR),
53			UNIT_MERCENARIES => array(MRC_ADMIRAL),
54			UNIT_SHIPS => classSupernova::$gc->groupFleet,
55			UNIT_RESOURCES => sn_get_groups('resources_loot'),
56			UNIT_GOVERNORS => array(MRC_FORTIFIER),
57			UNIT_DEFENCE => sn_get_groups('defense_active'),
58			);
59			foreach($show_groups as $unit_group_id => $unit_group)
60			{
61			$template->assign_block_vars('simulator', array(
62			'GROUP' => $unit_group_id,
63			'NAME' => classLocale::$lang['tech'][$unit_group_id],
64			));
65
66			foreach($unit_group as $unit_id)
			0 ignored issues – show Bug introduced 2016-09-03 12:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$unit_group` of type `array\|object<Closure>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
67			{
68			$tab++;
69
70			$value = mrc_get_level($user, $planetrow, $unit_id);
71
72			$template->assign_block_vars('simulator', array(
73			'NUM' => $tab < 9 ? "0{$tab}" : $tab,
74			'ID' => $unit_id,
75			'GROUP' => $unit_group_id,
76			'NAME' => classLocale::$lang['tech'][$unit_id],
77			'ATTACKER' => intval($sym_attacker[1][$unit_id]),
78			'DEFENDER' => intval($sym_defender[0][$unit_id]),
79			'VALUE' => $value,
80			));
81			}
82			}
83
84			$template->assign_vars(array(
85			'BE_DEBUG' => BE_DEBUG,
86			'UNIT_DEFENCE' => UNIT_DEFENCE,
87			'UNIT_GOVERNORS' => UNIT_GOVERNORS,
88			));
89
90			display($template, classLocale::$lang['coe_combatSimulator'], false);
91			}
92

supernova-ws / SuperNova

Push — work-fleets ( d1f99e...fc0000 )

simulator.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like