supernova-ws / SuperNova

classes/V2Unit/V2UnitList.php

Doc Comments +3 added lines

@@ -31,6 +31,9 @@
 
   }
 
+  /**
+   * @param integer $snId
+   */
   public function unitAdd($snId, $level) {
     if($this->indexIsSet($snId)) {
       $this->indexGetObject($snId)->$level += $level;

classes/V2Fleet/V2FleetModel.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 
 use Common\V2Location;
 use DBStatic\DBStaticFleetACS;
-use V2Unit\V2UnitList;
 use Vector\Vector;
 use Entity\KeyedModel;
 

Spacing +13 added lines, -13 removed lines

@@ -93,28 +93,28 @@ 
   public function __construct(\Common\GlobalContainer $gc) {
     parent::__construct($gc);
 
-    $this->accessors->set(P_CONTAINER_SET, 'dbId', function (V2FleetContainer $that, $value) {
+    $this->accessors->set(P_CONTAINER_SET, 'dbId', function(V2FleetContainer $that, $value) {
       $that->setDirect('dbId', $value);
       $that->location->setLocationId($value);
     });
 
-    $this->accessors->set(P_CONTAINER_SET, 'ownerId', function (V2FleetContainer $that, $value) {
+    $this->accessors->set(P_CONTAINER_SET, 'ownerId', function(V2FleetContainer $that, $value) {
       $that->setDirect('ownerId', $value);
       $that->location->setLocationPlayerId($value);
     });
 
-    $this->accessors->set(P_CONTAINER_SET, 'owner', function (V2FleetContainer $that, $value) {
+    $this->accessors->set(P_CONTAINER_SET, 'owner', function(V2FleetContainer $that, $value) {
       $that->owner = $value;
-      if(isset($value['id'])) {
+      if (isset($value['id'])) {
         $that->ownerId = $value['id'];
       } else {
         $that->ownerId = 0;
       }
     });
 
-    $this->accessors->set(P_CONTAINER_SET, 'departure', function (V2FleetContainer $that, $value) {
+    $this->accessors->set(P_CONTAINER_SET, 'departure', function(V2FleetContainer $that, $value) {
       $that->departure = $value;
-      if(isset($value['id'])) {
+      if (isset($value['id'])) {
         $that->departurePlanetId = $value['id'];
         $that->vectorDeparture = $value;
       } else {
@@ -122,20 +122,20 @@ 
       }
     });
 
-    $this->accessors->set(P_CONTAINER_GET, 'vectorDeparture', function (V2FleetContainer $that) {
+    $this->accessors->set(P_CONTAINER_GET, 'vectorDeparture', function(V2FleetContainer $that) {
       $vector = new Vector();
       $that->setDirect('vectorDeparture', $vector);
 
       return $vector;
     }, ACCESSOR_SHARED);
-    $this->accessors->set(P_CONTAINER_SET, 'vectorDeparture', function (V2FleetContainer $that, $value) {
+    $this->accessors->set(P_CONTAINER_SET, 'vectorDeparture', function(V2FleetContainer $that, $value) {
       $vector = $that->vectorDeparture;
 
-      if(is_array($value)) {
+      if (is_array($value)) {
         $value = Vector::convertToVector($value);
       }
 
-      if($value instanceof Vector) {
+      if ($value instanceof Vector) {
         $vector->readFromVector($value);
       } else {
         throw new \Exception('V2Fleet::vectorDeparture setter - value is not a Vector or array!', ERR_ERROR);
@@ -148,7 +148,7 @@ 
     $this->accessors->set(P_CONTAINER_EXPORT, 'vectorArrive', array($this, 'exportVector'));
 
 
-    $this->accessors->set(P_CONTAINER_GET, 'location', function (V2FleetContainer $that) {
+    $this->accessors->set(P_CONTAINER_GET, 'location', function(V2FleetContainer $that) {
 //      if (is_null($location = $that->getDirect('location'))) {}
       $location = new V2Location(LOC_FLEET);
       $that->setDirect('location', $location);
@@ -156,7 +156,7 @@ 
       return $location;
     }, ACCESSOR_SHARED);
 
-    $this->accessors->set(P_CONTAINER_GET, 'units', function (V2FleetContainer $that) {
+    $this->accessors->set(P_CONTAINER_GET, 'units', function(V2FleetContainer $that) {
 //      if (is_null($units = $that->getDirect('units'))) {}
       $units = \classSupernova::$gc->unitList;
       $that->setDirect('units', $units);
@@ -164,7 +164,7 @@ 
       return $units;
     }, ACCESSOR_SHARED);
 
-    $this->accessors->set(P_CONTAINER_GET, 'isReturning', function (V2FleetContainer $that) {
+    $this->accessors->set(P_CONTAINER_GET, 'isReturning', function(V2FleetContainer $that) {
       return $that->status == FLEET_FLAG_RETURNING;
     });
 

Doc Comments +1 added lines, -1 removed lines

@@ -213,7 +213,7 @@
   /**
    * @param int|string $dbId
    *
-   * @return V2FleetContainer|false
+   * @return V2FleetContainer
    */
   public function loadById($dbId) {
     /**

classes/Common/ObjectCollection.php

Spacing +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
    * @since 5.0.0
    */
   public function offsetUnset($offset) {
-    if($this->offsetExists($offset)) {
+    if ($this->offsetExists($offset)) {
       parent::offsetUnset($this->offsetGet($offset));
     }
   }

classes/Common/Invoker.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
   }
 
   public static function build($callable) {
-    if(is_array($callable) && count($callable) == 2 && is_object($callable[0])) {
+    if (is_array($callable) && count($callable) == 2 && is_object($callable[0])) {
       return new static($callable);
     } else {
       return false;

includes/includes/flt_mission_transport.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
   $source_planet = &$mission_data->src_planet;
   $destination_planet = &$mission_data->dst_planet;
 
-  if(empty($destination_planet['id_owner'])) {
+  if (empty($destination_planet['id_owner'])) {
     $objFleet->markReturnedAndSave();
 
     return $result;
@@ -33,7 +33,7 @@ 
     $fleet_resources[RES_DEUTERIUM], classLocale::$lang['Deuterium']);
   DBStaticMessages::msg_send_simple_message($objFleet->target_owner_id, '', $objFleet->time_arrive_to_target, MSG_TYPE_TRANSPORT, classLocale::$lang['sys_mess_tower'], classLocale::$lang['sys_mess_transport'], $Message);
 
-  if($objFleet->target_owner_id <> $objFleet->playerOwnerId) {
+  if ($objFleet->target_owner_id <> $objFleet->playerOwnerId) {
     DBStaticMessages::msg_send_simple_message($objFleet->playerOwnerId, '', $objFleet->time_arrive_to_target, MSG_TYPE_TRANSPORT, classLocale::$lang['sys_mess_tower'], classLocale::$lang['sys_mess_transport'], $Message);
   }
 

includes/includes/flt_flying_fleet_handler2.php

Doc Comments -1 removed lines

@@ -14,7 +14,6 @@
  *
  * @param Fleet $objFleet
  * @param bool  $start
- * @param null  $result
  *
  * @return mixed
  */

Spacing +7 added lines, -11 removed lines

@@ -23,15 +23,11 @@ 
 // ------------------------------------------------------------------
 function flt_flyingFleetsSort($a, $b) {
   // Сравниваем время флотов - кто раньше, тот и первый обрабатывается
-  return $a['fleet_time'] > $b['fleet_time'] ? 1 : ($a['fleet_time'] < $b['fleet_time'] ? -1 :
-    // Если время - одинаковое, сравниваем события флотов
+  return $a['fleet_time'] > $b['fleet_time'] ? 1 : ($a['fleet_time'] < $b['fleet_time'] ? -1 : // Если время - одинаковое, сравниваем события флотов
     // Если события - одинаковые, то флоты равны
-    ($a['fleet_event'] == $b['fleet_event'] ? 0 :
-      // Если события разные - первыми считаем прибывающие флоты
-      ($a['fleet_event'] == EVENT_FLT_ARRIVE ? 1 : ($b['fleet_event'] == EVENT_FLT_ARRIVE ? -1 :
-        // Если нет прибывающих флотов - дальше считаем флоты, которые закончили миссию
-        ($a['fleet_event'] == EVENT_FLT_ACOMPLISH ? 1 : ($b['fleet_event'] == EVENT_FLT_ACOMPLISH ? -1 :
-          // Если нет флотов, закончивших задание - остались возвращающиеся флоты, которые равны между собой
+    ($a['fleet_event'] == $b['fleet_event'] ? 0 : // Если события разные - первыми считаем прибывающие флоты
+      ($a['fleet_event'] == EVENT_FLT_ARRIVE ? 1 : ($b['fleet_event'] == EVENT_FLT_ARRIVE ? -1 : // Если нет прибывающих флотов - дальше считаем флоты, которые закончили миссию
+        ($a['fleet_event'] == EVENT_FLT_ACOMPLISH ? 1 : ($b['fleet_event'] == EVENT_FLT_ACOMPLISH ? -1 : // Если нет флотов, закончивших задание - остались возвращающиеся флоты, которые равны между собой
           // TODO: Добавить еще проверку по ID флота и/или времени запуска - что бы обсчитывать их в порядке запуска
           (
           0 // Вообще сюда доходить не должно - будет отсекаться на равенстве событий
@@ -55,7 +51,7 @@ 
 // ------------------------------------------------------------------
 function flt_flying_fleet_handler($skip_fleet_update = false) {
   if (true) {
-    if(!defined('IN_AJAX')) {
+    if (!defined('IN_AJAX')) {
       print('<div style="color: red; font-size: 300%">Fleet handler is disabled</div>');
       pdump('Fleet handler is disabled');
     }
@@ -190,7 +186,7 @@ 
     // Watchdog timer
     // If flying fleet handler works more then 10 seconds - stopping it
     // Let next run handle rest of fleets
-    if(time() - SN_TIME_NOW > 10) {
+    if (time() - SN_TIME_NOW > 10) {
       $debug->warning('Flying fleet handler standard routine works more then 10 seconds - watchdog unlocked', 'FFH Warning', 504);
       break;
     }
@@ -256,7 +252,7 @@ 
     $objMission->fleet_event = $fleet_event['fleet_event'];
 
     // Fleet that have planet destination is returned
-    if($mission_data['dst_planet'] && empty($objMission->dst_planet['id_owner'])) {
+    if ($mission_data['dst_planet'] && empty($objMission->dst_planet['id_owner'])) {
       $objFleet->markReturnedAndSave();
       sn_db_transaction_commit();
       continue;

classes/FleetList.php

Doc Comments +5 added lines

@@ -64,6 +64,10 @@ 
    *
    */
   // DEPRECATED
+
+  /**
+   * @param boolean $for_update
+   */
   public static function dbGetFleetList($where_safe = '', $for_update = DB_SELECT_FOR_UPDATE) {
     $fleetList = new static();
     $fleetList->dbLoadWhere($where_safe, $for_update);
@@ -246,6 +250,7 @@ 
    * LIST - Get missile attack list by condition
    *
    * @param string $where
+   * @param boolean $for_update
    */
   public function dbMergeMissileList($where, $for_update = DB_SELECT_FOR_UPDATE) {
     $query = classSupernova::$db->doSelect(

Spacing +8 added lines, -8 removed lines

@@ -37,14 +37,14 @@ 
       (!empty($where_safe) ? " WHERE {$where_safe}" : '') .
       " FOR UPDATE;"
     );
-    while($row = db_fetch($query)) {
+    while ($row = db_fetch($query)) {
       /**
        * @var Fleet $fleet
        */
       $fleet = $this->_createElement();
       $fleet->dbRowParse($row);
 
-      if(isset($this[$fleet->dbId])) {
+      if (isset($this[$fleet->dbId])) {
         // Нужно ли ????
         classSupernova::$debug->error('Fleet list already set');
       }
@@ -170,7 +170,7 @@ 
    * @return static
    */
   public static function dbGetFleetListAndMissileByCoordinates($coordinates, $for_phalanx = false) {
-    if(empty($coordinates) || !is_array($coordinates)) {
+    if (empty($coordinates) || !is_array($coordinates)) {
       return array();
     }
 
@@ -199,8 +199,8 @@ 
      * @var Fleet[] $array_of_Fleet
      */
     $array_of_Fleet = array();
-    if(!empty($fleet_db_list) && $fleet_db_list->count()) {
-      foreach($fleet_db_list->_container as $fleet_id => $objFleet) {
+    if (!empty($fleet_db_list) && $fleet_db_list->count()) {
+      foreach ($fleet_db_list->_container as $fleet_id => $objFleet) {
         $array_of_Fleet[$fleet_id] = $objFleet;
       }
       $planet_fleets = flt_get_fleets_to_planet_by_array_of_Fleet($array_of_Fleet);
@@ -249,7 +249,7 @@ 
       "SELECT * FROM `{{iraks}}`" .
       (!empty($where) ? " WHERE {$where}" : '') .
       " FOR UPDATE;");
-    while($missile_db_row = db_fetch($query)) {
+    while ($missile_db_row = db_fetch($query)) {
       /**
        * @var Fleet $objFleet
        */
@@ -271,7 +271,7 @@ 
    */
   public static function dbGetFleetListAndMissileINCOMING($owner_id) {
     $owner_id_safe = idval($owner_id);
-    if(empty($owner_id_safe)) {
+    if (empty($owner_id_safe)) {
       return array();
     }
 
@@ -305,7 +305,7 @@ 
    */
   public static function fleet_count_flying($player_id, $mission_id = 0) {
     $player_id_safe = idval($player_id);
-    if(!empty($player_id_safe)) {
+    if (!empty($player_id_safe)) {
       $mission_id_safe = intval($mission_id);
       $result = static::db_fleet_count(
         "`fleet_owner` = {$player_id_safe}" .

classes/FleetValidator.php

Doc Comments +5 added lines, -1 removed lines

@@ -820,7 +820,7 @@ 
 
 
   /**
-   * @return int
+   * @return boolean
    */
   protected function checkExpeditionsMax() {
     return get_player_max_expeditons($this->fleet->dbOwnerRow) > 0;
@@ -920,6 +920,10 @@ 
       $this->checkMissionExact($missionType);
   }
 
+  /**
+   * @param integer $missionType
+   * @param boolean $result
+   */
   protected function checkMissionResultAndUnset($missionType, $result, $forceMission = false) {
     $this->unsetMission($missionType, $result, $forceMission);
 

Spacing +2 added lines, -2 removed lines

@@ -16,7 +16,7 @@ 
     'checkSpeedPercentOld'       => FLIGHT_FLEET_SPEED_WRONG,
     'checkTargetInUniverse'      => FLIGHT_VECTOR_BEYOND_UNIVERSE,
     'checkTargetNotSource'       => FLIGHT_VECTOR_SAME_SOURCE,
-    'checkSenderNoVacation'      => FLIGHT_PLAYER_VACATION_OWN,  // tODO
+    'checkSenderNoVacation'      => FLIGHT_PLAYER_VACATION_OWN, // tODO
     'checkTargetNoVacation'      => FLIGHT_PLAYER_VACATION,
     'checkFleetNotEmpty'         => FLIGHT_SHIPS_NO_SHIPS,
     // 'checkUnitsPositive'         => FLIGHT_SHIPS_NEGATIVE, // Unused - 'cause it's not allowed to put negative units into Unit class
@@ -158,7 +158,7 @@ 
         $this->checkMissionRestrictions($action);
       } else {
         // No - then just performing action
-        if($exception) {
+        if ($exception) {
           throw new ExceptionFleetInvalid($action, $action);
         } else {
           return $action;

includes/includes/flt_mission_recycle.php

Spacing +9 added lines, -9 removed lines

@@ -16,10 +16,10 @@ 
   $RecyclerCapacity = 0;
   $OtherFleetCapacity = 0;
 
-  foreach($objFleet->shipsIterator() as $unit_id => $unit) {
-    if(in_array($unit_id, classSupernova::$gc->groupFleet)) {
+  foreach ($objFleet->shipsIterator() as $unit_id => $unit) {
+    if (in_array($unit_id, classSupernova::$gc->groupFleet)) {
       $capacity = get_unit_param($unit_id, P_CAPACITY) * $unit->count;
-      if(in_array($unit_id, classSupernova::$gc->groupRecyclers)) {
+      if (in_array($unit_id, classSupernova::$gc->groupRecyclers)) {
         $RecyclerCapacity += $capacity;
       } else {
         $OtherFleetCapacity += $capacity;
@@ -28,33 +28,33 @@ 
   }
 
   $fleet_resources_amount = $objFleet->resourcesGetTotal();
-  if($fleet_resources_amount > $OtherFleetCapacity) {
+  if ($fleet_resources_amount > $OtherFleetCapacity) {
     // Если во флоте есть другие корабли И количество ресурсов больше, чем их ёмкость трюмов - значит часть этих ресурсов лежит в трюмах переработчиков
     // Уменьшаем ёмкость переработчиков на указанную величину
     $RecyclerCapacity -= ($fleet_resources_amount - $OtherFleetCapacity);
   }
 
   $resources_recycled = array();
-  if(($destination_planet["debris_metal"] + $destination_planet["debris_crystal"]) <= $RecyclerCapacity) {
+  if (($destination_planet["debris_metal"] + $destination_planet["debris_crystal"]) <= $RecyclerCapacity) {
     $resources_recycled[RES_METAL] = $destination_planet["debris_metal"];
     $resources_recycled[RES_CRYSTAL] = $destination_planet["debris_crystal"];
   } else {
-    if(($destination_planet["debris_metal"] > $RecyclerCapacity / 2) &&
+    if (($destination_planet["debris_metal"] > $RecyclerCapacity / 2) &&
       ($destination_planet["debris_crystal"] > $RecyclerCapacity / 2)
     ) {
       $resources_recycled[RES_METAL] = $RecyclerCapacity / 2;
       $resources_recycled[RES_CRYSTAL] = $RecyclerCapacity / 2;
     } else {
-      if($destination_planet["debris_metal"] > $destination_planet["debris_crystal"]) {
+      if ($destination_planet["debris_metal"] > $destination_planet["debris_crystal"]) {
         $resources_recycled[RES_CRYSTAL] = $destination_planet["debris_crystal"];
-        if($destination_planet["debris_metal"] > ($RecyclerCapacity - $resources_recycled[RES_CRYSTAL])) {
+        if ($destination_planet["debris_metal"] > ($RecyclerCapacity - $resources_recycled[RES_CRYSTAL])) {
           $resources_recycled[RES_METAL] = $RecyclerCapacity - $resources_recycled[RES_CRYSTAL];
         } else {
           $resources_recycled[RES_METAL] = $destination_planet["debris_metal"];
         }
       } else {
         $resources_recycled[RES_METAL] = $destination_planet["debris_metal"];
-        if($destination_planet["debris_crystal"] > ($RecyclerCapacity - $resources_recycled[RES_METAL])) {
+        if ($destination_planet["debris_crystal"] > ($RecyclerCapacity - $resources_recycled[RES_METAL])) {
           $resources_recycled[RES_CRYSTAL] = $RecyclerCapacity - $resources_recycled[RES_METAL];
         } else {
           $resources_recycled[RES_CRYSTAL] = $destination_planet["debris_crystal"];