DBStaticSurveyVote::db_survey_vote_insert() - Code Metrics - Inspection of "CODE-feat-41a7.14: DBStaticNews anc Co, DBStaticAC..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( 4aef09...b4179a )

by SuperNova.WS

created 2016-05-16 12:41 UTC

DBStaticSurveyVote::db_survey_vote_insert() A

↳ Parent: DBStaticSurveyVote

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
nc	1
nop	4
dl	0
loc	3
rs	10
c	1
b	0
f	0

<?php

class DBStaticSurveyVote {

  /**
   * @param $announce
   * @param $user
   *
   * @return array|bool|mysqli_result|null
   */
  public static function db_survey_get_vote($announce, $user) {
    return $survey_vote = doquery("SELECT `survey_vote_id` FROM `{{survey_votes}}` WHERE survey_parent_id = {$announce['survey_id']} AND survey_vote_user_id = {$user['id']} LIMIT 1;", true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
  }


  /**
   * @param $user
   * @param $survey_id
   * @param $survey_vote_id
   * @param $user_name_safe
   */
  public static function db_survey_vote_insert(&$user, $survey_id, $survey_vote_id, $user_name_safe) {
    doquery("INSERT INTO {{survey_votes}} SET `survey_parent_id` = {$survey_id}, `survey_parent_answer_id` = {$survey_vote_id}, `survey_vote_user_id` = {$user['id']}, `survey_vote_user_name` = '{$user_name_safe}';");
  }


  /**
   * @param $user
   * @param $survey_id
   *
   * @return array|bool|mysqli_result|null
   */
  public static function db_survey_vote_get(&$user, $survey_id) {
    $is_voted = doquery("SELECT `survey_vote_id` FROM `{{survey_votes}}` WHERE survey_parent_id = {$survey_id} AND survey_vote_user_id = {$user['id']} FOR UPDATE;", true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

    return $is_voted;
  }

}

1			<?php
2
3			class DBStaticSurveyVote {
4
5			/**
6			* @param $announce
7			* @param $user
8			*
9			* @return array\|bool\|mysqli_result\|null
10			*/
11			public static function db_survey_get_vote($announce, $user) {
12			return $survey_vote = doquery("SELECT `survey_vote_id` FROM `{{survey_votes}}` WHERE survey_parent_id = {$announce['survey_id']} AND survey_vote_user_id = {$user['id']} LIMIT 1;", true);
			0 ignored issues – show Documentation introduced 2016-03-23 18:43 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Unused Code introduced 2016-03-23 18:43 UTC by Report Bug Copy Issue Report `$survey_vote` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
13			}
14
15
16			/**
17			* @param $user
18			* @param $survey_id
19			* @param $survey_vote_id
20			* @param $user_name_safe
21			*/
22			public static function db_survey_vote_insert(&$user, $survey_id, $survey_vote_id, $user_name_safe) {
23			doquery("INSERT INTO {{survey_votes}} SET `survey_parent_id` = {$survey_id}, `survey_parent_answer_id` = {$survey_vote_id}, `survey_vote_user_id` = {$user['id']}, `survey_vote_user_name` = '{$user_name_safe}';");
24			}
25
26
27			/**
28			* @param $user
29			* @param $survey_id
30			*
31			* @return array\|bool\|mysqli_result\|null
32			*/
33			public static function db_survey_vote_get(&$user, $survey_id) {
34			$is_voted = doquery("SELECT `survey_vote_id` FROM `{{survey_votes}}` WHERE survey_parent_id = {$survey_id} AND survey_vote_user_id = {$user['id']} FOR UPDATE;", true);
			0 ignored issues – show Documentation introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35
36			return $is_voted;
37			}
38
39			}

supernova-ws / SuperNova

Push — work-fleets ( 4aef09...b4179a )

DBStaticSurveyVote::db_survey_vote_insert() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like