DBAL\ActiveRecordAbstract

Complexity

Total Complexity

86

Size/Duplication

Total Lines	616
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

39 Methods

Rating	Name	Duplication	Size	Complexity
	dbInsert()	0	1	?
	dbLastInsertId()	0	1	?
	dbUpdate()	0	1	?
A	db()	0	5	2
A	dbGetTableFields()	0	3	1
A	setDb()	0	3	1
A	tableName()	0	5	2
A	buildEvenEmpty()	0	6	1
A	build()	0	7	3
A	find()	0	12	3
A	findRecordFirst()	0	6	3
A	findRecordsAll()	0	3	2
A	findRecordsAllIndexed()	0	10	3
A	findFirst()	0	12	3
A	findAll()	0	3	1
A	findAllIndexed()	0	3	1
A	__construct()	0	3	1
A	acceptChanges()	0	4	1
A	reload()	0	18	3
A	insert()	0	21	4
A	update()	0	15	4
A	ptlArray()	0	8	2
A	__get()	0	3	2
A	shieldName()	0	7	2
A	__set()	0	4	1
A	getDefault()	0	8	2
A	calcTableName()	0	9	2
A	haveTranslationToProperty()	0	3	1
A	haveField()	0	3	1
B	getFieldName()	0	18	5
A	haveProperty()	0	3	1
A	getPropertyName()	0	9	3
B	translateNames()	0	18	6
C	fromRecordList()	0	22	8
A	dbPrepareQuery()	0	3	1
A	dbFetch()	0	3	1
B	defaultValues()	0	19	6
A	fromProperties()	0	7	2
A	fromFields()	0	3	1

<?php
/**
 * Created by Gorlum 12.07.2017 10:27
 */

namespace DBAL;

use Common\AccessLogged;
use Common\GlobalContainer;
use Exceptions\DbalFieldInvalidException;

abstract class ActiveRecordAbstract extends AccessLogged {
  const FIELDS_TO_PROPERTIES = true;
  const PROPERTIES_TO_FIELDS = false;

  const IGNORE_PREFIX = 'Record';
  const ID_PROPERTY_NAME = 'id';

  /**
   * @var \db_mysql $db
   */
  protected static $db;

  /**
   * Table name for current Active Record
   *
   * Can be predefined in class or calculated in run-time
   *
   * ALWAYS SHOULD BE OVERRIDEN IN CHILD CLASSES!
   *
   * @var string $_tableName
   */
  protected static $_tableName = '';
  /**
   * Autoincrement index field name in DB
   * Would be normalized to 'id' ($id class property)
   *
   * @var string $_primaryIndexField
   */
  protected static $_primaryIndexField = 'id';

  /**
   * Field name translations to property names
   *
   * @var string[] $_fieldsToProperties
   */
  protected static $_fieldsToProperties = [];
  /**
   * Property name translations to field names
   *
   * Cached structure
   *
   * @var string[] $_propertiesToFields
   */
  private static $_propertiesToFields = [];

The property $_propertiesToFields is not used and could be removed.

  // AR's service fields
  /**
   * Is this field - new field?
   *
   * @var bool $_isNew
   */
  protected $_isNew = true;

  // ABSTRACT METHODS - need override ==================================================================================

  /**
   * @return bool
   */
  abstract protected function dbInsert();

  /**
   * Asks DB for last insert ID
   *
   * @return int|string
   */
  abstract protected function dbLastInsertId();

  /**
   * @return bool
   */
  abstract protected function dbUpdate();


  /**
   * Get used DB
   *
   * @return \db_mysql
   */
  public static function db() {
    empty(static::$db) ? static::$db = \classSupernova::services()->db : false;

The property db does not exist on object<Common\GlobalContainer>. Since you implemented __set, maybe consider adding a @property annotation.

    return static::$db;
  }

  /**
   * @return array[]
   */
  protected static function dbGetTableFields() {
    return static::db()->schema()->getTableSchema(static::tableName())->fields;
  }

  public static function setDb(\db_mysql $db) {
    static::$db = $db;
  }

  /**
   * Get table name
   *
   * @return string
   */
  public static function tableName() {
    empty(static::$_tableName) ? static::$_tableName = static::calcTableName() : false;

    return static::$_tableName;
  }

  /**
   * Instate ActiveRecord from array of field values - even if it is empty
   *
   * @param array $fields List of field values [$propertyName => $propertyValue]

There is no parameter named $fields. Was it maybe removed?

   *
   * @return static
   */
  public static function buildEvenEmpty(array $properties = []) {
    $record = new static();
    $record->fromProperties($properties);

    return $record;
  }

  /**
   * Instate ActiveRecord from array of field values
   *
   * @param array $fields List of field values [$propertyName => $propertyValue]

There is no parameter named $fields. Was it maybe removed?

   *
   * @return static|bool
   */
  public static function build(array $properties = []) {
    if (!is_array($properties) || empty($properties)) {
      return false;
    }

    return static::buildEvenEmpty($properties);
  }

  /**
   * Finds records by property - equivalent of SELECT ... WHERE ... AND ...
   *
   * @param array|mixed $propertyFilter - ID of record to find OR [$propertyName => $propertyValue]. Pass [] to find all records in table
   *
   * @return bool|\mysqli_result
   */
  public static function find($propertyFilter) {
    if (!is_array($propertyFilter)) {
      $propertyFilter = [self::ID_PROPERTY_NAME => $propertyFilter];
    }

    $dbq = static::dbPrepareQuery();
    if (!empty($propertyFilter)) {
      $dbq->setWhereArray(static::translateNames($propertyFilter, static::PROPERTIES_TO_FIELDS));
    }

    return $dbq->doSelect();
  }

  /**
   * Gets first record by $where
   *
   * @param array|mixed $propertyFilter - ID of record to find OR [$propertyName => $propertyValue]. Pass [] to find all records in table
   *
   * @return string[] - [$field_name => $field_value]
   */
  public static function findRecordFirst($propertyFilter) {
    $result = empty($mysqliResult = static::find($propertyFilter)) ? [] : $mysqliResult->fetch_assoc();

    // Secondary check - for fetch_assoc() result
    return empty($result) ? [] : $result;
  }

  /**
   * Gets all records by $where
   *
   * @param array|mixed $propertyFilter - ID of record to find OR [$property_name => $property_value]
   *
   * @return string[][] - [(int) => [$field_name => $field_value]]
   */
  public static function findRecordsAll($propertyFilter) {
    return empty($mysqliResult = static::find($propertyFilter)) ? [] : $mysqliResult->fetch_all(MYSQLI_ASSOC);
  }

  /**
   * Gets all records by $where - array indexes is a record IDs
   *
   * @param array|mixed $propertyFilter - ID of record to find OR [$property_name => $property_value]
   *
   * @return string[][] - [$record_db_id => [$field_name => $field_value]]
   */
  public static function findRecordsAllIndexed($propertyFilter) {
    $result = [];
    if (!empty($mysqliResult = static::find($propertyFilter))) {
      while ($row = $mysqliResult->fetch_assoc()) {
        $result[$row[static::$_primaryIndexField]] = $row;
      }
    }

    return $result;
  }

  /**
   * Gets first ActiveRecord by $where
   *
   * @param array|mixed $propertyFilter - ID of record to find OR [$propertyName => $propertyValue]. Pass [] to find all records in table
   *
   * @return static|bool
   */
  public static function findFirst($propertyFilter) {
    $record = false;
    $fields = static::findRecordFirst($propertyFilter);
    if (!empty($fields)) {
      $record = static::build(static::translateNames($fields, self::FIELDS_TO_PROPERTIES));
      if (is_object($record)) {
        $record->_isNew = false;
      }
    }

    return $record;
  }

  /**
   * Gets all ActiveRecords by $where
   *
   * @param array|mixed $propertyFilter - ID of record to find OR [$propertyName => $propertyValue]. Pass [] to find all records in table
   *
   * @return array|static[] - [(int) => static]
   */
  public static function findAll($propertyFilter) {
    return static::fromRecordList(static::findRecordsAll($propertyFilter));
  }

  /**
   * Gets all ActiveRecords by $where - array indexed by record IDs
   *
   * @param array|mixed $propertyFilter - ID of record to find OR [$propertyName => $propertyValue]. Pass [] to find all records in table
   *
   * @return array|static[] - [$record_db_id => static]
   */
  public static function findAllIndexed($propertyFilter) {
    return static::fromRecordList(static::findRecordsAllIndexed($propertyFilter));
  }


  /**
   * ActiveRecord constructor.
   *
   * @param GlobalContainer|null $services
   */
  public function __construct(GlobalContainer $services = null) {
    parent::__construct($services);
  }

  public function acceptChanges() {
    parent::acceptChanges();
    $this->_isNew = empty($this->id);

The property id does not exist on object<DBAL\ActiveRecordAbstract>. Since you implemented __get, maybe consider adding a @property annotation.

  }

  /**
   * Reload current record from ID
   *
   * @return bool
   */
  public function reload() {
    $recordId = $this->id;

The property id does not exist on object<DBAL\ActiveRecordAbstract>. Since you implemented __set, maybe consider adding a @property annotation.

    if (empty($recordId)) {
      return false;
    }

    $this->acceptChanges();

    $fields = static::findRecordFirst($recordId);
    if (empty($fields)) {
      return false;
    }

    $this->fromFields($fields);
    $this->_isNew = false;

    return true;
  }

  /**
   * @return array|bool|\mysqli_result|null
   */
  // TODO - do a check that all fields present in stored data. I.e. no empty fields with no defaults
  public function insert() {
    if ($this->isEmpty()) {
      return false;
    }
    if (!$this->_isNew) {
      return false;
    }

    $this->defaultValues();

    if (!$this->dbInsert()) {
      return false;
    }

    $this->id = $this->dbLastInsertId();

The property id does not exist on object<DBAL\ActiveRecordAbstract>. Since you implemented __set, maybe consider adding a @property annotation.

    $this->acceptChanges();
    $this->_isNew = false;

//    return $this->reload();

67% of this comment could be valid code. Did you maybe forget this after debugging?

    return true;
  }

  /**
   * @return array|bool|\mysqli_result|null
   */
  public function update() {
    if (empty($this->_changes) && empty($this->_deltas)) {
      return true;
    }

    $this->defaultValues();

    if (!$this->dbUpdate()) {
      return false;
    }

    $this->acceptChanges();

    return true;
  }

  /**
   * Normalize array
   *
   * Basically - uppercase all field names to make it use in PTL
   * Can be override by descendants to make more convinient, clear and robust indexes
   *
   * @return array
   */
  public function ptlArray() {
    $result = [];
    foreach ($this->values as $key => $value) {
      $result[strtoupper(\HelperString::camelToUnderscore($key))] = $value;
    }

    return $result;
  }


  /**
   * Returns default value if original value not set
   *
   * @param string $propertyName
   *
   * @return mixed
   */
  public function __get($propertyName) {
    return $this->__isset($propertyName) ? parent::__get($propertyName) : $this->getDefault($propertyName);
  }

  /**
   * Protects object from setting non-existing property
   *
   * @param string $propertyName
   */
  protected function shieldName($propertyName) {
    if (!self::haveProperty($propertyName)) {
      throw new DbalFieldInvalidException(sprintf(
        '{{{ Свойство \'%1$s\' не существует в ActiveRecord \'%2$s\' }}}', $propertyName, get_called_class()
      ));
    }
  }

  public function __set($propertyName, $value) {
    $this->shieldName($propertyName);
    parent::__set($propertyName, $value);
  }

  /**
   * Get default value for field
   *
   * @param string $propertyName
   *
   * @return mixed
   */
  public function getDefault($propertyName) {
    $fieldName = self::getFieldName($propertyName);

    return
      isset(static::dbGetTableFields()[$fieldName]['Default'])
        ? static::dbGetTableFields()[$fieldName]['Default']
        : null;
  }

  /**
   * Calculate table name by class name and fills internal property
   *
   * Namespaces does not count - only class name taken into account
   * Class name converted from CamelCase to underscore_name
   * Prefix "Record" is ignored - can be override
   *
   * Examples:
   * Class \Namespace\ClassName will map to table `class_name`
   * Class \NameSpace\RecordLongName will map to table `long_name`
   *
   * Can be overriden to provide different name
   *
   * @return string - table name in DB
   *
   */
  protected static function calcTableName() {
    $temp = explode('\\', get_called_class());
    $className = end($temp);
    if (strpos($className, static::IGNORE_PREFIX) === 0) {
      $className = substr($className, strlen(static::IGNORE_PREFIX));
    }

    return \HelperString::camelToUnderscore($className);
  }

  /**
   * Is there translation for this field name to property name
   *
   * @param string $fieldName
   *
   * @return bool
   */
  protected static function haveTranslationToProperty($fieldName) {
    return !empty(static::$_fieldsToProperties[$fieldName]);
  }

  /**
   * Check if field exists
   *
   * @param string $fieldName
   *
   * @return bool
   */
  protected static function haveField($fieldName) {
    return !empty(static::dbGetTableFields()[$fieldName]);
  }

  /**
   * Returns field name by property name
   *
   * @param string $propertyName
   *
   * @return string Field name for property or '' if not field
   */
  protected static function getFieldName($propertyName) {
    $fieldName = array_search($propertyName, static::$_fieldsToProperties);
    if (
      // No translation found for property name
      !$fieldName

The expression $fieldName of type false|integer is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

      &&
      // AND Property name is not among translatable field names
      !static::haveTranslationToProperty($propertyName)
      &&
      // AND field name exists
      static::haveField($propertyName)
    ) {
      // Returning property name as field name
      $fieldName = $propertyName;
    }

    return $fieldName === false ? '' : $fieldName;
  }

  /**
   * Does property exists?
   *
   * @param string $propertyName
   *
   * @return bool
   */
  protected static function haveProperty($propertyName) {
    return !empty(static::getFieldName($propertyName));
  }

  /**
   * Translate field name to property name
   *
   * @param string $fieldName
   *
   * @return string Property name for field if field exists or '' otherwise
   */
  protected static function getPropertyName($fieldName) {
    return
      // If there translation of field name = returning translation result
      static::haveTranslationToProperty($fieldName)
        ? static::$_fieldsToProperties[$fieldName]
        // No, there is no translation
        // Is field exists in table? If yes - returning field name as property name
        : (static::haveField($fieldName) ? $fieldName : '');
  }

  /**
   * Converts property-indexed value array to field-indexed via translation table
   *
   * @param array $names
   * @param bool  $fieldToProperties - translation direction:
   *    - self::FIELDS_TO_PROPERTIES - field to props.
   *    - self::PROPERTIES_TO_FIELDS - prop to fields
   *
   * @return array
   */
  // TODO - Throw exception on incorrect field
  protected static function translateNames(array $names, $fieldToProperties = self::FIELDS_TO_PROPERTIES) {
    $translations = $fieldToProperties == self::FIELDS_TO_PROPERTIES ? static::$_fieldsToProperties : array_flip(static::$_fieldsToProperties);

    $result = [];
    foreach ($names as $name => $value) {
      $exists = $fieldToProperties == self::FIELDS_TO_PROPERTIES ? static::haveField($name) : static::haveProperty($name);
      if (!$exists) {
        continue;
      }

      if (!empty($translations[$name])) {
        $name = $translations[$name];
      }
      $result[$name] = $value;
    }

    return $result;
  }

  /**
   * Makes array of object from field/property list array
   *
   * Empty records and non-records (non-subarrays) are ignored
   * Function maintains record indexes
   *
   * @param array $records - array of DB records [(int) => [$name => $value]]
   * @param bool  $fieldToProperties - should names be translated (true - for field records, false - for property records)
   *
   * @return array|static[]
   */
  protected static function fromRecordList($records, $fieldToProperties = self::FIELDS_TO_PROPERTIES) {
    $result = [];
    if (is_array($records) && !empty($records)) {
      foreach ($records as $key => $recordArray) {
        if (!is_array($recordArray) || empty($recordArray)) {
          continue;
        }

        $fieldToProperties === self::FIELDS_TO_PROPERTIES
          ? $recordArray = static::translateNames($recordArray, self::FIELDS_TO_PROPERTIES)
          : false;

        $theRecord = static::build($recordArray);
        if (is_object($theRecord)) {
          $theRecord->_isNew = false;
          $result[$key] = $theRecord;
        }
      }
    }

    return $result;
  }

  /**
   * Prepares DbQuery object for further operations
   *
   * @return DbQuery
   */
  protected static function dbPrepareQuery() {
    return DbQuery::build(static::db())->setTable(static::tableName());
  }

  protected static function dbFetch(\mysqli_result $mysqliResult) {
    return $mysqliResult->fetch_assoc();
  }


  protected function defaultValues() {
    foreach (static::dbGetTableFields() as $fieldName => $fieldData) {
      if (array_key_exists($propertyName = static::getPropertyName($fieldName), $this->values)) {
        continue;
      }

      // Skipping auto increment fields
      if (strpos($fieldData['Extra'], SN_SQL_EXTRA_AUTO_INCREMENT) !== false) {
        continue;
      }

      if ($fieldData['Type'] == SN_SQL_TYPE_NAME_TIMESTAMP && $fieldData['Default'] == SN_SQL_DEFAULT_CURRENT_TIMESTAMP) {
        $this->__set($propertyName, SN_TIME_SQL);
        continue;
      }

      $this->__set($propertyName, $fieldData['Default']);
    }
  }

  /**
   * Set AR properties from array of PROPERTIES
   *
   * DOES NOT override existing values
   * DOES set default values for empty fields
   *
   * @param array $properties
   */
  protected function fromProperties(array $properties) {
    foreach ($properties as $name => $value) {
      $this->__set($name, $value);
    }

    $this->defaultValues();
  }

  /**
   * Set AR properties from array of FIELDS
   *
   * DOES NOT override existing values
   * DOES set default values for empty fields
   *
   * @param array $fields List of field values [$fieldName => $fieldValue]
   */
  protected function fromFields(array $fields) {
    $this->fromProperties(static::translateNames($fields, self::FIELDS_TO_PROPERTIES));
  }

}