db_mysql

Complexity

Total Complexity

78

Size/Duplication

Total Lines	396
Duplicated Lines	3.54 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

28 Methods

Rating	Name	Duplication	Size	Complexity
A	driver_connect()	0	13	3
A	db_disconnect()	0	8	2
A	__construct()	0	5	1
A	schema()	0	7	2
A	load_db_settings()	0	7	1
D	sn_db_connect()	0	28	9
F	doquery()	0	51	12
A	dbqSelectAndFetch()	0	3	1
B	security_watch_user_queries()	0	20	7
C	security_query_check_bad_words()	0	53	17
A	mysql_get_table_list()	0	3	1
A	mysql_get_innodb_status()	0	3	1
A	mysql_get_fields()	0	10	2
A	mysql_get_indexes()	0	19	3
B	mysql_get_constraints()	0	24	3
A	db_sql_query()	7	7	1
A	db_fetch()	7	7	1
A	db_fetch_row()	0	3	1
A	db_escape()	0	3	1
A	driver_disconnect()	0	3	1
A	db_error()	0	3	1
A	db_insert_id()	0	3	1
A	db_num_rows()	0	3	1
A	db_affected_rows()	0	3	1
A	db_get_client_info()	0	3	1
A	db_get_server_info()	0	3	1
A	db_get_host_info()	0	3	1
A	db_get_server_stat()	0	3	1

<?php

use Common\GlobalContainer;

/**
 * User: Gorlum
 * Date: 01.09.2015
 * Time: 15:58
 */
class db_mysql {
  const DB_MYSQL_TRANSACTION_SERIALIZABLE = 'SERIALIZABLE';
  const DB_MYSQL_TRANSACTION_REPEATABLE_READ = 'REPEATABLE READ';
  const DB_MYSQL_TRANSACTION_READ_COMMITTED = 'READ COMMITTED';
  const DB_MYSQL_TRANSACTION_READ_UNCOMMITTED = 'READ UNCOMMITTED';

  /**
   * Статус соеднения с MySQL
   *
   * @var bool
   */
  public $connected = false;
  /**
   * Префикс названий таблиц в БД
   *
   * @var string
   */
  public $db_prefix = '';
  /**
   * Настройки БД
   *
   * @var array
   */
  protected $dbsettings = array();
  /**
   * Драйвер для прямого обращения к MySQL
   *
   * @var db_mysql_v5 $driver
   */
  public $driver = null;

  /**
   * Общее время запросов
   *
   * @var float $time_mysql_total
   */
  public $time_mysql_total = 0.0;

  /**
   * DB schemes
   *
   * @var \DBAL\Schema|null $schema
   */
  protected static $schema = null;

  /**
   * db_mysql constructor.
   *
   * @param GlobalContainer $gc
   */
  public function __construct($gc) {

The parameter $gc is not used and could be removed.

//    $this->transaction = new \DBAL\DbTransaction($gc, $this);

52% of this comment could be valid code. Did you maybe forget this after debugging?

//    $this->snCache = new $gc->snCacheClass($gc, $this);
//    $this->operator = new DbRowDirectOperator($this);
  }

  public function schema() {
    if(!isset(self::$schema)) {
      self::$schema = new \DBAL\Schema($this);
    }

    return self::$schema;
  }

  function load_db_settings() {

It is generally recommended to explicitly declare the visibility for methods.

    $dbsettings = array();

    require(SN_ROOT_PHYSICAL . "config" . DOT_PHP_EX);

    $this->dbsettings = $dbsettings;
  }

  function sn_db_connect($external_db_settings = null) {

It is generally recommended to explicitly declare the visibility for methods.

    $this->db_disconnect();

    if(!empty($external_db_settings) && is_array($external_db_settings)) {
      $this->dbsettings = $external_db_settings;
    }

    if(empty($this->dbsettings)) {
      $this->load_db_settings();
    }

    // TODO - фатальные (?) ошибки на каждом шагу. Хотя - скорее Эксепшны
    if(!empty($this->dbsettings)) {
      $driver_name = empty($this->dbsettings['sn_driver']) ? 'db_mysql_v5' : $this->dbsettings['sn_driver'];
      $this->driver = new $driver_name();
      $this->db_prefix = $this->dbsettings['prefix'];

      $this->connected = $this->connected || $this->driver_connect();

      if($this->connected && empty($this->schema()->getSnTables())) {
        die('DB error - cannot find any table. Halting...');
      }
    } else {
      $this->connected = false;
    }

    return $this->connected;
  }

  function driver_connect() {

It is generally recommended to explicitly declare the visibility for methods.

    global $debug;

    if(!is_object($this->driver)) {
      $debug->error_fatal('DB Error - No driver for MySQL found!');
    }

    if(!method_exists($this->driver, 'mysql_connect')) {
      $debug->error_fatal('DB Error - WRONG MySQL driver!');
    }

    return $this->driver->mysql_connect($this->dbsettings);
  }

  function db_disconnect() {

It is generally recommended to explicitly declare the visibility for methods.

    if($this->connected) {
      $this->connected = !$this->driver_disconnect();
      $this->connected = false;
    }

    return !$this->connected;
  }

  function doquery($query, $table = '', $fetch = false, $skip_query_check = false) {

It is generally recommended to explicitly declare the visibility for methods.

    global $numqueries, $debug, $sn_cache, $config;

    if(!is_string($table)) {
      $fetch = $table;
    }

    if(!$this->connected) {
      $this->sn_db_connect();
    }

    $query = trim($query);
    $this->security_watch_user_queries($query);
    $skip_query_check or $this->security_query_check_bad_words($query);

    $sql = $query;
    if(strpos($sql, '{{') !== false) {
      foreach($this->schema()->getSnTables() as $tableName) {

The expression $this->schema()->getSnTables() of type null|array<integer,string> is not guaranteed to be traversable. How about adding an additional type check?

        $sql = str_replace("{{{$tableName}}}", $this->db_prefix . $tableName, $sql);
      }
    }

    if($config->debug) {
      $numqueries++;
      $arr = debug_backtrace();
      $file = end(explode('/',$arr[0]['file']));

explode('/', $arr[0]['file']) cannot be passed to end() as the parameter $array expects a reference.

      $line = $arr[0]['line'];
      $debug->add("<tr><th>Query $numqueries: </th><th>$query</th><th>$file($line)</th><th>$table</th><th>$fetch</th></tr>");
    }

    if(defined('DEBUG_SQL_COMMENT')) {
      $backtrace = debug_backtrace();
      $sql_comment = $debug->compact_backtrace($backtrace, defined('DEBUG_SQL_COMMENT_LONG'));

      $sql_commented = '/* ' . implode("<br />", $sql_comment) . '<br /> */ ' . preg_replace("/\s+/", ' ', $sql);
      if(defined('DEBUG_SQL_ONLINE')) {
        $debug->warning($sql_commented, 'SQL Debug', LOG_DEBUG_SQL);
      }

      if(defined('DEBUG_SQL_ERROR')) {
        array_unshift($sql_comment, preg_replace("/\s+/", ' ', $sql));
        $debug->add_to_array($sql_comment);
        // $debug->add_to_array($sql_comment . preg_replace("/\s+/", ' ', $sql));

62% of this comment could be valid code. Did you maybe forget this after debugging?

      }
      $sql = $sql_commented;
    }

    $sqlquery = $this->db_sql_query($sql) or $debug->error(db_error()."<br />$sql<br />",'SQL Error');

    return $fetch ? $this->db_fetch($sqlquery) : $sqlquery;
  }

  /**
   * @param \DBAL\DbQuery $dbQuery
   *
   * @return array|null
   */
  public function dbqSelectAndFetch(\DBAL\DbQuery $dbQuery) {
    return $this->doquery($dbQuery->select(), true);

true is of type boolean, but the function expects a string.

  }


  function security_watch_user_queries($query) {

It is generally recommended to explicitly declare the visibility for methods.

    // TODO Заменить это на новый логгер
    global $config, $is_watching, $user, $debug;

    if(!$is_watching && $config->game_watchlist_array && in_array($user['id'], $config->game_watchlist_array))
    {
      if(!preg_match('/^(select|commit|rollback|start transaction)/i', $query)) {
        $is_watching = true;
        $msg = "\$query = \"{$query}\"\n\r";
        if(!empty($_POST)) {
          $msg .= "\n\r" . dump($_POST,'$_POST');
        }
        if(!empty($_GET)) {
          $msg .= "\n\r" . dump($_GET,'$_GET');
        }
        $debug->warning($msg, "Watching user {$user['id']}", 399, array('base_dump' => true));
        $is_watching = false;
      }
    }
  }


  function security_query_check_bad_words($query) {

It is generally recommended to explicitly declare the visibility for methods.

    global $user, $dm_change_legit, $mm_change_legit;

    switch(true) {
      case stripos($query, 'RUNCATE TABL') != false:

It seems like you are loosely comparing stripos($query, 'RUNCATE TABL') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

      case stripos($query, 'ROP TABL') != false:

It seems like you are loosely comparing stripos($query, 'ROP TABL') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

      case stripos($query, 'ENAME TABL') != false:

It seems like you are loosely comparing stripos($query, 'ENAME TABL') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

      case stripos($query, 'REATE DATABAS') != false:

It seems like you are loosely comparing stripos($query, 'REATE DATABAS') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

      case stripos($query, 'REATE TABL') != false:

It seems like you are loosely comparing stripos($query, 'REATE TABL') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

      case stripos($query, 'ET PASSWOR') != false:

It seems like you are loosely comparing stripos($query, 'ET PASSWOR') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

      case stripos($query, 'EOAD DAT') != false:

It seems like you are loosely comparing stripos($query, 'EOAD DAT') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

      case stripos($query, 'RPG_POINTS') != false && stripos(trim($query), 'UPDATE ') === 0 && !$dm_change_legit:

It seems like you are loosely comparing stripos($query, 'RPG_POINTS') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

      case stripos($query, 'METAMATTER') != false && stripos(trim($query), 'UPDATE ') === 0 && !$mm_change_legit:

It seems like you are loosely comparing stripos($query, 'METAMATTER') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

      case stripos($query, 'AUTHLEVEL') != false && $user['authlevel'] < 3 && stripos($query, 'SELECT') !== 0:

It seems like you are loosely comparing stripos($query, 'AUTHLEVEL') of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

        $report  = "Hacking attempt (".date("d.m.Y H:i:s")." - [".time()."]):\n";
        $report .= ">Database Inforamation\n";
        $report .= "\tID - ".$user['id']."\n";
        $report .= "\tUser - ".$user['username']."\n";
        $report .= "\tAuth level - ".$user['authlevel']."\n";
        $report .= "\tAdmin Notes - ".$user['adminNotes']."\n";
        $report .= "\tCurrent Planet - ".$user['current_planet']."\n";
        $report .= "\tUser IP - ".$user['user_lastip']."\n";
        $report .= "\tUser IP at Reg - ".$user['ip_at_reg']."\n";
        $report .= "\tUser Agent- ".$_SERVER['HTTP_USER_AGENT']."\n";
        $report .= "\tCurrent Page - ".$user['current_page']."\n";
        $report .= "\tRegister Time - ".$user['register_time']."\n";
        $report .= "\n";

        $report .= ">Query Information\n";
        $report .= "\tQuery - ".$query."\n";
        $report .= "\n";

        $report .= ">\$_SERVER Information\n";
        $report .= "\tIP - ".$_SERVER['REMOTE_ADDR']."\n";
        $report .= "\tHost Name - ".$_SERVER['HTTP_HOST']."\n";
        $report .= "\tUser Agent - ".$_SERVER['HTTP_USER_AGENT']."\n";
        $report .= "\tRequest Method - ".$_SERVER['REQUEST_METHOD']."\n";
        $report .= "\tCame From - ".$_SERVER['HTTP_REFERER']."\n";
        $report .= "\tPage is - ".$_SERVER['SCRIPT_NAME']."\n";
        $report .= "\tUses Port - ".$_SERVER['REMOTE_PORT']."\n";
        $report .= "\tServer Protocol - ".$_SERVER['SERVER_PROTOCOL']."\n";

        $report .= "\n--------------------------------------------------------------------------------------------------\n";

        $fp = fopen(SN_ROOT_PHYSICAL . 'badqrys.txt', 'a');
        fwrite($fp, $report);

        fclose($fp);

        $message = 'Привет, я не знаю то, что Вы пробовали сделать, но команда, которую Вы только послали базе данных, не выглядела очень дружественной и она была заблокированна.<br /><br />Ваш IP, и другие данные переданны администрации сервера. Удачи!.';
        die($message);
        break;

break; does not seem to be reachable.

    }
  }

  function mysql_get_table_list() {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->db_sql_query('SHOW TABLES;');
  }
  function mysql_get_innodb_status() {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->db_sql_query('SHOW ENGINE INNODB STATUS;');
  }

  /**
   * @param string $tableName_unsafe
   *
   * @return array[]
   */
  public function mysql_get_fields($tableName_unsafe) {
    $result = [];

    $prefixedTableName_safe = $this->db_escape($this->db_prefix . $tableName_unsafe);
    $q1 = $this->db_sql_query("SHOW FULL COLUMNS FROM `{$prefixedTableName_safe}`;");
    while($r1 = db_fetch($q1)) {
      $result[$r1['Field']] = $r1;
    }
    return $result;
  }

  /**
   * @param string $tableName_unsafe
   *
   * @return array[]
   */
  public function mysql_get_indexes($tableName_unsafe) {
    $result = [];

    $prefixedTableName_safe = $this->db_escape($this->db_prefix . $tableName_unsafe);
    $q1 = $this->db_sql_query("SHOW INDEX FROM {$prefixedTableName_safe};");
    while($r1 = db_fetch($q1)) {
      $indexName = $r1['Key_name'];

      $result[$indexName]['name'] = $r1['Key_name'];
      $result[$indexName]['signature'][] = $r1['Column_name'];
      $result[$indexName]['fields'][$r1['Column_name']] = $r1;
    }

    foreach ($result as &$indexDescription) {
      $indexDescription['signature'] = implode(',', $indexDescription['signature']);
    }

    return $result;
  }

  /**
   * @param string $tableName_unsafe
   *
   * @return array[]
   */
  public function mysql_get_constraints($tableName_unsafe) {
    $result = [];

    $prefixedTableName_safe = $this->db_escape($this->db_prefix . $tableName_unsafe);

    $q1 = $this->db_sql_query("SELECT * FROM `information_schema`.`KEY_COLUMN_USAGE` WHERE `TABLE_SCHEMA` = '" . db_escape(classSupernova::$db_name). "' AND `TABLE_NAME` = '{$prefixedTableName_safe}' AND `REFERENCED_TABLE_NAME` IS NOT NULL;");
    while($r1 = db_fetch($q1)) {
      $indexName = $r1['CONSTRAINT_NAME'];

      $table_referenced = str_replace($this->db_prefix, '', $r1['REFERENCED_TABLE_NAME']);

      $result[$indexName]['name'] = $indexName;
      $result[$indexName]['signature'][] = "{$r1['COLUMN_NAME']}=>{$table_referenced}.{$r1['REFERENCED_COLUMN_NAME']}";
      $r1['REFERENCED_TABLE_NAME'] = $table_referenced;
      $r1['TABLE_NAME'] = $tableName_unsafe;
      $result[$indexName]['fields'][$r1['COLUMN_NAME']] = $r1;
    }

    foreach ($result as &$constraint) {
      $constraint['signature'] = implode(',', $constraint['signature']);
    }

    return $result;
  }


  function db_sql_query($query_string) {

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    $microtime = microtime(true);
    $result = $this->driver->mysql_query($query_string);
    $this->time_mysql_total += microtime(true) - $microtime;
    return $result;
//    return $this->driver->mysql_query($query_string);

67% of this comment could be valid code. Did you maybe forget this after debugging?

  }

  /**
   * @param mysqli_result $query_result
   *
   * @return array|null
   */
  function db_fetch(&$query_result) {

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    $microtime = microtime(true);
    $result = $this->driver->mysql_fetch_assoc($query_result);
    $this->time_mysql_total += microtime(true) - $microtime;
    return $result;
//    return $this->driver->mysql_fetch_assoc($query);

67% of this comment could be valid code. Did you maybe forget this after debugging?

  }
  function db_fetch_row(&$query) {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->driver->mysql_fetch_row($query);
  }
  function db_escape($unescaped_string) {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->driver->mysql_real_escape_string($unescaped_string);
  }
  function driver_disconnect() {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->driver->mysql_close_link();
  }
  function db_error() {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->driver->mysql_error();
  }
  function db_insert_id() {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->driver->mysql_insert_id();
  }
  function db_num_rows(&$result) {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->driver->mysql_num_rows($result);
  }
  function db_affected_rows() {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->driver->mysql_affected_rows();
  }
  function db_get_client_info() {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->driver->mysql_get_client_info();
  }
  function db_get_server_info() {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->driver->mysql_get_server_info();
  }
  function db_get_host_info() {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->driver->mysql_get_host_info();
  }
  function db_get_server_stat() {

It is generally recommended to explicitly declare the visibility for methods.

    return $this->driver->mysql_stat();
  }

}