db_user_list_admin_multiaccounts() - Code Metrics - Inspection of "FLEET-fix-46a163: Fixed error when fleet arrived/r..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed
Push — trunk ( 132e87...b3f953 )

by SuperNova.WS
created 2025-05-06 18:14 UTC
db_user_list_admin_multiaccounts() A

↳ Parent: Project
Complexity

Conditions	1
Paths	1
Size

Total Lines	2
Code Lines	1
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	2
rs	10
c	0
b	0
f	0
<?php
/** @noinspection PhpDeprecationInspection */
/** @noinspection SqlResolve */
/** @noinspection PhpUnnecessaryCurlyVarSyntaxInspection */

use Player\PlayerStatic;

/**
 * Возвращает информацию о пользователе по его ID
 *
 * @param int   $user_id_unsafe  ID пользователя
 * @param bool  $for_update      @deprecated
 * @param ?bool $player          Признак выбора записи пользователь типа "игрок"
 *                               <p>null - Можно выбрать запись любого типа</p>
 *                               <p>true - Выбирается только запись типа "игрок"</p>
 *                               <p>false - Выбирается только запись типа "альянс"</p>
 *
 * @return array|false
 *    <p>false - Нет записи с указанным ID и $player</p>
 *    <p>array - запись типа $user</p>
 * @deprecated
 * @noinspection PhpUnusedParameterInspection
 */
function db_user_by_id($user_id_unsafe, $for_update = false, $player = null) {
  $user  = PlayerStatic::dbSelectOne("SELECT * FROM {{users}} WHERE `id` = " . idval($user_id_unsafe));
  $user  = /** @scrutinizer ignore-deprecated */ PlayerStatic::dbSelectOne("SELECT * FROM {{users}} WHERE `id` = " . idval($user_id_unsafe));

  return (is_array($user) &&
    (
      $player === null
      ||
      ($player === true && !$user['user_as_ally'])
      ||
      ($player === false && $user['user_as_ally'])
    )) ? $user : false;
}

/**
 * @deprecated
 */
function db_user_by_username($username_unsafe, $like = false) {
  if (!($username_unsafe = trim($username_unsafe))) {
    return null;
  }

  // тут на самом деле strtolower() лишняя, но пусть будет
  $username_safe = SN::$db->db_escape($like ? strtolower($username_unsafe) : $username_unsafe);

  // Вытаскиваем запись
  $operand = $like ? 'LIKE' : '=';

   $user  = PlayerStatic::dbSelectOne("SELECT * FROM {{users}} WHERE `username` {$operand} '{$username_safe}'");
   $user  = /** @scrutinizer ignore-deprecated */ PlayerStatic::dbSelectOne("SELECT * FROM {{users}} WHERE `username` {$operand} '{$username_safe}'");

  return $user;
}

/**
 * @param        $playerIdOrName
 * @param null   $player

 * @param bool   $like
 *
 * @return array|false
 * @deprecated
 */
function dbPlayerByIdOrName($playerIdOrName, $player = null, $like = false) {
  $row = db_user_by_id($playerIdOrName, false, $player);
  $row = /** @scrutinizer ignore-deprecated */ db_user_by_id($playerIdOrName, false, $player);
  if (empty($row['id'])) {
    $row = db_user_by_username($playerIdOrName, $like);
    $row = /** @scrutinizer ignore-deprecated */ db_user_by_username($playerIdOrName, $like);
  }

  return !is_array($row) || empty($row['id']) ? false : $row;
}

/**
 * @deprecated
 * @noinspection PhpUnusedParameterInspection
 */
function db_user_list($filter = '', $for_update = false, $fields = '*') {
  return SN::db_get_record_list(LOC_USER, $filter);
}


/**
 * @deprecated
 */
function db_user_set_by_id($user_id, $set) {
  return SN::db_upd_record_by_id(LOC_USER, $user_id, $set);
}


/**
 * @deprecated
 */
function db_user_list_set_mass_mail($owners_list, $set) {
  return SN::db_upd_record_list(LOC_USER, !empty($owners_list) ? '`id` IN (' . implode(',', $owners_list) . ');' : '', $set);
}

/**
 * @deprecated
 */
function db_user_list_set_by_ally_and_rank($ally_id, $ally_rank_id, $set) {
  return SN::db_upd_record_list(LOC_USER, "`ally_id`={$ally_id} AND `ally_rank_id` >= {$ally_rank_id}", $set);
}

/**
 * @deprecated
 */
function db_user_list_set_ally_deprecated_convert_ranks($ally_id, $i, $rank_id) {
  return SN::db_upd_record_list(LOC_USER, "`ally_id` = {$ally_id} AND `ally_rank_id`={$rank_id}", "`ally_rank_id` = {$i}");
}


function db_user_change_active_planet_to_capital($user_id, $captured_planet) {
  return doquery("UPDATE {{users}} SET `current_planet` = `id_planet` WHERE `id` = {$user_id} AND `current_planet` = {$captured_planet};");
  return /** @scrutinizer ignore-deprecated */ doquery("UPDATE {{users}} SET `current_planet` = `id_planet` WHERE `id` = {$user_id} AND `current_planet` = {$captured_planet};");
}


// TODO Внести это всё в supernova для HyperNova
/**
 * @return string
 * @deprecated
 * TODO - это вообще-то надо хранить в конфигурации
 */
function db_user_last_registered_username() {
  $user = PlayerStatic::dbSelectOne('SELECT * FROM `{{users}}` WHERE `user_as_ally` IS NULL ORDER BY `id` DESC');
  $user = /** @scrutinizer ignore-deprecated */ PlayerStatic::dbSelectOne('SELECT * FROM `{{users}}` WHERE `user_as_ally` IS NULL ORDER BY `id` DESC');

  return isset($user['username']) ? $user['username'] : '';
}

function db_user_count($online = false) {
  $result = doquery('SELECT COUNT(`id`) AS user_count FROM `{{users}}` WHERE `user_as_ally` IS NULL AND `user_bot` = ' . USER_BOT_PLAYER . ($online ? ' AND onlinetime > ' . (SN_TIME_NOW - SN::$config->game_users_online_timeout) : ''), true);
  $result = /** @scrutinizer ignore-deprecated */ doquery('SELECT COUNT(`id`) AS user_count FROM `{{users}}` WHERE `user_as_ally` IS NULL AND `user_bot` = ' . USER_BOT_PLAYER . ($online ? ' AND onlinetime > ' . (SN_TIME_NOW - SN::$config->game_users_online_timeout) : ''), true);

  return isset($result['user_count']) ? $result['user_count'] : 0;
}

function db_user_list_to_celebrate($config_user_birthday_range) {
  // TODO
  /** @noinspection SqlAggregates */
  return doquery(
  return /** @scrutinizer ignore-deprecated */ doquery(
    "SELECT
      `id`, `username`, `user_birthday`, `user_birthday_celebrated`
      , CONCAT(YEAR(CURRENT_DATE), DATE_FORMAT(`user_birthday`, '-%m-%d')) AS `current_birthday`
      , DATEDIFF(CURRENT_DATE, CONCAT(YEAR(CURRENT_DATE), DATE_FORMAT(`user_birthday`, '-%m-%d'))) AS `days_after_birthday`
    FROM
      `{{users}}`
    WHERE
      `user_birthday` IS NOT NULL
      AND (`user_birthday_celebrated` IS NULL OR DATE_ADD(`user_birthday_celebrated`, INTERVAL 1 YEAR) < CURRENT_DATE)
      AND `user_as_ally` IS NULL
    HAVING
      `days_after_birthday` >= 0 AND `days_after_birthday` < {$config_user_birthday_range} FOR UPDATE;");
}

//function db_user_list_online_sorted($TypeSort) {
//  global $config;
//
//  return doquery(
//    "SELECT `id` AS `ID`, `username` AS `NAME`, `ally_name` AS `ALLY`, `total_points` AS `STAT_POINTS`,
//      `onlinetime` AS `ACTIVITY`
//    FROM `{{users}}`
//    WHERE `onlinetime` >= " . (SN_TIME_NOW - $config->game_users_online_timeout) . " ORDER BY user_as_ally, `" . $TypeSort . "`;");
//}


function db_user_list_admin_multi_accounts() {
  return doquery("SELECT COUNT(*) as ip_count, `user_lastip` FROM `{{users}}` WHERE user_as_ally IS NULL GROUP BY user_lastip HAVING COUNT(*) > 1;");
  return /** @scrutinizer ignore-deprecated */ doquery("SELECT COUNT(*) as ip_count, `user_lastip` FROM `{{users}}` WHERE user_as_ally IS NULL GROUP BY user_lastip HAVING COUNT(*) > 1;");
}


function db_user_list_admin_sorted($sort, $online = false) {
  global $config;

  return doquery("SELECT u.*, COUNT(r.id) AS referral_count, SUM(r.dark_matter) AS referral_dm FROM {{users}} as u
  return /** @scrutinizer ignore-deprecated */ doquery("SELECT u.*, COUNT(r.id) AS referral_count, SUM(r.dark_matter) AS referral_dm FROM {{users}} as u
    LEFT JOIN {{referrals}} as r on r.id_partner = u.id
    WHERE" .
    ($online ? " `onlinetime` >= " . (SN_TIME_NOW - $config->game_users_online_timeout) : ' user_as_ally IS NULL') .
    " GROUP BY u.id
    ORDER BY user_as_ally, {$sort}");
}

/**
 * Выбирает записи игроков по списку их ID
 *
 * @param $user_id_list
 *
 * @return array
 */
function db_user_list_by_id($user_id_list) {
  if (!is_array($user_id_list)) {
    $user_id_list = array($user_id_list);
  }

  $user_list = array();
  foreach ($user_id_list as $user_id_unsafe) {
    if (!empty($user = db_user_by_id($user_id_unsafe))) {
    if (!empty($user = /** @scrutinizer ignore-deprecated */ db_user_by_id($user_id_unsafe))) {
      $user_list[$user_id_unsafe] = $user;
    }
  }

  return $user_list;
}

supernova-ws / SuperNova

Push — trunk ( 132e87...b3f953 )

db_user_list_admin_multiaccounts() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
