supernova-ws / SuperNova

jumpgate.php

<?php

/**
 * jumpgate.php
 *
 * Jump Gate interface, I presume
 *
 * @version 1.0st Security checks & tests by Gorlum for http://supernova.ws
 * @version 1
 * @copyright 2008 By Chlorel for XNova
 */

use DBStatic\DBStaticPlanet;
use DBStatic\DBStaticUnit;
use DBStatic\DBStaticUser;

include('common.' . substr(strrchr(__FILE__, '.'), 1));

lng_include('fleet');

if($TargetPlanet = sys_get_param_id('jmpto'))
{
  sn_db_transaction_start();
  DBStaticUser::db_user_by_id($user['id'], true, 'id');
  $planetrow = DBStaticPlanet::db_planet_by_id($planetrow['id'], true);
  if(!($NextJumpTime = uni_get_time_to_jump($planetrow)))
  {
    $TargetGate = DBStaticPlanet::db_planet_by_id($TargetPlanet, true, '`id`, `last_jump_time`');
    if(mrc_get_level($user, $TargetGate, STRUC_MOON_GATE) > 0)
    {
      $NextDestTime = uni_get_time_to_jump ( $TargetGate );
      if(!$NextDestTime)
      {
        $ship_list = sys_get_param('ships');
        $jumpMade = false;
        foreach($ship_list as $ship_id => $ship_count)

The expression $ship_list of type string|array is not guaranteed to be traversable. How about adding an additional type check?

        {
          if(!in_array($ship_id, Fleet::$snGroupFleet))
          {
            continue;
          }

          $ship_count = max(0, min(floor($ship_count), mrc_get_level($user, $planetrow, $ship_id)));
          if($ship_count)
          {
            $jumpMade = true;
            DBStaticUnit::dbUpdateOrInsertUnit($ship_id, -$ship_count, $user, $planetrow['id']);
            DBStaticUnit::dbUpdateOrInsertUnit($ship_id, $ship_count, $user, $TargetGate['id']);
          }
        }

        if($jumpMade)
        {
          DBStaticPlanet::db_planet_update_set_by_id(
            $TargetGate['id'],
            array(
              'last_jump_time' => SN_TIME_NOW,
            )
          );
          DBStaticPlanet::db_planet_update_set_by_id(
            $planetrow['id'],
            array(
              'last_jump_time' => SN_TIME_NOW,
            )
          );
          DBStaticUser::db_user_set_by_id(
            $user['id'],
            array(
              'current_planet' => $TargetGate['id'],
            )
          );

          $planetrow['last_jump_time'] = SN_TIME_NOW;
          $RetMessage = classLocale::$lang['gate_jump_done'] ." - ". pretty_time(uni_get_time_to_jump($planetrow));
        } else {
          $RetMessage = classLocale::$lang['gate_wait_data'];
        }
      } else {
        $RetMessage = classLocale::$lang['gate_wait_dest'] ." - ". pretty_time($NextDestTime);
      }
    } else {
      $RetMessage = classLocale::$lang['gate_no_dest_g'];
    }
  } else {
    $RetMessage = classLocale::$lang['gate_wait_star'] ." - ". pretty_time($NextJumpTime);
  }
  sn_db_transaction_commit();
  message($RetMessage, classLocale::$lang['tech'][STRUC_MOON_GATE], "jumpgate.php", 10);
} else {
  $template = gettemplate('jumpgate', true);
  if(mrc_get_level($user, $planetrow, STRUC_MOON_GATE) > 0)
  {
    $Combo = '';
    $MoonList = DBStaticPlanet::db_planet_list_moon_other($user['id'], $planetrow['id']);
    // while($CurMoon = db_fetch($MoonList))

59% of this comment could be valid code. Did you maybe forget this after debugging?

    foreach($MoonList as $CurMoon)
    {
      if(mrc_get_level($user, $CurMoon, STRUC_MOON_GATE) >= 1)
      {
        $NextJumpTime = uni_get_time_to_jump($CurMoon);
        $template->assign_block_vars('moon', array(
          'ID'             => $CurMoon['id'],
          'GALAXY'         => $CurMoon['galaxy'],
          'SYSTEM'         => $CurMoon['system'],
          'PLANET'         => $CurMoon['planet'],
          'NAME'           => $CurMoon['name'],
          'NEXT_JUMP_TIME' => $NextJumpTime ? pretty_time($NextJumpTime) : '',
        ));
      }
    }

    foreach(Fleet::$snGroupFleet as $Ship)
    {
      if(($ship_count = mrc_get_level($user, $planetrow, $Ship)) <= 0)
      {
        continue;
      }

      $template->assign_block_vars('fleet', array(
        'SHIP_ID'         => $Ship,
        'SHIP_NAME'       => classLocale::$lang['tech'][$Ship],
        'SHIP_COUNT'      => $ship_count,
        'SHIP_COUNT_TEXT' => pretty_number($ship_count),
      ));
    }

    $template->assign_vars(array(
      'GATE_JUMP_REST_TIME' => uni_get_time_to_jump($planetrow),
      'gate_start_name' => $planetrow['name'],
      'gate_start_link' => uni_render_coordinates_href($planetrow, '', 3),
    ));

    display($template, classLocale::$lang['tech'][STRUC_MOON_GATE]);
  }
  else
  {
    message(classLocale::$lang['gate_no_src_ga'], classLocale::$lang['tech'][STRUC_MOON_GATE], "overview.php", 10);
  }
}

// -----------------------------------------------------------------------------------------------------------
// History version
// 1.0 - Version from scrap .. y avait pas ... bin maintenant y a !!