supernova-ws / SuperNova

flotenajax.php

Spacing +11 added lines, -11 removed lines

@@ -38,7 +38,7 @@ 
 
   $target_mission = sys_get_param_int('mission');
   $sn_group_missions = sn_get_groups('missions');
-  if(empty($sn_group_missions[$target_mission]['AJAX'])) {
+  if (empty($sn_group_missions[$target_mission]['AJAX'])) {
     die(classLocale::$lang['gs_c00']);
   }
 
@@ -53,7 +53,7 @@ 
   );
   // fleet_ajax now can send fleets only to existing planets/moons
   // TODO - sending colonization and expeditions in 1 click
-  if(!uni_coordinates_valid($target_coord)) {
+  if (!uni_coordinates_valid($target_coord)) {
     die(classLocale::$lang['gs_c02']);
   }
 
@@ -64,7 +64,7 @@ 
 
   // TODO - DEADLOCK CAN BE HERE!!!! We should lock SOURCE and TARGET owners in one query
   $target_row = db_planet_by_vector($target_coord);
-  if(empty($target_row)) {
+  if (empty($target_row)) {
     $target_row = $target_coord;
     $target_row['id_owner'] = 0;
     // If fleet destination is PT_DEBRIS - then it's actually destination is PT_PLANET // TODO - REMOVE! Debris should be valid DESTINATION planet_type!
@@ -75,15 +75,15 @@ 
   }
 
   $fleet_array = array();
-  switch($target_mission) {
+  switch ($target_mission) {
     case MT_SPY:
       $fleet_array[SHIP_SPY] = min(mrc_get_level($user, $planetrow, SHIP_SPY), abs(classSupernova::$user_options[PLAYER_OPTION_FLEET_SPY_DEFAULT]));
       $unit_group = 'flt_spies';
     break;
 
     case MT_RECYCLE:
-      foreach(sn_get_groups('flt_recyclers') as $unit_id) {
-        if($unit_count = mrc_get_level($user, $planetrow, $unit_id)) {
+      foreach (sn_get_groups('flt_recyclers') as $unit_id) {
+        if ($unit_count = mrc_get_level($user, $planetrow, $unit_id)) {
           $fleet_array[$unit_id] = $unit_count;
         }
       }
@@ -108,16 +108,16 @@ 
       'target_structure' => $target_structure = sys_get_param_int('structures'),
     )
   );
-  if($isAttackAllowed != FLIGHT_ALLOWED) {
+  if ($isAttackAllowed != FLIGHT_ALLOWED) {
     die(classLocale::$lang['fl_attack_error'][$isAttackAllowed]);
   }
 
   $db_changeset = array();
-  foreach($fleet_array as $unit_id => $unit_count) {
+  foreach ($fleet_array as $unit_id => $unit_count) {
     $db_changeset['unit'][] = sn_db_unit_changeset_prepare($unit_id, -$unit_count, $user, $planetrow);
   }
 
-  if($target_mission == MT_MISSILE) {
+  if ($target_mission == MT_MISSILE) {
     $distance = abs($target_coord['system'] - $planetrow['system']);
     $duration = round((30 + (60 * $distance)) / flt_server_flight_speed_multiplier());
     $arrival = SN_TIME_NOW + $duration;
@@ -127,7 +127,7 @@ 
   } else {
     $travel_data = flt_travel_data($user, $planetrow, $target_coord, $fleet_array, 10);
 
-    if($planetrow['deuterium'] < $travel_data['consumption']) {
+    if ($planetrow['deuterium'] < $travel_data['consumption']) {
       die(classLocale::$lang['gs_c13']);
     }
 
@@ -148,7 +148,7 @@ 
 
   $ships_sent = array();
   $ships_sent_js = 0;
-  foreach($fleet_array as $unit_id => $unit_count) {
+  foreach ($fleet_array as $unit_id => $unit_count) {
     $ships_sent[] = "{$unit_count} {$classLocale['tech'][$unit_id]}";
     $ships_sent_js += mrc_get_level($user, $planetrow, $unit_id, false, true);
   }

includes/classes/Fleet.php

Doc Comments +9 added lines, -4 removed lines

@@ -819,6 +819,9 @@ 
     return max(0, $this->shipsGetCapacity() - $this->resourcesGetTotal());
   }
 
+  /**
+   * @param integer $ship_id
+   */
   public function shipsGetTotalById($ship_id) {
     return $this->unitList->unitsCountById($ship_id);
   }
@@ -933,7 +936,7 @@ 
   /**
    * Set current resource list from array of units
    *
-   * @param array $resource_list
+   * @param integer[] $resource_list
    */
   public function resourcesSet($resource_list) {
     if(!empty($this->propertiesAdjusted['resource_list'])) {
@@ -978,7 +981,7 @@ 
   }
 
   /**
-   * @param array $rate
+   * @param integer[] $rate
    *
    * @return float
    */
@@ -1009,7 +1012,6 @@ 
    * Restores fleet or resources to planet
    *
    * @param bool $start
-   * @param bool $only_resources
    * @param int  $result
    *
    * @return int
@@ -1060,7 +1062,7 @@ 
   /**
    * @param int $speed_percent
    *
-   * @return array
+   * @return integer
    */
   protected function flt_travel_data($speed_percent = 10) {
     $distance = $this->targetVector->distanceFromCoordinates($this->dbSourcePlanetRow);
@@ -1161,6 +1163,9 @@ 
     }
   }
 
+  /**
+   * @param integer $errorCode
+   */
   public function restrictToTypePlanet($errorCode) {
     if($this->targetVector->type != PT_PLANET) {
       throw new Exception($errorCode, $errorCode);

Spacing +75 added lines, -76 removed lines

@@ -314,9 +314,9 @@ 
   public function renderAvailableShips(&$template_result, $playerRow, $planetRow) {
     $record_index = 0;
     $ship_list = array();
-    foreach(sn_get_groups('fleet') as $n => $unit_id) {
+    foreach (sn_get_groups('fleet') as $n => $unit_id) {
       $unit_level = mrc_get_level($playerRow, $planetRow, $unit_id, false, true);
-      if($unit_level <= 0) {
+      if ($unit_level <= 0) {
         continue;
       }
       $ship_data = get_ship_data($unit_id, $playerRow);
@@ -337,7 +337,7 @@ 
 
     sortUnitRenderedList($ship_list, classSupernova::$user_options[PLAYER_OPTION_FLEET_SHIP_SORT], classSupernova::$user_options[PLAYER_OPTION_FLEET_SHIP_SORT_INVERSE]);
 
-    foreach($ship_list as $ship_data) {
+    foreach ($ship_list as $ship_data) {
       $template_result['.']['ships'][] = $ship_data;
     }
   }
@@ -356,7 +356,7 @@ 
   public function dbInsert() {
     // WARNING! MISSION TIMES MUST BE SET WITH set_times() method!
     // TODO - more checks!
-    if(empty($this->_time_launch)) {
+    if (empty($this->_time_launch)) {
       die('Fleet time not set!');
     }
 
@@ -565,7 +565,7 @@ 
     // Записываем изменения в БД
     $this->dbSave();
 
-    if($this->_group_id) {
+    if ($this->_group_id) {
       // TODO: Make here to delete only one AKS - by adding aks_fleet_count to AKS table
       db_fleet_aks_purge();
     }
@@ -632,18 +632,18 @@ 
    */
   // TODO - separate shipList and unitList
   public function unitsSetFromArray($unit_array) {
-    if(empty($unit_array) || !is_array($unit_array)) {
+    if (empty($unit_array) || !is_array($unit_array)) {
       return;
     }
-    foreach($unit_array as $unit_id => $unit_count) {
+    foreach ($unit_array as $unit_id => $unit_count) {
       $unit_count = floatval($unit_count);
-      if(!$unit_count) {
+      if (!$unit_count) {
         continue;
       }
 
-      if($this->isShip($unit_id)) {
+      if ($this->isShip($unit_id)) {
         $this->unitList->unitSetCount($unit_id, $unit_count);
-      } elseif($this->isResource($unit_id)) {
+      } elseif ($this->isResource($unit_id)) {
         $this->resource_list[$unit_id] = $unit_count;
       } else {
         throw new Exception('Trying to pass to fleet non-resource and non-ship ' . var_export($unit_array, true), ERR_ERROR);
@@ -672,7 +672,7 @@ 
   public function parse_missile_db_row($missile_db_row) {
 //    $this->_reset();
 
-    if(empty($missile_db_row) || !is_array($missile_db_row)) {
+    if (empty($missile_db_row) || !is_array($missile_db_row)) {
       return;
     }
 
@@ -835,7 +835,7 @@ 
   public function shipsGetCapacityRecyclers(array $recycler_info) {
     $recyclers_incoming_capacity = 0;
     $fleet_data = $this->shipsGetArray();
-    foreach($recycler_info as $recycler_id => $recycler_data) {
+    foreach ($recycler_info as $recycler_id => $recycler_data) {
       $recyclers_incoming_capacity += $fleet_data[$recycler_id] * $recycler_data['capacity'];
     }
 
@@ -855,7 +855,7 @@ 
     sn_db_transaction_check(true);
 
     // Если флот уже обработан - не существует или возращается - тогда ничего не делаем
-    if($this->isEmpty()) {
+    if ($this->isEmpty()) {
       return $result;
     }
 
@@ -877,18 +877,18 @@ 
     // TODO - Проверка, что планета всё еще существует на указанных координатах, а не телепортировалась, не удалена хозяином, не уничтожена врагом
     // Флот, который возвращается на захваченную планету, пропадает
     // Ship landing is possible only to fleet owner's planet
-    if($this->getPlayerOwnerId() == $planet_arrival['id_owner']) {
+    if ($this->getPlayerOwnerId() == $planet_arrival['id_owner']) {
       $db_changeset = array();
 
       $fleet_array = $this->shipsGetArray();
-      foreach($fleet_array as $ship_id => $ship_count) {
-        if($ship_count) {
+      foreach ($fleet_array as $ship_id => $ship_count) {
+        if ($ship_count) {
           $db_changeset['unit'][] = sn_db_unit_changeset_prepare($ship_id, $ship_count, $user, $planet_arrival['id']);
         }
       }
 
       // Adjusting ship amount on planet
-      if(!empty($db_changeset)) {
+      if (!empty($db_changeset)) {
         db_changeset_apply($db_changeset);
       }
 
@@ -936,7 +936,7 @@ 
    * @param array $resource_list
    */
   public function resourcesSet($resource_list) {
-    if(!empty($this->propertiesAdjusted['resource_list'])) {
+    if (!empty($this->propertiesAdjusted['resource_list'])) {
       throw new PropertyAccessException('Property "resource_list" already was adjusted so no SET is possible until dbSave in ' . get_called_class() . '::unitSetResourceList', ERR_ERROR);
     }
     $this->resourcesAdjust($resource_list, true);
@@ -950,13 +950,13 @@ 
   public function resourcesAdjust($resource_delta_list, $replace_value = false) {
     !is_array($resource_delta_list) ? $resource_delta_list = array() : false;
 
-    foreach($resource_delta_list as $resource_id => $unit_delta) {
-      if(!UnitResourceLoot::is_in_group($resource_id) || !($unit_delta = floor($unit_delta))) {
+    foreach ($resource_delta_list as $resource_id => $unit_delta) {
+      if (!UnitResourceLoot::is_in_group($resource_id) || !($unit_delta = floor($unit_delta))) {
         // Not a resource or no resources - continuing
         continue;
       }
 
-      if($replace_value) {
+      if ($replace_value) {
         $this->resource_list[$resource_id] = $unit_delta;
       } else {
         $this->resource_list[$resource_id] += $unit_delta;
@@ -966,7 +966,7 @@ 
       }
 
       // Check for negative unit value
-      if($this->resource_list[$resource_id] < 0) {
+      if ($this->resource_list[$resource_id] < 0) {
         // TODO
         throw new Exception('Resource ' . $resource_id . ' will become negative in ' . get_called_class() . '::unitAdjustResourceList', ERR_ERROR);
       }
@@ -1018,7 +1018,7 @@ 
     sn_db_transaction_check(true);
 
     // Если флот уже обработан - не существует или возращается - тогда ничего не делаем
-    if(!$this->resourcesGetTotal()) {
+    if (!$this->resourcesGetTotal()) {
       return $result;
     }
 
@@ -1038,7 +1038,7 @@ 
     // TODO - Проверка, что планета всё еще существует на указанных координатах, а не телепортировалась, не удалена хозяином, не уничтожена врагом
 
     // Restoring resources to planet
-    if($this->resourcesGetTotal()) {
+    if ($this->resourcesGetTotal()) {
       $fleet_resources = $this->resourcesGetList();
       db_planet_set_by_id($planet_arrival['id'],
         "`metal` = `metal` + '{$fleet_resources[RES_METAL]}', `crystal` = `crystal` + '{$fleet_resources[RES_CRYSTAL]}', `deuterium` = `deuterium` + '{$fleet_resources[RES_DEUTERIUM]}'");
@@ -1103,12 +1103,12 @@ 
 
   protected function populateTargetPlanet() {
     $targetPlanetCoords = $this->targetVector;
-    if($this->mission_type != MT_NONE) {
+    if ($this->mission_type != MT_NONE) {
       $this->restrictTargetTypeByMission();
 
       // TODO - Нельзя тут просто менять тип планеты или координат!
       // If current planet type is not allowed on mission - switch planet type
-      if(empty($this->allowed_planet_types[$this->targetVector->type])) {
+      if (empty($this->allowed_planet_types[$this->targetVector->type])) {
         $targetPlanetCoords->type = reset($this->allowed_planet_types);
       }
     }
@@ -1117,14 +1117,14 @@ 
   }
 
   protected function restrictTargetTypeByMission() {
-    if($this->_mission_type == MT_MISSILE) {
+    if ($this->_mission_type == MT_MISSILE) {
       $this->allowed_planet_types = array(PT_PLANET => PT_PLANET);
-    } elseif($this->_mission_type == MT_COLONIZE || $this->_mission_type == MT_EXPLORE) {
+    } elseif ($this->_mission_type == MT_COLONIZE || $this->_mission_type == MT_EXPLORE) {
       // TODO - PT_NONE
       $this->allowed_planet_types = array(PT_PLANET => PT_PLANET);
-    } elseif($this->_mission_type == MT_RECYCLE) {
+    } elseif ($this->_mission_type == MT_RECYCLE) {
       $this->allowed_planet_types = array(PT_DEBRIS => PT_DEBRIS);
-    } elseif($this->_mission_type == MT_DESTROY) {
+    } elseif ($this->_mission_type == MT_DESTROY) {
       $this->allowed_planet_types = array(PT_MOON => PT_MOON);
     } else {
       $this->allowed_planet_types = array(PT_PLANET => PT_PLANET, PT_MOON => PT_MOON);
@@ -1156,13 +1156,13 @@ 
 
 
   public function restrictToKnownSpace() {
-    if(!$this->targetVector->isInKnownSpace()) {
+    if (!$this->targetVector->isInKnownSpace()) {
       throw new Exception('FLIGHT_VECTOR_BEYOND_SYSTEM', FLIGHT_VECTOR_BEYOND_SYSTEM);
     }
   }
 
   public function restrictToTypePlanet($errorCode) {
-    if($this->targetVector->type != PT_PLANET) {
+    if ($this->targetVector->type != PT_PLANET) {
       throw new Exception($errorCode, $errorCode);
     }
   }
@@ -1170,25 +1170,25 @@ 
   public function restrictToNoMissiles() {
     $missilesAttack = $this->unitList->unitsCountById(UNIT_DEF_MISSILE_INTERPLANET);
     $missilesDefense = $this->unitList->unitsCountById(UNIT_DEF_MISSILE_INTERCEPTOR);
-    if($missilesAttack > 0 || $missilesDefense > 0) {
+    if ($missilesAttack > 0 || $missilesDefense > 0) {
       throw new Exception('FLIGHT_SHIPS_NO_MISSILES', FLIGHT_SHIPS_NO_MISSILES);
     }
   }
 
   public function restrictToTargetOwn() {
-    if($this->dbTargetRow['id'] != $this->getPlayerOwnerId()) {
+    if ($this->dbTargetRow['id'] != $this->getPlayerOwnerId()) {
       throw new Exception('FLIGHT_VECTOR_ONLY_OWN', FLIGHT_VECTOR_ONLY_OWN);
     }
   }
 
   public function restrictToTargetOther() {
-    if($this->dbTargetRow['id'] == $this->getPlayerOwnerId()) {
+    if ($this->dbTargetRow['id'] == $this->getPlayerOwnerId()) {
       throw new Exception('FLIGHT_VECTOR_ONLY_OTHER', FLIGHT_VECTOR_ONLY_OTHER);
     }
   }
 
   public function restrictToNotOnlySpies() {
-    if($this->unitList->unitsCountById(SHIP_SPY) == $this->shipsGetTotal()) {
+    if ($this->unitList->unitsCountById(SHIP_SPY) == $this->shipsGetTotal()) {
       throw new Exception('FLIGHT_SHIPS_NOT_ONLY_SPIES', FLIGHT_SHIPS_NOT_ONLY_SPIES);
     }
   }
@@ -1198,26 +1198,26 @@ 
   }
 
   protected function restrictToMovable() {
-    if(!$this->unitList->unitsIsAllMovable($this->dbOwnerRow)) {
+    if (!$this->unitList->unitsIsAllMovable($this->dbOwnerRow)) {
       throw new Exception('FLIGHT_SHIPS_UNMOVABLE', FLIGHT_SHIPS_UNMOVABLE);
     }
   }
 
   protected function restrictToFleetUnits() {
-    if(!$this->unitList->unitsInGroup(sn_get_groups(array('fleet', 'missile')))) {
+    if (!$this->unitList->unitsInGroup(sn_get_groups(array('fleet', 'missile')))) {
       throw new Exception('FLIGHT_SHIPS_UNIT_WRONG', FLIGHT_SHIPS_UNIT_WRONG);
     }
   }
 
   protected function restrictToColonizer() {
     // Colonization fleet should have at least one colonizer
-    if(!$this->unitList->unitsCountById(SHIP_COLONIZER) <= 0) {
+    if (!$this->unitList->unitsCountById(SHIP_COLONIZER) <= 0) {
       throw new Exception('FLIGHT_SHIPS_NO_COLONIZER', FLIGHT_SHIPS_NO_COLONIZER);
     }
   }
 
   protected function restrictToTargetExists() {
-    if(empty($this->dbTargetRow) || empty($this->dbTargetRow['id'])) {
+    if (empty($this->dbTargetRow) || empty($this->dbTargetRow['id'])) {
       throw new Exception('FLIGHT_VECTOR_NO_TARGET', FLIGHT_VECTOR_NO_TARGET);
     }
   }
@@ -1225,7 +1225,7 @@ 
 
   protected function restrictKnownSpaceOrMissionExplore() {
     // Is it exploration - fleet sent beyond of system?
-    if($this->targetVector->isInKnownSpace()) {
+    if ($this->targetVector->isInKnownSpace()) {
       // No exploration beyond this point
       unset($this->allowed_missions[MT_EXPLORE]);
 
@@ -1243,7 +1243,7 @@ 
 
   protected function restrictTargetExistsOrMissionColonize() {
     // Is it colonization - fleet sent to empty place?
-    if(!empty($this->dbTargetRow)) {
+    if (!empty($this->dbTargetRow)) {
       // No colonization beyond this point
       unset($this->allowed_missions[MT_COLONIZE]);
 
@@ -1262,7 +1262,7 @@ 
   }
 
   protected function restrictNotDebrisOrMissionRecycle() {
-    if($this->targetVector->type != PT_DEBRIS) {
+    if ($this->targetVector->type != PT_DEBRIS) {
       // No recycling beyond this point
       unset($this->allowed_missions[MT_RECYCLE]);
 
@@ -1273,11 +1273,11 @@ 
 
     // restrict to recyclers
     $recyclers = 0;
-    foreach(sn_get_groups('flt_recyclers') as $recycler_id) {
+    foreach (sn_get_groups('flt_recyclers') as $recycler_id) {
       $recyclers += $this->unitList->unitsCountById($recycler_id);
     }
 
-    if($recyclers <= 0) {
+    if ($recyclers <= 0) {
       throw new Exception('FLIGHT_SHIPS_NO_RECYCLERS', FLIGHT_SHIPS_NO_RECYCLERS);
     }
 
@@ -1288,14 +1288,14 @@ 
 
   protected function restrictMissionMissile() {
     $missilesAttack = $this->unitList->unitsCountById(UNIT_DEF_MISSILE_INTERPLANET);
-    if($missilesAttack <= 0) {
+    if ($missilesAttack <= 0) {
       // No missile attack beyond this point
       unset($this->allowed_missions[MT_MISSILE]);
 
       return;
     }
 
-    if($missilesAttack != $this->shipsGetTotal()) {
+    if ($missilesAttack != $this->shipsGetTotal()) {
       throw new Exception('FLIGHT_SHIPS_ONLY_MISSILES', FLIGHT_SHIPS_ONLY_MISSILES);
     }
 
@@ -1307,7 +1307,7 @@ 
   }
 
   protected function restrictToNotOnlySpiesOrMissionSpy() {
-    if($this->unitList->unitsCountById(SHIP_SPY) != $this->shipsGetTotal()) {
+    if ($this->unitList->unitsCountById(SHIP_SPY) != $this->shipsGetTotal()) {
 //      throw new Exception('FLIGHT_SHIPS_ONLY_SPIES', FLIGHT_SHIPS_ONLY_SPIES);
       unset($this->allowed_missions[MT_SPY]);
 
@@ -1323,14 +1323,14 @@ 
   protected function restrictMissionDestroy() {
     // If target vector is not Moon - then it can't be Destroy mission
     // If no Reapers (i.e. Death Star) in fleet - then mission Moon Destroy is unaccessible
-    if($this->targetVector->type != PT_MOON || $this->unitList->unitsCountById(SHIP_HUGE_DEATH_STAR) <= 0) {
+    if ($this->targetVector->type != PT_MOON || $this->unitList->unitsCountById(SHIP_HUGE_DEATH_STAR) <= 0) {
       unset($this->allowed_missions[MT_DESTROY]);
     }
   }
 
   protected function restrictMissionACS() {
     // If no ACS group is shown - then it can't be an ACS attack
-    if(empty($this->_group_id)) {
+    if (empty($this->_group_id)) {
       unset($this->allowed_missions[MT_ACS]);
     }
   }
@@ -1338,7 +1338,7 @@ 
   /** @throws Exception */
   protected function restrictFriendOrFoe() {
     // Checking target owner
-    if($this->dbTargetRow['id'] == $this->getPlayerOwnerId()) {
+    if ($this->dbTargetRow['id'] == $this->getPlayerOwnerId()) {
       // Spying can't be done on owner's planet/moon
       unset($this->allowed_missions[MT_SPY]);
       // Attack can't be done on owner's planet/moon
@@ -1399,7 +1399,7 @@ 
    * @throws Exception
    */
   public function restrictMission() {
-    if($this->targetVector->isEqualToPlanet($this->dbSourcePlanetRow)) {
+    if ($this->targetVector->isEqualToPlanet($this->dbSourcePlanetRow)) {
       throw new Exception('FLIGHT_VECTOR_SAME_SOURCE', FLIGHT_VECTOR_SAME_SOURCE);
     }
 
@@ -1430,7 +1430,7 @@ 
 
 
   protected function printErrorIfNoShips() {
-    if($this->unitList->unitsCount() <= 0) {
+    if ($this->unitList->unitsCount() <= 0) {
       message(classLocale::$lang['fl_err_no_ships'], classLocale::$lang['fl_error'], 'fleet' . DOT_PHP_EX, 5);
     }
   }
@@ -1467,7 +1467,7 @@ 
 
     lng_include('overview');
 
-    if(empty($this->dbSourcePlanetRow)) {
+    if (empty($this->dbSourcePlanetRow)) {
       message(classLocale::$lang['fl_noplanetrow'], classLocale::$lang['fl_error']);
     }
 
@@ -1543,9 +1543,9 @@ 
 
     try {
       $this->restrictMission();
-    } catch(Exception $e) {
+    } catch (Exception $e) {
       // TODO - MESSAGE BOX
-      if($e->getCode() != FLIGHT_ALLOWED) {
+      if ($e->getCode() != FLIGHT_ALLOWED) {
         pdie(classLocale::$lang['fl_attack_error'][$e->getCode()]);
       } else {
         pdump('FLIGHT_ALLOWED', FLIGHT_ALLOWED);
@@ -1555,20 +1555,19 @@ 
     $this->renderAllowedMissions($template_result);
     $this->renderFleet($template_result);
 
-    $max_duration = $this->_mission_type == MT_EXPLORE ? get_player_max_expedition_duration($this->dbOwnerRow) :
-      (isset($this->allowed_missions[MT_HOLD]) ? 12 : 0);
+    $max_duration = $this->_mission_type == MT_EXPLORE ? get_player_max_expedition_duration($this->dbOwnerRow) : (isset($this->allowed_missions[MT_HOLD]) ? 12 : 0);
     $this->renderDuration($template_result, $max_duration);
 
     $travel_data = $this->flt_travel_data($this->oldSpeedInTens);
 
     $sn_group_resources = sn_get_groups('resources_loot');
     $planetResources = array();
-    foreach($sn_group_resources as $resource_id) {
+    foreach ($sn_group_resources as $resource_id) {
       $planetResources[$resource_id] = floor(mrc_get_level($this->dbOwnerRow, $this->dbSourcePlanetRow, $resource_id) - ($resource_id == RES_DEUTERIUM ? $travel_data['consumption'] : 0));
     }
     $this->renderPlanetResources($planetResources, $template_result);
 
-    if(sn_module::$sn_module['unit_captain']->manifest['active'] && ($captain = sn_module::$sn_module['unit_captain']->unit_captain_get($this->dbSourcePlanetRow['id'])) && $captain['unit_location_type'] == LOC_PLANET) {
+    if (sn_module::$sn_module['unit_captain']->manifest['active'] && ($captain = sn_module::$sn_module['unit_captain']->unit_captain_get($this->dbSourcePlanetRow['id'])) && $captain['unit_location_type'] == LOC_PLANET) {
       $template_result += array(
         'CAPTAIN_ID'     => $captain['unit_id'],
         'CAPTAIN_LEVEL'  => $captain['captain_level'],
@@ -1610,10 +1609,10 @@ 
   protected function renderAllowedMissions(&$template_result) {
     ksort($this->allowed_missions);
     // If mission is not set - setting first mission from allowed
-    if(empty($this->_mission_type) && is_array($this->allowed_missions)) {
+    if (empty($this->_mission_type) && is_array($this->allowed_missions)) {
       $this->_mission_type = reset($this->allowed_missions);
     }
-    foreach($this->allowed_missions as $key => $value) {
+    foreach ($this->allowed_missions as $key => $value) {
       $template_result['.']['missions'][] = array(
         'ID'   => $key,
         'NAME' => classLocale::$lang['type_mission'][$key],
@@ -1625,9 +1624,9 @@ 
    * @param $template_result
    */
   protected function renderDuration(&$template_result, $max_duration) {
-    if($max_duration) {
+    if ($max_duration) {
       $config_game_speed_expedition = ($this->_mission_type == MT_EXPLORE && classSupernova::$config->game_speed_expedition ? classSupernova::$config->game_speed_expedition : 1);
-      for($i = 1; $i <= $max_duration; $i++) {
+      for ($i = 1; $i <= $max_duration; $i++) {
         $template_result['.']['duration'][] = array(
           'ID'   => $i,
           'TIME' => pretty_time(ceil($i * 3600 / $config_game_speed_expedition)),
@@ -1643,7 +1642,7 @@ 
   protected function renderPlanetResources(&$planetResources, &$template_result) {
     // TODO - REDO to resource_id
     $i = 0;
-    foreach($planetResources as $resource_id => $resource_amount) {
+    foreach ($planetResources as $resource_id => $resource_amount) {
       $template_result['.']['resources'][] = array(
         'ID'        => $i++, // $resource_id,
         'ON_PLANET' => $resource_amount,
@@ -1657,7 +1656,7 @@ 
    * @param $template_result
    */
   protected function renderAllowedPlanetTypes(&$template_result) {
-    foreach($this->allowed_planet_types as $possible_planet_type_id) {
+    foreach ($this->allowed_planet_types as $possible_planet_type_id) {
       $template_result['.']['possible_planet_type_id'][] = array(
         'ID'         => $possible_planet_type_id,
         'NAME'       => classLocale::$lang['sys_planet_type'][$possible_planet_type_id],
@@ -1680,14 +1679,14 @@ 
       'TYPE_PRINT' => classLocale::$lang['fl_shrtcup'][$shortcut['planet_type']],
     );
 
-    if(isset($shortcut['priority'])) {
+    if (isset($shortcut['priority'])) {
       $result += array(
         'PRIORITY'       => $shortcut['priority'],
         'PRIORITY_CLASS' => $note_priority_classes[$shortcut['priority']],
       );
     }
 
-    if(isset($shortcut['id'])) {
+    if (isset($shortcut['id'])) {
       $result += array(
         'ID' => $shortcut['id'],
       );
@@ -1702,7 +1701,7 @@ 
   protected function renderFleetShortcuts(&$template_result) {
     // Building list of shortcuts
     $query = db_note_list_select_by_owner_and_planet($this->dbOwnerRow);
-    while($row = db_fetch($query)) {
+    while ($row = db_fetch($query)) {
       $template_result['.']['shortcut'][] = $this->renderFleet1TargetSelect($row);
     }
   }
@@ -1714,12 +1713,12 @@ 
    */
   protected function renderOwnPlanets(&$template_result) {
     $colonies = db_planet_list_sorted($this->dbOwnerRow);
-    if(count($colonies) <= 1) {
+    if (count($colonies) <= 1) {
       return;
     }
 
-    foreach($colonies as $row) {
-      if($row['id'] == $this->dbSourcePlanetRow['id']) {
+    foreach ($colonies as $row) {
+      if ($row['id'] == $this->dbSourcePlanetRow['id']) {
         continue;
       }
 
@@ -1732,10 +1731,10 @@ 
    */
   protected function renderACSList(&$template_result) {
     $query = db_acs_get_list();
-    while($row = db_fetch($query)) {
+    while ($row = db_fetch($query)) {
       $members = explode(',', $row['eingeladen']);
-      foreach($members as $a => $b) {
-        if($b == $this->dbOwnerRow['id']) {
+      foreach ($members as $a => $b) {
+        if ($b == $this->dbOwnerRow['id']) {
           $template_result['.']['acss'][] = $this->renderFleet1TargetSelect($row);
         }
       }
@@ -1746,7 +1745,7 @@ 
    * @param $template_result
    */
   protected function renderShipSortOptions(&$template_result) {
-    foreach(classLocale::$lang['player_option_fleet_ship_sort'] as $sort_id => $sort_text) {
+    foreach (classLocale::$lang['player_option_fleet_ship_sort'] as $sort_id => $sort_text) {
       $template_result['.']['ship_sort_list'][] = array(
         'VALUE' => $sort_id,
         'TEXT'  => $sort_text,

includes/classes/UnitList.php

Doc Comments +4 added lines

@@ -324,6 +324,10 @@
    * @return int|mixed
    */
   // TODO - REDO!!!!
+
+  /**
+   * @return double
+   */
   function flt_fleet_speed($user) {
     $speeds = array();
     if(!empty($this->mapUnitIdToDb)) {

Spacing +34 added lines, -34 removed lines

@@ -88,7 +88,7 @@ 
    * @param Unit  $value
    */
   public function offsetSet($offset, $value) {
-    if(isset($this->mapUnitIdToDb[$value->unitId])) {
+    if (isset($this->mapUnitIdToDb[$value->unitId])) {
       classSupernova::$debug->error('UnitList::offsetSet: Unit with UnitId ' . $value->unitId . ' already exists');
     }
     $this->mapUnitIdToDb[$value->unitId] = $value;
@@ -96,7 +96,7 @@ 
   }
 
   public function offsetUnset($offset) {
-    if(!empty($this[$offset]->unitId)) {
+    if (!empty($this[$offset]->unitId)) {
 //      $unit_id = $this[$offset]->unitId;
 //      $this->mapUnitIdToDb[$unit_id] = null;
 //      unset($this->mapUnitIdToDb[$unit_id]);
@@ -117,20 +117,20 @@ 
   public function dbLoad($dbId, $lockSkip = false) {
 //    $this->_reset();
 
-    if($dbId <= 0) {
+    if ($dbId <= 0) {
       return;
     }
 
-    if(!is_object($this->locatedAt)) {
+    if (!is_object($this->locatedAt)) {
       classSupernova::$debug->error('UnitList::dbLoad have no locatedAt field set');
     }
 
     $unit_array = classSupernova::db_get_unit_list_by_location(0, $this->getLocationType(), $this->getLocationDbId());
-    if(!is_array($unit_array)) {
+    if (!is_array($unit_array)) {
       return;
     }
 
-    foreach($unit_array as $unit_db_row) {
+    foreach ($unit_array as $unit_db_row) {
       $unit = $this->_createElement();
       $unit->dbRowParse($unit_db_row);
 
@@ -145,25 +145,25 @@ 
   }
 
   public function dbSave() {
-    if(!is_object($this->locatedAt)) {
+    if (!is_object($this->locatedAt)) {
       classSupernova::$debug->error('UnitList::dbSave have no locatedAt field set');
     }
 
-    foreach($this->mapUnitIdToDb as $unit) {
+    foreach ($this->mapUnitIdToDb as $unit) {
       $unit_db_id = $unit->dbId;
       $unit->dbSave();
 
-      if($unit->isEmpty()) {
+      if ($unit->isEmpty()) {
         // Removing unit object
         // TODO - change when there will be common bus for all objects
         // ...or should I? If COUNT is empty - it means that object does not exists in DB. So it should be deleted from PHP memory and cache too
         unset($this[$unit_db_id]);
       } else {
-        if($unit->dbId <= 0) {
+        if ($unit->dbId <= 0) {
           classSupernova::$debug->error('Error writing unit to DB');
         }
         // If unit is new then putting unit object to container
-        if(empty($this->_container[$unit->dbId])) {
+        if (empty($this->_container[$unit->dbId])) {
           $this->_container[$unit->dbId] = $unit;
         }
       }
@@ -201,7 +201,7 @@ 
   }
 
   public function unitGetCount($unit_id) {
-    if(empty($this->mapUnitIdToDb[$unit_id])) {
+    if (empty($this->mapUnitIdToDb[$unit_id])) {
       throw new Exception('Unit [' . $unit_id . '] is not exists in UnitList');
     }
     return $this->mapUnitIdToDb[$unit_id]->count;
@@ -216,14 +216,14 @@ 
    * @param bool $replace_value
    */
   public function unitAdjustCount($unit_id, $unit_count = 0, $replace_value = false) {
-    if(empty($this->mapUnitIdToDb[$unit_id])) {
+    if (empty($this->mapUnitIdToDb[$unit_id])) {
       // If unit not exists - creating one and setting all attributes
       $this->mapUnitIdToDb[$unit_id] = $this->_createElement();
       $this->mapUnitIdToDb[$unit_id]->setUnitId($unit_id);
       $this->mapUnitIdToDb[$unit_id]->setLocatedAt($this);
     }
 
-    if($replace_value) {
+    if ($replace_value) {
       $this->mapUnitIdToDb[$unit_id]->count = $unit_count;
     } else {
       $this->mapUnitIdToDb[$unit_id]->adjustCount($unit_count);
@@ -237,7 +237,7 @@ 
    */
   public function unitsGetArray() {
     $result = array();
-    foreach($this->mapUnitIdToDb as $unit) {
+    foreach ($this->mapUnitIdToDb as $unit) {
       $result[$unit->unitId] = $unit->count;
     }
 
@@ -245,7 +245,7 @@ 
   }
 
   public function unitsCountApplyLossMultiplier($ships_lost_multiplier) {
-    foreach($this->mapUnitIdToDb as $unit_id => $unit) {
+    foreach ($this->mapUnitIdToDb as $unit_id => $unit) {
       $unit->count = floor($unit->count * $ships_lost_multiplier);
     }
   }
@@ -271,8 +271,8 @@ 
 
   public function unitsPropertySumById($unit_id = 0, $propertyName = 'count') {
     $result = 0;
-    foreach($this->mapUnitIdToDb as $unit) {
-      if(!$unit_id || $unit->unitId == $unit_id) {
+    foreach ($this->mapUnitIdToDb as $unit) {
+      if (!$unit_id || $unit->unitId == $unit_id) {
         $result += $unit->$propertyName;
       }
     }
@@ -289,15 +289,15 @@ 
      * @var Fleet $objFleet
      */
     $objFleet = $this->getLocatedAt();
-    if(empty($objFleet)) {
+    if (empty($objFleet)) {
       throw new Exception('No fleet owner on UnitList::unitsRender() in ' . __FILE__ . '@' . __LINE__);
     }
 
     $tplShips = array();
-    foreach($this->mapUnitIdToDb as $unit) {
+    foreach ($this->mapUnitIdToDb as $unit) {
       $ship_id = $unit->unitId;
       $ship_count = $unit->count;
-      if(!UnitShip::is_in_group($ship_id) || $ship_count <= 0) {
+      if (!UnitShip::is_in_group($ship_id) || $ship_count <= 0) {
         continue;
       }
 
@@ -326,9 +326,9 @@ 
   // TODO - REDO!!!!
   function flt_fleet_speed($user) {
     $speeds = array();
-    if(!empty($this->mapUnitIdToDb)) {
-      foreach($this->mapUnitIdToDb as $ship_id => $unit) {
-        if($unit->getCount() > 0 && in_array($unit->unitId, sn_get_groups(array('fleet', 'missile')))) {
+    if (!empty($this->mapUnitIdToDb)) {
+      foreach ($this->mapUnitIdToDb as $ship_id => $unit) {
+        if ($unit->getCount() > 0 && in_array($unit->unitId, sn_get_groups(array('fleet', 'missile')))) {
           $single_ship_data = get_ship_data($unit->unitId, $user);
           $speeds[] = $single_ship_data['speed'];
         }
@@ -349,11 +349,11 @@ 
     $fleet_speed = $this->flt_fleet_speed($dbOwnerRow);
     $real_speed = $speed_percent * sqrt($fleet_speed);
 
-    if($fleet_speed && $game_fleet_speed) {
+    if ($fleet_speed && $game_fleet_speed) {
       $duration = max(1, round((35000 / $speed_percent * sqrt($distance * 10 / $fleet_speed) + 10) / $game_fleet_speed));
 
-      foreach($this->mapUnitIdToDb as $ship_id => $unit) {
-        if(!$unit->unitId || $unit->getCount() <= 0) {
+      foreach ($this->mapUnitIdToDb as $ship_id => $unit) {
+        if (!$unit->unitId || $unit->getCount() <= 0) {
           continue;
         }
 
@@ -384,8 +384,8 @@ 
    * @return bool
    */
   public function unitsInGroup($group) {
-    foreach($this->mapUnitIdToDb as $unitId => $unit) {
-      if(!in_array($unitId, $group)) {
+    foreach ($this->mapUnitIdToDb as $unitId => $unit) {
+      if (!in_array($unitId, $group)) {
         return false;
       }
     }
@@ -394,9 +394,9 @@ 
   }
 
   public function unitsIsAllMovable($dbOwnerRow) {
-    foreach($this->mapUnitIdToDb as $unitId => $unit) {
+    foreach ($this->mapUnitIdToDb as $unitId => $unit) {
       $single_ship_data = get_ship_data($unit->unitId, $dbOwnerRow);
-      if($single_ship_data['speed'] <= 0) {
+      if ($single_ship_data['speed'] <= 0) {
         return false;
       }
     }
@@ -475,7 +475,7 @@ 
 
     print('</tr>');
 
-    foreach($this->mapUnitIdToDb as $unit) {
+    foreach ($this->mapUnitIdToDb as $unit) {
       print('<tr>');
 
       print('<td>');
@@ -526,14 +526,14 @@ 
 
 
   public function unitZeroDbId() {
-    foreach($this->mapUnitIdToDb as $unit) {
+    foreach ($this->mapUnitIdToDb as $unit) {
       $unit->zeroDbId();
     }
   }
 
 
   public function unitZeroCount() {
-    foreach($this->mapUnitIdToDb as $unit) {
+    foreach ($this->mapUnitIdToDb as $unit) {
       $unit->count = 0;
     }
   }

includes/includes/eco_bld_structures.php

Spacing +31 added lines, -31 removed lines

@@ -19,10 +19,10 @@ 
   global $template_result;
   $classLocale = classLocale::$lang;
 
-  if($ally_id = sys_get_param_id('ally_id')) {
+  if ($ally_id = sys_get_param_id('ally_id')) {
     define('SN_IN_ALLY', true);
     $ranks = ally_get_ranks($auser['ally']);
-    if($ranks[$auser['ally_rank_id']]['admin'] || $auser['ally']['ally_owner'] == $auser['id']) {
+    if ($ranks[$auser['ally_rank_id']]['admin'] || $auser['ally']['ally_owner'] == $auser['id']) {
       $user = &$auser['ally']['player'];
       $planet = array(
         'metal'     => $user['metal'],
@@ -32,11 +32,11 @@ 
     }
   }
 
-  if(!$user) {
+  if (!$user) {
     $user = &$auser;
   }
 
-  switch($action = sys_get_param_escaped('action')) {
+  switch ($action = sys_get_param_escaped('action')) {
     case 'create': // Add unit to que for build
     case 'create_autoconvert': // Add unit to que for build
     case 'destroy': // Add unit to que for remove
@@ -53,28 +53,28 @@ 
 
   $group_missile = sn_get_groups('missile');
   $silo_capacity_free = 0;
-  if($que_type == QUE_STRUCTURES) {
+  if ($que_type == QUE_STRUCTURES) {
     $build_unit_list = sn_get_groups('build_allow');
     $build_unit_list = $build_unit_list[$planet['planet_type']];
     $artifact_id = ART_NANO_BUILDER;
     $page_header = classLocale::$lang['tech'][UNIT_STRUCTURES];
-  } elseif($que_type == QUE_RESEARCH) {
-    if(!mrc_get_level($user, $planet, STRUC_LABORATORY)) {
+  } elseif ($que_type == QUE_RESEARCH) {
+    if (!mrc_get_level($user, $planet, STRUC_LABORATORY)) {
       message(classLocale::$lang['no_laboratory'], classLocale::$lang['tech'][UNIT_TECHNOLOGIES]);
     }
 
-    if(eco_unit_busy($user, $planet, UNIT_TECHNOLOGIES)) {
+    if (eco_unit_busy($user, $planet, UNIT_TECHNOLOGIES)) {
       message(classLocale::$lang['eco_bld_msg_err_laboratory_upgrading'], classLocale::$lang['tech'][UNIT_TECHNOLOGIES]);
     }
     $build_unit_list = sn_get_groups('tech');
     $artifact_id = ART_HEURISTIC_CHIP;
     $page_header = classLocale::$lang['tech'][UNIT_TECHNOLOGIES] . ($user['user_as_ally'] ? " {$classLocale['sys_of_ally']} {$user['username']}" : '');
-  } elseif($que_type == QUE_MERCENARY) {
+  } elseif ($que_type == QUE_MERCENARY) {
     $build_unit_list = sn_get_groups('mercenaries');
     $artifact_id = 0;
     $page_header = classLocale::$lang['tech'][UNIT_MERCENARIES] . ($user['user_as_ally'] ? " {$classLocale['sys_of_ally']} {$user['username']}" : '');
   } else {
-    if(mrc_get_level($user, $planet, STRUC_FACTORY_HANGAR) == 0) {
+    if (mrc_get_level($user, $planet, STRUC_FACTORY_HANGAR) == 0) {
       message(classLocale::$lang['need_hangar'], classLocale::$lang['tech'][STRUC_FACTORY_HANGAR]);
     }
 
@@ -83,7 +83,7 @@ 
     $artifact_id = 0;
 
     $silo_capacity_free = mrc_get_level($user, $planet, STRUC_SILO) * get_unit_param(STRUC_SILO, P_CAPACITY);
-    foreach($group_missile as $unit_id) {
+    foreach ($group_missile as $unit_id) {
       $silo_capacity_free -= (mrc_get_level($user, $planet, $unit_id, false, true) + (isset($in_que[$unit_id]) && $in_que[$unit_id] ? $in_que[$unit_id] : 0)) * get_unit_param($unit_id, P_UNIT_SIZE);
     }
     $silo_capacity_free = max(0, $silo_capacity_free);
@@ -94,7 +94,7 @@ 
   $config_resource_multiplier_plain = game_resource_multiplier(true);
 
   $template = gettemplate('buildings_builds', true);
-  if(!empty($operation_result)) {
+  if (!empty($operation_result)) {
     $template_result['.']['result'][] = $operation_result;
   }
 
@@ -124,7 +124,7 @@ 
 
   $record_index = 0;
 
-  foreach($build_unit_list as $unit_id) {
+  foreach ($build_unit_list as $unit_id) {
     $level_base = mrc_get_level($user, $planet, $unit_id, false, true);
     $level_effective = mrc_get_level($user, $planet, $unit_id);
     $level_in_que = $in_que[$unit_id];
@@ -147,12 +147,12 @@ 
     $can_build = $unit_info[P_MAX_STACK] ? max(0, $unit_info[P_MAX_STACK] - $level_in_que - $level_effective) : $build_data['CAN'][BUILD_CREATE];
     // Restricting $can_build by free silo capacity
     $can_build = ($unit_is_missile = in_array($unit_id, $group_missile)) ? min($can_build, floor($silo_capacity_free / $unit_info[P_UNIT_SIZE])) : $can_build;
-    if(!$can_build) {
-      if(!$build_data['CAN'][BUILD_CREATE]) {
+    if (!$can_build) {
+      if (!$build_data['CAN'][BUILD_CREATE]) {
         $build_data['RESULT'][BUILD_CREATE] = BUILD_NO_RESOURCES;
-      } elseif($unit_is_missile && $silo_capacity_free < $unit_info[P_UNIT_SIZE]) {
+      } elseif ($unit_is_missile && $silo_capacity_free < $unit_info[P_UNIT_SIZE]) {
         $build_data['RESULT'][BUILD_CREATE] = BUILD_SILO_FULL;
-      } elseif($unit_info[P_MAX_STACK]) {
+      } elseif ($unit_info[P_MAX_STACK]) {
         $build_data['RESULT'][BUILD_CREATE] = BUILD_MAX_REACHED;
       }
     }
@@ -219,14 +219,14 @@ 
       'MAP_IS_RESOURCE' => !empty($unit_info[P_UNIT_PRODUCTION]),
     );
 
-    if($unit_stackable) {
+    if ($unit_stackable) {
       $level_production_base = array(
         'ACTUAL_SHIELD' => pretty_number(mrc_modify_value($user, false, array(MRC_ADMIRAL, TECH_SHIELD), $unit_info['shield'])),
         'ACTUAL_ARMOR'  => pretty_number(mrc_modify_value($user, false, array(MRC_ADMIRAL, TECH_ARMOR), $unit_info['armor'])),
         'ACTUAL_WEAPON' => pretty_number(mrc_modify_value($user, false, array(MRC_ADMIRAL, TECH_WEAPON), $unit_info['attack'])),
       );
 
-      if($unit_info[P_UNIT_TYPE] == UNIT_SHIPS) {
+      if ($unit_info[P_UNIT_TYPE] == UNIT_SHIPS) {
         $ship_data = get_ship_data($unit_id, $user);
 
         $level_production_base += array(
@@ -236,9 +236,9 @@ 
         );
       }
 
-      if($unit_info[P_UNIT_PRODUCTION]) {
-        foreach($unit_info[P_UNIT_PRODUCTION] as $resource_id => $resource_calc) {
-          if($resource_income =
+      if ($unit_info[P_UNIT_PRODUCTION]) {
+        foreach ($unit_info[P_UNIT_PRODUCTION] as $resource_id => $resource_calc) {
+          if ($resource_income =
             floor(mrc_modify_value($user, $planet, $sn_modifiers_resource, $resource_calc(1, 10, $user, $planet)
               * ($resource_id == RES_ENERGY ? $config_resource_multiplier_plain : $config_resource_multiplier)
               * (isset($density_info[$resource_id]) ? $density_info[$resource_id] : 1)))
@@ -248,11 +248,11 @@ 
         }
       }
       $production['.']['resource'][] = $level_production_base;
-    } elseif($unit_info[P_UNIT_PRODUCTION]) {
+    } elseif ($unit_info[P_UNIT_PRODUCTION]) {
       $level_production_base = array();
       $element_level_start = $level_effective + $in_que[$unit_id];
-      foreach($unit_info[P_UNIT_PRODUCTION] as $resource_id => $resource_calc) {
-        if($resource_income =
+      foreach ($unit_info[P_UNIT_PRODUCTION] as $resource_id => $resource_calc) {
+        if ($resource_income =
           floor(mrc_modify_value($user, $planet, $sn_modifiers_resource, $resource_calc($element_level_start, 10, $user, $planet)
             * ($resource_id == RES_ENERGY ? $config_resource_multiplier_plain : $config_resource_multiplier)
             * (isset($density_info[$resource_id]) ? $density_info[$resource_id] : 1)))
@@ -262,10 +262,10 @@ 
       }
 
       $level_start = $level_base_and_que > 1 ? $level_effective + $level_in_que - 1 : 1;
-      for($i = 0; $i < 6; $i++) {
+      for ($i = 0; $i < 6; $i++) {
         $level_production = array('LEVEL' => $level_start + $i);
-        foreach($unit_info[P_UNIT_PRODUCTION] as $resource_id => $resource_calc) {
-          if(
+        foreach ($unit_info[P_UNIT_PRODUCTION] as $resource_id => $resource_calc) {
+          if (
           $resource_income = floor(mrc_modify_value($user, $planet, $sn_modifiers_resource, $resource_calc($level_start + $i, 10, $user, $planet)
             * ($resource_id == RES_ENERGY ? $config_resource_multiplier_plain : $config_resource_multiplier)
             * (isset($density_info[$resource_id]) ? $density_info[$resource_id] : 1)))
@@ -276,7 +276,7 @@ 
         }
         $production['.']['resource'][] = $level_production;
       }
-    } elseif($unit_id == TECH_ASTROTECH) {
+    } elseif ($unit_id == TECH_ASTROTECH) {
       $element_level_start = $level_effective + $in_que[$unit_id];
       $level_production_base = array(
         UNIT_PLAYER_EXPEDITIONS_MAX => get_player_max_expeditons($user, $element_level_start),
@@ -284,7 +284,7 @@ 
       );
 
       $level_start = $level_base_and_que > 1 ? $level_effective + $level_in_que - 1 : 1;
-      for($i = 0; $i < 6; $i++) {
+      for ($i = 0; $i < 6; $i++) {
         $level_production = array('LEVEL' => $level_start + $i);
         $level_production['R' . UNIT_PLAYER_EXPEDITIONS_MAX] = get_player_max_expeditons($user, $level_start + $i);
         $level_production['D' . UNIT_PLAYER_EXPEDITIONS_MAX] = $level_production['R' . UNIT_PLAYER_EXPEDITIONS_MAX] - $level_production_base[UNIT_PLAYER_EXPEDITIONS_MAX];
@@ -305,7 +305,7 @@ 
     $template_result['.']['production'][] = $production;
   }
 
-  foreach(classLocale::$lang['player_option_building_sort'] as $sort_id => $sort_text) {
+  foreach (classLocale::$lang['player_option_building_sort'] as $sort_id => $sort_text) {
     $template->assign_block_vars('sort_values', array(
       'VALUE' => $sort_id,
       'TEXT'  => $sort_text,